Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74757/?format=api
{ "id": 74757, "url": "https://patches.dpdk.org/api/patches/74757/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1595592431-164904-1-git-send-email-matan@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1595592431-164904-1-git-send-email-matan@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1595592431-164904-1-git-send-email-matan@mellanox.com", "date": "2020-07-24T12:07:11", "name": "vdpa/mlx5: fix live migration termination", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "cce0bc1190019669c5963e7ecc22434c8eb70f93", "submitter": { "id": 796, "url": "https://patches.dpdk.org/api/people/796/?format=api", "name": "Matan Azrad", "email": "matan@mellanox.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1595592431-164904-1-git-send-email-matan@mellanox.com/mbox/", "series": [ { "id": 11284, "url": "https://patches.dpdk.org/api/series/11284/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11284", "date": "2020-07-24T12:07:11", "name": "vdpa/mlx5: fix live migration termination", "version": 1, "mbox": "https://patches.dpdk.org/series/11284/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/74757/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/74757/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 916D2A0518;\n\tFri, 24 Jul 2020 14:07:20 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 781721C135;\n\tFri, 24 Jul 2020 14:07:20 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 8EF061C12C\n for <dev@dpdk.org>; Fri, 24 Jul 2020 14:07:19 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n matan@mellanox.com) with SMTP; 24 Jul 2020 15:07:15 +0300", "from pegasus25.mtr.labs.mlnx. (pegasus25.mtr.labs.mlnx\n [10.210.16.10])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 06OC7F5K024628;\n Fri, 24 Jul 2020 15:07:15 +0300" ], "From": "Matan Azrad <matan@mellanox.com>", "To": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Cc": "dev@dpdk.org", "Date": "Fri, 24 Jul 2020 12:07:11 +0000", "Message-Id": "<1595592431-164904-1-git-send-email-matan@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "Subject": "[dpdk-dev] [PATCH] vdpa/mlx5: fix live migration termination", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There are a lot of per virtq operations in the live migration\nhandling.\n\nBefore the driver support for queue update, when a virtq was not valid,\nall the LM handling was terminated.\n\nBut now, when the driver supports queue update, the virtq can be invalid\nas legal stage.\n\nSkip invalid virtq in LM handling.\n\nFixes: c47d6e83334e (\"vdpa/mlx5: support queue update\")\n\nSigned-off-by: Matan Azrad <matan@mellanox.com>\nAcked-by: Xueming Li <xuemingl@mellanox.com>\n---\n drivers/vdpa/mlx5/mlx5_vdpa_lm.c | 28 +++++++++++++++++-----------\n 1 file changed, 17 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_lm.c b/drivers/vdpa/mlx5/mlx5_vdpa_lm.c\nindex 460e01d..273c46f 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa_lm.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa_lm.c\n@@ -19,9 +19,13 @@\n \n \tfor (i = 0; i < priv->nr_virtqs; ++i) {\n \t\tattr.queue_index = i;\n-\t\tif (!priv->virtqs[i].virtq ||\n-\t\t mlx5_devx_cmd_modify_virtq(priv->virtqs[i].virtq, &attr)) {\n-\t\t\tDRV_LOG(ERR, \"Failed to modify virtq %d logging.\", i);\n+\t\tif (!priv->virtqs[i].virtq) {\n+\t\t\tDRV_LOG(DEBUG, \"virtq %d is invalid for dirty bitmap \"\n+\t\t\t\t\"enabling.\", i);\n+\t\t} else if (mlx5_devx_cmd_modify_virtq(priv->virtqs[i].virtq,\n+\t\t\t &attr)) {\n+\t\t\tDRV_LOG(ERR, \"Failed to modify virtq %d for dirty \"\n+\t\t\t\t\"bitmap enabling.\", i);\n \t\t\treturn -1;\n \t\t}\n \t}\n@@ -69,9 +73,11 @@\n \tattr.dirty_bitmap_mkey = mr->mkey->id;\n \tfor (i = 0; i < priv->nr_virtqs; ++i) {\n \t\tattr.queue_index = i;\n-\t\tif (!priv->virtqs[i].virtq ||\n-\t\t mlx5_devx_cmd_modify_virtq(priv->virtqs[i].virtq, &attr)) {\n-\t\t\tDRV_LOG(ERR, \"Failed to modify virtq %d for lm.\", i);\n+\t\tif (!priv->virtqs[i].virtq) {\n+\t\t\tDRV_LOG(DEBUG, \"virtq %d is invalid for LM.\", i);\n+\t\t} else if (mlx5_devx_cmd_modify_virtq(priv->virtqs[i].virtq,\n+\t\t\t\t\t\t &attr)) {\n+\t\t\tDRV_LOG(ERR, \"Failed to modify virtq %d for LM.\", i);\n \t\t\tgoto err;\n \t\t}\n \t}\n@@ -104,15 +110,15 @@\n \tif (!RTE_VHOST_NEED_LOG(features))\n \t\treturn 0;\n \tfor (i = 0; i < priv->nr_virtqs; ++i) {\n-\t\tif (priv->virtqs[i].virtq) {\n+\t\tif (!priv->virtqs[i].virtq) {\n+\t\t\tDRV_LOG(DEBUG, \"virtq %d is invalid for LM log.\", i);\n+\t\t} else {\n \t\t\tret = mlx5_vdpa_virtq_stop(priv, i);\n \t\t\tif (ret) {\n-\t\t\t\tDRV_LOG(ERR, \"Failed to stop virtq %d.\", i);\n+\t\t\t\tDRV_LOG(ERR, \"Failed to stop virtq %d for LM \"\n+\t\t\t\t\t\"log.\", i);\n \t\t\t\treturn -1;\n \t\t\t}\n-\t\t} else {\n-\t\t\tDRV_LOG(ERR, \"virtq %d is not created.\", i);\n-\t\t\treturn -1;\n \t\t}\n \t\trte_vhost_log_used_vring(priv->vid, i, 0,\n \t\t\t MLX5_VDPA_USED_RING_LEN(priv->virtqs[i].vq_size));\n", "prefixes": [] }