Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74732/?format=api
{ "id": 74732, "url": "https://patches.dpdk.org/api/patches/74732/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200724053235.71069-23-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200724053235.71069-23-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200724053235.71069-23-ajit.khaparde@broadcom.com", "date": "2020-07-24T05:32:35", "name": "[v3,22/22] net/bnxt: fix build error with extra cflags", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e3834e1dfbb9ef50eec3c0630bce719d1792c491", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200724053235.71069-23-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 11269, "url": "https://patches.dpdk.org/api/series/11269/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11269", "date": "2020-07-24T05:32:13", "name": "bnxt patches", "version": 3, "mbox": "https://patches.dpdk.org/series/11269/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/74732/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/74732/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 04E90A0518;\n\tFri, 24 Jul 2020 07:37:05 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EC16C1C196;\n\tFri, 24 Jul 2020 07:34:47 +0200 (CEST)", "from mail-ua1-f99.google.com (mail-ua1-f99.google.com\n [209.85.222.99]) by dpdk.org (Postfix) with ESMTP id D5F501C1CB\n for <dev@dpdk.org>; Fri, 24 Jul 2020 07:34:06 +0200 (CEST)", "by mail-ua1-f99.google.com with SMTP id u6so2580408uau.8\n for <dev@dpdk.org>; Thu, 23 Jul 2020 22:34:06 -0700 (PDT)", "from localhost.localdomain ([192.19.223.252])\n by smtp-relay.gmail.com with ESMTPS id h17sm592840vsk.0.2020.07.23.22.34.02\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Thu, 23 Jul 2020 22:34:06 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=9pLkqIBt1N/Wcwpd8QY6ki6GoJEoytzyw7DXr/qd+ww=;\n b=OM1DuU16AZ/OnMwV6d/Ey0Dex03diuLKunQwNq3S+r146NJCysd94jz8rfV4lS0RDu\n cBy7HOuvW3encvzjq8sB5SDpUUOGyiHHkxkUncuMBKv6mLuMDj9YjAOO1v81sYlZCl0R\n BFKRII8uEYy6U6+xOEtmy3conbANQ/k5VrIfA=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=9pLkqIBt1N/Wcwpd8QY6ki6GoJEoytzyw7DXr/qd+ww=;\n b=YECL4gp1J3/PvTH6nuUvLt/7Q8rfhp+TAwRezc5N3MQTJA2Vg4eUnaoNTc4Bg5OsUk\n CfiAG6z3bDUdCa4rQD4nSfAqyFzLGWxHUxYhTXZRYUcmY4RLPiD/A3hpBZ5rB+Gf4mhL\n zF9OUtkJo06YWwHLn8g5yjeXe9nUeUOGucAR86EWVPqq2yMiXdeBK4nvBTADzy6z3ctQ\n hy62BlSJZRfPGsq4vsQLlx2BmyFX7yWkrspd0hz8D1o6LfPLsQc4bPC7EdeJE4y7Tuzm\n ka7q8i7HZilJXO6Xwg2Iu49tbjhHMh4GfkMXZZl41F6ta8IdtWqX2V8NeCsSBM7E1yRt\n RFVA==", "X-Gm-Message-State": "AOAM531HtshwOaahx7aXkWjia2COS+X8FJ4CLOFM1K+sNUoAInMSe1xl\n 0G+z6l01P0TyJYqCYh3A8REG8oZ9jtqfRQaycFVP0YGD6kH2hpbLYQ99hnxkcFze+7Ma/vkXtVB\n +0JAduz1E0eP+G6QZzpvEnNhSXNTDmtq0s5Xnpm+H3qIqHb/+87CEpEM2momQO9mxyX5jVyrj0J\n wSjA==", "X-Google-Smtp-Source": "\n ABdhPJzQbRvdsm2g5DnP0iHLikl3OZdCL/ZdH99if6A/DDto2XtWHXqEyrmdDznRVoBtseQjo+E8soOlv//f", "X-Received": "by 2002:ab0:4e98:: with SMTP id l24mr6889854uah.15.1595568846253;\n Thu, 23 Jul 2020 22:34:06 -0700 (PDT)", "X-Relaying-Domain": "broadcom.com", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, stephen@networkplumber.org,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>", "Date": "Thu, 23 Jul 2020 22:32:35 -0700", "Message-Id": "<20200724053235.71069-23-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20200724053235.71069-1-ajit.khaparde@broadcom.com>", "References": "<20200723115639.22357-1-somnath.kotur@broadcom.com>\n <20200724053235.71069-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 22/22] net/bnxt: fix build error with extra\n\tcflags", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When we compile PMD with CFLAGS set to -O -g, build fails because of\nuninitialized error. This patch fixes it.\n\nFixes: 1e46b3962620 (\"net/bnxt: fill cfa action in Tx descriptor\")\n\nBugzilla ID: 509\n\nCc: stephen@networkplumber.org\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>\n---\n drivers/net/bnxt/bnxt_txr.c | 15 +++++----------\n 1 file changed, 5 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c\nindex 1113aca44..c7a2de67c 100644\n--- a/drivers/net/bnxt/bnxt_txr.c\n+++ b/drivers/net/bnxt/bnxt_txr.c\n@@ -111,7 +111,7 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \tuint32_t outer_tpid_bd = 0;\n \tstruct tx_bd_long *txbd;\n \tstruct tx_bd_long_hi *txbd1 = NULL;\n-\tuint32_t vlan_tag_flags, cfa_action;\n+\tuint32_t vlan_tag_flags;\n \tbool long_bd = false;\n \tunsigned short nr_bds = 0;\n \tstruct rte_mbuf *m_seg;\n@@ -187,13 +187,6 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \t\ttxbd->flags_type |= TX_BD_LONG_TYPE_TX_BD_LONG;\n \t\tvlan_tag_flags = 0;\n \n-\t\tif (BNXT_TRUFLOW_EN(txq->bp)) {\n-\t\t\tif (txq->vfr_tx_cfa_action)\n-\t\t\t\tcfa_action = txq->vfr_tx_cfa_action;\n-\t\t\telse\n-\t\t\t\tcfa_action = txq->bp->tx_cfa_action;\n-\t\t}\n-\n \t\t/* HW can accelerate only outer vlan in QinQ mode */\n \t\tif (tx_buf->mbuf->ol_flags & PKT_TX_QINQ_PKT) {\n \t\t\tvlan_tag_flags = TX_BD_LONG_CFA_META_KEY_VLAN_TAG |\n@@ -222,8 +215,10 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \t\ttxbd1->lflags = 0;\n \t\ttxbd1->cfa_meta = vlan_tag_flags;\n \n-\t\tif (BNXT_TRUFLOW_EN(txq->bp))\n-\t\t\ttxbd1->cfa_action = cfa_action;\n+\t\tif (txq->vfr_tx_cfa_action)\n+\t\t\ttxbd1->cfa_action = txq->vfr_tx_cfa_action;\n+\t\telse\n+\t\t\ttxbd1->cfa_action = txq->bp->tx_cfa_action;\n \n \t\tif (tx_pkt->ol_flags & PKT_TX_TCP_SEG) {\n \t\t\tuint16_t hdr_size;\n", "prefixes": [ "v3", "22/22" ] }