List comments

GET /api/patches/74719/comments/?order=-id
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 116727,
        "web_url": "https://patches.dpdk.org/comment/116727/",
        "msgid": "<CACZ4nhtns9hNMwjVAEOyijeakM8mhLeWrnge6Ny0HQt1jhfN1A@mail.gmail.com>",
        "date": "2020-07-28T05:22:13",
        "subject": "Re: [dpdk-dev] [PATCH v3 09/22] net/bnxt: ignore VLAN priority mask",
        "submitter": {
            "id": 501,
            "url": "https://patches.dpdk.org/api/people/501/",
            "name": "Ajit Khaparde",
            "email": "ajit.khaparde@broadcom.com"
        },
        "content": "On Mon, Jul 27, 2020 at 3:30 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:\n\n> On 7/24/2020 6:32 AM, Ajit Khaparde wrote:\n> > From: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\n> >\n> > This is a work around for the OVS setting offload rules that\n> > are passing vlan priority mask as wild card and currently we\n> > do not support it.\n> >\n> > Signed-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\n> > Reviewed-by: Michael Baucom <michael.baucom@broadcom.com>\n> > ---\n> >  drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 9 +++++++++\n> >  1 file changed, 9 insertions(+)\n> >\n> > diff --git a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c\n> b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c\n> > index 67f9319d6..665f5d381 100644\n> > --- a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c\n> > +++ b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c\n> > @@ -709,8 +709,17 @@ ulp_rte_vlan_hdr_handler(const struct rte_flow_item\n> *item,\n> >                       vlan_tag |= ~ULP_VLAN_TAG_MASK;\n> >               vlan_tag = htons(vlan_tag);\n> >\n> > +#ifdef ULP_DONT_IGNORE_TOS\n> >               ulp_rte_prsr_mask_copy(params, &idx, &priority,\n> >                                      sizeof(priority));\n> > +#else\n> > +             /*\n> > +              * The priority field is ignored since OVS is setting it as\n> > +              * wild card match and it is not supported. This is a work\n> > +              * around and shall be addressed in the future.\n> > +              */\n> > +             idx += 1;\n> > +#endif\n> >               ulp_rte_prsr_mask_copy(params, &idx, &vlan_tag,\n> >                                      sizeof(vlan_tag));\n> >               ulp_rte_prsr_mask_copy(params, &idx,\n> &vlan_mask->inner_type,\n> >\n>\n> Hi Ajit,\n>\n> What sets the 'ULP_DONT_IGNORE_TOS', I don't see it in our build system.\n> If ways\n> 'else' leg is taken, why not drop the macro completely?\n>\nFerruh,\nYes. I will submit a v4 to take care of that.\n\nThanks\nAjit",
        "headers": {
            "Return-Path": "<dev-bounces@dpdk.org>",
            "References": "<20200723115639.22357-1-somnath.kotur@broadcom.com>\n <20200724053235.71069-1-ajit.khaparde@broadcom.com>\n <20200724053235.71069-10-ajit.khaparde@broadcom.com>\n <64484f93-7ee6-fc41-4fd6-ed73f42f69e8@intel.com>",
            "X-Mailman-Version": "2.1.15",
            "Date": "Mon, 27 Jul 2020 22:22:13 -0700",
            "List-Post": "<mailto:dev@dpdk.org>",
            "X-BeenThere": "dev@dpdk.org",
            "Content-Type": "text/plain; charset=\"UTF-8\"",
            "MIME-Version": "1.0",
            "X-Original-To": "patchwork@inbox.dpdk.org",
            "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:mime-version:references:in-reply-to:from:date\n :message-id:subject:to:cc;\n bh=KKdsbht7VOOY+0OBDqFV3kv05CH13A363n0OW2+4vQo=;\n b=Wf7fUBMYFdFAv7LmFXwy+bSW5dhpDRV0/l+l+4pBJAUetB3NV/9I70V65z9IG2+znG\n wEYvjaAZatPakeDaEZTctL6pAO7T+ClkhovRn0fvep59ryb1D/Wxj84065wD6pga6xGS\n sroew0G6q4+w4bezmWYQa/1CPSRwf9A7TfqYSCAaKvTPdVsqsRqLe8GSUkGZQGdzpM88\n 8lHO09v7Dkml6WUSBhT8yF7XdQFDgsvsKxa4h4vdFF6mUkyYOzq/5D2K5rk+mVjHJsSR\n VdrQt8miufpbCxExzI9MSPeEr2mtcwUpGPHCZG1X7Ch7Gyb/qQL6qCTnQJjlWZNDObVW\n Yezg==",
            "Received": [
                "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C78F0A0521;\n\tTue, 28 Jul 2020 07:22:31 +0200 (CEST)",
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 904321BFF5;\n\tTue, 28 Jul 2020 07:22:31 +0200 (CEST)",
                "from mail-ot1-f68.google.com (mail-ot1-f68.google.com\n [209.85.210.68]) by dpdk.org (Postfix) with ESMTP id 8D8DF1BFF2\n for <dev@dpdk.org>; Tue, 28 Jul 2020 07:22:30 +0200 (CEST)",
                "by mail-ot1-f68.google.com with SMTP id 93so3874790otx.2\n for <dev@dpdk.org>; Mon, 27 Jul 2020 22:22:30 -0700 (PDT)"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH v3 09/22] net/bnxt: ignore VLAN priority mask",
            "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15",
            "X-Received": "by 2002:a9d:5f92:: with SMTP id g18mr21508343oti.95.1595913749760;\n Mon, 27 Jul 2020 22:22:29 -0700 (PDT)",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>",
            "Message-ID": "\n <CACZ4nhtns9hNMwjVAEOyijeakM8mhLeWrnge6Ny0HQt1jhfN1A@mail.gmail.com>",
            "Precedence": "list",
            "X-Gm-Message-State": "AOAM531RwPHggR1QcI8UC3cP75IFszDqWfkXvclyHThSuzhUcw+ENFT1\n V/sm9/Obi/dNk6mXoByVXB+kAODZLlH0JPmr+UbqJMMx9o4=",
            "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=mime-version:references:in-reply-to:from:date:message-id:subject:to\n :cc; bh=KKdsbht7VOOY+0OBDqFV3kv05CH13A363n0OW2+4vQo=;\n b=UQQNmLKiOGOdb1AloNTVn1Xc3AD6UdI5Wqz6cV0yFrnpReRZNvOeFhRCBEipJga36j\n vSyUBa6QuNybGt8NuFK7eMGacF6k3rqeZ+5CK0W6C8ULsddg6XYwt08IhMYimL6vPBsm\n JOWNwKY68hAoYQprDSXjLPBe73//sTZysshvc=",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "Errors-To": "dev-bounces@dpdk.org",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
            "X-Google-Smtp-Source": "\n ABdhPJxVVoCnI8UuSOc8vaGb5oqj1HwMmU8GeLBqKS3m9b7fTB4OGD2TQYKPOV0qRbgLE5WWMLfNVwEm+EBsZ4y4mTs=",
            "Cc": "dpdk-dev <dev@dpdk.org>,\n Kishore Padmanabha <kishore.padmanabha@broadcom.com>,\n Michael Baucom <michael.baucom@broadcom.com>",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Delivered-To": "patchwork@inbox.dpdk.org",
            "In-Reply-To": "<64484f93-7ee6-fc41-4fd6-ed73f42f69e8@intel.com>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "To": "Ferruh Yigit <ferruh.yigit@intel.com>"
        }
    },
    {
        "id": 116690,
        "web_url": "https://patches.dpdk.org/comment/116690/",
        "msgid": "<64484f93-7ee6-fc41-4fd6-ed73f42f69e8@intel.com>",
        "date": "2020-07-27T10:30:05",
        "subject": "Re: [dpdk-dev] [PATCH v3 09/22] net/bnxt: ignore VLAN priority mask",
        "submitter": {
            "id": 324,
            "url": "https://patches.dpdk.org/api/people/324/",
            "name": "Ferruh Yigit",
            "email": "ferruh.yigit@intel.com"
        },
        "content": "On 7/24/2020 6:32 AM, Ajit Khaparde wrote:\n> From: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\n> \n> This is a work around for the OVS setting offload rules that\n> are passing vlan priority mask as wild card and currently we\n> do not support it.\n> \n> Signed-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>\n> Reviewed-by: Michael Baucom <michael.baucom@broadcom.com>\n> ---\n>  drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 9 +++++++++\n>  1 file changed, 9 insertions(+)\n> \n> diff --git a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c\n> index 67f9319d6..665f5d381 100644\n> --- a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c\n> +++ b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c\n> @@ -709,8 +709,17 @@ ulp_rte_vlan_hdr_handler(const struct rte_flow_item *item,\n>  \t\t\tvlan_tag |= ~ULP_VLAN_TAG_MASK;\n>  \t\tvlan_tag = htons(vlan_tag);\n>  \n> +#ifdef ULP_DONT_IGNORE_TOS\n>  \t\tulp_rte_prsr_mask_copy(params, &idx, &priority,\n>  \t\t\t\t       sizeof(priority));\n> +#else\n> +\t\t/*\n> +\t\t * The priority field is ignored since OVS is setting it as\n> +\t\t * wild card match and it is not supported. This is a work\n> +\t\t * around and shall be addressed in the future.\n> +\t\t */\n> +\t\tidx += 1;\n> +#endif\n>  \t\tulp_rte_prsr_mask_copy(params, &idx, &vlan_tag,\n>  \t\t\t\t       sizeof(vlan_tag));\n>  \t\tulp_rte_prsr_mask_copy(params, &idx, &vlan_mask->inner_type,\n> \n\nHi Ajit,\n\nWhat sets the 'ULP_DONT_IGNORE_TOS', I don't see it in our build system. If ways\n'else' leg is taken, why not drop the macro completely?",
        "headers": {
            "Return-Path": "<dev-bounces@dpdk.org>",
            "References": "<20200723115639.22357-1-somnath.kotur@broadcom.com>\n <20200724053235.71069-1-ajit.khaparde@broadcom.com>\n <20200724053235.71069-10-ajit.khaparde@broadcom.com>",
            "X-Mailman-Version": "2.1.15",
            "X-IronPort-AV": [
                "E=McAfee;i=\"6000,8403,9694\"; a=\"169100004\"",
                "E=Sophos;i=\"5.75,402,1589266800\"; d=\"scan'208\";a=\"169100004\"",
                "E=Sophos;i=\"5.75,402,1589266800\"; d=\"scan'208\";a=\"433884172\""
            ],
            "From": "Ferruh Yigit <ferruh.yigit@intel.com>",
            "IronPort-SDR": [
                "\n 9MjJsmhkD6szxk1tEdSXoFQSf6Iim08BXb56ielhYSrsN2kMzsM2BI+GSwxRclRbeRX30ZsVDb\n +/OetnMabBzw==",
                "\n t21H23vjYxHu8Vo3QzXMfDGDBr3andheXRZ2BEDPYEfbcGBNNFUP/znQ8Hhg2I4thrbMgvT9KR\n /wuN/HIvtHjA=="
            ],
            "Message-ID": "<64484f93-7ee6-fc41-4fd6-ed73f42f69e8@intel.com>",
            "Autocrypt": "addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata=\n mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy\n qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ\n +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9\n GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb\n +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF\n YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy\n ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX\n CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1\n 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz\n cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln\n aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK\n CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl\n eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk\n UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT\n PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO\n lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC\n ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2\n 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H\n 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo\n cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx\n Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp\n e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59\n gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES\n YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai\n bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD\n UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/\n 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj\n sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc\n q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7\n 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB\n VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI\n 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC\n GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b\n cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz\n EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H\n o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2\n 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA\n WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA\n 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T\n GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n\n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv\n ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae\n dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ==",
            "X-Original-To": "patchwork@inbox.dpdk.org",
            "Received": [
                "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B51B2A0524;\n\tMon, 27 Jul 2020 12:30:13 +0200 (CEST)",
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6E3B21BFE2;\n\tMon, 27 Jul 2020 12:30:12 +0200 (CEST)",
                "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by dpdk.org (Postfix) with ESMTP id 715F9A69\n for <dev@dpdk.org>; Mon, 27 Jul 2020 12:30:11 +0200 (CEST)",
                "from orsmga004.jf.intel.com ([10.7.209.38])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Jul 2020 03:30:10 -0700",
                "from fyigit-mobl.ger.corp.intel.com (HELO [10.213.196.62])\n ([10.213.196.62])\n by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Jul 2020 03:30:08 -0700"
            ],
            "Subject": "Re: [dpdk-dev] [PATCH v3 09/22] net/bnxt: ignore VLAN priority mask",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "Content-Language": "en-US",
            "Content-Type": "text/plain; charset=utf-8",
            "Precedence": "list",
            "X-BeenThere": "dev@dpdk.org",
            "Date": "Mon, 27 Jul 2020 11:30:05 +0100",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "X-Amp-File-Uploaded": "False",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
            "Cc": "Kishore Padmanabha <kishore.padmanabha@broadcom.com>,\n Michael Baucom <michael.baucom@broadcom.com>",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Delivered-To": "patchwork@inbox.dpdk.org",
            "In-Reply-To": "<20200724053235.71069-10-ajit.khaparde@broadcom.com>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "MIME-Version": "1.0",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Content-Transfer-Encoding": "8bit",
            "To": "Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org",
            "X-Amp-Result": "SKIPPED(no attachment in message)",
            "Errors-To": "dev-bounces@dpdk.org"
        }
    }
]