Patch Comment List
List patch comments
GET /api/patches/74703/comments/?format=api
[ { "id": 116573, "web_url": "https://patches.dpdk.org/comment/116573/", "msgid": "<9481f69e-d83f-64cf-cfa0-4f740b64f0e8@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/9481f69e-d83f-64cf-cfa0-4f740b64f0e8@intel.com", "date": "2020-07-24T03:57:52", "subject": "Re: [dpdk-dev] [PATCH v4] net/i40e: fix incorrect hash look up table", "submitter": { "id": 507, "url": "https://patches.dpdk.org/api/people/507/?format=api", "name": "Guo, Jia", "email": "jia.guo@intel.com" }, "content": "hi, shougang\n\nOn 7/24/2020 10:47 AM, Shougang Wang wrote:\n> The hash look up table (LUT) is managed by global register but it is not\n> initialized when RSS is disabled. Once user wants to enable RSS during\n> runtime, the LUT will not be initialized.\n> This patch fixes the issue by initializing the LUT whether RSS enabled\n> or not.\n\n\n\"whatever\" but not \"whether\"?\n\n\n>\n> Fixes: feaae285b342 (\"net/i40e: support hash configuration in RSS flow\")\n> Cc: stable@dpdk.org\n>\n> Signed-off-by: Shougang Wang <shougangx.wang@intel.com>\n> ---\n> v4:\n> -Updated code.\n> ---\n> drivers/net/i40e/i40e_ethdev.c | 15 ++++-----------\n> 1 file changed, 4 insertions(+), 11 deletions(-)\n>\n> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\n> index 05d5f2861..0a3f5e3c1 100644\n> --- a/drivers/net/i40e/i40e_ethdev.c\n> +++ b/drivers/net/i40e/i40e_ethdev.c\n> @@ -8985,6 +8985,7 @@ static int\n> i40e_pf_config_rss(struct i40e_pf *pf)\n> {\n> \tstruct i40e_hw *hw = I40E_PF_TO_HW(pf);\n> +\tenum rte_eth_rx_mq_mode mq_mode = pf->dev_data->dev_conf.rxmode.mq_mode;\n> \tstruct rte_eth_rss_conf rss_conf;\n> \tuint32_t i, lut = 0;\n> \tuint16_t j, num;\n> @@ -9022,7 +9023,8 @@ i40e_pf_config_rss(struct i40e_pf *pf)\n> \t}\n> \n> \trss_conf = pf->dev_data->dev_conf.rx_adv_conf.rss_conf;\n> -\tif ((rss_conf.rss_hf & pf->adapter->flow_types_mask) == 0) {\n> +\tif ((rss_conf.rss_hf & pf->adapter->flow_types_mask) == 0 ||\n> +\t !(mq_mode & ETH_MQ_RX_RSS_FLAG)) {\n> \t\ti40e_pf_disable_rss(pf);\n> \t\treturn 0;\n> \t}\n> @@ -9198,16 +9200,7 @@ i40e_tunnel_filter_handle(struct rte_eth_dev *dev,\n> static int\n> i40e_pf_config_mq_rx(struct i40e_pf *pf)\n\n\nThis function is still need or could it be replace by i40e_pf_config_rss?\n\n\n> {\n> -\tint ret = 0;\n> -\tenum rte_eth_rx_mq_mode mq_mode = pf->dev_data->dev_conf.rxmode.mq_mode;\n> -\n> -\t/* RSS setup */\n> -\tif (mq_mode & ETH_MQ_RX_RSS_FLAG)\n> -\t\tret = i40e_pf_config_rss(pf);\n> -\telse\n> -\t\ti40e_pf_disable_rss(pf);\n> -\n> -\treturn ret;\n> +\treturn i40e_pf_config_rss(pf);\n> }\n> \n> /* Get the symmetric hash enable configurations per port */", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 59682A0518;\n\tFri, 24 Jul 2020 05:57:58 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D9BEA1D5F5;\n\tFri, 24 Jul 2020 05:57:57 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by dpdk.org (Postfix) with ESMTP id 8D8D61D451;\n Fri, 24 Jul 2020 05:57:55 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Jul 2020 20:57:54 -0700", "from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.150])\n ([10.67.68.150])\n by orsmga002.jf.intel.com with ESMTP; 23 Jul 2020 20:57:53 -0700" ], "IronPort-SDR": [ "\n lTW6YKg6Q3+614ydFH3CGbSHfWWnAK1TAhsYtPtQiVybGN+LDVGw4yNy5U4Vq2svCV2MWuRKLT\n wHwS6kmklIWQ==", "\n f4uMpoRSROpnCxlpudln49y3+EyXktTTUcd9KAawYl1+oFAXDh33JYAMDTOwDZfOwQqoPzgXdY\n UWWXH0fcs9PQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9691\"; a=\"168787021\"", "E=Sophos;i=\"5.75,389,1589266800\"; d=\"scan'208\";a=\"168787021\"", "E=Sophos;i=\"5.75,389,1589266800\"; d=\"scan'208\";a=\"302541241\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "To": "Shougang Wang <shougangx.wang@intel.com>, dev@dpdk.org", "Cc": "beilei.xing@intel.com, stable@dpdk.org", "References": "<20200715063515.9262-1-shougangx.wang@intel.com>\n <20200724024712.10727-1-shougangx.wang@intel.com>", "From": "Jeff Guo <jia.guo@intel.com>", "Message-ID": "<9481f69e-d83f-64cf-cfa0-4f740b64f0e8@intel.com>", "Date": "Fri, 24 Jul 2020 11:57:52 +0800", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101\n Thunderbird/68.10.0", "MIME-Version": "1.0", "In-Reply-To": "<20200724024712.10727-1-shougangx.wang@intel.com>", "Content-Type": "text/plain; charset=utf-8; format=flowed", "Content-Transfer-Encoding": "7bit", "Content-Language": "en-US", "Subject": "Re: [dpdk-dev] [PATCH v4] net/i40e: fix incorrect hash look up table", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116575, "web_url": "https://patches.dpdk.org/comment/116575/", "msgid": "<BYAPR11MB3477CC1009ED8A5D70F1471A88770@BYAPR11MB3477.namprd11.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/BYAPR11MB3477CC1009ED8A5D70F1471A88770@BYAPR11MB3477.namprd11.prod.outlook.com", "date": "2020-07-24T04:49:19", "subject": "Re: [dpdk-dev] [PATCH v4] net/i40e: fix incorrect hash look up table", "submitter": { "id": 1418, "url": "https://patches.dpdk.org/api/people/1418/?format=api", "name": "Shougang Wang", "email": "shougangx.wang@intel.com" }, "content": "Hi, Jeff\n\n> -----Original Message-----\n> From: Guo, Jia <jia.guo@intel.com>\n> Sent: Friday, July 24, 2020 11:58 AM\n> To: Wang, ShougangX <shougangx.wang@intel.com>; dev@dpdk.org\n> Cc: Xing, Beilei <beilei.xing@intel.com>; stable@dpdk.org\n> Subject: Re: [PATCH v4] net/i40e: fix incorrect hash look up table\n> \n> hi, shougang\n> \n> On 7/24/2020 10:47 AM, Shougang Wang wrote:\n> > The hash look up table (LUT) is managed by global register but it is\n> > not initialized when RSS is disabled. Once user wants to enable RSS\n> > during runtime, the LUT will not be initialized.\n> > This patch fixes the issue by initializing the LUT whether RSS enabled\n> > or not.\n> \n> \n> \"whatever\" but not \"whether\"?\n\"whatever\", I will fix it.\n\n> \n> \n> >\n> > Fixes: feaae285b342 (\"net/i40e: support hash configuration in RSS\n> > flow\")\n> > Cc: stable@dpdk.org\n> >\n> > Signed-off-by: Shougang Wang <shougangx.wang@intel.com>\n> > ---\n> > v4:\n> > -Updated code.\n> > ---\n> > drivers/net/i40e/i40e_ethdev.c | 15 ++++-----------\n> > 1 file changed, 4 insertions(+), 11 deletions(-)\n> >\n> > diff --git a/drivers/net/i40e/i40e_ethdev.c\n> > b/drivers/net/i40e/i40e_ethdev.c index 05d5f2861..0a3f5e3c1 100644\n> > --- a/drivers/net/i40e/i40e_ethdev.c\n> > +++ b/drivers/net/i40e/i40e_ethdev.c\n> > @@ -8985,6 +8985,7 @@ static int\n> > i40e_pf_config_rss(struct i40e_pf *pf)\n> > {\n> > \tstruct i40e_hw *hw = I40E_PF_TO_HW(pf);\n> > +\tenum rte_eth_rx_mq_mode mq_mode =\n> > +pf->dev_data->dev_conf.rxmode.mq_mode;\n> > \tstruct rte_eth_rss_conf rss_conf;\n> > \tuint32_t i, lut = 0;\n> > \tuint16_t j, num;\n> > @@ -9022,7 +9023,8 @@ i40e_pf_config_rss(struct i40e_pf *pf)\n> > \t}\n> >\n> > \trss_conf = pf->dev_data->dev_conf.rx_adv_conf.rss_conf;\n> > -\tif ((rss_conf.rss_hf & pf->adapter->flow_types_mask) == 0) {\n> > +\tif ((rss_conf.rss_hf & pf->adapter->flow_types_mask) == 0 ||\n> > +\t !(mq_mode & ETH_MQ_RX_RSS_FLAG)) {\n> > \t\ti40e_pf_disable_rss(pf);\n> > \t\treturn 0;\n> > \t}\n> > @@ -9198,16 +9200,7 @@ i40e_tunnel_filter_handle(struct rte_eth_dev\n> *dev,\n> > static int\n> > i40e_pf_config_mq_rx(struct i40e_pf *pf)\n> \n> \n> This function is still need or could it be replace by i40e_pf_config_rss?\nIt can be replaced by i40e_pf_config_rss, thanks for your review.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C1DA0A0518;\n\tFri, 24 Jul 2020 06:49:26 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 246A31D533;\n\tFri, 24 Jul 2020 06:49:25 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id 63AC41C211;\n Fri, 24 Jul 2020 06:49:23 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Jul 2020 21:49:22 -0700", "from orsmsx605.amr.corp.intel.com ([10.22.229.18])\n by orsmga008.jf.intel.com with ESMTP; 23 Jul 2020 21:49:22 -0700", "from orsmsx605.amr.corp.intel.com (10.22.229.18) by\n ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.1713.5; Thu, 23 Jul 2020 21:49:21 -0700", "from ORSEDG001.ED.cps.intel.com (10.7.248.4) by\n orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5\n via Frontend Transport; Thu, 23 Jul 2020 21:49:21 -0700", "from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.58) by\n edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server\n (TLS) id 14.3.439.0; Thu, 23 Jul 2020 21:49:21 -0700", "from BYAPR11MB3477.namprd11.prod.outlook.com (2603:10b6:a03:7c::28)\n by BY5PR11MB3894.namprd11.prod.outlook.com (2603:10b6:a03:18c::20)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.24; Fri, 24 Jul\n 2020 04:49:19 +0000", "from BYAPR11MB3477.namprd11.prod.outlook.com\n ([fe80::11b9:abd9:39e0:f26a]) by BYAPR11MB3477.namprd11.prod.outlook.com\n ([fe80::11b9:abd9:39e0:f26a%3]) with mapi id 15.20.3195.025; Fri, 24 Jul 2020\n 04:49:19 +0000" ], "IronPort-SDR": [ "\n jQ8HUs3rx5pUMfRaVxZTVATkXeseRFGi75BaG8OZsUUMZBpbuZL3aaZwkhWuePDsGE0lB4lG1U\n UpZLaU7qYRpQ==", "\n FRsV9HlOEU6uqwesHssVL8pcqrIGHdxjSMODcRxUid2DXxlGq7O2Nlj0oy6sifvaml3BMxms/P\n aVfFg6W8PsAw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9691\"; a=\"151950810\"", "E=Sophos;i=\"5.75,389,1589266800\"; d=\"scan'208\";a=\"151950810\"", "E=Sophos;i=\"5.75,389,1589266800\"; d=\"scan'208\";a=\"319205794\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=ciCZqgfBCkxcCLfE7lXWapWH5gi31ozrWghLA/nugAHwHxptwqLqajeYWxTFJ2T8n9p06ubWyPyyTFx4DJOilkPLz9UzZlIaF0LfQttcBYIQ8cyi1mFHtgjswdblR5miv27BwJFUn/0+58V3RwpuMGShySvV3nX3EEvree7O9NHbbmqge+SyumQB981p+KODG9FKDTy8ro7N1tio1Jxv6ovSxcFAgax+xwT6ZHW3WHU5NfORShKlwrBVfrTN+jMXYb/Eu9DcJvIssUb6k5e+9mzIXBn05vpObMrSuRwgQb9TTCcaFCtF6evNXoLq628T/tMrxEbIKG7Gv+GAEnug+w==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=TpCLjezauC/4kgmI+KhfiqzgZmiQdfk17xVCYGzCpOk=;\n b=BRluPUuXtJWsflcceDPY0zJDTOTJx6mx+HATMtUFQOWfc6hjIOrh5CF4swiCwxiGI1g9W5LEYZd9VgVpd9bhITZzF7sLH5EaizFm4f26C9rPaUjgrMqu/tO7YNikvG2PSTMIdExNRPXgNde7rWBFur/BGuI7jYlEJt67ilg4o6XksyOizTLUTJkv19IgHZTAWKhnb2hIfbTMpcWpvwWDdx7kM8iLilglbX5n7w0grv0koBVRDwQnCwyNnaqbDdh2YbzffITYZzzPCrVgNgLZr3ZNWktxlPpBeJzXqWHbjvRRT/ovWiyrXF5lm1lnZgSG2MagZnQ6CachjdMOQBGBtA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;\n s=selector2-intel-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=TpCLjezauC/4kgmI+KhfiqzgZmiQdfk17xVCYGzCpOk=;\n b=eb+89f13/QO+Q6AU04rb/2UdViXMg590VUYPnFz4brFyKBL58EkBhQXjOBEvDAi4AXM8DidQDsPgs6y8cngeQznXX6OwO2HLAr23r+N3t5dCWlgsFmceVJ1n4wRQ/kfJdUlHGApAEZlnsnDFgWAJU1iZqpYmkDbdEZIWGErWKfo=", "From": "\"Wang, ShougangX\" <shougangx.wang@intel.com>", "To": "\"Guo, Jia\" <jia.guo@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"Xing, Beilei\" <beilei.xing@intel.com>,\n \"stable@dpdk.org\" <stable@dpdk.org>", "Thread-Topic": "[PATCH v4] net/i40e: fix incorrect hash look up table", "Thread-Index": "AQHWYWeGVDEv7hi1akun0axOM7lZWKkWGmUAgAAM5yA=", "Date": "Fri, 24 Jul 2020 04:49:19 +0000", "Message-ID": "\n <BYAPR11MB3477CC1009ED8A5D70F1471A88770@BYAPR11MB3477.namprd11.prod.outlook.com>", "References": "<20200715063515.9262-1-shougangx.wang@intel.com>\n <20200724024712.10727-1-shougangx.wang@intel.com>\n <9481f69e-d83f-64cf-cfa0-4f740b64f0e8@intel.com>", "In-Reply-To": "<9481f69e-d83f-64cf-cfa0-4f740b64f0e8@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "intel.com; dkim=none (message not signed)\n header.d=none;intel.com; dmarc=none action=none header.from=intel.com;", "x-originating-ip": "[192.55.46.46]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "7bb436d3-a7d4-415f-bc4b-08d82f8ced58", "x-ms-traffictypediagnostic": "BY5PR11MB3894:", "x-ld-processed": "46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <BY5PR11MB389473134A42A84040D760B888770@BY5PR11MB3894.namprd11.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:4502;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n W8y+Z4Y6AHT7DwqueznZuHzZyEmTuScWTea9UjCUt4GBTjKBcEklnXfGlUWgC+rJtuXV/ceB3fAGaIhaBa9XS28sp+KHA/G/IB738nBsBynS/IIIP2vt+n90ieU8o3OCXtsvVksmspnXXt2nQrJwx4BaKJC8ejgJIzIrOLLc3oem/USstAshVOnC7NmAadGRMkjKTWO+LmjfWxuLUrkvtKF+lT5TtRwKoJMzrpOtl7WQdHF/T4NrREyX64EAr9LcfgVvDtbnGQaBIUCZwT0xyk2s6okHnmOBd6bNJMid8wCV02smJOfd51m2WnpJFTAlwcfAdMrUCMWGJHnCjEis/g==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:BYAPR11MB3477.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(39860400002)(136003)(376002)(346002)(396003)(366004)(186003)(8936002)(26005)(8676002)(64756008)(478600001)(33656002)(86362001)(7696005)(316002)(66446008)(2906002)(83380400001)(66476007)(66556008)(66946007)(55016002)(450100002)(9686003)(76116006)(110136005)(6506007)(53546011)(54906003)(52536014)(5660300002)(4326008)(71200400001);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata": "\n i+2tNEF+IUgypJfn4RJeDsrbQjUqMvmcGMly8A6T34/fzibvjqMKoTAujxlqXgRv5AhYTn0TH4ylUTGK8ujQfFjWdkJG2wybnlNzbrW7miO0LzWa+Gge/IW+JNqJp6pTF2eFNiGwZdUZOhCCKWQ33woxoQBKOA5BkUw5hPllRl7JYoh/yo1CZMElXhstGC39a79yNT7z+2VzKJ/dfc6nLaO8NuVdSX919vUjqnvXZiz4hVvz6qJsZT5Fhujy06GHffFzZyyBIemlkz/lso1Pw9xoMmrKGUwMSwQPPWIt1rpMZwwTc1WPAEJaa+xJUrtaN/aYDb1T8SZiYklUKAD8+AUBsGsg3Qmgh3vr4e/lvYBgQPiFFCuxfLF9CtSTl/NBtRv/JEOyhOqSS8i9N/KmhvIg6fUj1VuPnxcUc6gqGpy5AuxKs/btncKBWZOKGTXFDk9p1VxE2oSvNdDbnAPHM52P0bqUCUl/dieqLsGR6Kc=", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "BYAPR11MB3477.namprd11.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 7bb436d3-a7d4-415f-bc4b-08d82f8ced58", "X-MS-Exchange-CrossTenant-originalarrivaltime": "24 Jul 2020 04:49:19.4958 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "46c98d88-e344-4ed4-8496-4ed7712e255d", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n 9KGoOa8l5mAvBraNUQRI8Lg7xVaXJj/MueNq0qW8t2Apc3+eTom8JTgYaOwnTYomvH1/lGiTazOQU4B7Ut/oUt0LaMzoHkFUDIqcVNngWGQ=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BY5PR11MB3894", "X-OriginatorOrg": "intel.com", "Subject": "Re: [dpdk-dev] [PATCH v4] net/i40e: fix incorrect hash look up table", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116577, "web_url": "https://patches.dpdk.org/comment/116577/", "msgid": "<BN6PR11MB00172061D0D00FD185107EE5E5770@BN6PR11MB0017.namprd11.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/BN6PR11MB00172061D0D00FD185107EE5E5770@BN6PR11MB0017.namprd11.prod.outlook.com", "date": "2020-07-24T05:07:49", "subject": "Re: [dpdk-dev] [PATCH v4] net/i40e: fix incorrect hash look up table", "submitter": { "id": 522, "url": "https://patches.dpdk.org/api/people/522/?format=api", "name": "Qiming Yang", "email": "qiming.yang@intel.com" }, "content": "Hi, Shougang\nThis version looks better, only two small questions.\nOnce somebody gave comments to your patch, you should reply the comments and CC when you send patch next version.\nYou don't include me in this version, don't forget this next time.\n\nQiming\n> -----Original Message-----\n> From: dev <dev-bounces@dpdk.org> On Behalf Of Shougang Wang\n> Sent: Friday, July 24, 2020 10:47\n> To: dev@dpdk.org\n> Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>; Wang,\n> ShougangX <shougangx.wang@intel.com>; stable@dpdk.org\n> Subject: [dpdk-dev] [PATCH v4] net/i40e: fix incorrect hash look up table\n> \n> The hash look up table (LUT) is managed by global register but it is not\n> initialized when RSS is disabled. Once user wants to enable RSS during\n> runtime, the LUT will not be initialized.\n> This patch fixes the issue by initializing the LUT whether RSS enabled or not.\n> \n> Fixes: feaae285b342 (\"net/i40e: support hash configuration in RSS flow\")\n> Cc: stable@dpdk.org\n> \n> Signed-off-by: Shougang Wang <shougangx.wang@intel.com>\n> ---\n> v4:\n> -Updated code.\n> ---\n> drivers/net/i40e/i40e_ethdev.c | 15 ++++-----------\n> 1 file changed, 4 insertions(+), 11 deletions(-)\n> \n> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\n> index 05d5f2861..0a3f5e3c1 100644\n> --- a/drivers/net/i40e/i40e_ethdev.c\n> +++ b/drivers/net/i40e/i40e_ethdev.c\n> @@ -8985,6 +8985,7 @@ static int\n> i40e_pf_config_rss(struct i40e_pf *pf)\n> {\n> \tstruct i40e_hw *hw = I40E_PF_TO_HW(pf);\n> +\tenum rte_eth_rx_mq_mode mq_mode =\n> +pf->dev_data->dev_conf.rxmode.mq_mode;\n\nNo tab?\n\n> \tstruct rte_eth_rss_conf rss_conf;\n> \tuint32_t i, lut = 0;\n> \tuint16_t j, num;\n> @@ -9022,7 +9023,8 @@ i40e_pf_config_rss(struct i40e_pf *pf)\n> \t}\n> \n> \trss_conf = pf->dev_data->dev_conf.rx_adv_conf.rss_conf;\n> -\tif ((rss_conf.rss_hf & pf->adapter->flow_types_mask) == 0) {\n> +\tif ((rss_conf.rss_hf & pf->adapter->flow_types_mask) == 0 ||\n> +\t !(mq_mode & ETH_MQ_RX_RSS_FLAG)) {\n> \t\ti40e_pf_disable_rss(pf);\n> \t\treturn 0;\n> \t}\n> @@ -9198,16 +9200,7 @@ i40e_tunnel_filter_handle(struct rte_eth_dev\n> *dev, static int i40e_pf_config_mq_rx(struct i40e_pf *pf) {\n> -\tint ret = 0;\n> -\tenum rte_eth_rx_mq_mode mq_mode = pf->dev_data-\n> >dev_conf.rxmode.mq_mode;\n> -\n> -\t/* RSS setup */\n> -\tif (mq_mode & ETH_MQ_RX_RSS_FLAG)\n> -\t\tret = i40e_pf_config_rss(pf);\n> -\telse\n> -\t\ti40e_pf_disable_rss(pf);\n> -\n> -\treturn ret;\n> +\treturn i40e_pf_config_rss(pf);\n\nIf only have one function call in this function, we can delete it, and just use\ni40e_pf_config_rss(pf) instead of i40e_pf_config_mq_rx.\n\n> }\n> \n> /* Get the symmetric hash enable configurations per port */\n> --\n> 2.17.1", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A9796A0518;\n\tFri, 24 Jul 2020 07:08:03 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4FF5F1D530;\n\tFri, 24 Jul 2020 07:08:02 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 6CE491D44F;\n Fri, 24 Jul 2020 07:07:59 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Jul 2020 22:07:58 -0700", "from orsmsx602.amr.corp.intel.com ([10.22.229.15])\n by fmsmga005.fm.intel.com with ESMTP; 23 Jul 2020 22:07:57 -0700", "from orsmsx612.amr.corp.intel.com (10.22.229.25) by\n ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.1713.5; Thu, 23 Jul 2020 22:07:57 -0700", "from ORSEDG002.ED.cps.intel.com (10.7.248.5) by\n orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5\n via Frontend Transport; Thu, 23 Jul 2020 22:07:57 -0700", "from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by\n edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server\n (TLS) id 14.3.439.0; Thu, 23 Jul 2020 22:07:54 -0700", "from BN6PR11MB0017.namprd11.prod.outlook.com (2603:10b6:405:6c::34)\n by BN8PR11MB3716.namprd11.prod.outlook.com (2603:10b6:408:8a::30)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.23; Fri, 24 Jul\n 2020 05:07:49 +0000", "from BN6PR11MB0017.namprd11.prod.outlook.com\n ([fe80::c8eb:f4c9:5b58:3120]) by BN6PR11MB0017.namprd11.prod.outlook.com\n ([fe80::c8eb:f4c9:5b58:3120%6]) with mapi id 15.20.3195.028; Fri, 24 Jul 2020\n 05:07:49 +0000" ], "IronPort-SDR": [ "\n uAo1svIXl3JfPY+1Zi5yjwW2Quc/iBGvKAYANpuEYSyioLrCUDLm79LnSj4sMnVXI6BqJll30L\n WP1VcGPPiQmg==", "\n lLlpxYdqeyiB/CpGCx/yi6sNyfsAGA8vzOF2+AqVJwBEpGu3jAL5CxZxHVo73ULm+VlJezqEmb\n UMhw6ZN5sHQA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9691\"; a=\"150645893\"", "E=Sophos;i=\"5.75,389,1589266800\"; d=\"scan'208\";a=\"150645893\"", "E=Sophos;i=\"5.75,389,1589266800\"; d=\"scan'208\";a=\"489082247\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=eXgzdx5F3n7KAEZK5jdIKJFNYE3O6KsF+Y5XGvREuMVTxYiP6tW9set3nxLto3YIIFKZap/HpEqeW0j02lmO/vvJJhCN6QPUJWnF0NqoMG9lApEvzafBe/CAAXBzDsDWMOLK6VHPDpZDs0ZqGQK7HwhidpwA+94WxbtnduCel8M3Os6FRuXLT4Uo3fi1lnfGlPV3paoh0XryQ9waTs4uAP/hCd/Lt9psukbPS0y8Z4Y/9uA5/cR/3bjG16ks8EaTXtBiN1IHnXC/UhK3Kx/4CUSMnbXvgaDv7QeZrZic2RKtgiDWY5FUWrNKh+N2epDfVJS8j8EB66FhGmi+Au8u2A==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=jDhz9p5lpad4AsfCa9I4eeMIqwhE00hJ05iAFtjbFk8=;\n b=Zu1ra6zsqxkSF1IdfLa0inK+yXfwplS7QTf5M9LftXvbQY8NBm5IqvuJpmDT7Xc+tO02B9+03qrsWK3TFgPdIHR1elZeIx2lr0pYH0z7jKM+2jjSLTJiHwWrL1FLEupFrPUct2tTOuXy0bmXz2dp4kH7y/dH8oUrgJRD4RUajHaoyWpcukfr8jAi0ZG1X+7VhjqdAUgjugvRlR9Mj6fdCo8B1QqcCtF5dIAWmpygKw390nFceM7xWMraASTBBSLNti2exHtluF8sXnTlMSfL5UHqmOm857k6Q8GVv2trPEANZV4vxhlP4O9zFWS/DTvbup+CymEmvbzf/m4NDkWsDA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;\n s=selector2-intel-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=jDhz9p5lpad4AsfCa9I4eeMIqwhE00hJ05iAFtjbFk8=;\n b=d2/e4yj6NiSivGdjHKe4wRECP2A0sldG5lMVSaFdrSDILfWeR8k9NSHmhDF61Nuvf65ZIoyot8YvuLzhN4yvfYZWmHuk3B8UO03DMJacRY3KwCu6k4IJjY/M1wDAeAG9F3Tec2sUW089zxLTITrGWI1YYYPtXd3RmNfpbU4k5pk=", "From": "\"Yang, Qiming\" <qiming.yang@intel.com>", "To": "\"Wang, ShougangX\" <shougangx.wang@intel.com>,\n \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"Xing, Beilei\" <beilei.xing@intel.com>, \"Guo, Jia\" <jia.guo@intel.com>,\n \"Wang, ShougangX\" <shougangx.wang@intel.com>, \"stable@dpdk.org\"\n <stable@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH v4] net/i40e: fix incorrect hash look up table", "Thread-Index": "AQHWYWeQOz0f4vGahk+Z3HZHCOs8DKkWLESQ", "Date": "Fri, 24 Jul 2020 05:07:49 +0000", "Message-ID": "\n <BN6PR11MB00172061D0D00FD185107EE5E5770@BN6PR11MB0017.namprd11.prod.outlook.com>", "References": "<20200715063515.9262-1-shougangx.wang@intel.com>\n <20200724024712.10727-1-shougangx.wang@intel.com>", "In-Reply-To": "<20200724024712.10727-1-shougangx.wang@intel.com>", "Accept-Language": "en-US, zh-CN", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "intel.com; dkim=none (message not signed)\n header.d=none;intel.com; dmarc=none action=none header.from=intel.com;", "x-originating-ip": "[192.102.204.45]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "9f5671f5-ae04-4286-f32c-08d82f8f82a5", "x-ms-traffictypediagnostic": "BN8PR11MB3716:", "x-ld-processed": "46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <BN8PR11MB37162A3821A62A91992D71B7E5770@BN8PR11MB3716.namprd11.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:1923;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n zftWtAAt/fsdMJ0xjtINfzrZolvF/qR0ZXeqQbEQ78HxPD4lNkllVI1Jobuxm2REhjT2YhkcEnDHItRYoTYle0wx7m54itrOJwzVbrvslIjlZO+Bf0bIwa3dCYBX6TnMjJK/yJQdaQn+6v9/4xV/YOd13YcaN5XLFxtANfpH4UZYURpImQsKhfJ+MzOH/ua5kjmDHaDM2ROAp8EzEsnUv42zIBI2EBqwiN+0IWCpYa9aMH0BkwuKDEexocBzEJvyaWpqUKnCPiYYkw3I9nl3/Pxxux2MnGQXuh4p2HgJa3qNifhuhSWgPK57HGwEEm8F2x8iBOLewiiCISdQw1OxXA==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:BN6PR11MB0017.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(39860400002)(136003)(376002)(346002)(396003)(366004)(26005)(8676002)(186003)(8936002)(64756008)(478600001)(7696005)(86362001)(66446008)(2906002)(33656002)(83380400001)(316002)(66476007)(66556008)(66946007)(55016002)(9686003)(450100002)(76116006)(110136005)(6506007)(53546011)(54906003)(52536014)(5660300002)(4326008)(71200400001);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata": "\n qn7/nQafC7dG8D2VZbS7sh/9s5Mobeh1BP9hiIocgxh6xYvcqfV8UAqtLjrGDypaiyQBbCPe9wZlkhasG6BmaAxG0hz4NKiMzrRgnRxwpXAo2tPLWb7WEUAJP7rSOB4qFC0ZBPRAfUbhYo0wcn9KlI2djDHPj8aNHsORJjCJCO66tyTdqO1XdsXkhBuU9lxczcaxC/9QMA+o6ssfIShF0iJWBkmnkVDmo1GS0TILYd9YqQYbZHJbaVgOveeB+Zd5pJFJFmxZCM7S1Hz3uCXL82UeUcXwPZJAWIUzmU6GgDNdYwKhNp+sz2fUjkIwbZU4fbw9kRoHuAqfgZ1qnnyF08wHW+UZoKOHauwvUtH/ZPQF6RhE9iov6INF2vBybrI5HN4Yvd5BT7kHG2qedm7y/ENkMTH7NPdQlVpI1+OIJcrH7QlucfZIWLXimuHbm0qJ7p04BipD6Og0+axymazrdKCbtGTyfZAz+a3ryfuhgF3sXNnMFstXh2EFbm7gL/En", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "BN6PR11MB0017.namprd11.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 9f5671f5-ae04-4286-f32c-08d82f8f82a5", "X-MS-Exchange-CrossTenant-originalarrivaltime": "24 Jul 2020 05:07:49.0348 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "46c98d88-e344-4ed4-8496-4ed7712e255d", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n aw4Q3PDjo1RTLIb9hyZIlOyLN0LL4eE1Qz6pS83+Bnuhdm+hgFDcfkE3PD2X6rhIRZW+FaKGE2MzClBdjFhdMA==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN8PR11MB3716", "X-OriginatorOrg": "intel.com", "Subject": "Re: [dpdk-dev] [PATCH v4] net/i40e: fix incorrect hash look up table", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116579, "web_url": "https://patches.dpdk.org/comment/116579/", "msgid": "<BYAPR11MB3477E2A83ED7F82CEE54C29B88770@BYAPR11MB3477.namprd11.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/BYAPR11MB3477E2A83ED7F82CEE54C29B88770@BYAPR11MB3477.namprd11.prod.outlook.com", "date": "2020-07-24T05:42:48", "subject": "Re: [dpdk-dev] [PATCH v4] net/i40e: fix incorrect hash look up table", "submitter": { "id": 1418, "url": "https://patches.dpdk.org/api/people/1418/?format=api", "name": "Shougang Wang", "email": "shougangx.wang@intel.com" }, "content": "Hi, Qiming\n\n> -----Original Message-----\n> From: Yang, Qiming <qiming.yang@intel.com>\n> Sent: Friday, July 24, 2020 1:08 PM\n> To: Wang, ShougangX <shougangx.wang@intel.com>; dev@dpdk.org\n> Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>; Wang,\n> ShougangX <shougangx.wang@intel.com>; stable@dpdk.org\n> Subject: RE: [dpdk-dev] [PATCH v4] net/i40e: fix incorrect hash look up table\n> \n> Hi, Shougang\n> This version looks better, only two small questions.\n> Once somebody gave comments to your patch, you should reply the\n> comments and CC when you send patch next version.\n> You don't include me in this version, don't forget this next time.\nGot it, I will keep in mind.\n\n> Qiming\n> > -----Original Message-----\n> > From: dev <dev-bounces@dpdk.org> On Behalf Of Shougang Wang\n> > Sent: Friday, July 24, 2020 10:47\n> > To: dev@dpdk.org\n> > Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia\n> > <jia.guo@intel.com>; Wang, ShougangX <shougangx.wang@intel.com>;\n> > stable@dpdk.org\n> > Subject: [dpdk-dev] [PATCH v4] net/i40e: fix incorrect hash look up\n> > table\n> >\n> > The hash look up table (LUT) is managed by global register but it is\n> > not initialized when RSS is disabled. Once user wants to enable RSS\n> > during runtime, the LUT will not be initialized.\n> > This patch fixes the issue by initializing the LUT whether RSS enabled or not.\n> >\n> > Fixes: feaae285b342 (\"net/i40e: support hash configuration in RSS\n> > flow\")\n> > Cc: stable@dpdk.org\n> >\n> > Signed-off-by: Shougang Wang <shougangx.wang@intel.com>\n> > ---\n> > v4:\n> > -Updated code.\n> > ---\n> > drivers/net/i40e/i40e_ethdev.c | 15 ++++-----------\n> > 1 file changed, 4 insertions(+), 11 deletions(-)\n> >\n> > diff --git a/drivers/net/i40e/i40e_ethdev.c\n> > b/drivers/net/i40e/i40e_ethdev.c index 05d5f2861..0a3f5e3c1 100644\n> > --- a/drivers/net/i40e/i40e_ethdev.c\n> > +++ b/drivers/net/i40e/i40e_ethdev.c\n> > @@ -8985,6 +8985,7 @@ static int\n> > i40e_pf_config_rss(struct i40e_pf *pf) {\n> > \tstruct i40e_hw *hw = I40E_PF_TO_HW(pf);\n> > +\tenum rte_eth_rx_mq_mode mq_mode =\n> > +pf->dev_data->dev_conf.rxmode.mq_mode;\n> \n> No tab?\nActually, this line is on the same line as the code above, but it looks like two lines here.\nI will adjust the position of this definition to follow the \"Christmas tree\" in next version.\n\n> \n> > \tstruct rte_eth_rss_conf rss_conf;\n> > \tuint32_t i, lut = 0;\n> > \tuint16_t j, num;\n> > @@ -9022,7 +9023,8 @@ i40e_pf_config_rss(struct i40e_pf *pf)\n> > \t}\n> >\n> > \trss_conf = pf->dev_data->dev_conf.rx_adv_conf.rss_conf;\n> > -\tif ((rss_conf.rss_hf & pf->adapter->flow_types_mask) == 0) {\n> > +\tif ((rss_conf.rss_hf & pf->adapter->flow_types_mask) == 0 ||\n> > +\t !(mq_mode & ETH_MQ_RX_RSS_FLAG)) {\n> > \t\ti40e_pf_disable_rss(pf);\n> > \t\treturn 0;\n> > \t}\n> > @@ -9198,16 +9200,7 @@ i40e_tunnel_filter_handle(struct rte_eth_dev\n> > *dev, static int i40e_pf_config_mq_rx(struct i40e_pf *pf) {\n> > -\tint ret = 0;\n> > -\tenum rte_eth_rx_mq_mode mq_mode = pf->dev_data-\n> > >dev_conf.rxmode.mq_mode;\n> > -\n> > -\t/* RSS setup */\n> > -\tif (mq_mode & ETH_MQ_RX_RSS_FLAG)\n> > -\t\tret = i40e_pf_config_rss(pf);\n> > -\telse\n> > -\t\ti40e_pf_disable_rss(pf);\n> > -\n> > -\treturn ret;\n> > +\treturn i40e_pf_config_rss(pf);\n> \n> If only have one function call in this function, we can delete it, and just use\n> i40e_pf_config_rss(pf) instead of i40e_pf_config_mq_rx.\nGot it. Thanks for your review.\n\nThanks.\nShougang", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 86F97A0518;\n\tFri, 24 Jul 2020 07:42:59 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 29DC01C01E;\n\tFri, 24 Jul 2020 07:42:58 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id B090CE07;\n Fri, 24 Jul 2020 07:42:55 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Jul 2020 22:42:54 -0700", "from fmsmsx103.amr.corp.intel.com ([10.18.124.201])\n by orsmga002.jf.intel.com with ESMTP; 23 Jul 2020 22:42:53 -0700", "from fmsmsx123.amr.corp.intel.com (10.18.125.38) by\n FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Thu, 23 Jul 2020 22:42:52 -0700", "from FMSEDG001.ED.cps.intel.com (10.1.192.133) by\n fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Thu, 23 Jul 2020 22:42:51 -0700", "from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109)\n by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id\n 14.3.439.0; Thu, 23 Jul 2020 22:42:50 -0700", "from BYAPR11MB3477.namprd11.prod.outlook.com (2603:10b6:a03:7c::28)\n by BY5PR11MB4226.namprd11.prod.outlook.com (2603:10b6:a03:1bf::12)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.21; Fri, 24 Jul\n 2020 05:42:49 +0000", "from BYAPR11MB3477.namprd11.prod.outlook.com\n ([fe80::11b9:abd9:39e0:f26a]) by BYAPR11MB3477.namprd11.prod.outlook.com\n ([fe80::11b9:abd9:39e0:f26a%3]) with mapi id 15.20.3195.025; Fri, 24 Jul 2020\n 05:42:49 +0000" ], "IronPort-SDR": [ "\n t+9V4v1GPPKzYvM+JBp6SNUQLnGSjQcLvAxHCOmE3rFyzjHl/OQqz5h36PBeX58+MdInn7rLnR\n k6LnjEBIPtxg==", "\n 3z3oqCNocdQJ6DmmSWqqMRfyAP5iyLUJte4vg7pUXjwtwy2ffkYkqhURe7WKUvlE59flNSx84Z\n Ri8XzDYN5Seg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9691\"; a=\"215251723\"", "E=Sophos;i=\"5.75,389,1589266800\"; d=\"scan'208\";a=\"215251723\"", "E=Sophos;i=\"5.75,389,1589266800\"; d=\"scan'208\";a=\"302558626\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Yz1IZJ3VZxIOzrdecGIE8Mi41BHcytxM2HQEaj5yWJFEFvr92O/oLQ3YUMNBStM73v3DUMRx7Agg0Z9+bkTrE9RXSZVpZLmC132cCTEYIHx/EisuXL51zTquxpQUgwKM3o+uWZXDdeRQqqizNzLtDNU0af9te/nwEoo0FWoGqUbUC4mSSwzkugQ+L7AeL34J3dKFY0/cxzlnzw3j1z2i4LI6U1JKS6XZXVLm9ns8nlvqDKktpbyumP2Cqybvl+2udRMLReF+ns3jjFVUk1MNCdiF5sVqJNxUMhh8h+4FannUqCZvLdZOdeDeZf2Ur2/bw9LTtojYsUb8NFrQDf5KhQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=LwM4yFijrlbgqUk6PA7cAOshQXrlj/HMr0FCy3hX/BM=;\n b=SeKwDZh152qcEf2cL51C8tmQVx/T76YCCeqOKUcT9zxvLYYg/4JRJujbVRFncJJm5xiXSkVF0wNCmsjZXHjFEBXaw9W/sSdkOMISfLKAh8ChKW7f5qkxCxE8Mej0kU3/Qks99BYdvXBjm6GF4NRt+p8zHcmkScsFH9p3UHmT1EijzkgicI93ESAj/xk/EqSD3ss0TqTkUModDN7VM1EgG9TkRnomnIQ9OpzCODguhBPBuisiiM2iZXJVorWE8MVYwEwriSI2PYJYe4O2O3yJ8HkJhiNelH2tlaIMb3xtiPxv50QEIuHZkRJ/kdjMPZEXi58vK2RbMkIWWBsiU8RCxg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;\n s=selector2-intel-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=LwM4yFijrlbgqUk6PA7cAOshQXrlj/HMr0FCy3hX/BM=;\n b=jHp8tLfwXrME4GDu+vairt943etx20f91d6tW8WlZJGWH2Z9Bh8KtrVafiAsuj3WxQuCgDE29nW2u1SdxziQjjVN4ZJ5gcN+LLdd4nUMc6CL4/IoqorqPwNUrH6+bQVJ902JChrLCqYmjbeRxw08b+BB6h/8wrqYyBduclkYAUU=", "From": "\"Wang, ShougangX\" <shougangx.wang@intel.com>", "To": "\"Yang, Qiming\" <qiming.yang@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"Xing, Beilei\" <beilei.xing@intel.com>, \"Guo, Jia\" <jia.guo@intel.com>,\n \"stable@dpdk.org\" <stable@dpdk.org>, \"Di, ChenxuX\" <chenxux.di@intel.com>", "Thread-Topic": "[dpdk-dev] [PATCH v4] net/i40e: fix incorrect hash look up table", "Thread-Index": "AQHWYWeGVDEv7hi1akun0axOM7lZWKkWLfGAgAAFrMA=", "Date": "Fri, 24 Jul 2020 05:42:48 +0000", "Message-ID": "\n <BYAPR11MB3477E2A83ED7F82CEE54C29B88770@BYAPR11MB3477.namprd11.prod.outlook.com>", "References": "<20200715063515.9262-1-shougangx.wang@intel.com>\n <20200724024712.10727-1-shougangx.wang@intel.com>\n <BN6PR11MB00172061D0D00FD185107EE5E5770@BN6PR11MB0017.namprd11.prod.outlook.com>", "In-Reply-To": "\n <BN6PR11MB00172061D0D00FD185107EE5E5770@BN6PR11MB0017.namprd11.prod.outlook.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "intel.com; dkim=none (message not signed)\n header.d=none;intel.com; dmarc=none action=none header.from=intel.com;", "x-originating-ip": "[192.55.46.46]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "8fdb9f40-2759-42df-a6b8-08d82f946647", "x-ms-traffictypediagnostic": "BY5PR11MB4226:", "x-ld-processed": "46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <BY5PR11MB42261D1603A44A4D927E183C88770@BY5PR11MB4226.namprd11.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:10000;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n DfMQ/DlWaXP2z5Xe95bp+DMKXbydDWBD9BzAIls8X2CM6GKOEyS/Qd/ze8tPdlZUNKmA9y2/IBg/3g4eVAAy+pYUFl1/JRj2M35u+0A68UAOYnqm5xRfFh4biJpXFntGN7jlK244blmNmQrTkaqWvt/MvwWqS83Yw5C0uMPQorb91gLO1+Z4AGiUiQgad9b1ALvekOXOMNa23ctjtLREsd3l4YpIV/oSWgiBQuSVBe9OLgC6z+VRJhd07/wy0tE6xjeAFxs2qRIlY29gDtMvqzWs+HwK2lcg1F5f+38uxDog6fVOWN+DYpCIee1D4RCqRA6deSZZ+VL6KudoEkdDSw==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:BYAPR11MB3477.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(39860400002)(136003)(366004)(346002)(396003)(376002)(86362001)(66946007)(52536014)(6506007)(53546011)(66446008)(64756008)(71200400001)(2906002)(76116006)(66476007)(66556008)(26005)(186003)(7696005)(478600001)(8676002)(110136005)(55016002)(83380400001)(4326008)(54906003)(107886003)(9686003)(316002)(450100002)(5660300002)(8936002)(33656002);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata": "\n fjmfD78G2HPYy7P722MhQW9t4nfvVQ/aTm2VbywrwlSyGvYasb4wiGKj5GrgUT7hbA4LLZGa+8JczZcWOxtNGYK46pg+emVYXpzI2LS4MvsLof7RNBL8YpyQSy5vRxhX7xPX9gLKxvNHN6FWDYmUwRdsOGSoE7dKZcXkxhKKLJXGkPF9oTAjaFmxB08jluf03mL1bpgVnupqT+sTQqZKumuWwZ6LinMFih1y4TrGaOrO6MJVCPp86VmX4B8uVimm9Nn1NNAHCJhERp9h1yp0lzVgLyIOtZ8CWlFzqTtwg6ZfS9QLs1virJp2TyQLQu6a0V1hCkt18Szur19F0b0k+gpEsJc/dfDvjYtcibBxGq/7+9UU3rf+zHLAfuQjiNcx6AuJrPXCqMWlQrMsavxbC9hmQcIY3vpQveD0qK1I/4D4LJUj3IXzVw2kybu+Q7j4NX5irRAPGFz7bpDFLKim1gAkyvmtoV2FmL7S4Cmn+Yw=", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "BYAPR11MB3477.namprd11.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 8fdb9f40-2759-42df-a6b8-08d82f946647", "X-MS-Exchange-CrossTenant-originalarrivaltime": "24 Jul 2020 05:42:48.9113 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "46c98d88-e344-4ed4-8496-4ed7712e255d", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n GadZJBGUIbREaHZohANkDoEgYAwCDTng3yuLKL63zwW5i1uKkwWTLOUTTvQYQr9ZolMGPzz1CIysQ3ntYYMLfPZKNWp2ov1xs6IKu8u7ITc=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BY5PR11MB4226", "X-OriginatorOrg": "intel.com", "Subject": "Re: [dpdk-dev] [PATCH v4] net/i40e: fix incorrect hash look up table", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]