Show a patch.

GET /api/patches/74700/
HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 74700,
    "url": "https://patches.dpdk.org/api/patches/74700/",
    "web_url": "https://patches.dpdk.org/patch/74700/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk"
    },
    "msgid": "<20200723200910.376581-11-parav@mellanox.com>",
    "date": "2020-07-23T20:09:10",
    "name": "[v8,10/10] common/mlx5: remove class check from class drivers",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "6883cf88957a9b323d191111f2ef4589d0072606",
    "submitter": {
        "id": 1780,
        "url": "https://patches.dpdk.org/api/people/1780/",
        "name": "Parav Pandit",
        "email": "parav@mellanox.com"
    },
    "delegate": {
        "id": 3268,
        "url": "https://patches.dpdk.org/api/users/3268/",
        "username": "rasland",
        "first_name": "Raslan",
        "last_name": "Darawsheh",
        "email": "rasland@mellanox.com"
    },
    "mbox": "https://patches.dpdk.org/patch/74700/mbox/",
    "series": [
        {
            "id": 11259,
            "url": "https://patches.dpdk.org/api/series/11259/",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11259",
            "date": "2020-07-23T20:09:00",
            "name": "Improve mlx5 PMD driver framework for multiple classes",
            "version": 8,
            "mbox": "https://patches.dpdk.org/series/11259/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/74700/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/74700/checks/",
    "tags": {},
    "headers": {
        "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted",
        "X-Mailman-Version": "2.1.15",
        "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DB7PR05MB5558",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n DkQ+6fEYEYQ0/t+IzlBKyFlM2UFarJ/4NDXfAtc3Em01rtj/DMiUgOXuv/cjpikGGvL5zGO+1bcXO3UZ6rF0kw==",
        "Precedence": "list",
        "X-MS-Exchange-Transport-Forked": "True",
        "X-BeenThere": "dev@dpdk.org",
        "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr",
        "X-ClientProxiedBy": "DM6PR03CA0009.namprd03.prod.outlook.com\n (2603:10b6:5:40::22) To DB7PR05MB4876.eurprd05.prod.outlook.com\n (2603:10a6:10:1d::32)",
        "Content-Transfer-Encoding": "8bit",
        "X-MS-Exchange-CrossTenant-AuthAs": "Internal",
        "X-MS-Exchange-AntiSpam-MessageData": "\n xsWSrb1956SZnPSIBRvS3uRdEtwnjzyFNwqd7zoWMRyl2N1RXM5nqPBgqEfivUlZAQRQDp5pYZW9rdcJCWKA96j+dkM7hFWDMStl9AJ4EeWNs1uAnr773kN/U6XbxHd0motOUq+PTr68PMgSoHAnQnZSARck1fe0htphYT8N3U5f8MwugvOL/8cw3vh5OeX91XJU4B8+y23T5XOrzxXfapUm01J5tme0XcK5T8RlbD1exvP6S+UeKV2KxG/7UrfEzixK44o8beWu/iaIuI+d3geI9Gr7cp5q/356PhMsc+ZC/cptOUR1jujewP5+IHU/lp2+wB5SQ/Cg+KkgsRNtolL1jnb1EzCRwIQiCbYmajdMwSGl+tEXftubaT9/SOQs1Z0JxtOr8xBs11DBV88U8t6SE8HsGtt0amk8Bj9VCV8Abb5Gf5aJcWlhTf7b/p78BvtQIS39EXH+6SxFBthMvCd3JqnGH+07PNlqYNR0Ylg8sAQvkMQzR3DCkvDlt0Ld",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7D355A0518;\n\tThu, 23 Jul 2020 22:11:25 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A99E31C0D2;\n\tThu, 23 Jul 2020 22:09:55 +0200 (CEST)",
            "from EUR04-VI1-obe.outbound.protection.outlook.com\n (mail-eopbgr80051.outbound.protection.outlook.com [40.107.8.51])\n by dpdk.org (Postfix) with ESMTP id E883F1C0AE\n for <dev@dpdk.org>; Thu, 23 Jul 2020 22:09:49 +0200 (CEST)",
            "from DB7PR05MB4876.eurprd05.prod.outlook.com (2603:10a6:10:1d::32)\n by DB7PR05MB5558.eurprd05.prod.outlook.com (2603:10a6:10:5c::21) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20; Thu, 23 Jul\n 2020 20:09:48 +0000",
            "from DB7PR05MB4876.eurprd05.prod.outlook.com\n ([fe80::8cb3:93cb:c3ef:4293]) by DB7PR05MB4876.eurprd05.prod.outlook.com\n ([fe80::8cb3:93cb:c3ef:4293%5]) with mapi id 15.20.3216.022; Thu, 23 Jul 2020\n 20:09:48 +0000",
            "from sw-mtx-036.mtx.labs.mlnx (208.176.44.194) by\n DM6PR03CA0009.namprd03.prod.outlook.com (2603:10b6:5:40::22) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.3216.21 via Frontend Transport; Thu, 23 Jul 2020 20:09:46 +0000"
        ],
        "Subject": "[dpdk-dev] [PATCH v8 10/10] common/mlx5: remove class check from\n\tclass drivers",
        "X-MS-PublicTrafficType": "Email",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "Message-Id": "<20200723200910.376581-11-parav@mellanox.com>",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=M8SXPw7eKOJbjLmDRs/d1C2C7IKFtlh10Bqvlh2eiQs=;\n b=Ho666SR2TD8XxH1ZgYmv/+9AO/J1ceDn0RrsvP9ktriHEGaDIQapKMhax0R0KhYv2II79McHLPZLPVCGlXt24rkFE1Bg87rc23tljq4nSex6tgCL+/lMr9DMiK333xkhStbxHGOvuOvrl9MOfTPtLCZWyQ4wEnZ5jjOF1LH6y3Q=",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>",
        "X-MS-Office365-Filtering-HT": "Tenant",
        "To": "dev@dpdk.org, grive@u256.net, ferruh.yigit@intel.com, thomas@monjalon.net",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "From": "Parav Pandit <parav@mellanox.com>",
        "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED",
        "Cc": "rasland@mellanox.com, orika@mellanox.com, matan@mellanox.com,\n joyce.kong@arm.com, Parav Pandit <parav@mellanox.com>",
        "X-MS-Exchange-CrossTenant-AuthSource": "DB7PR05MB4876.eurprd05.prod.outlook.com",
        "X-MS-TrafficTypeDiagnostic": "DB7PR05MB5558:",
        "Return-Path": "<dev-bounces@dpdk.org>",
        "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none",
        "Authentication-Results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com;",
        "X-OriginatorOrg": "Mellanox.com",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "X-Microsoft-Antispam-PRVS": "\n <DB7PR05MB555854607D2E130DAB86A47AD1760@DB7PR05MB5558.eurprd05.prod.outlook.com>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "MIME-Version": "1.0",
        "In-Reply-To": "<20200723200910.376581-1-parav@mellanox.com>",
        "X-MS-Exchange-MessageSentRepresentingType": "1",
        "References": "<20200610171728.89-2-parav@mellanox.com>\n <20200723200910.376581-1-parav@mellanox.com>",
        "Content-Type": "text/plain",
        "X-MS-Oob-TLC-OOBClassifiers": "OLM:7219;",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "X-Originating-IP": "[208.176.44.194]",
        "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DB7PR05MB4876.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(376002)(346002)(366004)(396003)(136003)(39860400002)(6506007)(8676002)(8936002)(26005)(52116002)(2906002)(4326008)(478600001)(66946007)(66476007)(66556008)(83380400001)(36756003)(5660300002)(2616005)(6486002)(86362001)(956004)(1076003)(6512007)(6666004)(107886003)(186003)(16526019)(316002);\n DIR:OUT; SFP:1101;",
        "X-Mailer": [
            "git-send-email 2.26.2",
            "git-send-email 2.26.2"
        ],
        "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=M8SXPw7eKOJbjLmDRs/d1C2C7IKFtlh10Bqvlh2eiQs=;\n b=DsURQQY5Wwx5JaF6FGPUYZaVoBMguut35rTRgCV7i1dOj4IlfT8Q2EkWDHqP76yv623yvF8PXFJ6iyDBMynYfw8K29zAWty6yX0Igs4RZlRth7Vx0CQAJKulyGqop3Fh86pbE/wW0nHtMRmeX6VjwSbVoYWgPta7X1BXcQLZt4TXU9AJDFi8VuPFCLSy2XrIa3JI/M5qwrrms9TfK962/Y4FGC6n67nlAYDJZfWCHEo9GmW0o/Fnf1sW+H7lzQ49hIuEdUvBTmMNNH1jwb8pmeoeqCXZg3P85dwmV7iu25rnH6mBeZDijkGKfrXlJex/HO7yf6RlQf0AomWjnqPDtw==",
        "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 041afbd6-f5fd-4d03-774d-08d82f4459a5",
        "Date": "Thu, 23 Jul 2020 23:09:10 +0300",
        "X-MS-Office365-Filtering-Correlation-Id": "041afbd6-f5fd-4d03-774d-08d82f4459a5",
        "X-Microsoft-Antispam-Message-Info": "\n nMHGyv84Cg/d9C92hx+bkeWFNKAy52QB0YBgDx46wAcw9dZsvcahsoCy6Ml5Hu+PT0+6Q686yYmHzw5S83a4Qetq9dwRK5dBtf3mi6N5N2fFCHLqY7iUlaE7GmKJOaj44GEwee/XO4GDAX2TO7nN9LPNha2efpxjGOq2s96za3d7vEDA5ChCgYCkbJFj6vnR6gPSoL5nTjTGzKhRl1UZhsyEdt6V/9EJTBSy0DOSQ06/l/I69AZL44A+hwZLtJYbk7NKSOddHd7qKTgAWU3TACnkISuxZN8t7ug2hzBzd+j2gh0R0wmnzEmb7goePs8m",
        "X-MS-Exchange-SenderADCheck": "1",
        "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b",
        "X-Microsoft-Antispam": "BCL:0;",
        "Errors-To": "dev-bounces@dpdk.org",
        "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=oGY8x7jViABvHJ4jGqGf6nAgXfrJ6xCHhEHhuV621m9u4ACA/N8GYXFCeMD6L6tVydOJ+Q8gXMZQlxiAe0bTK460flq0jxqX2l1rK4wX4CSjDgKw/q0LMni6090KjLR4fCdgjSY/KhjSbvJ/G+zIuwi85d8wB6pc5eVXB+Zs3OecPI1X35v1pBpPJthr4s/WCaQBAToR3k3Fj6JxcMGiLiOWr+KfHbMQt1gt0Taavcfn2Cn5zrVmfPSGXik1ADB7m6gTitNeOLG/qFFnQyXBopMmuwkLoUaGq4DmT7DRw3xMeTGaI0aLwFoUujIl016IIubpkZhSCLIi/FrE9aK0xw==",
        "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "23 Jul 2020 20:09:48.2382 (UTC)"
    },
    "content": "Now that mlx5_pci PMD checks for enabled classes and performs\nprobe(), remove() of associated classes, individual class driver\ndoes not need to check if other driver is enabled.\n\nSigned-off-by: Parav Pandit <parav@mellanox.com>\nAcked-by: Matan Azrad <matan@mellanox.com>\n---\n drivers/common/mlx5/mlx5_common.c             | 37 -------------------\n drivers/common/mlx5/mlx5_common.h             |  2 -\n .../common/mlx5/rte_common_mlx5_version.map   |  3 +-\n drivers/net/mlx5/linux/mlx5_os.c              |  5 ---\n drivers/vdpa/mlx5/mlx5_vdpa.c                 |  5 ---\n 5 files changed, 1 insertion(+), 51 deletions(-)",
    "diff": "diff --git a/drivers/common/mlx5/mlx5_common.c b/drivers/common/mlx5/mlx5_common.c\nindex fd818ef24..06f0a6400 100644\n--- a/drivers/common/mlx5/mlx5_common.c\n+++ b/drivers/common/mlx5/mlx5_common.c\n@@ -20,43 +20,6 @@ int mlx5_common_logtype;\n \n uint8_t haswell_broadwell_cpu;\n \n-static int\n-mlx5_class_check_handler(__rte_unused const char *key, const char *value,\n-\t\t\t void *opaque)\n-{\n-\tenum mlx5_class *ret = opaque;\n-\n-\tif (strcmp(value, \"vdpa\") == 0) {\n-\t\t*ret = MLX5_CLASS_VDPA;\n-\t} else if (strcmp(value, \"net\") == 0) {\n-\t\t*ret = MLX5_CLASS_NET;\n-\t} else {\n-\t\tDRV_LOG(ERR, \"Invalid mlx5 class %s. Maybe typo in device\"\n-\t\t\t\" class argument setting?\", value);\n-\t\t*ret = MLX5_CLASS_INVALID;\n-\t}\n-\treturn 0;\n-}\n-\n-enum mlx5_class\n-mlx5_class_get(struct rte_devargs *devargs)\n-{\n-\tstruct rte_kvargs *kvlist;\n-\tconst char *key = MLX5_CLASS_ARG_NAME;\n-\tenum mlx5_class ret = MLX5_CLASS_NET;\n-\n-\tif (devargs == NULL)\n-\t\treturn ret;\n-\tkvlist = rte_kvargs_parse(devargs->args, NULL);\n-\tif (kvlist == NULL)\n-\t\treturn ret;\n-\tif (rte_kvargs_count(kvlist, key))\n-\t\trte_kvargs_process(kvlist, key, mlx5_class_check_handler, &ret);\n-\trte_kvargs_free(kvlist);\n-\treturn ret;\n-}\n-\n-\n /* In case this is an x86_64 intel processor to check if\n  * we should use relaxed ordering.\n  */\ndiff --git a/drivers/common/mlx5/mlx5_common.h b/drivers/common/mlx5/mlx5_common.h\nindex 864e82ff0..2cdb226f3 100644\n--- a/drivers/common/mlx5/mlx5_common.h\n+++ b/drivers/common/mlx5/mlx5_common.h\n@@ -247,8 +247,6 @@ struct mlx5_klm {\n \n LIST_HEAD(mlx5_dbr_page_list, mlx5_devx_dbr_page);\n \n-__rte_internal\n-enum mlx5_class mlx5_class_get(struct rte_devargs *devargs);\n __rte_internal\n void mlx5_translate_port_name(const char *port_name_in,\n \t\t\t      struct mlx5_switch_info *port_info_out);\ndiff --git a/drivers/common/mlx5/rte_common_mlx5_version.map b/drivers/common/mlx5/rte_common_mlx5_version.map\nindex 73cf72548..7729d0dd0 100644\n--- a/drivers/common/mlx5/rte_common_mlx5_version.map\n+++ b/drivers/common/mlx5/rte_common_mlx5_version.map\n@@ -1,9 +1,8 @@\n INTERNAL {\n \tglobal:\n \n-\tmlx5_class_get;\n-\n \tmlx5_common_init;\n+\n \tmlx5_common_verbs_reg_mr;\n \tmlx5_common_verbs_dereg_mr;\n \ndiff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c\nindex 97d7b0e7b..fc339affa 100644\n--- a/drivers/net/mlx5/linux/mlx5_os.c\n+++ b/drivers/net/mlx5/linux/mlx5_os.c\n@@ -1524,11 +1524,6 @@ mlx5_os_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \tunsigned int dev_config_vf;\n \tint ret;\n \n-\tif (mlx5_class_get(pci_dev->device.devargs) != MLX5_CLASS_NET) {\n-\t\tDRV_LOG(DEBUG, \"Skip probing - should be probed by other mlx5\"\n-\t\t\t\" driver.\");\n-\t\treturn 1;\n-\t}\n \tif (rte_eal_process_type() == RTE_PROC_PRIMARY)\n \t\tmlx5_pmd_socket_init();\n \tret = mlx5_init_once();\ndiff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c\nindex ffe2f00ac..c0b87bcc0 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa.c\n@@ -680,11 +680,6 @@ mlx5_vdpa_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \tstruct mlx5_hca_attr attr;\n \tint ret;\n \n-\tif (mlx5_class_get(pci_dev->device.devargs) != MLX5_CLASS_VDPA) {\n-\t\tDRV_LOG(DEBUG, \"Skip probing - should be probed by other mlx5\"\n-\t\t\t\" driver.\");\n-\t\treturn 1;\n-\t}\n \tibv = mlx5_vdpa_get_ib_device_match(&pci_dev->addr);\n \tif (!ibv) {\n \t\tDRV_LOG(ERR, \"No matching IB device for PCI slot \"\n",
    "prefixes": [
        "v8",
        "10/10"
    ]
}