Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74695/?format=api
{ "id": 74695, "url": "https://patches.dpdk.org/api/patches/74695/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200723200910.376581-6-parav@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200723200910.376581-6-parav@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200723200910.376581-6-parav@mellanox.com", "date": "2020-07-23T20:09:05", "name": "[v8,05/10] regex/mlx5: fix segmentation fault during error unwinding", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3abd0131eaf70c3ffa564fd6c9f6b32c36d62b70", "submitter": { "id": 1780, "url": "https://patches.dpdk.org/api/people/1780/?format=api", "name": "Parav Pandit", "email": "parav@mellanox.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200723200910.376581-6-parav@mellanox.com/mbox/", "series": [ { "id": 11259, "url": "https://patches.dpdk.org/api/series/11259/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11259", "date": "2020-07-23T20:09:00", "name": "Improve mlx5 PMD driver framework for multiple classes", "version": 8, "mbox": "https://patches.dpdk.org/series/11259/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/74695/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/74695/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0C6DEA0518;\n\tThu, 23 Jul 2020 22:10:28 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BE7091C065;\n\tThu, 23 Jul 2020 22:09:45 +0200 (CEST)", "from EUR04-VI1-obe.outbound.protection.outlook.com\n (mail-eopbgr80087.outbound.protection.outlook.com [40.107.8.87])\n by dpdk.org (Postfix) with ESMTP id 320271C032\n for <dev@dpdk.org>; Thu, 23 Jul 2020 22:09:40 +0200 (CEST)", "from DB7PR05MB4876.eurprd05.prod.outlook.com (2603:10a6:10:1d::32)\n by DB7PR05MB5558.eurprd05.prod.outlook.com (2603:10a6:10:5c::21) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20; Thu, 23 Jul\n 2020 20:09:38 +0000", "from DB7PR05MB4876.eurprd05.prod.outlook.com\n ([fe80::8cb3:93cb:c3ef:4293]) by DB7PR05MB4876.eurprd05.prod.outlook.com\n ([fe80::8cb3:93cb:c3ef:4293%5]) with mapi id 15.20.3216.022; Thu, 23 Jul 2020\n 20:09:38 +0000", "from sw-mtx-036.mtx.labs.mlnx (208.176.44.194) by\n DM6PR03CA0009.namprd03.prod.outlook.com (2603:10b6:5:40::22) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.3216.21 via Frontend Transport; Thu, 23 Jul 2020 20:09:37 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=N/NkK5cWHOjEXwF8Xqjry0UsHPYSMHnVCrmHpCamhlet4tpo0VIevfrjGhG351APMRBn/kcgIbNShQx5/sHUuHxuT4GrT+2ZUrS/vllpKMNdoAfBtlosvj7NMGmkoYQELkl+I47oRyJorM04VWmRx56QCzNUOx2LyeMGJN+MnV26PnXg8Pl9asxqKBZaNJAjF51H/Ur1AVzlYq/Ht8J7k53KuoFMHoUfMFPGVeXcFBuD1fk1qgC9RAKjx/hTzeVAjSSQffjgW+RaAqv/MjVnrxfVModV32iwnXLSdcOIgwH5UrbrDSC5cd/V/gV5f8Qz/1181p0ErYuws0rwVQ9Hvw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=jBckSGlVRAelxJZdaG8qEr/r4MZiBz6gqZABQJD0T2M=;\n b=Zki6YueuRBeCsv+eubTFN9m0qq7dFXPESF6lGUSKtswCHkcmZLpceK8e6g8o9y3qXfkPpTEfmP1HKRtRAg9rg0aZICdv7GkdPwVNrLR/bl5H5ApWWtVwC74dRXNflGgKgk/Ayqd/Muk64FGE3LsSrUAe8VtJRJ/BQSOWr06ZtstyNn5m9CPljgVCtK/6FvmMrkmaS3DqHKJ3DddevVBtRiPTuYTz6bBNmgQczm6QG+k6d1kjMdsG6FzkfXjtVz1Jrs5LPCegFzrk2+JqK36BoDANUKWS2dNpMYsgpQkX91RZRJuICiJyqO85k1iXr+6C6RDK9LzpxhdxcDH7TRpEdA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=jBckSGlVRAelxJZdaG8qEr/r4MZiBz6gqZABQJD0T2M=;\n b=r1/5AOPg8sSXJKXsUBmtRDXzL5aJbj/ZY7qB79PfM0pPNTkgWJD96ej1TvFb3QSADByYFk4O4ZqVOFipToUoegC0E/ihOZwnqpDZAq/m4uxGFhY+WMC5LRUMIv6QED8DVCa0Zy8apDnTfnHGBU5byyfkWZLWplWEzHARqZKhCIA=", "Authentication-Results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com;", "From": "Parav Pandit <parav@mellanox.com>", "To": "dev@dpdk.org, grive@u256.net, ferruh.yigit@intel.com, thomas@monjalon.net", "Cc": "rasland@mellanox.com, orika@mellanox.com, matan@mellanox.com,\n joyce.kong@arm.com, Parav Pandit <parav@mellanox.com>", "Date": "Thu, 23 Jul 2020 23:09:05 +0300", "Message-Id": "<20200723200910.376581-6-parav@mellanox.com>", "X-Mailer": [ "git-send-email 2.26.2", "git-send-email 2.26.2" ], "In-Reply-To": "<20200723200910.376581-1-parav@mellanox.com>", "References": "<20200610171728.89-2-parav@mellanox.com>\n <20200723200910.376581-1-parav@mellanox.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "DM6PR03CA0009.namprd03.prod.outlook.com\n (2603:10b6:5:40::22) To DB7PR05MB4876.eurprd05.prod.outlook.com\n (2603:10a6:10:1d::32)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-Originating-IP": "[208.176.44.194]", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "8c705c86-477e-4b87-6ce6-08d82f4453cf", "X-MS-TrafficTypeDiagnostic": "DB7PR05MB5558:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <DB7PR05MB5558F94B4752125DD303331AD1760@DB7PR05MB5558.eurprd05.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:1360;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 5lgadj30aZLwrBthr3YC4kUBh59FQ3X9Z0ZD51bqpqzUSCzbRSWL68PlxsWLc+7YlAjrvKpgbPUZpyt9AauyZix3hI8xYfqFCoy9R3PCracrZFhQs+149FKsLketSUAZ3fMKxofo3NBVCSvS34Mqrw+0wBrbE76wURnw1kGi/w7IN1XTI9Fi/A/7+gHqg3LwxajBGgAFGz6wHXjSXySOHIfnh3iidJc01GJueQ8ST0L7NZf+O/pbkzCCzZ/9SS0oeU1t/HvGhOxIl1VAyER/9GRCcSEy5ia4EvipGzR+L97r3R7HX7aisFFBeiKiS26SgL9DuFw6ccUpi+tNcLpwGg==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DB7PR05MB4876.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(376002)(346002)(366004)(396003)(136003)(39860400002)(6506007)(8676002)(8936002)(26005)(52116002)(2906002)(4326008)(478600001)(66946007)(66476007)(66556008)(83380400001)(36756003)(5660300002)(2616005)(6486002)(86362001)(956004)(1076003)(6512007)(6666004)(107886003)(186003)(16526019)(316002);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData": "\n RxZXTjgwz3YeIBcy2WFo7qfF07FYUdjpwh6AHlnsOP68/rUgBP6BEIcwavAq1nKZ+4cF2tB1pWAlRgxusmAOx5p/7kOr9VwoWxxlNa5g8Rn4LmQJZG/kPCB6KfQ0QnbLPmTIA2a3+06GnIoUlJ/lEnTePXLV5K2TFjus3WDOWdHUEL4DQv6BPG9gc1h4wNBuVgnWa0u2fJanBV1nhJaYUX+wCjKd5Btww4iE7Vk/oK6j0CqcFpDpUk+XR+Rr7x5up+jm2ur19snm1y6TZavD4TfJLJiBsMbankGyWwOCn2Mm4nXEJ3oyRn7TGmKthaB5k28wvYGf+pvuzu8jFwWGme16weAZ1NUGxAgSpWBR+MVxgpfICpYqHtn6K9O+aos8N0QKd+LxGM6uNHU3NiHgH418fEdyzm8iV88VPmT4K6B67LpU1ZJUPAihO5mzymycKOHuVB9onJnrVFLjK3NcZ+EZ+PzpktlRIcGAV/glWkolo85RBR/RSzT1feYJ5tsx", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 8c705c86-477e-4b87-6ce6-08d82f4453cf", "X-MS-Exchange-CrossTenant-AuthSource": "DB7PR05MB4876.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "23 Jul 2020 20:09:38.4738 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n 9zl1jx3N3UFfkKUwX9Q5yHq1Rf9sEICy+wZdnnEhj5doCDHXpxTgYdZa0lkYfKA4mZgDcOsHnbmRPOrhpgAU7A==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DB7PR05MB5558", "Subject": "[dpdk-dev] [PATCH v8 05/10] regex/mlx5: fix segmentation fault\n\tduring error unwinding", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When fail to initialize the device, avoid segmentation fault while\naccessing unintialized priv.\n\nFixes: cfc672a90b74 (\"regex/mlx5: support probing\")\nSigned-off-by: Parav Pandit <parav@mellanox.com>\n---\n drivers/regex/mlx5/mlx5_regex.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/regex/mlx5/mlx5_regex.c b/drivers/regex/mlx5/mlx5_regex.c\nindex 1ca5bfe9b..36ae9f809 100644\n--- a/drivers/regex/mlx5/mlx5_regex.c\n+++ b/drivers/regex/mlx5/mlx5_regex.c\n@@ -137,17 +137,17 @@ mlx5_regex_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \tif (ret) {\n \t\tDRV_LOG(ERR, \"Unable to read HCA capabilities.\");\n \t\trte_errno = ENOTSUP;\n-\t\tgoto error;\n+\t\tgoto dev_error;\n \t} else if (!attr.regex || attr.regexp_num_of_engines == 0) {\n \t\tDRV_LOG(ERR, \"Not enough capabilities to support RegEx, maybe \"\n \t\t\t\"old FW/OFED version?\");\n \t\trte_errno = ENOTSUP;\n-\t\tgoto error;\n+\t\tgoto dev_error;\n \t}\n \tif (mlx5_regex_engines_status(ctx, 2)) {\n \t\tDRV_LOG(ERR, \"RegEx engine error.\");\n \t\trte_errno = ENOMEM;\n-\t\tgoto error;\n+\t\tgoto dev_error;\n \t}\n \tpriv = rte_zmalloc(\"mlx5 regex device private\", sizeof(*priv),\n \t\t\t RTE_CACHE_LINE_SIZE);\n@@ -200,6 +200,7 @@ mlx5_regex_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \t\tmlx5_glue->devx_free_uar(priv->uar);\n \tif (priv->regexdev)\n \t\trte_regexdev_unregister(priv->regexdev);\n+dev_error:\n \tif (ctx)\n \t\tmlx5_glue->close_device(ctx);\n \tif (priv)\n", "prefixes": [ "v8", "05/10" ] }