Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74686/?format=api
{ "id": 74686, "url": "https://patches.dpdk.org/api/patches/74686/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200723142106.2391-1-getelson@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200723142106.2391-1-getelson@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200723142106.2391-1-getelson@mellanox.com", "date": "2020-07-23T14:21:04", "name": "[v2] net/mlx5: fix dynamic inline hint handling", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f880cdeb16a9b60b6484895e8217424cd804f08a", "submitter": { "id": 1773, "url": "https://patches.dpdk.org/api/people/1773/?format=api", "name": "Gregory Etelson", "email": "getelson@mellanox.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200723142106.2391-1-getelson@mellanox.com/mbox/", "series": [ { "id": 11256, "url": "https://patches.dpdk.org/api/series/11256/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11256", "date": "2020-07-23T14:21:04", "name": "[v2] net/mlx5: fix dynamic inline hint handling", "version": 2, "mbox": "https://patches.dpdk.org/series/11256/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/74686/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/74686/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9D88AA0521;\n\tThu, 23 Jul 2020 16:21:21 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E7E27199BC;\n\tThu, 23 Jul 2020 16:21:20 +0200 (CEST)", "from EUR04-DB3-obe.outbound.protection.outlook.com\n (mail-eopbgr60041.outbound.protection.outlook.com [40.107.6.41])\n by dpdk.org (Postfix) with ESMTP id 06ACB2C6E\n for <dev@dpdk.org>; Thu, 23 Jul 2020 16:21:19 +0200 (CEST)", "from DB8PR05MB6761.eurprd05.prod.outlook.com (2603:10a6:10:139::21)\n by DB7PR05MB5001.eurprd05.prod.outlook.com (2603:10a6:10:22::29) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.24; Thu, 23 Jul\n 2020 14:21:18 +0000", "from DB8PR05MB6761.eurprd05.prod.outlook.com\n ([fe80::5895:a00:3355:eb9f]) by DB8PR05MB6761.eurprd05.prod.outlook.com\n ([fe80::5895:a00:3355:eb9f%7]) with mapi id 15.20.3216.024; Thu, 23 Jul 2020\n 14:21:18 +0000", "from mellanox.com (176.230.224.223) by\n AM4PR07CA0020.eurprd07.prod.outlook.com (2603:10a6:205:1::33) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.3239.9 via Frontend Transport; Thu, 23 Jul 2020 14:21:17 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=ZCkDfVu1AOCFXJv5rUKBp+9OcBDPuO+WRQOgdHDBVKSaQZJSy/gqr732htanreYmzMOgEanv2itbpAVllNZ5pLRC3kSJuHY8XV9jtkW/O0VqvBj3LLwH4UxWlyiO49o3dzqC9TjDiKsarl26DLBFo3v4Awdly49ArGiXKcckcBMe7AGOaB6dinhEQ7KUWaZonf3qag7Ed0qLX2TXus5UZ3IW/wBf2Z1t2PPVnrJncbXa+MmUhImhQn5GA3YT0FW8et2RSkOzOlm9hnBfLmVbIKnCnln8FEVXUW0tYXxdc2k+pqc+i4Hbxi0vm7/qISpycqSBKweZoMPmBvLMPTgTTg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=pQ76LLaZqz1M4XvJaDUoYv8g8PYSZCqstoaLaxXCRzQ=;\n b=jnVDeZv92H5u2d1VCaKcpBcVNwnibMtTUIc6Zugwk39/Q0VWFBu+Qt6WNoZ+8HxnKLOxUjl4xS1Q4saZbJ57TlHbZnd9Kl548TuwYbfxo588+7KHWd3xljN0qkAqkGSg9/vCF2dPf7ZgTfEAokJyoTheRrA/PHROhXNPVjVtVv2JfGXAr1tOpiU6UCaBASMVeUlqAYKPFGPaubOGd7uYbenNgTmczZLIxrCRPU6wrw4aPfpfe+uwQx3o3h2TtUe2qEkuU0IMAH5tqJCWH+v8U8ndA2nBK69x9pK45UczOZbxkD18LOTbwS9iTG79J4jaN/+JVharhvb+PiLRUFSB9Q==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=pQ76LLaZqz1M4XvJaDUoYv8g8PYSZCqstoaLaxXCRzQ=;\n b=QTtWiAiY0mKflKjLDskWC52hdRX0NHWBg1ZQjyA5tfX1LBT0NXeHJ9jjm+fO5dg1wQdq0sc5BQnvzZZFcH9o2xh5uYx0SQ8hbck75UA1Z0pqnMyr+ndfCSujHWV8I2Sxdr3QoThEWUho2oa8Y3SKk3Ap4dP3QqvPl9ppVuRhG2Y=", "Authentication-Results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com;", "From": "Gregory Etelson <getelson@mellanox.com>", "To": "dev@dpdk.org", "Cc": "getelson@mellanox.com, matan@mellanox.com, rasland@mellanox.com,\n Viacheslav Ovsiienko <viacheslavo@mellanox.com>,\n Shahaf Shuler <shahafs@mellanox.com>", "Date": "Thu, 23 Jul 2020 17:21:04 +0300", "Message-Id": "<20200723142106.2391-1-getelson@mellanox.com>", "X-Mailer": [ "git-send-email 2.25.1", "git-send-email 2.25.1" ], "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "AM4PR07CA0020.eurprd07.prod.outlook.com\n (2603:10a6:205:1::33) To DB8PR05MB6761.eurprd05.prod.outlook.com\n (2603:10a6:10:139::21)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-Originating-IP": "[176.230.224.223]", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "bf926495-a3fe-4d49-ced4-08d82f13aa84", "X-MS-TrafficTypeDiagnostic": "DB7PR05MB5001:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <DB7PR05MB5001F5E64CD802F9EC332F40A8760@DB7PR05MB5001.eurprd05.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:8882;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 1nDPgcfBdf9mG1f1IB8wPQCvYAh7hQitzUtWn2NkmVuD21HNbF6k72CJ9/e2t8G1ZIH2ujfb7SxWO2EcihlxTp4nlgYr+QKiB7/8W0+jcrE4Xu3PbECxAaJ/4p2JKCrkjNkIQrdr6+TU+caO5ty51QW8/29X5Isj+6k6AB/x/qTxKZRAevC+y0TTMiEj+E+hx8+lqhFbGojU/jWEyo9+AOy+MvV4xSzR7o8PyqV+/i+3uq/jlgbDRnay6qpHOdKqJBEO8W2jJcDgEvoKkfoa/bw4jGX4JnFHI+VNajkJIfWZHjOA1AtSP5GzVr4alT/45JlZbG8kv+nJzdJ4CPqm8w==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DB8PR05MB6761.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(346002)(376002)(366004)(39860400002)(136003)(396003)(83380400001)(86362001)(5660300002)(186003)(8886007)(26005)(4326008)(107886003)(2906002)(36756003)(54906003)(66946007)(66476007)(66556008)(316002)(8936002)(7696005)(52116002)(6916009)(478600001)(1076003)(16526019)(2616005)(6666004)(956004)(55016002)(8676002);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData": "\n w+j//xDWN9GVnPZZ+phGr+VNbCS4s540NhqoAbsljBCQkSb30nGqWQUP9uHbwICTqLz3IE0PMljWq2aEorrac+b/BqVsV1/q5igbc4qmQaMZeeEbhWCWASVZxTUDhiCKSEOmTz/cZqKCsUGVE8ySg7cMuzVI3Q3bVR4SoX8JLhMe4lTEI+cIq2N2uSFIKfz3By0iUqAWeRno4/orLVw5oVmldXMME1UD5dDCvtsqeY8gy9wE4WTZna7vJPEzzY776CKCU2AKGsd2XxWIVDQRL3bC0FBsj1bnU4Se9bI02DwZBXoOM7zFTprja3bmWLlXdixCtAVQACiGLOq7Y36nLGGITQaiRwpmGj1t/amN7bnUBJmt4LRNK5bz1dj3mit5MnycBf5uv8cQSmSGsyIJSFbqRoGmDkBVsSPo8aQQjWdQ7hIgrFjjBdb1hZp/soJ9HwiG9o8TGuAbsHv86V4UdrPmtzxzWB+zttNc0JhdTSuzF2TeKSIg/Uu3nmdRa0wu", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n bf926495-a3fe-4d49-ced4-08d82f13aa84", "X-MS-Exchange-CrossTenant-AuthSource": "DB8PR05MB6761.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "23 Jul 2020 14:21:18.6307 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n CM7aqquj/trFSznPcbEc94H9HVfPFbAdxrxY1FpMqP/N9QM0XdeBw/h7Xs8dxVKHWaI+/KyzIqYegYn+FE43qA==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DB7PR05MB5001", "Subject": "[dpdk-dev] [PATCH v2] net/mlx5: fix dynamic inline hint handling", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The ConnectX NICs can transfer data from the host memory with two\napproaches: provide the pointer to the data buffer, or do data inline\n- copy the data to the transmit descriptor (WQE) entirely or only the\npart of data. In some configurations the NIC hardware requires the\nminimal data to be inline in the descriptor to operate correctly. And\nthere is the special dynamic flag to hint PMD not to inline the data\n(for example, if buffer is located on some other device - storage or\nGPU) on per packet basis.\n\nIf there was a packet with length shorter than the minimal inline data\nlength requested by the NIC hardware and the no-inline hint was set\nthe PMD tried to inline the packet with minimal required length\ninstead of actual packet's one. This patch adds the missed length\ncheck into no-inline hint handling branch.\n\nFixes: cacb44a09962 (\"net/mlx5: add no-inline Tx flag\")\n\nSigned-off-by: Gregory Etelson <getelson@mellanox.com>\nAcked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n---\n drivers/net/mlx5/mlx5_rxtx.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c\nindex 3eb0243603..1b71e94221 100644\n--- a/drivers/net/mlx5/mlx5_rxtx.c\n+++ b/drivers/net/mlx5/mlx5_rxtx.c\n@@ -4739,6 +4739,8 @@ mlx5_tx_burst_single_send(struct mlx5_txq_data *__rte_restrict txq,\n \t\t\t\t\t txq->inlen_mode) ||\n \t\t\t\t\t (MLX5_TXOFF_CONFIG(MPW) &&\n \t\t\t\t\t txq->inlen_mode)) {\n+\t\t\t\t\t\tif (inlen <= txq->inlen_send)\n+\t\t\t\t\t\t\tgoto single_inline;\n \t\t\t\t\t\t/*\n \t\t\t\t\t\t * The hardware requires the\n \t\t\t\t\t\t * minimal inline data header.\n@@ -4755,6 +4757,7 @@ mlx5_tx_burst_single_send(struct mlx5_txq_data *__rte_restrict txq,\n \t\t\t\t\t}\n \t\t\t\t\tgoto single_no_inline;\n \t\t\t\t}\n+single_inline:\n \t\t\t\t/*\n \t\t\t\t * Completely inlined packet data WQE:\n \t\t\t\t * - Control Segment, SEND opcode\n", "prefixes": [ "v2" ] }