List comments

GET /api/patches/74685/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 116704,
        "web_url": "https://patches.dpdk.org/comment/116704/",
        "msgid": "<MN2PR11MB40638CF0FD5E2FC8184388A69C720@MN2PR11MB4063.namprd11.prod.outlook.com>",
        "date": "2020-07-27T13:54:59",
        "subject": "Re: [dpdk-dev] [PATCH 2/2] net/vhost: fix queue update",
        "submitter": {
            "id": 1276,
            "url": "https://patches.dpdk.org/api/people/1276/",
            "name": "Xia, Chenbo",
            "email": "chenbo.xia@intel.com"
        },
        "content": "Hi Maxime,\n\n> -----Original Message-----\n> From: Maxime Coquelin <maxime.coquelin@redhat.com>\n> Sent: Thursday, July 23, 2020 9:09 PM\n> To: dev@dpdk.org; matan@mellanox.com; Xia, Chenbo\n> <chenbo.xia@intel.com>; Liu, Yong <yong.liu@intel.com>; Wang, Yinan\n> <yinan.wang@intel.com>\n> Cc: thomas@monjalon.net; Yigit, Ferruh <ferruh.yigit@intel.com>;\n> david.marchand@redhat.com; Maxime Coquelin\n> <maxime.coquelin@redhat.com>\n> Subject: [PATCH 2/2] net/vhost: fix queue update\n> \n> Now that the vhost library saves the guest notifications enablement value in its\n> virtqueues metadata, it is not necessary to do it in the vring_state_changed\n> callback.\n> \n> One effect of the patch is also to prevent possible deadlock happening in vhost\n> library.\n> \n> Fixes: 604052ae5395 (\"net/vhost: support queue update\")\n> \n> Reported-by: Yinan Wang <yinan.wang@intel.com>\n> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n> ---\n>  drivers/net/vhost/rte_eth_vhost.c | 25 ++++++-------------------\n>  1 file changed, 6 insertions(+), 19 deletions(-)\n> \n> diff --git a/drivers/net/vhost/rte_eth_vhost.c\n> b/drivers/net/vhost/rte_eth_vhost.c\n> index bbf79b2c0e..14b7b59f67 100644\n> --- a/drivers/net/vhost/rte_eth_vhost.c\n> +++ b/drivers/net/vhost/rte_eth_vhost.c\n> @@ -94,7 +94,6 @@ struct vhost_queue {\n>  \tstruct rte_mempool *mb_pool;\n>  \tuint16_t port;\n>  \tuint16_t virtqueue_id;\n> -\tbool intr_en;\n>  \tstruct vhost_stats stats;\n>  };\n> \n> @@ -547,8 +546,6 @@ eth_rxq_intr_enable(struct rte_eth_dev *dev, uint16_t\n> qid)\n>  \trte_vhost_enable_guest_notification(vq->vid, (qid << 1) + 1, 1);\n>  \trte_wmb();\n> \n> -\tvq->intr_en = true;\n> -\n>  \treturn ret;\n>  }\n> \n> @@ -574,8 +571,6 @@ eth_rxq_intr_disable(struct rte_eth_dev *dev, uint16_t\n> qid)\n>  \trte_vhost_enable_guest_notification(vq->vid, (qid << 1) + 1, 0);\n>  \trte_wmb();\n> \n> -\tvq->intr_en = false;\n> -\n>  \treturn 0;\n>  }\n> \n> @@ -841,7 +836,6 @@ vring_conf_update(int vid, struct rte_eth_dev *eth_dev,\n> uint16_t vring_id)\n>  \tstruct rte_eth_conf *dev_conf = &eth_dev->data->dev_conf;\n>  \tstruct pmd_internal *internal = eth_dev->data->dev_private;\n>  \tstruct rte_vhost_vring vring;\n> -\tstruct vhost_queue *vq;\n>  \tint rx_idx = vring_id % 2 ? (vring_id - 1) >> 1 : -1;\n>  \tint ret = 0;\n> \n> @@ -853,21 +847,14 @@ vring_conf_update(int vid, struct rte_eth_dev\n> *eth_dev, uint16_t vring_id)\n>  \t    rte_atomic32_read(&internal->dev_attached) &&\n>  \t    rte_atomic32_read(&internal->started) &&\n>  \t    dev_conf->intr_conf.rxq) {\n> -\t\tvq = eth_dev->data->rx_queues[rx_idx];\n>  \t\tret = rte_vhost_get_vhost_vring(vid, vring_id, &vring);\n> -\t\tif (!ret) {\n> -\t\t\tif (vring.kickfd !=\n> -\t\t\t    eth_dev->intr_handle->efds[rx_idx]) {\n> -\t\t\t\tVHOST_LOG(INFO,\n> -\t\t\t\t\t  \"kickfd for rxq-%d was changed.\\n\",\n> -\t\t\t\t\t  rx_idx);\n> -\t\t\t\teth_dev->intr_handle->efds[rx_idx] =\n> -\t\t\t\t\t\t\t\t   vring.kickfd;\n> -\t\t\t}\n> +\t\tif (ret)\n> +\t\t\treturn ret;\n\nDo you think it'll be better to add a VHOST_LOG here to show the get_vring failure\nlike it's done in other place? But since it's the only place that will fail, it's also easy\nfor user to find out. 😊\n\nThanks,\nChenbo\n\n> \n> -\t\t\trte_vhost_enable_guest_notification(vid, vring_id,\n> -\t\t\t\t\t\t\t    vq->intr_en);\n> -\t\t\trte_wmb();\n> +\t\tif (vring.kickfd != eth_dev->intr_handle->efds[rx_idx]) {\n> +\t\t\tVHOST_LOG(INFO, \"kickfd for rxq-%d was changed.\\n\",\n> +\t\t\t\t\t  rx_idx);\n> +\t\t\teth_dev->intr_handle->efds[rx_idx] = vring.kickfd;\n>  \t\t}\n>  \t}\n> \n> --\n> 2.26.2",
        "headers": {
            "Accept-Language": "en-US, zh-CN",
            "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;\n s=selector2-intel-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=zoWfIScJxS6BjWuq+oPhM/s0f0Xf/ICLf+GwTfeV03c=;\n b=xDuABxgL3fZa2gioRL8aQIMQOG96/i2Y8wjSv4iX78nxLINsZR1e4nsoF35cD9UEGkM8I7/Dfn7ykyL4jFs+fVsjE4G6BQ8f7SMVHYICqIBOzl9WaqwUrx6t7YOBea4V7cmhFBhNrR8obUE9+jNc7NTtc4b8XJ51ZV8vynFrxQc=",
            "x-ms-oob-tlc-oobclassifiers": "OLM:10000;",
            "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN2PR11MB4726",
            "authentication-results": "redhat.com; dkim=none (message not signed)\n header.d=none;redhat.com; dmarc=none action=none header.from=intel.com;",
            "X-Amp-File-Uploaded": "False",
            "Precedence": "list",
            "X-MS-TNEF-Correlator": "",
            "List-Post": "<mailto:dev@dpdk.org>",
            "x-ms-exchange-senderadcheck": "1",
            "X-Mailman-Version": "2.1.15",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Subject": "Re: [dpdk-dev] [PATCH 2/2] net/vhost: fix queue update",
            "X-MS-Exchange-CrossTenant-AuthAs": "Internal",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "From": "\"Xia, Chenbo\" <chenbo.xia@intel.com>",
            "Received": [
                "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 427AFA053A;\n\tMon, 27 Jul 2020 15:55:06 +0200 (CEST)",
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0F4651BFD9;\n\tMon, 27 Jul 2020 15:55:05 +0200 (CEST)",
                "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by dpdk.org (Postfix) with ESMTP id 9B1731BFCF\n for <dev@dpdk.org>; Mon, 27 Jul 2020 15:55:03 +0200 (CEST)",
                "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Jul 2020 06:55:02 -0700",
                "from orsmsx102.amr.corp.intel.com ([10.22.225.129])\n by orsmga008.jf.intel.com with ESMTP; 27 Jul 2020 06:55:02 -0700",
                "from orsmsx158.amr.corp.intel.com (10.22.240.20) by\n ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Mon, 27 Jul 2020 06:55:02 -0700",
                "from ORSEDG001.ED.cps.intel.com (10.7.248.4) by\n ORSMSX158.amr.corp.intel.com (10.22.240.20) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Mon, 27 Jul 2020 06:55:01 -0700",
                "from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102)\n by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Mon, 27 Jul 2020 06:55:01 -0700",
                "from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22)\n by MN2PR11MB4726.namprd11.prod.outlook.com (2603:10b6:208:269::7)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.24; Mon, 27 Jul\n 2020 13:54:59 +0000",
                "from MN2PR11MB4063.namprd11.prod.outlook.com\n ([fe80::b898:36f5:61cb:42ca]) by MN2PR11MB4063.namprd11.prod.outlook.com\n ([fe80::b898:36f5:61cb:42ca%7]) with mapi id 15.20.3216.033; Mon, 27 Jul 2020\n 13:54:59 +0000"
            ],
            "x-originating-ip": "[192.198.147.193]",
            "x-microsoft-antispam": "BCL:0;",
            "x-ms-exchange-transport-forked": "True",
            "X-MS-Exchange-CrossTenant-AuthSource": "MN2PR11MB4063.namprd11.prod.outlook.com",
            "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=zoWfIScJxS6BjWuq+oPhM/s0f0Xf/ICLf+GwTfeV03c=;\n b=Dy15hAKrjeKq6bcnC/hCngTLq8WXOdaeLDrXjdAkTiec1L1kH8l1OewrJty1PlDtRN8zEMsEaEY9q8edgjsOGFbI3wA4MEZNTDIXVASWwfSpR7ED7F40hP4nu4rUesVx28XmTskC3QkBXvJgDU9fPrlangkq9pm6TsQ95xTxJCcxCDoIFeJGkM50f0UsnOR2IoRno/e+X3Nfa9Bioh24RwmT16PD90sbAHF2wmlkit1DtXUuCQVP1Kd7q1nTfYQKRJbMbhNWYDh98XaXMl1ZU01wF1GwGSsYYFI+Gh8spZTzGZYrFyK9vJt/ePf1nXCmScMgwwCGKDX8ZRpqY9R1zg==",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted",
            "X-ExtLoop1": "1",
            "Message-ID": "\n <MN2PR11MB40638CF0FD5E2FC8184388A69C720@MN2PR11MB4063.namprd11.prod.outlook.com>",
            "X-MS-Exchange-CrossTenant-userprincipalname": "\n btn6HbSEsDB9HFQTeNY/f60j4/SwQE/5O532o83X+wUTmZRCzWMLoa6SWY4Z7Sgk73tpdN5qSHqREbiFlWLq5A==",
            "To": "Maxime Coquelin <maxime.coquelin@redhat.com>, \"dev@dpdk.org\"\n <dev@dpdk.org>, \"matan@mellanox.com\" <matan@mellanox.com>, \"Liu, Yong\"\n <yong.liu@intel.com>, \"Wang, Yinan\" <yinan.wang@intel.com>",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
            "Delivered-To": "patchwork@inbox.dpdk.org",
            "x-ld-processed": "46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr",
            "dlp-reaction": "no-action",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "dlp-product": "dlpe-windows",
            "x-ms-publictraffictype": "Email",
            "Content-Language": "en-US",
            "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none",
            "X-IronPort-AV": [
                "E=McAfee;i=\"6000,8403,9694\"; a=\"150192155\"",
                "E=Sophos;i=\"5.75,402,1589266800\"; d=\"scan'208\";a=\"150192155\"",
                "E=Sophos;i=\"5.75,402,1589266800\"; d=\"scan'208\";a=\"320037359\""
            ],
            "IronPort-SDR": [
                "\n 92WE0qq6LmZ7eUPjzyJSEkDKEFHHcrvp+XTktaqueDSm9Xgd9wu7oiXKn3iHyUmamvpI/xnm+X\n b9wepqX+GhHQ==",
                "\n LS2kMtk0A8mriNnk0U+/PHvNzFwZ2O02Y0H+RZ0GodbW9XVlGvFiCZnUu8feqz7zz+fluB9naH\n aG1P9ZeG/GZw=="
            ],
            "Thread-Index": "AQHWYPKlO8RveUEE1EiZGTcLm4Tnh6kbdtgw",
            "CC": "\"thomas@monjalon.net\" <thomas@monjalon.net>, \"Yigit, Ferruh\"\n <ferruh.yigit@intel.com>, \"david.marchand@redhat.com\"\n <david.marchand@redhat.com>",
            "X-OriginatorOrg": "intel.com",
            "X-MS-Exchange-CrossTenant-originalarrivaltime": "27 Jul 2020 13:54:59.7564 (UTC)",
            "Thread-Topic": "[PATCH 2/2] net/vhost: fix queue update",
            "X-Original-To": "patchwork@inbox.dpdk.org",
            "x-microsoft-antispam-message-info": "\n tcC7KyOH1xu7Pgl6vP/5pJ8bnPJj0zweXfZmY0RuzIeSmU4VqUhkc8HEOHXzwJ+9wWPUDZSPbyUMoT3jmjAIcrqPjKD0C4vtniFyQxN/h9mudZIEI/TDAkm6WtRUc6B+QWOyQmzkORja0iJ+TicW1gtKgsSEz7xridNkba60lAFblW98If1qr9D0WtfsQKvtibthc/TQxDqkX8LkVxiRpQSk35eCzpKZo/spKXQ3wK/bxFKA2oxlKcVAZL6RHow5o5yHqkB7oB+7Kqz8F0YuXTYrpkXnksMO9ckl8iTSQBZmyt9T8gybuwbYbUqJD5UuUSsmGFU3S1Eh+vtiQ4SKKA==",
            "x-ms-traffictypediagnostic": "MN2PR11MB4726:",
            "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED",
            "MIME-Version": "1.0",
            "dlp-version": "11.2.0.6",
            "X-BeenThere": "dev@dpdk.org",
            "References": "<20200723130854.322771-1-maxime.coquelin@redhat.com>\n <20200723130854.322771-3-maxime.coquelin@redhat.com>",
            "Content-Type": "text/plain; charset=\"utf-8\"",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "X-Amp-Result": "SKIPPED(no attachment in message)",
            "X-MS-Exchange-CrossTenant-id": "46c98d88-e344-4ed4-8496-4ed7712e255d",
            "x-ms-office365-filtering-correlation-id": "472a0d0b-1400-417a-4940-08d83234a73b",
            "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 472a0d0b-1400-417a-4940-08d83234a73b",
            "Date": "Mon, 27 Jul 2020 13:54:59 +0000",
            "Content-Transfer-Encoding": "base64",
            "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:MN2PR11MB4063.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(39860400002)(366004)(346002)(376002)(136003)(396003)(55016002)(9686003)(316002)(54906003)(52536014)(53546011)(6506007)(15650500001)(86362001)(71200400001)(83380400001)(110136005)(8936002)(66556008)(8676002)(5660300002)(478600001)(6636002)(4326008)(33656002)(26005)(76116006)(2906002)(64756008)(66446008)(66476007)(66946007)(7696005)(186003);\n DIR:OUT; SFP:1102;",
            "X-MS-Has-Attach": "",
            "x-ms-exchange-antispam-messagedata": "\n xNlBY6OP2UWtL8ZoD/EM1mtcjpF9fPwfCMI5vXos/ZoIwoO4QsNDCpF8d93v9ltT6XgTW9kSwotFzHukoJRrD8YYmQC5h78dbd0aHbJWm7q2wlJDoIuE/25l8yPXURPDiBcYgq3hp72a4Y8X0LMSX5xehZSlPlmE9MvwPD9SgMupa/wDqa6O/vGeVnJY5159OIUyo7u18IHJlfitKli7Ukq4o2iPoHSJBLLjL0ZYF830ICo6C0uJyi/gzBTHh8g5QasQGJBJd3mHF+uLTSDKmpa3hZHfEgzzfSbSnIeV2ANlz/PSQZGJIFR8d2C8E6w+fwbrxQxbsZvsFT2G44dVjLb+61iH9eQzqQ9dCt3XqL8qI2vZmbTX1S2fAiV7dS0LVz7Axg12yLJfAEkyr9SOQA+qaKxaZNtgdZvA1mM6q/k4Q5FBku9XxyDvB97ZZRY0O6+m3cMq5alPaFpfjrydC379qTnkGCZNS3m4hgUVec5+3/cn3g89KDEOmwEuNtWU",
            "In-Reply-To": "<20200723130854.322771-3-maxime.coquelin@redhat.com>",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "Errors-To": "dev-bounces@dpdk.org",
            "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=jMOeMpSYYf4XQkfCh+Sy2h8NdtBcP+UP0O017zyNgUjgy/C8KtP6Va8Rn2+7Fm7IPWKCjA7a6MfxXgFvPeefe1t5SEVI/7vhKHK4SxbHQlGRohxzZk7K1OPngIYQLaEk+JlybhK7nIuS8w42uNa8cxf/okSj01DYaZzcqUAZ0uDic42bQRUPEsJ/14a8bc7fU5Dsg9FA+75Oi7zgTKpqGYNJQBw27zvq+bYWFlZwqVxLN14ZH2WC09XiaXxj61sb8o0RvnwvRBnPglmB2XwtJGncKEtCbO7IjVEZ20IUhmV1pdCGKoxaphp4E88y/scZuDAt5ohLWJD3gb1RBtH4Vw==",
            "x-microsoft-antispam-prvs": "\n <MN2PR11MB4726EB3C4093CB7A89C782CE9C720@MN2PR11MB4726.namprd11.prod.outlook.com>"
        }
    }
]