Patch Comment List
List patch comments
GET /api/patches/74639/comments/?format=api&order=-id
[ { "id": 116544, "web_url": "https://patches.dpdk.org/comment/116544/", "msgid": "<AM0PR05MB6707A17A161F11840190ADFCC2760@AM0PR05MB6707.eurprd05.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/AM0PR05MB6707A17A161F11840190ADFCC2760@AM0PR05MB6707.eurprd05.prod.outlook.com", "date": "2020-07-23T11:25:08", "subject": "Re: [dpdk-dev] [PATCH v2] net/mlx5: fix VF MAC address set\n\tover\tBluefield", "submitter": { "id": 513, "url": "https://patches.dpdk.org/api/people/513/?format=api", "name": "Raslan Darawsheh", "email": "rasland@mellanox.com" }, "content": "Hi,\n\n> -----Original Message-----\n> From: dev <dev-bounces@dpdk.org> On Behalf Of Raslan Darawsheh\n> Sent: Thursday, July 23, 2020 2:06 PM\n> To: dev@dpdk.org\n> Cc: ferruh.yigit@intel.com; stable@dpdk.org; Slava Ovsiienko\n> <viacheslavo@mellanox.com>\n> Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix VF MAC address set over\n> Bluefield\n> \n> When trying to set MAC address of an ethethet device and if it was\n> a representor, PMD sets the MAC over the corresponding VF instead.\n> \n> For the case of HPF (Host PF representor on BluueField), PMD shouldn't\n> attempt to set it, since it doesn't have any corresponding VF and fails.\n> \n> This will fix the issue by setting the MAC on the dev directly.\n> \n> Fixes: 0d1d73170820 (\"net/mlx5: set VF MAC address from host\")\n> Cc: stable@dpdk.org\n> \n> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>\n> Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n> ---\n> v2: fix the use of representor bit to use the representor id instead\n> ---\n> drivers/net/mlx5/mlx5_mac.c | 7 +++++--\n> 1 file changed, 5 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/net/mlx5/mlx5_mac.c b/drivers/net/mlx5/mlx5_mac.c\n> index 2d808d629..88c52b29f 100644\n> --- a/drivers/net/mlx5/mlx5_mac.c\n> +++ b/drivers/net/mlx5/mlx5_mac.c\n> @@ -157,8 +157,11 @@ mlx5_mac_addr_set(struct rte_eth_dev *dev, struct\n> rte_ether_addr *mac_addr)\n> \tuint16_t port_id;\n> \tstruct mlx5_priv *priv = dev->data->dev_private;\n> \n> -\t/* Configuring the VF instead of its representor. */\n> -\tif (priv->representor) {\n> +\t/*\n> +\t * Configuring the VF instead of its representor,\n> +\t * need to skip the special case of HPF on Bluefield.\n> +\t */\n> +\tif (priv->representor && priv->representor_id >= 0) {\n> \t\tDRV_LOG(DEBUG, \"VF represented by port %u setting\n> primary MAC address\",\n> \t\t\tdev->data->port_id);\n> \t\tRTE_ETH_FOREACH_DEV_SIBLING(port_id, dev->data-\n> >port_id) {\n> --\n> 2.27.0\n\n\nRemoved V1 from next-net-mlx, \nAnd V2 is applied with the fix.\n\nKindest regards\nRaslan Darawsheh", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 82E07A0521;\n\tThu, 23 Jul 2020 13:25:13 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CD2281C02D;\n\tThu, 23 Jul 2020 13:25:11 +0200 (CEST)", "from EUR04-VI1-obe.outbound.protection.outlook.com\n (mail-eopbgr80085.outbound.protection.outlook.com [40.107.8.85])\n by dpdk.org (Postfix) with ESMTP id 00C461BF94;\n Thu, 23 Jul 2020 13:25:10 +0200 (CEST)", "from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17)\n by AM0PR05MB5795.eurprd05.prod.outlook.com (2603:10a6:208:111::26)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.25; Thu, 23 Jul\n 2020 11:25:09 +0000", "from AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.028; Thu, 23 Jul 2020\n 11:25:09 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=lRvJMtOYcU23Qnsz5zDbXUm9sWkl1fDahkHE14p01eXKjl6kNvFizkpbho0ErMF/KoRwaJT73bMjjFQFS9+mWyXutRgQQeoBh0BvCP25C2t4CQ3shv0jOeyE8QjWR8GaPcw1Fm3pUAsZ7gqeQO70AZ28KxPW2AEZb9T5pGAUuxQjUB3u6Tr8Dq96kdc+eP4ArKt7yqgHCJECJfKMaqbblIJ7BLNdLseRQbhuL+F9znfWbW2ZDqTW66Z3Rogv8T24RgKapRM3O+oiMGaU4civRFYs6kKwUYDY/4MVHtgtug8XsmdHNmwT8EzfvswZJdQnRmGax46Y0mCE2i6xLklfDA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=SCTebCCX2fq9t8EDE7PX6OppgNEwM6dtnbGoeJluXps=;\n b=X+SLHUKdwECJRU8Nz0i2i9IlNZUpb755qH8FTPGoFqbj2gDFv0P2Hq0u9P40GqHHyC/YXlij3HXo8XkqidKIyoP9LWrvgnwXm7mm1RpCIXpuNvvOEN7O6dZy9C3kqbjZz1JwPHNaMAeIpIl1vgAlJSEOq7PlCaQYpdJumFA+OZrpzKkJWa7VMoM+rT4IaDhAD7ewZlURKJP/aRagkMUxw2oXmqmCive9kZtt5m03dJODShf/O4fDmWjS+LOe7XbJEZCFtD3WbXr1BIk/wGnRrmkXAc2qizOm1vYe5hrS1nYzmjpxU80V+MkJ1Ff0B1p5XwdK25twe10/3jRKWmsjYA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=SCTebCCX2fq9t8EDE7PX6OppgNEwM6dtnbGoeJluXps=;\n b=qxehg+uckNeGZu4HS0ZmpwDIKlbD07DHcvR8qKC/x92W7iTfsa42WMYhd02Oa2qowaBWXB+mCl1K7DYfKysepfqhIbn3kt/b1eTqbBekWmpEnQEfFU3FIWIlBfNsNvMME8cInw7QQ+oJMcEOR1OErkWgjcY+5Hp4c0BgRFvemwU=", "From": "Raslan Darawsheh <rasland@mellanox.com>", "To": "Raslan Darawsheh <rasland@mellanox.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"ferruh.yigit@intel.com\" <ferruh.yigit@intel.com>, \"stable@dpdk.org\"\n <stable@dpdk.org>, Slava Ovsiienko <viacheslavo@mellanox.com>", "Thread-Topic": "[dpdk-dev] [PATCH v2] net/mlx5: fix VF MAC address set over\n Bluefield", "Thread-Index": "AQHWYOPshPsFh3UFtE6TDsXq0a7iKA==", "Date": "Thu, 23 Jul 2020 11:25:08 +0000", "Message-ID": "\n <AM0PR05MB6707A17A161F11840190ADFCC2760@AM0PR05MB6707.eurprd05.prod.outlook.com>", "References": "<20200722090755.26103-1-rasland@mellanox.com>\n <20200723110613.8363-1-rasland@mellanox.com>", "In-Reply-To": "<20200723110613.8363-1-rasland@mellanox.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "mellanox.com; dkim=none (message not signed)\n header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com;", "x-originating-ip": "[84.242.49.134]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-ht": "Tenant", "x-ms-office365-filtering-correlation-id": "166eeac7-9224-4705-686a-08d82efb0ea2", "x-ms-traffictypediagnostic": "AM0PR05MB5795:", "x-ld-processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <AM0PR05MB5795B9E8B6385D2CBCA68C9FC2760@AM0PR05MB5795.eurprd05.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:1923;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n nMxtolaRG2wv6FSjQfwtqdzn9FZytUTeizahsxkmBtMosqVQAYBbuffOmfPqnly78J3UcRpBszh/EPdC9PoGdzs3LvTPPnWtHCmUi4jksuiik/2Mu0Ngudp1+LtZHZ3r2/PoWURVtEY8lQ6O1kaGF2qo8ufu6gZgXbvxS9FRayX/NrltpDp4k0AKERZVMkw7PnpH9ehC5ZNF/orOtfXyzFnYHKdNb2C7Fw0ak0oXb4czzHS5F3wan+O8yt5NT7sMSOo0z6IXOpq0SOz6mqu/QQqmynGVvHSqr6arMWEwWb3T82JsuggwD2r3yxXT2t5KWYu6kXlUIHMAAXAZxSnE5Q==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(39860400002)(136003)(346002)(396003)(366004)(376002)(76116006)(33656002)(66946007)(66446008)(64756008)(107886003)(66476007)(66556008)(26005)(186003)(86362001)(83380400001)(6506007)(53546011)(2906002)(478600001)(7696005)(9686003)(4326008)(8936002)(55016002)(5660300002)(316002)(54906003)(110136005)(71200400001)(52536014);\n DIR:OUT; SFP:1101;", "x-ms-exchange-antispam-messagedata": "\n SOMP9LQ/30x3ZGBTiNp0d/N3iBp5RwOEWfenYUa0kim9Lqv4x8gVGSkmYCGjP/zmz95gHky+ybO8VSaqUEc6nYTFnnjIE4lDHXZJaFsN20MZOD83ppritp/AXIlO0vLuphwP//vlHdm0KaFsdXC0841KgKzS+riQ/wZKRKajtIKSLuQZjMvnGIiRotUtKpRib2xVchVgLFISSc1qWjqP4xU3kuhdDm5c/k7o0H/bjLwSOcgA/aeU9iMQ71yUs6QC8Aqv8lWUMiUesnieA7S54iK8WU0oXZAItIoHtwzWl87xGPZm7ycEb29WgNQxHAEGjkxYl+HxasE2NF1CyYhg7Xvbjf7ccb4+xOBrFJOV1gLbBY6gcg54MQCZ6PaRFidX5EsLD557uO/i73UnyzkKzbAKW43iqYIA0d5dKU4EFBFwI4QrUiQnwlVq12IhIErzggAY8CqxF8W4IC/abW8r5eAYLUJOQXWSFSuZg8JgaMJPXeMTdo9id7w/rPv5HEO4", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB6707.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 166eeac7-9224-4705-686a-08d82efb0ea2", "X-MS-Exchange-CrossTenant-originalarrivaltime": "23 Jul 2020 11:25:08.9451 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n K3aKFFvLsUkHGEwehCD9cxWOpf11olTywGMj0hHeeCE0myB1Kork64nG4rIYs1rYgRoiaPkj/xxnE6VofXEIEQ==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR05MB5795", "Subject": "Re: [dpdk-dev] [PATCH v2] net/mlx5: fix VF MAC address set\n\tover\tBluefield", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]