List comments

GET /api/patches/74638/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 116551,
        "web_url": "https://patches.dpdk.org/comment/116551/",
        "msgid": "<AM0PR05MB670715797DB888EBB98C28A7C2760@AM0PR05MB6707.eurprd05.prod.outlook.com>",
        "date": "2020-07-23T13:34:12",
        "subject": "Re: [dpdk-dev] [PATCH] net/mlx5: fix metadata storing for NEON\n vectorized Rx burst",
        "submitter": {
            "id": 513,
            "url": "https://patches.dpdk.org/api/people/513/",
            "name": "Raslan Darawsheh",
            "email": "rasland@mellanox.com"
        },
        "content": "Hi,\n\n> -----Original Message-----\n> From: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n> Sent: Thursday, July 23, 2020 1:54 PM\n> To: dev@dpdk.org\n> Cc: Matan Azrad <matan@mellanox.com>; Raslan Darawsheh\n> <rasland@mellanox.com>; Alexander Kozyrev <akozyrev@mellanox.com>;\n> stable@dpdk.org\n> Subject: [PATCH] net/mlx5: fix metadata storing for NEON vectorized Rx\n> burst\n> \n> There was the typo introducing the bug, affected the mlx5 vectorized\n> rx_burst on ARM architectures in case if CQE compression was enabled.\n> \n> Fixes: 6c55b622a956 (\"net/mlx5: set dynamic flow metadata in Rx queues\")\n> Cc: stable@dpdk.org\n> \n> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n> ---\n>  drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 8 ++++----\n>  1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h\n> b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h\n> index 6c31495..af924b7 100644\n> --- a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h\n> +++ b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h\n> @@ -736,20 +736,20 @@\n>  \t\t\t\t\t\t      pkt_info)->timestamp);\n>  \t\t\t}\n>  \t\t}\n> -\t\tif (!!rxq->flow_meta_mask) {\n> +\t\tif (rxq->dynf_meta) {\n>  \t\t\t/* This code is subject for futher optimization. */\n>  \t\t\tint32_t offs = rxq->flow_meta_offset;\n> \n>  \t\t\t*RTE_MBUF_DYNFIELD(pkts[pos], offs, uint32_t *) =\n>  \t\t\t\tcontainer_of(p0, struct mlx5_cqe,\n>  \t\t\t\t\t     pkt_info)->flow_table_metadata;\n> -\t\t\t*RTE_MBUF_DYNFIELD(pkts[pos], offs, uint32_t *) =\n> +\t\t\t*RTE_MBUF_DYNFIELD(pkts[pos + 1], offs, uint32_t\n> *) =\n>  \t\t\t\tcontainer_of(p1, struct mlx5_cqe,\n>  \t\t\t\t\t     pkt_info)->flow_table_metadata;\n> -\t\t\t*RTE_MBUF_DYNFIELD(pkts[pos], offs, uint32_t *) =\n> +\t\t\t*RTE_MBUF_DYNFIELD(pkts[pos + 2], offs, uint32_t\n> *) =\n>  \t\t\t\tcontainer_of(p2, struct mlx5_cqe,\n>  \t\t\t\t\t     pkt_info)->flow_table_metadata;\n> -\t\t\t*RTE_MBUF_DYNFIELD(pkts[pos], offs, uint32_t *) =\n> +\t\t\t*RTE_MBUF_DYNFIELD(pkts[pos + 3], offs, uint32_t\n> *) =\n>  \t\t\t\tcontainer_of(p3, struct mlx5_cqe,\n>  \t\t\t\t\t     pkt_info)->flow_table_metadata;\n>  \t\t\tif (*RTE_MBUF_DYNFIELD(pkts[pos], offs, uint32_t\n> *))\n> --\n> 1.8.3.1\n\n\nPatch applied to next-net-mlx,\n\nKindest regards,\nRaslan Darawsheh",
        "headers": {
            "Accept-Language": "en-US",
            "X-Mailman-Version": "2.1.15",
            "x-ms-oob-tlc-oobclassifiers": "OLM:6108;",
            "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM4PR0501MB2722",
            "authentication-results": "mellanox.com; dkim=none (message not signed)\n header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com;",
            "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED",
            "Precedence": "list",
            "List-Post": "<mailto:dev@dpdk.org>",
            "x-ms-exchange-senderadcheck": "1",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Subject": "Re: [dpdk-dev] [PATCH] net/mlx5: fix metadata storing for NEON\n vectorized Rx burst",
            "X-MS-Exchange-CrossTenant-AuthAs": "Internal",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "Delivered-To": "patchwork@inbox.dpdk.org",
            "Received": [
                "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B90CBA0521;\n\tThu, 23 Jul 2020 15:34:16 +0200 (CEST)",
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5318A1BFD7;\n\tThu, 23 Jul 2020 15:34:15 +0200 (CEST)",
                "from EUR03-AM5-obe.outbound.protection.outlook.com\n (mail-eopbgr30061.outbound.protection.outlook.com [40.107.3.61])\n by dpdk.org (Postfix) with ESMTP id B8FDE2C6E;\n Thu, 23 Jul 2020 15:34:13 +0200 (CEST)",
                "from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17)\n by AM4PR0501MB2722.eurprd05.prod.outlook.com (2603:10a6:200:5a::19)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.24; Thu, 23 Jul\n 2020 13:34:12 +0000",
                "from AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.028; Thu, 23 Jul 2020\n 13:34:12 +0000"
            ],
            "x-originating-ip": "[84.242.49.134]",
            "x-microsoft-antispam": "BCL:0;",
            "x-ms-exchange-transport-forked": "True",
            "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB6707.eurprd05.prod.outlook.com",
            "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ZqLSgPOyiKUSow49OiYzObFAfTBdxuKOjq7xTE0zHJg=;\n b=OmQj0CfrAOILWMsrox3kv/GysjjBH3giTyX9VL2t6B8O9MIKq0FJdsnjHrR5jOZzLPmkLufCX0IcC8YCi5Eeb7ioWgV10Z1i+a9VYlTkBgVD+o59LaW+RduqAHZR7sZDATW8oagnwME+dVtsjG/VDbeM8YKdGfd/JKQ3tarItE7Hg1RccLDzcVC6mUlpMEi1FLaa+V5rzJglsnkTkfgfAkjtggC//ZijLx4fuRfk0PzOBNb1Agi5XTMdgsQC+seWvoe1nreV6lnoKuUvuJp5WfXenbY7aIBK0qBgqWdgvsA5k1kGdABwTCmaKFC23CTrvRn28iiDVwQc9K53K/WgOA==",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted",
            "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ZqLSgPOyiKUSow49OiYzObFAfTBdxuKOjq7xTE0zHJg=;\n b=lYuHViy5HByI0wZQc3Fr51QAj0XZcVrgr8bDPbtDU5kQ18dJZDWuNw8gPCiWNeOqz92H40Z3/SHOzJa5A8uM/bDpQYdsdsgztuJhhnGUda7/PlD5NKb7Sg/S571b/v7ZETdzdibrP/KeadveVBbJbQjB50QYFDDq2PvSRsFkQMw=",
            "Message-ID": "\n <AM0PR05MB670715797DB888EBB98C28A7C2760@AM0PR05MB6707.eurprd05.prod.outlook.com>",
            "X-MS-Exchange-CrossTenant-userprincipalname": "\n /5Q4/VMJlSpVCEyMu/kvQ2lpifv/n0QuAniZXsBL5VnZEubfvs0xcWYyn6MGbvsqKXtTk0A1fR3T+Ax1sdma/w==",
            "To": "Slava Ovsiienko <viacheslavo@mellanox.com>, \"dev@dpdk.org\" <dev@dpdk.org>",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
            "From": "Raslan Darawsheh <rasland@mellanox.com>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "x-ms-publictraffictype": "Email",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none",
            "X-MS-TNEF-Correlator": "",
            "Thread-Index": "AQHWYN+TX7Glkl8hm064p6aPxvwcm6kVKYEA",
            "CC": "Matan Azrad <matan@mellanox.com>, Alexander Kozyrev\n <akozyrev@mellanox.com>, \"stable@dpdk.org\" <stable@dpdk.org>",
            "X-OriginatorOrg": "Mellanox.com",
            "Thread-Topic": "[PATCH] net/mlx5: fix metadata storing for NEON vectorized Rx\n burst",
            "X-Original-To": "patchwork@inbox.dpdk.org",
            "x-microsoft-antispam-message-info": "\n KnzJvUXml2wGtI8m2DW9bmDGnPgFA8nDOawoM7/TPNQsVJF37ZR6mykuWF/qBkwBmtiIeQkj//BfwpbNB3XFsbaE00MRlPKW50TYpVyfum7c594ZIBzH85an/ZdRRINPu1AnwMknf+tXglVvEZdpjcDrWAjz15kEuZrdGm+NqhCRehAHqhqpBSZRFo5yMTRZdIcCKbS3M43ccRAqE/8RlG6eFhGIEcZqGGy+bsiGr7BTAIyb5XkIPKbO505PvdwYDKpDDwJ+bWehGrT+xLmKNaNIIH90ktJMFjKrCPqVH2nwHyTcnE/i50URvuX5IC31hfAAyqKNqjmZdAcRl+UXkw==",
            "x-ms-office365-filtering-ht": "Tenant",
            "MIME-Version": "1.0",
            "In-Reply-To": "<1595501612-21309-1-git-send-email-viacheslavo@mellanox.com>",
            "X-BeenThere": "dev@dpdk.org",
            "References": "<1595501612-21309-1-git-send-email-viacheslavo@mellanox.com>",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b",
            "x-ms-office365-filtering-correlation-id": "5ad493d4-3ea7-4aaf-c9a9-08d82f0d162f",
            "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 5ad493d4-3ea7-4aaf-c9a9-08d82f0d162f",
            "Date": "Thu, 23 Jul 2020 13:34:12 +0000",
            "Content-Transfer-Encoding": "quoted-printable",
            "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(396003)(346002)(39860400002)(376002)(136003)(366004)(33656002)(86362001)(76116006)(66946007)(66476007)(66556008)(64756008)(66446008)(5660300002)(52536014)(83380400001)(478600001)(8936002)(8676002)(450100002)(4326008)(71200400001)(2906002)(26005)(55016002)(9686003)(186003)(53546011)(7696005)(316002)(110136005)(54906003)(6506007);\n DIR:OUT; SFP:1101;",
            "X-MS-Has-Attach": "",
            "x-ms-traffictypediagnostic": "AM4PR0501MB2722:",
            "x-ms-exchange-antispam-messagedata": "\n somS0r8281a3WYq1a7+Vg3JKdNq86MOroJTvkCIkgUyobD8yLFWAbE6SgxxbEfCxx8K/yJogpzEobReupDOfCjx+cC9sYW5jT6Cupk/TpP+bDlNRBv1ClSzNpfVb+gRug15b3LG3dTydd6If+oKDKrDOILg7iQQ1Wad8GWeN3S3/k+MIKVKk3Tfj6PYd9St16pA2Tug6HO5b3/ZigXfTIllEvLX5aIXVEtmk+7ckIEGTtXKVetIYTPBv8UPU2nEYusieFuyiD8Eiqt0YVtCkO2bj+gya5hkGDXiKTJOauL8Sgdqbu6C+0feM5LdrKgzpG7YwOdduIg9UtBFEgiLomCNZk8WneUclmTL3rtvxioJN44FvvIy08eZGEv/xCbsyx/CjVoBAA9kgzF+YWSDklBKin9NB90jVMHZ89SuMUmN+XGGJnng8HI0oSFjYXqfGMfgMu8yL7owJmWI0omGHxCjegVuKBhE0/SBXVOSPGNQKBr4nX1f8Vc+HVKcVqnGW",
            "X-MS-Exchange-CrossTenant-originalarrivaltime": "23 Jul 2020 13:34:12.5101 (UTC)",
            "Content-Language": "en-US",
            "Errors-To": "dev-bounces@dpdk.org",
            "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=nQNAehE4otp2QpjwNS/yPcRzBli3Am3mvRHKxYAQfjzUnBpVF8bnFmlm7UbLRaDLkVPEH/7TaYp68umvV7RncuDbZSjvq+N/inQ06OKuSPW3OvqvO74aabbOIm8wafhwH8Or17aKAQCaARoj1+EiuxGh/WQ0LFvFNjNxQ6QF5NBV5I42ITmIrHBZNTd2f6iAuVaKcZzwzseIuWx0smXO3YYF4+MiJMoIxptj0HRSQ2MCWkP2A/36SXQPuK225n7qMCRWAHIcYW1PonuNfaQNGqj0tx1O4lJfEa0R5BgScWG7qzQSzJxp80nSH8pxoKD2SKDrJmFmTBDZXBu9wseJDg==",
            "x-microsoft-antispam-prvs": "\n <AM4PR0501MB2722BE57F32F8A09564E4127C2760@AM4PR0501MB2722.eurprd05.prod.outlook.com>"
        }
    }
]