Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74637/?format=api
{ "id": 74637, "url": "https://patches.dpdk.org/api/patches/74637/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200723095755.14561-1-getelson@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200723095755.14561-1-getelson@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200723095755.14561-1-getelson@mellanox.com", "date": "2020-07-23T09:57:54", "name": "net/mlx5: fix no-inline Tx flag", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f880cdeb16a9b60b6484895e8217424cd804f08a", "submitter": { "id": 1773, "url": "https://patches.dpdk.org/api/people/1773/?format=api", "name": "Gregory Etelson", "email": "getelson@mellanox.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200723095755.14561-1-getelson@mellanox.com/mbox/", "series": [ { "id": 11249, "url": "https://patches.dpdk.org/api/series/11249/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11249", "date": "2020-07-23T09:57:54", "name": "net/mlx5: fix no-inline Tx flag", "version": 1, "mbox": "https://patches.dpdk.org/series/11249/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/74637/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/74637/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C7E6FA0521;\n\tThu, 23 Jul 2020 11:58:20 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 505C11BE9A;\n\tThu, 23 Jul 2020 11:58:19 +0200 (CEST)", "from EUR05-AM6-obe.outbound.protection.outlook.com\n (mail-am6eur05on2040.outbound.protection.outlook.com [40.107.22.40])\n by dpdk.org (Postfix) with ESMTP id A42F7199BC\n for <dev@dpdk.org>; Thu, 23 Jul 2020 11:58:17 +0200 (CEST)", "from DB8PR05MB6761.eurprd05.prod.outlook.com (2603:10a6:10:139::21)\n by DB8PR05MB6762.eurprd05.prod.outlook.com (2603:10a6:10:133::10)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.23; Thu, 23 Jul\n 2020 09:58:16 +0000", "from DB8PR05MB6761.eurprd05.prod.outlook.com\n ([fe80::5895:a00:3355:eb9f]) by DB8PR05MB6761.eurprd05.prod.outlook.com\n ([fe80::5895:a00:3355:eb9f%7]) with mapi id 15.20.3216.024; Thu, 23 Jul 2020\n 09:58:16 +0000", "from mellanox.com (176.230.224.223) by\n AM0PR03CA0075.eurprd03.prod.outlook.com (2603:10a6:208:69::16) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.3216.20 via Frontend Transport; Thu, 23 Jul 2020 09:58:15 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=hEHZRKbYzXGNy8ANNDnOQDu+p3qk+7DohPnpb+TGHW8vfmGqxjRkRowkNRYu53HUK/4zPlGfe54ArQX/UgfQAVol+myJ84XE4cY06eT6Pcqgbc9Qj3xZPD1VFlFzFreefkJuHPw7ts1UaqacSTnI4CNVcKbzOiHG/4nftj2bgUOPfKBQHOC+ulNBnna6fwt/18lmoI5zzpY5aq7JCtqc6G3HY6SuSqEJauDgVeRNCIiGp27cSpnNCqOeVY7QeflbZ1qtR0doeVTWCTxYMvpRplQNeiOcrcMBTmo7Su/CCZM0IC1LOopqf0gu+/JLDR89dy9RSiecA8lnWs/i1TtOQA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ziM2Lg4OB62YT1yL8IrzAX4mBr0ddYqm4VrOXh51fHI=;\n b=bNnYm3IUMk/0irY/BMVhoGPCFHpkkMmRRdkfNP8ecrjOxubsFB9HdYeTdRan5/d7oS7lhYWUvbgmH0XSx6Zqlwu28ZeYLta60fUZ8m7qlzSG6Jm+rEjsHUeR5LuR6r+pQ6xFiEN97aAJ6Ru7u+fYeLc8zmyjC2jQrcJWbQNzbV5+G0LP4qwAXFaAUpaWvebiWL8b8c9phja2ou/JmiE4ACnZWbdqevnI4WotC4HTY3G3bbdyvG5VSuT65v4astQg3p2IJzG97A2qFIJyL9hb+xUwwoY7Asl8KZy8al7dBKmE+K8Ycm+lEzQ5Jdq7zmQtYKAcm4K3hBeIrP4t1oTtbA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ziM2Lg4OB62YT1yL8IrzAX4mBr0ddYqm4VrOXh51fHI=;\n b=QjHZo+qJycymkfe1WzikMEqGtHKS4FRDsGmHvou3xViK+ntT2auFaSEMShKTeAqEgqoy2A7jJ0ulo+ZIqomGoeJoJAkgw3Ny6yMkTA5z8eW3GbqBaNS3vi8Bxl9y+9CFTWsdANP+llAM6mCeAcOi6xM1xIb++5bByL2H+xn8GhQ=", "Authentication-Results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com;", "From": "Gregory Etelson <getelson@mellanox.com>", "To": "dev@dpdk.org", "Cc": "getelson@mellanox.com, matan@mellanox.com, rasland@mellanox.com,\n Viacheslav Ovsiienko <viacheslavo@mellanox.com>,\n Shahaf Shuler <shahafs@mellanox.com>", "Date": "Thu, 23 Jul 2020 12:57:54 +0300", "Message-Id": "<20200723095755.14561-1-getelson@mellanox.com>", "X-Mailer": [ "git-send-email 2.25.1", "git-send-email 2.25.1" ], "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "AM0PR03CA0075.eurprd03.prod.outlook.com\n (2603:10a6:208:69::16) To DB8PR05MB6761.eurprd05.prod.outlook.com\n (2603:10a6:10:139::21)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-Originating-IP": "[176.230.224.223]", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "152046b5-d9fe-4e8f-7b3b-08d82eeeeb62", "X-MS-TrafficTypeDiagnostic": "DB8PR05MB6762:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <DB8PR05MB676282EE9995D5FD05B1922AA8760@DB8PR05MB6762.eurprd05.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:5797;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n c16jTQqkGuE9YPKARKKGC36pLAns8uw/FmrYzh4nQ1oURCcJWn/XfgEPObPE2+j4YZcYaN5UMfXidCluBeGwBVndOrVQ8T4C9hRtOe66oA4OnwUsIGgqI+y6klRCiCDu29qHKIpTd9JER8gHXLQQc7qTGZIJEJpce1K9A9yn1VZMM0Rt1rdxz+DfMP9PvJ8rbiEh6aUH2BDv9/diAh0M+hMsKc2boBVDbnmvsE0kxxrye3lTG8emtbIfQv7lDmpwl4MyiNbXmc5oGQwBd6bCeIW8JJ6ymfnrHac0HgG5vVdUpYw9pIBx7qwvxYOG7XX6osam+4yxBwZ6Cz7aOfwCJw==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DB8PR05MB6761.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(136003)(376002)(396003)(346002)(366004)(39860400002)(316002)(956004)(2616005)(16526019)(186003)(8936002)(54906003)(478600001)(5660300002)(6666004)(66476007)(66946007)(66556008)(86362001)(1076003)(6916009)(8886007)(36756003)(4326008)(7696005)(26005)(55016002)(107886003)(8676002)(52116002)(2906002);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData": "\n 7SW9vE1r6OzDMCjdzQBHAn1ZmugIYMEbZ9XVEpXpAxvwmC24IkruJpBe9wZbnQG/1fIWzzPJslkD6XAIzZ1HYeAtyMR1sGSNSIMWitvb75YQ8gsVs5CSMcpl/9RczpKlxqubUIYXx+EGvrvuOuub9p+P+GgztCNK5Pbe+eWh1nWhbmcollyhdG7wANN0xw6TOVhEMnN7Qssmn368VgmzH+WbyoOOi1RSJ2x/DRcK//MnBToqQZSdcWhcv77FYbQwIJDrXYXGRbVP9nJ9tl1zAV+FLkpPr98imap6aRP6whYdYKHqpXrBUOKwWNk6EplPSvqKqv4QGP3FSH/TroqiycyVKgW5C7LKFLMdu2sd9hmJ6TsKWcthsroIz4P6Y+vd3gSU+ufYqNRuUmwLPaCExOTGCWIIL0BbMUEiGLlCP8kyJhqEfpvesUFaXos0d8nBrurC8a9vrO/ZHTo6rpjnCeaOYcvpgLonh/16LkEbRKGJG2BMfwu+bvw22JJVau0q", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 152046b5-d9fe-4e8f-7b3b-08d82eeeeb62", "X-MS-Exchange-CrossTenant-AuthSource": "DB8PR05MB6761.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "23 Jul 2020 09:58:16.1687 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n oBEibkcOjZQhmGnnwLtdiED5jesvGzJ6MZ4J8MurdXQFG+zhxLp8CTW+5GPCpXEzejfpB619NdNoUaVgKJUL+A==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DB8PR05MB6762", "Subject": "[dpdk-dev] [PATCH] net/mlx5: fix no-inline Tx flag", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch addresses specific configuration:\nPMD was explicitly configured to inline TX data info WQE with the\n`txq_inline_min' PMD parameter and run-time TX no-inline dynamic\nflag was added.\n\nTX processing was broken for packets with length less than TXQ\nminimal inline size.\n\nFixes: cacb44a09962 (\"net/mlx5: add no-inline Tx flag\")\n\nSigned-off-by: Gregory Etelson <getelson@mellanox.com>\nAcked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n---\n drivers/net/mlx5/mlx5_rxtx.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c\nindex 3eb0243603..1b71e94221 100644\n--- a/drivers/net/mlx5/mlx5_rxtx.c\n+++ b/drivers/net/mlx5/mlx5_rxtx.c\n@@ -4739,6 +4739,8 @@ mlx5_tx_burst_single_send(struct mlx5_txq_data *__rte_restrict txq,\n \t\t\t\t\t txq->inlen_mode) ||\n \t\t\t\t\t (MLX5_TXOFF_CONFIG(MPW) &&\n \t\t\t\t\t txq->inlen_mode)) {\n+\t\t\t\t\t\tif (inlen <= txq->inlen_send)\n+\t\t\t\t\t\t\tgoto single_inline;\n \t\t\t\t\t\t/*\n \t\t\t\t\t\t * The hardware requires the\n \t\t\t\t\t\t * minimal inline data header.\n@@ -4755,6 +4757,7 @@ mlx5_tx_burst_single_send(struct mlx5_txq_data *__rte_restrict txq,\n \t\t\t\t\t}\n \t\t\t\t\tgoto single_no_inline;\n \t\t\t\t}\n+single_inline:\n \t\t\t\t/*\n \t\t\t\t * Completely inlined packet data WQE:\n \t\t\t\t * - Control Segment, SEND opcode\n", "prefixes": [] }