Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 74635,
    "url": "https://patches.dpdk.org/api/patches/74635/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200723070825.6448-2-fady@mellanox.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20200723070825.6448-2-fady@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20200723070825.6448-2-fady@mellanox.com",
    "date": "2020-07-23T07:08:23",
    "name": "[v4,1/3] net: fix s_addr redefinition in Windows",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "143b9299721a9a9f7d46226b4125704f0e088e7d",
    "submitter": {
        "id": 1650,
        "url": "https://patches.dpdk.org/api/people/1650/?format=api",
        "name": "Fady Bader",
        "email": "fady@mellanox.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200723070825.6448-2-fady@mellanox.com/mbox/",
    "series": [
        {
            "id": 11248,
            "url": "https://patches.dpdk.org/api/series/11248/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11248",
            "date": "2020-07-23T07:08:25",
            "name": "compile librte_net for windows",
            "version": 4,
            "mbox": "https://patches.dpdk.org/series/11248/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/74635/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/74635/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2B8CBA0527;\n\tThu, 23 Jul 2020 09:09:01 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4E6581BFFB;\n\tThu, 23 Jul 2020 09:08:48 +0200 (CEST)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id C7B9E1BFD9\n for <dev@dpdk.org>; Thu, 23 Jul 2020 09:08:43 +0200 (CEST)",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n fady@mellanox.com) with SMTP; 23 Jul 2020 10:08:41 +0300",
            "from l-wincomp04-vm.labs.mlnx (l-wincomp04-vm.mtl.labs.mlnx\n [10.237.1.5])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 06N78eGi027335;\n Thu, 23 Jul 2020 10:08:40 +0300"
        ],
        "From": "Fady Bader <fady@mellanox.com>",
        "To": "dev@dpdk.org",
        "Cc": "thomas@monjalon.net, tbashar@mellanox.com, talshn@mellanox.com,\n yohadt@mellanox.com, dmitry.kozliuk@gmail.com,\n harini.ramakrishnan@microsoft.com, ocardona@microsoft.com,\n pallavi.kadam@intel.com, ranjit.menon@intel.com, olivier.matz@6wind.com",
        "Date": "Thu, 23 Jul 2020 10:08:23 +0300",
        "Message-Id": "<20200723070825.6448-2-fady@mellanox.com>",
        "X-Mailer": "git-send-email 2.16.1.windows.4",
        "In-Reply-To": "<20200723070825.6448-1-fady@mellanox.com>",
        "References": "<20200610120040.17968-1-fady@mellanox.com>\n <20200723070825.6448-1-fady@mellanox.com>",
        "Subject": "[dpdk-dev] [PATCH v4 1/3] net: fix s_addr redefinition in Windows",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "s_addr in Windows is defined in defined winsock2.h which is included by\nwindows.h so its undefined in order to be defined as part of\nrte_ether_hdr.\n\nSigned-off-by: Fady Bader <fady@mellanox.com>\n---\n lib/librte_net/rte_ether.h | 9 +++++++++\n 1 file changed, 9 insertions(+)",
    "diff": "diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h\nindex a358e88763..6690690b13 100644\n--- a/lib/librte_net/rte_ether.h\n+++ b/lib/librte_net/rte_ether.h\n@@ -23,6 +23,15 @@ extern \"C\" {\n #include <rte_mbuf.h>\n #include <rte_byteorder.h>\n \n+/*\n+ * s_addr in windows is defined in winsock2.h which is included by windows.h\n+ * it is undefined here to be defined as part of rte_ether_hdr\n+ */\n+#ifdef RTE_EXEC_ENV_WINDOWS\n+#undef s_addr\n+#endif\n+\n+\n #define RTE_ETHER_ADDR_LEN  6 /**< Length of Ethernet address. */\n #define RTE_ETHER_TYPE_LEN  2 /**< Length of Ethernet type field. */\n #define RTE_ETHER_CRC_LEN   4 /**< Length of Ethernet CRC. */\n",
    "prefixes": [
        "v4",
        "1/3"
    ]
}