Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74633/?format=api
{ "id": 74633, "url": "https://patches.dpdk.org/api/patches/74633/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200723070825.6448-4-fady@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200723070825.6448-4-fady@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200723070825.6448-4-fady@mellanox.com", "date": "2020-07-23T07:08:25", "name": "[v4,3/3] eal/windows: librte_net build on Windows", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2b53275f7d898b9a2ac03040b79889c1995b4dc1", "submitter": { "id": 1650, "url": "https://patches.dpdk.org/api/people/1650/?format=api", "name": "Fady Bader", "email": "fady@mellanox.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200723070825.6448-4-fady@mellanox.com/mbox/", "series": [ { "id": 11248, "url": "https://patches.dpdk.org/api/series/11248/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11248", "date": "2020-07-23T07:08:25", "name": "compile librte_net for windows", "version": 4, "mbox": "https://patches.dpdk.org/series/11248/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/74633/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/74633/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3B154A0527;\n\tThu, 23 Jul 2020 09:08:46 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 77C3E1BF94;\n\tThu, 23 Jul 2020 09:08:45 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id C362D1BFD7\n for <dev@dpdk.org>; Thu, 23 Jul 2020 09:08:43 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n fady@mellanox.com) with SMTP; 23 Jul 2020 10:08:41 +0300", "from l-wincomp04-vm.labs.mlnx (l-wincomp04-vm.mtl.labs.mlnx\n [10.237.1.5])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 06N78eGk027335;\n Thu, 23 Jul 2020 10:08:41 +0300" ], "From": "Fady Bader <fady@mellanox.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, tbashar@mellanox.com, talshn@mellanox.com,\n yohadt@mellanox.com, dmitry.kozliuk@gmail.com,\n harini.ramakrishnan@microsoft.com, ocardona@microsoft.com,\n pallavi.kadam@intel.com, ranjit.menon@intel.com, olivier.matz@6wind.com", "Date": "Thu, 23 Jul 2020 10:08:25 +0300", "Message-Id": "<20200723070825.6448-4-fady@mellanox.com>", "X-Mailer": "git-send-email 2.16.1.windows.4", "In-Reply-To": "<20200723070825.6448-1-fady@mellanox.com>", "References": "<20200610120040.17968-1-fady@mellanox.com>\n <20200723070825.6448-1-fady@mellanox.com>", "Subject": "[dpdk-dev] [PATCH v4 3/3] eal/windows: librte_net build on Windows", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "librte_net wasn't compiling under Windows.\nTo solve this, needed header files were added.\n\nSigned-off-by: Fady Bader <fady@mellanox.com>\n---\n lib/librte_eal/windows/include/netinet/in.h | 23 +++++++++++++++++++++++\n lib/librte_eal/windows/include/netinet/ip.h | 10 ++++++++++\n lib/librte_net/rte_ether.c | 4 ++++\n lib/meson.build | 2 +-\n 4 files changed, 38 insertions(+), 1 deletion(-)\n create mode 100644 lib/librte_eal/windows/include/netinet/in.h\n create mode 100644 lib/librte_eal/windows/include/netinet/ip.h", "diff": "diff --git a/lib/librte_eal/windows/include/netinet/in.h b/lib/librte_eal/windows/include/netinet/in.h\nnew file mode 100644\nindex 0000000000..2be25c8bea\n--- /dev/null\n+++ b/lib/librte_eal/windows/include/netinet/in.h\n@@ -0,0 +1,23 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright 2020 Mellanox Technologies, Ltd\n+ */\n+\n+#ifndef _IN_H_\n+#define _IN_H_\n+\n+#define IPPROTO_IP 0 /* Dummy for IP */\n+#define IPPROTO_HOPOPTS 0 /* IPv6 Hop-by-Hop options */\n+#define IPPROTO_IPIP 4 /* IPIP tunnels (for compatibility) */\n+#define IPPROTO_TCP 6 /* Transmission Control Protocol */\n+#define IPPROTO_UDP 17 /* User Datagram Protocol */\n+#define IPPROTO_IPV6 41 /* IPv6 header */\n+#define IPPROTO_ROUTING 43 /* IPv6 routing header */\n+#define IPPROTO_FRAGMENT 44 /* IPv6 fragmentation header */\n+#define IPPROTO_GRE 47 /* General Routing Encap */\n+#define IPPROTO_ESP 50 /* IPsec Encap Sec. Payload */\n+#define IPPROTO_AH 51 /* IPsec Auth Header */\n+#define IPPROTO_NONE 59 /* IPv6 no next header */\n+#define IPPROTO_DSTOPTS 60 /* IPv6 destination option */\n+#define IPPROTO_SCTP 132 /* Stream Control Transmission Protocol */\n+\n+#endif\ndiff --git a/lib/librte_eal/windows/include/netinet/ip.h b/lib/librte_eal/windows/include/netinet/ip.h\nnew file mode 100644\nindex 0000000000..2126498797\n--- /dev/null\n+++ b/lib/librte_eal/windows/include/netinet/ip.h\n@@ -0,0 +1,10 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright 2020 Mellanox Technologies, Ltd\n+ */\n+\n+#ifndef _IP_H_\n+#define _IP_H_\n+\n+#define IPVERSION 4\n+\n+#endif\ndiff --git a/lib/librte_net/rte_ether.c b/lib/librte_net/rte_ether.c\nindex ced65ed9f3..6055ae1463 100644\n--- a/lib/librte_net/rte_ether.c\n+++ b/lib/librte_net/rte_ether.c\n@@ -10,12 +10,16 @@\n void\n rte_eth_random_addr(uint8_t *addr)\n {\n+#ifdef RTE_EXEC_ENV_WINDOWS\n+\tRTE_SET_USED(addr); /* random is not supported yet */\n+#else\n \tuint64_t rand = rte_rand();\n \tuint8_t *p = (uint8_t *)&rand;\n \n \trte_memcpy(addr, p, RTE_ETHER_ADDR_LEN);\n \taddr[0] &= (uint8_t)~RTE_ETHER_GROUP_ADDR;\t/* clear multicast bit */\n \taddr[0] |= RTE_ETHER_LOCAL_ADMIN_ADDR;\t/* set local assignment bit */\n+#endif\n }\n \n void\ndiff --git a/lib/meson.build b/lib/meson.build\nindex 3852c01564..6bbaf242a9 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -40,7 +40,7 @@ if is_windows\n \t\t'kvargs',\n \t\t'eal',\n \t\t'ring',\n-\t\t'mempool', 'mbuf', 'pci',\n+\t\t'mempool', 'mbuf', 'pci', 'net',\n \t] # only supported libraries for windows\n endif\n \n", "prefixes": [ "v4", "3/3" ] }