Patch Comment List
List patch comments
GET /api/patches/74631/comments/?format=api
[ { "id": 116698, "web_url": "https://patches.dpdk.org/comment/116698/", "msgid": "<MN2PR11MB4063504834916505D09747929C720@MN2PR11MB4063.namprd11.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/MN2PR11MB4063504834916505D09747929C720@MN2PR11MB4063.namprd11.prod.outlook.com", "date": "2020-07-27T12:52:45", "subject": "Re: [dpdk-dev] [PATCH v1] vhost: fix async callback return type\n\tdefine", "submitter": { "id": 1276, "url": "https://patches.dpdk.org/api/people/1276/?format=api", "name": "Chenbo Xia", "email": "chenbo.xia@intel.com" }, "content": "> -----Original Message-----\n> From: Fu, Patrick <patrick.fu@intel.com>\n> Sent: Thursday, July 23, 2020 1:39 PM\n> To: dev@dpdk.org; maxime.coquelin@redhat.com; Xia, Chenbo\n> <chenbo.xia@intel.com>\n> Cc: Fu, Patrick <patrick.fu@intel.com>\n> Subject: [PATCH v1] vhost: fix async callback return type define\n> \n> From: Patrick Fu <patrick.fu@intel.com>\n> \n> The async copy device callbacks are used by async APIs to transfer data and\n> check completion status. Async APIs return the number of packets successfully\n> processed to the caller applications and no error (negative) value is allowed for\n> API return value. Thus, negative return values from async device callbacks don't\n> have meaningful usage, while adding overhead in checking the return value\n> validity. This patch change the callback return values from \"int\" to \"uint32_t\" to\n> get aligned with async API definition.\n> \n> Fixes: 78639d54563a (\"vhost: introduce async enqueue registration API\")\n> \n> Signed-off-by: Patrick Fu <patrick.fu@intel.com>\n> ---\n> lib/librte_vhost/rte_vhost_async.h | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/lib/librte_vhost/rte_vhost_async.h\n> b/lib/librte_vhost/rte_vhost_async.h\n> index c8ad8dbc7..66d258abe 100644\n> --- a/lib/librte_vhost/rte_vhost_async.h\n> +++ b/lib/librte_vhost/rte_vhost_async.h\n> @@ -59,9 +59,9 @@ struct rte_vhost_async_channel_ops {\n> \t * @param count\n> \t * number of elements in the \"descs\" array\n> \t * @return\n> -\t * -1 on failure, number of descs processed on success\n> +\t * number of descs processed on success\n> \t */\n> -\tint (*transfer_data)(int vid, uint16_t queue_id,\n> +\tuint32_t (*transfer_data)(int vid, uint16_t queue_id,\n> \t\tstruct rte_vhost_async_desc *descs,\n> \t\tstruct rte_vhost_async_status *opaque_data,\n> \t\tuint16_t count);\n> @@ -70,15 +70,15 @@ struct rte_vhost_async_channel_ops {\n> \t * @param vid\n> \t * id of vhost device to check copy completion\n> \t * @param queue_id\n> -\t * queue id to check copyp completion\n> +\t * queue id to check copy completion\n> \t * @param opaque_data\n> \t * buffer to receive the opaque data pair from DMA engine\n> \t * @param max_packets\n> \t * max number of packets could be completed\n> \t * @return\n> -\t * -1 on failure, number of iov segments completed on success\n> +\t * number of iov segments completed on success\n> \t */\n> -\tint (*check_completed_copies)(int vid, uint16_t queue_id,\n> +\tuint32_t (*check_completed_copies)(int vid, uint16_t queue_id,\n> \t\tstruct rte_vhost_async_status *opaque_data,\n> \t\tuint16_t max_packets);\n> };\n> --\n> 2.18.4\n\nReviewed-by: Chenbo Xia <chenbo.xia@intel.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3FA29A053A;\n\tMon, 27 Jul 2020 14:52:54 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DAFE81BFE9;\n\tMon, 27 Jul 2020 14:52:52 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id 2ACD91BFE0\n for <dev@dpdk.org>; Mon, 27 Jul 2020 14:52:49 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Jul 2020 05:52:49 -0700", "from fmsmsx601.amr.corp.intel.com ([10.18.126.81])\n by orsmga001.jf.intel.com with ESMTP; 27 Jul 2020 05:52:48 -0700", "from fmsmsx601.amr.corp.intel.com (10.18.126.81) by\n fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.1713.5; Mon, 27 Jul 2020 05:52:48 -0700", "from FMSEDG002.ED.cps.intel.com (10.1.192.134) by\n fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5\n via Frontend Transport; Mon, 27 Jul 2020 05:52:48 -0700", "from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106)\n by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id\n 14.3.439.0; Mon, 27 Jul 2020 05:52:47 -0700", "from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22)\n by MN2PR11MB3856.namprd11.prod.outlook.com (2603:10b6:208:ef::11)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.23; Mon, 27 Jul\n 2020 12:52:45 +0000", "from MN2PR11MB4063.namprd11.prod.outlook.com\n ([fe80::b898:36f5:61cb:42ca]) by MN2PR11MB4063.namprd11.prod.outlook.com\n ([fe80::b898:36f5:61cb:42ca%7]) with mapi id 15.20.3216.033; Mon, 27 Jul 2020\n 12:52:45 +0000" ], "IronPort-SDR": [ "\n sDTbP+bVFWkrRCqRCG6fVabSYcV8ksHmpen0xd6jn7lJGb69DZ//O+gv/XTIlJsoBAecvw9AsI\n D0MQ3/MZzQXg==", "\n B5ahU9BwvGKVCA0PrbZfUi2cXFiSZANuAIQmCVXo1c2R9uXfy2BpLwcAIXdHD7qoxfBfs/NlLV\n boyiTrS4wJMA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9694\"; a=\"212529221\"", "E=Sophos;i=\"5.75,402,1589266800\"; d=\"scan'208\";a=\"212529221\"", "E=Sophos;i=\"5.75,402,1589266800\"; d=\"scan'208\";a=\"364110883\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Yy+sqFIg2hCg3uHSJ+DZmCEfBJ6ulrL0Y76moYDfZJwjePCcJyyDs+gKAcRbFqWlFj1wGsGCEAfdNTFMNdvBY7Lgh9By7pIcmTvJ+1kWqz6sZdw4gqCHiC5rCwUftk5d5gGCD/l6zLdGofKe36KF/oRtIRDTwqjLehdDwaUP9I7usdtMt3Fhw+lhemOI08PckSbg7folDmOgMvWK6kqihtcfvapEWRRXfAXwWH9oeZRvU1+oslK6q1DDZTSY/aYY1xMzNKoio1kMVdrGTB9+GhTMaXRputxwxAJ9FWfGgRRVBP/nAiZt6jV7meI3e9gOePvW9hclSspJI7ueeW/a5g==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=3jKnSaCBzmckimV8FRrSKZUZs2pJPzTdrEGXhiB89mI=;\n b=gCYTAIKYIE3K/o1FCnasMwuKks/JoYomOLlwb7D+V3dfgCO6EIBDOk15Tm3Lkz3zQ2CYi6H2hE8/AvD0+AARhe19eYtxC5RpHUaryUojU84HQ6JDWv/XcCIJ3GXaOxTIp2NxKWRUlm95T9Uj1FVvygXtIIwBROqTdcAIYALoJu6dvy/Xhy0Ta2nrlFijNbZe0mGnlf5+ui5/S/FbcriN/gNIgOKQkbknZb09viFKtE0pRQA7dyhSt6CAaFr4Hv3CxYSzy9Cgb5w+x3jp88ssoWYybcgsXsh9XNJoaE6KGHoh2dQGM5Oel5NtRMO9ZQyvmcD3tYvwZSgOQavPCQYY9g==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;\n s=selector2-intel-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=3jKnSaCBzmckimV8FRrSKZUZs2pJPzTdrEGXhiB89mI=;\n b=sjV5G/edlCUhixhsUbz1VYp3RqN+/wTKimy7gGFCBScacHh5XTKVtARIdgMGpBSO7u7CCMxmLPWKwcX1oK598yOmtaKhVSuRhac1ADws+3JbhsxAnrjEO6xWBsSqm/hX+DEOd22covaoFwtPsYPgzQSkAUYYVZYFzr3fXZ5fg1I=", "From": "\"Xia, Chenbo\" <chenbo.xia@intel.com>", "To": "\"Fu, Patrick\" <patrick.fu@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>,\n \"maxime.coquelin@redhat.com\" <maxime.coquelin@redhat.com>", "Thread-Topic": "[PATCH v1] vhost: fix async callback return type define", "Thread-Index": "AQHWYLPvhPq+jL2i6U+fKk8beOpcYakbZ+Ow", "Date": "Mon, 27 Jul 2020 12:52:45 +0000", "Message-ID": "\n <MN2PR11MB4063504834916505D09747929C720@MN2PR11MB4063.namprd11.prod.outlook.com>", "References": "<20200723053906.3616989-1-patrick.fu@intel.com>", "In-Reply-To": "<20200723053906.3616989-1-patrick.fu@intel.com>", "Accept-Language": "en-US, zh-CN", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "dlp-product": "dlpe-windows", "dlp-reaction": "no-action", "dlp-version": "11.2.0.6", "authentication-results": "intel.com; dkim=none (message not signed)\n header.d=none;intel.com; dmarc=none action=none header.from=intel.com;", "x-originating-ip": "[192.198.147.193]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "c3387496-3485-4719-f90e-08d8322bf577", "x-ms-traffictypediagnostic": "MN2PR11MB3856:", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <MN2PR11MB3856AAA372FE141E8C737C309C720@MN2PR11MB3856.namprd11.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:8273;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n zezoOq5AAksQXTxIB6cM8J5Jx6MeJbMK0Ezfhfw00T5UEVoKABUFImzSioUb7s9Pu+slI4ZjBzTMT4ZF+RcPkpBLlG+xNm1xIvBgGRKlFrbFj++0Nx4z40sY9nPAXkHfEmgD4/lGUR8wHRJehIRXsZRttS63ANLF6/7tjWFHZ6xnYEUR6FODA7KRq0lv/KaqZl2b0vO0OcFwQthwJi6HE+HI7iWbPZB8dqc+efz3H6oDuI3hPh8FNSfb0RsW5UHQW5CZakRXkpcXcezzt5OOVYIi8WaEj4aM2LwE+VIlrpjVKOX7iFaNCmS6T5Uys8/myMwJyev6fOPflrZrQlnTnQ==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:MN2PR11MB4063.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(136003)(366004)(376002)(396003)(346002)(39860400002)(53546011)(55016002)(6506007)(66446008)(66556008)(316002)(64756008)(9686003)(478600001)(76116006)(52536014)(26005)(86362001)(110136005)(7696005)(2906002)(33656002)(66946007)(66476007)(8676002)(71200400001)(186003)(5660300002)(83380400001)(8936002);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata": "\n Saga67Y+SMEzx1gFLxSqxGtZaiyKOODijn+xwEIJWJI92BHvCICuFKpmX8t4kTVRx9fZLv31O6qWL2o6Qbzq1aIykB6OyyG7TDxGILYHv9Jrh0ZMM/HxTULcGG/OQWnTWAENYmrXiZH4PQQexXLYOD+wWZVgaw7UHnijTzNKJ4DWb57Qi0mLljEkAfZoASTALP1rMYeXXdMLX4xnzPIBRKBVbMmYcA5NxckrjYRlL4sPMYqghvI/lHv+xZm4hiBUs/e8kqEkSQR0MSaSW2NL6qckJzpABziey7kh5N+m5UhkUBf7yzO0IYxFLoQSauR2BjK8I09fXrCDys5Z/IuU0MU+sVvcDqWnGxivmhjKoGVlduUZ0rcdK7Y8w/RlcJuzg7I7fRGRva/TEXckKUen2aYvkK9KTtNmBOZ+dNF0Tx5PaC6K0xRp7zIDJGyRT58Ww4ZnNhHLWVIPfQFHOUW0fRE5YG6tGORkButnshh4nw2yXOOzw6nn8/kcZAJJWLJ4", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "MN2PR11MB4063.namprd11.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n c3387496-3485-4719-f90e-08d8322bf577", "X-MS-Exchange-CrossTenant-originalarrivaltime": "27 Jul 2020 12:52:45.4029 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "46c98d88-e344-4ed4-8496-4ed7712e255d", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n vU/sufzAxyG/0wQSDhLRQIp7c8QItq5FLOKUgduF6PhtjUnvgRPHclhj8prVDQRq9LTYnNlOtgXcbhhiEUVm0w==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN2PR11MB3856", "X-OriginatorOrg": "intel.com", "Subject": "Re: [dpdk-dev] [PATCH v1] vhost: fix async callback return type\n\tdefine", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116750, "web_url": "https://patches.dpdk.org/comment/116750/", "msgid": "<2faeef8f-01e0-aaee-8105-7027c49e4589@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/2faeef8f-01e0-aaee-8105-7027c49e4589@redhat.com", "date": "2020-07-28T09:10:16", "subject": "Re: [dpdk-dev] [PATCH v1] vhost: fix async callback return type\n\tdefine", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "content": "On 7/23/20 7:39 AM, patrick.fu@intel.com wrote:\n> From: Patrick Fu <patrick.fu@intel.com>\n> \n> The async copy device callbacks are used by async APIs to transfer data\n> and check completion status. Async APIs return the number of packets\n> successfully processed to the caller applications and no error (negative)\n> value is allowed for API return value. Thus, negative return values\n> from async device callbacks don't have meaningful usage, while adding\n> overhead in checking the return value validity. This patch change the\n> callback return values from \"int\" to \"uint32_t\" to get aligned with\n> async API definition.\n> \n> Fixes: 78639d54563a (\"vhost: introduce async enqueue registration API\")\n> \n> Signed-off-by: Patrick Fu <patrick.fu@intel.com>\n> ---\n> lib/librte_vhost/rte_vhost_async.h | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/lib/librte_vhost/rte_vhost_async.h b/lib/librte_vhost/rte_vhost_async.h\n> index c8ad8dbc7..66d258abe 100644\n> --- a/lib/librte_vhost/rte_vhost_async.h\n> +++ b/lib/librte_vhost/rte_vhost_async.h\n> @@ -59,9 +59,9 @@ struct rte_vhost_async_channel_ops {\n> \t * @param count\n> \t * number of elements in the \"descs\" array\n> \t * @return\n> -\t * -1 on failure, number of descs processed on success\n> +\t * number of descs processed on success\n\nlet's remove on success as in case of failure it will still be the\nnumber of descriptors process, i.e. 0.\n\n> \t */\n> -\tint (*transfer_data)(int vid, uint16_t queue_id,\n> +\tuint32_t (*transfer_data)(int vid, uint16_t queue_id,\n> \t\tstruct rte_vhost_async_desc *descs,\n> \t\tstruct rte_vhost_async_status *opaque_data,\n> \t\tuint16_t count);\n> @@ -70,15 +70,15 @@ struct rte_vhost_async_channel_ops {\n> \t * @param vid\n> \t * id of vhost device to check copy completion\n> \t * @param queue_id\n> -\t * queue id to check copyp completion\n> +\t * queue id to check copy completion\n> \t * @param opaque_data\n> \t * buffer to receive the opaque data pair from DMA engine\n> \t * @param max_packets\n> \t * max number of packets could be completed\n> \t * @return\n> -\t * -1 on failure, number of iov segments completed on success\n> +\t * number of iov segments completed on success\nDitto\n\n> \t */\n> -\tint (*check_completed_copies)(int vid, uint16_t queue_id,\n> +\tuint32_t (*check_completed_copies)(int vid, uint16_t queue_id,\n> \t\tstruct rte_vhost_async_status *opaque_data,\n> \t\tuint16_t max_packets);\n> };\n> \n\nOther than that:\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n\nI can fixup the comments while applying if you agree with it.\n\nThanks,\nMaxime", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3A967A052B;\n\tTue, 28 Jul 2020 11:10:26 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0462010A3;\n\tTue, 28 Jul 2020 11:10:25 +0200 (CEST)", "from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81])\n by dpdk.org (Postfix) with ESMTP id 1B311A69\n for <dev@dpdk.org>; Tue, 28 Jul 2020 11:10:22 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-17-Ci6wqwupPt6D3QmBPirYoQ-1; Tue, 28 Jul 2020 05:10:20 -0400", "from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com\n [10.5.11.15])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 999AE800478;\n Tue, 28 Jul 2020 09:10:19 +0000 (UTC)", "from [10.36.110.21] (unknown [10.36.110.21])\n by smtp.corp.redhat.com (Postfix) with ESMTPS id A7718726B6;\n Tue, 28 Jul 2020 09:10:18 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1595927422;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references:autocrypt:autocrypt;\n bh=3q1owE2qA56qyhe2HQEPkO72YkXr2Vfnt+wNJ1LQMC0=;\n b=BBHJMniho3PxAudtt4BoY9P/WUMg1O7ovXO3q/zU3XFs+EwtnIAgZUdPlv5EiWW4kfUyV3\n fUsbkl0HkHWiAVfb5LLScVjw4JcKsv8tHWYyKdKXf+CJuFnkdamnlKPdiGPh5iLzTQU0oD\n xHqnu0J4UraYC2KPmZg8ZE63itm6eEo=", "X-MC-Unique": "Ci6wqwupPt6D3QmBPirYoQ-1", "To": "patrick.fu@intel.com, dev@dpdk.org, chenbo.xia@intel.com", "References": "<20200723053906.3616989-1-patrick.fu@intel.com>", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Autocrypt": "addr=maxime.coquelin@redhat.com; keydata=\n mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg\n kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a\n gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx\n YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR\n uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N\n jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un\n /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0\n KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r\n qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP\n LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x\n dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL\n CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf\n kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1\n 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H\n xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu\n Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc\n RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O\n wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz\n 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3\n gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi\n lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq\n TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7\n 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM\n H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL\n 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg\n CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su\n CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT\n d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE\n 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5\n aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp\n sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ\n Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD\n KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg\n jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB\n iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L\n +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP\n yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn\n DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA\n wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n\n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT\n UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1\n Mwqu3GQ=", "Message-ID": "<2faeef8f-01e0-aaee-8105-7027c49e4589@redhat.com>", "Date": "Tue, 28 Jul 2020 11:10:16 +0200", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n Thunderbird/68.10.0", "MIME-Version": "1.0", "In-Reply-To": "<20200723053906.3616989-1-patrick.fu@intel.com>", "Content-Language": "en-US", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "7bit", "Subject": "Re: [dpdk-dev] [PATCH v1] vhost: fix async callback return type\n\tdefine", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116759, "web_url": "https://patches.dpdk.org/comment/116759/", "msgid": "<DM5PR1101MB2169BB3F98176633901477F984730@DM5PR1101MB2169.namprd11.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/DM5PR1101MB2169BB3F98176633901477F984730@DM5PR1101MB2169.namprd11.prod.outlook.com", "date": "2020-07-28T10:15:55", "subject": "Re: [dpdk-dev] [PATCH v1] vhost: fix async callback return type\n\tdefine", "submitter": { "id": 1781, "url": "https://patches.dpdk.org/api/people/1781/?format=api", "name": "Patrick Fu", "email": "patrick.fu@intel.com" }, "content": "Hi Maxime,\n\n> -----Original Message-----\n> From: Maxime Coquelin <maxime.coquelin@redhat.com>\n> Sent: Tuesday, July 28, 2020 5:10 PM\n> To: Fu, Patrick <patrick.fu@intel.com>; dev@dpdk.org; Xia, Chenbo\n> <chenbo.xia@intel.com>\n> Subject: Re: [PATCH v1] vhost: fix async callback return type define\n> \n> \n> \n> On 7/23/20 7:39 AM, patrick.fu@intel.com wrote:\n> > From: Patrick Fu <patrick.fu@intel.com>\n> >\n> > \t * @return\n> > -\t * -1 on failure, number of iov segments completed on success\n> > +\t * number of iov segments completed on success\n> Ditto\n> \n> > \t */\n> > -\tint (*check_completed_copies)(int vid, uint16_t queue_id,\n> > +\tuint32_t (*check_completed_copies)(int vid, uint16_t queue_id,\n> > \t\tstruct rte_vhost_async_status *opaque_data,\n> > \t\tuint16_t max_packets);\n> > };\n> >\n> \n> Other than that:\n> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n> \n> I can fixup the comments while applying if you agree with it.\n> \n\nYes, I think removing \"on success\" is correct there.\n\nThanks,\n\nPatrick", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EA624A052B;\n\tTue, 28 Jul 2020 12:16:01 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B78F31C025;\n\tTue, 28 Jul 2020 12:16:00 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by dpdk.org (Postfix) with ESMTP id 205921BE8A\n for <dev@dpdk.org>; Tue, 28 Jul 2020 12:15:58 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Jul 2020 03:15:58 -0700", "from fmsmsx103.amr.corp.intel.com ([10.18.124.201])\n by orsmga004.jf.intel.com with ESMTP; 28 Jul 2020 03:15:57 -0700", "from fmsmsx122.amr.corp.intel.com (10.18.125.37) by\n FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Tue, 28 Jul 2020 03:15:57 -0700", "from FMSEDG001.ED.cps.intel.com (10.1.192.133) by\n fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Tue, 28 Jul 2020 03:15:57 -0700", "from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.54) by\n edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server\n (TLS) id 14.3.439.0; Tue, 28 Jul 2020 03:15:56 -0700", "from DM5PR1101MB2169.namprd11.prod.outlook.com (2603:10b6:4:51::14)\n by DM6PR11MB2636.namprd11.prod.outlook.com (2603:10b6:5:c8::14) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.23; Tue, 28 Jul\n 2020 10:15:55 +0000", "from DM5PR1101MB2169.namprd11.prod.outlook.com\n ([fe80::d96a:61:33a9:9036]) by DM5PR1101MB2169.namprd11.prod.outlook.com\n ([fe80::d96a:61:33a9:9036%12]) with mapi id 15.20.3216.033; Tue, 28 Jul 2020\n 10:15:55 +0000" ], "IronPort-SDR": [ "\n 9dcwQCejZTnMjWJo/r+KML5d7wCxrKA/o7NaePhk7PPkSrizHKMAo+BAcRDmzx2eKDkY1rR9Yt\n 08+ZoJRXBNCA==", "\n dOXKGmjNzW/vw5F49AHFtiIx1xT0/Y21BUZxNP5MAuKTMed+LXR9S/8e2vUKBWcuYUEiVK7z9P\n lgxJVguUJvrQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9695\"; a=\"149044468\"", "E=Sophos;i=\"5.75,406,1589266800\"; d=\"scan'208\";a=\"149044468\"", "E=Sophos;i=\"5.75,406,1589266800\"; d=\"scan'208\";a=\"434267312\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=RlJB313H4YjJdYXkuFnMsqgkg6MZwE7ZaOKvSktseTi10ijWIYFoBkeXnwaDQRSlR8ZrhmMgj4XLuwwwOguXTtdeJH6jOgPAq6w+eCab9vX4A2xLPTQroMVLV+VH/LmEuhLVyMPm5/o8gvffIKjjT7IXN5oqnrasdM4sy4U3e03mQ4h2BYjvv7PdOejImpIam74H9UYZALQhZge33vcA8D4oS5LmMeDpHvpkIPHx5nX7FTcQGIL6m1dqMl1KGdv4vhwHDytxd6wDFVXNZR/kGYnOzltHRm5tYc5TGZe+Abjj22g3nYvqg0wG5wllba2yPM2p2Nc502ojJMzYXgvWqA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=xdMslt2KLSAEugW/TH3MNByhQ+4bYZ63xzDyqLfXmhk=;\n b=kwa2tZP9ygk2m+LlJ1O2p47qWSBW0M2a8VF0xxvSx/c0q9UomeQmfUzJG7fmuJMSW207ojkwLAJUhTF3ZCRb8k33n8tAS+SMNMkw2o58IiZn3FySdiyvOT/WnK4aHRfOGWkA0SdBfdb8SF4+N+34hsPaExs6ISr8BaixJWdADa/qFhQXeYr5dP6YKUACvNh9ZYCF21UfXybtSMabJLxH77AbkLaHyc16pvDQ/Wh7Ad4axC8St98PygoA2wlhmA5O8n4OAqM1Ps3t96r/r6wlllbCQyQV30WcnI8iV1WrfJD/MGApe/okJjsm9D+uvMFcRhm3aayH+Q1lUVbzu9oA8A==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;\n s=selector2-intel-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=xdMslt2KLSAEugW/TH3MNByhQ+4bYZ63xzDyqLfXmhk=;\n b=IJXvVnl305OLr0Uxya7yfRppa/AMK6MfI5zQHvt5LeJC7fhAsVF/TFwiNfKxWH0TIBUunlejtobjk0za3ySIotYq5Gfu2leY4xtSXm+hOjz/ltaKcpNvoEmtCFuXEb940mJJzUUL49FTL2bKg8IWUK06ZR+NVFjJ9aHT23M/rGU=", "From": "\"Fu, Patrick\" <patrick.fu@intel.com>", "To": "Maxime Coquelin <maxime.coquelin@redhat.com>, \"dev@dpdk.org\"\n <dev@dpdk.org>, \"Xia, Chenbo\" <chenbo.xia@intel.com>", "Thread-Topic": "[PATCH v1] vhost: fix async callback return type define", "Thread-Index": "AQHWYLPvkOMlJvMoMEm4k95Nvw1zkakcvGgAgAARZ2A=", "Date": "Tue, 28 Jul 2020 10:15:55 +0000", "Message-ID": "\n <DM5PR1101MB2169BB3F98176633901477F984730@DM5PR1101MB2169.namprd11.prod.outlook.com>", "References": "<20200723053906.3616989-1-patrick.fu@intel.com>\n <2faeef8f-01e0-aaee-8105-7027c49e4589@redhat.com>", "In-Reply-To": "<2faeef8f-01e0-aaee-8105-7027c49e4589@redhat.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "dlp-version": "11.2.0.6", "dlp-product": "dlpe-windows", "dlp-reaction": "no-action", "authentication-results": "redhat.com; dkim=none (message not signed)\n header.d=none;redhat.com; dmarc=none action=none header.from=intel.com;", "x-originating-ip": "[192.198.147.218]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "6e05ba3a-ab9e-4b8e-dd6d-08d832df371e", "x-ms-traffictypediagnostic": "DM6PR11MB2636:", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <DM6PR11MB263645535C35FD6883EC851184730@DM6PR11MB2636.namprd11.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:3276;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n dIFaQqnUxqxQUx803hXrazJ8WfXhQJ0oGTMX6z1vSbBb7bhpvJhl+3PkC2JmzJQsAEj2vPe6mHagtdXwxoZq87sZtbY6nCDZWZh/OZXpxDuQ4t/Bgk7SrZTCR6aA4yHmElq9xkdIpDW+R9HWG5W1X430dR1NsviyjTGoJ+lnbVH06d7cYMD9uu/79i4I+oMrCYLJbzI17TS1mNHZ14LD/B8yM86uCPRPDr7i/fGRfmWtl22YU8aa5ScM47oxq8fHW5dkMJ/JxskyFr+ftKai3j6m/wxaP5Fds1YK2TK1ngEfszYtn/mi/YhwalpqlzH7pH5yextjqiDG9dehR1DQ4Q==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DM5PR1101MB2169.namprd11.prod.outlook.com; PTR:;\n CAT:NONE;\n SFTY:;\n SFS:(4636009)(396003)(136003)(376002)(346002)(366004)(39860400002)(478600001)(8676002)(26005)(110136005)(6636002)(33656002)(5660300002)(83380400001)(2906002)(53546011)(6506007)(52536014)(66946007)(66556008)(66476007)(186003)(316002)(8936002)(76116006)(9686003)(7696005)(64756008)(66446008)(86362001)(4744005)(55016002)(71200400001);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata": "\n l2BqU6Iak2j/cqu82g93RFArhU0ZySMimXCadnrNkhUmx8EgCCGWkOvxrkjxgeTsdGL4c/mzGX1Wz5uu1eNeeEpgfBGVbnQ/bQeulx4uwS/kW35XcefyW7m+W6yuSATUKFB6PmJuKKBpS4l6VOgH5HgIPJWHT0N3EBOMZpt7CQQ5X0YZqbDUhGs5y8kub6tiHa01UNpkX97WaXm+ggOqyaVFvjGnFErTFenQTYs0Zgo3TC9TBFRNgOm5Ist6EIbz34Col1r9pgfGMXLtDth+IeStqqnvA0WywFoMNAJbDc8iBBEozlfCyxmjMk4EJWFe+se4Obo5u3JF0al2cOyRzdo19J+DUYtjnojoaoPIVF1w2PXIYKnP1ETMOwIq7BstiwFtk9/UWAFeIfUxT0aAoIkpWzmO2uAP2WIk1nu9doCLFOfZ2gA+36aVdYlr6FbF1l5E2BkBNrMEMLCnYurCxKncfpxy1BVTMALBZamAiBgWrZibkZbL8B2V9Tj/QIM7", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM5PR1101MB2169.namprd11.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 6e05ba3a-ab9e-4b8e-dd6d-08d832df371e", "X-MS-Exchange-CrossTenant-originalarrivaltime": "28 Jul 2020 10:15:55.4651 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "46c98d88-e344-4ed4-8496-4ed7712e255d", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n +F++H5hf3vNmzHIkYGn7S/kJMrkgLDJuLR9nWz408qSAtAch0hLGiDbVwFqm7Xg1EKejPADKBMUb6DK03R8Y1Q==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR11MB2636", "X-OriginatorOrg": "intel.com", "Subject": "Re: [dpdk-dev] [PATCH v1] vhost: fix async callback return type\n\tdefine", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116786, "web_url": "https://patches.dpdk.org/comment/116786/", "msgid": "<db431739-f663-6cf0-c1ac-7ebb0f25d373@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/db431739-f663-6cf0-c1ac-7ebb0f25d373@redhat.com", "date": "2020-07-28T15:26:56", "subject": "Re: [dpdk-dev] [PATCH v1] vhost: fix async callback return type\n\tdefine", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "content": "On 7/23/20 7:39 AM, patrick.fu@intel.com wrote:\n> From: Patrick Fu <patrick.fu@intel.com>\n> \n> The async copy device callbacks are used by async APIs to transfer data\n> and check completion status. Async APIs return the number of packets\n> successfully processed to the caller applications and no error (negative)\n> value is allowed for API return value. Thus, negative return values\n> from async device callbacks don't have meaningful usage, while adding\n> overhead in checking the return value validity. This patch change the\n> callback return values from \"int\" to \"uint32_t\" to get aligned with\n> async API definition.\n> \n> Fixes: 78639d54563a (\"vhost: introduce async enqueue registration API\")\n> \n> Signed-off-by: Patrick Fu <patrick.fu@intel.com>\n> ---\n> lib/librte_vhost/rte_vhost_async.h | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n\nApplied to dpdk-next-virtio/master with agreed fixup.\n\nThanks,\nMaxime", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2C622A052B;\n\tTue, 28 Jul 2020 17:27:09 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 145552B9C;\n\tTue, 28 Jul 2020 17:27:09 +0200 (CEST)", "from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com\n [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 8B7A02B86\n for <dev@dpdk.org>; Tue, 28 Jul 2020 17:27:07 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-194-rSiK1PPvPmym6NeuhFlboA-1; Tue, 28 Jul 2020 11:27:04 -0400", "from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com\n [10.5.11.16])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 79F818017FB;\n Tue, 28 Jul 2020 15:27:03 +0000 (UTC)", "from [10.36.110.21] (unknown [10.36.110.21])\n by smtp.corp.redhat.com (Postfix) with ESMTPS id 82ABB5C5B7;\n Tue, 28 Jul 2020 15:27:02 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1595950027;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references:autocrypt:autocrypt;\n bh=pH1lUOeK7vq4peWB7nButmgzsPxZN5j43QuLkVjTAN4=;\n b=i6l4X9iyeKO3iL7OM9yOKzw+r3StGStjAFH0OJWa6FFIi1uXzkc+0Qq1GNqFQ4n7YrPeU0\n I53+wsAr3KJZl/uZdU8yf5UBCrCohMEvEVrMD/EGgNVFFwaj/+q+gfp7Kh8FkmKFh/ubGd\n 6/UcXfQHDgE6+LdzIaYMnB21XqaBpYE=", "X-MC-Unique": "rSiK1PPvPmym6NeuhFlboA-1", "To": "patrick.fu@intel.com, dev@dpdk.org, chenbo.xia@intel.com", "References": "<20200723053906.3616989-1-patrick.fu@intel.com>", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Autocrypt": "addr=maxime.coquelin@redhat.com; keydata=\n mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg\n kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a\n gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx\n YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR\n uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N\n jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un\n /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0\n KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r\n qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP\n LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x\n dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL\n CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf\n kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1\n 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H\n xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu\n Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc\n RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O\n wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz\n 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3\n gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi\n lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq\n TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7\n 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM\n H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL\n 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg\n CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su\n CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT\n d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE\n 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5\n aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp\n sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ\n Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD\n KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg\n jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB\n iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L\n +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP\n yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn\n DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA\n wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n\n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT\n UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1\n Mwqu3GQ=", "Message-ID": "<db431739-f663-6cf0-c1ac-7ebb0f25d373@redhat.com>", "Date": "Tue, 28 Jul 2020 17:26:56 +0200", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n Thunderbird/68.10.0", "MIME-Version": "1.0", "In-Reply-To": "<20200723053906.3616989-1-patrick.fu@intel.com>", "Content-Language": "en-US", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "7bit", "Subject": "Re: [dpdk-dev] [PATCH v1] vhost: fix async callback return type\n\tdefine", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]