Patch Comment List
List patch comments
GET /api/patches/74630/comments/?format=api
[ { "id": 116534, "web_url": "https://patches.dpdk.org/comment/116534/", "msgid": "<BYAPR11MB37356EAC250E36EA7EC86F0084760@BYAPR11MB3735.namprd11.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/BYAPR11MB37356EAC250E36EA7EC86F0084760@BYAPR11MB3735.namprd11.prod.outlook.com", "date": "2020-07-23T06:17:03", "subject": "Re: [dpdk-dev] [PATCH v1] vhost: fix vring disable fail in async\n\ttransfer", "submitter": { "id": 1781, "url": "https://patches.dpdk.org/api/people/1781/?format=api", "name": "Patrick Fu", "email": "patrick.fu@intel.com" }, "content": "Hi,\n\nSorry but I'd like to withdraw this patch as the issue could be addressed by applications to register a pre_msg_handler.\n\nThanks,\n\nPatrick\n\n> -----Original Message-----\n> From: Fu, Patrick <patrick.fu@intel.com>\n> Sent: Thursday, July 23, 2020 1:38 PM\n> To: dev@dpdk.org; maxime.coquelin@redhat.com; Xia, Chenbo\n> <chenbo.xia@intel.com>\n> Cc: Fu, Patrick <patrick.fu@intel.com>\n> Subject: [PATCH v1] vhost: fix vring disable fail in async transfer\n> \n> From: Patrick Fu <patrick.fu@intel.com>\n> \n> Async inflight packets is checked when front end virtio requests to disable\n> vring. If inflight packets exists, vring disabling will fail.\n> However, there is no good way for application to get notified before vring is\n> disabled and properly complete inflight packets. This patch moves the inflight\n> packets check from vring disabling time to the vring enabling time, so that\n> applications have chances to drain out pending packets.\n> \n> Fixes: 78639d54563a (\"vhost: introduce async enqueue registration API\")\n> \n> Signed-off-by: Patrick Fu <patrick.fu@intel.com>\n> ---\n> lib/librte_vhost/vhost_user.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\n> index 9ddeae362..36da1380a 100644\n> --- a/lib/librte_vhost/vhost_user.c\n> +++ b/lib/librte_vhost/vhost_user.c\n> @@ -2038,9 +2038,9 @@ vhost_user_set_vring_enable(struct virtio_net\n> **pdev,\n> \t\t\"set queue enable: %d to qp idx: %d\\n\",\n> \t\tenable, index);\n> \n> -\tif (!enable && dev->virtqueue[index]->async_registered) {\n> +\tif (enable && dev->virtqueue[index]->async_registered) {\n> \t\tif (dev->virtqueue[index]->async_pkts_inflight_n) {\n> -\t\t\tVHOST_LOG_CONFIG(ERR, \"failed to disable vring. \"\n> +\t\t\tVHOST_LOG_CONFIG(ERR, \"failed to enable vring. \"\n> \t\t\t\"async inflight packets must be completed first\\n\");\n> \t\t\treturn RTE_VHOST_MSG_RESULT_ERR;\n> \t\t}\n> --\n> 2.18.4", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CD583A0526;\n\tThu, 23 Jul 2020 08:17:09 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9AC001BFDA;\n\tThu, 23 Jul 2020 08:17:08 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 7D1F31BFD7\n for <dev@dpdk.org>; Thu, 23 Jul 2020 08:17:06 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Jul 2020 23:17:05 -0700", "from orsmsx601.amr.corp.intel.com ([10.22.229.14])\n by orsmga002.jf.intel.com with ESMTP; 22 Jul 2020 23:17:05 -0700", "from orsmsx601.amr.corp.intel.com (10.22.229.14) by\n ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.1713.5; Wed, 22 Jul 2020 23:17:05 -0700", "from ORSEDG002.ED.cps.intel.com (10.7.248.5) by\n orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5\n via Frontend Transport; Wed, 22 Jul 2020 23:17:05 -0700", "from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102)\n by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Wed, 22 Jul 2020 23:17:05 -0700", "from BYAPR11MB3735.namprd11.prod.outlook.com (2603:10b6:a03:b4::31)\n by BY5PR11MB3861.namprd11.prod.outlook.com (2603:10b6:a03:18d::13)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.24; Thu, 23 Jul\n 2020 06:17:03 +0000", "from BYAPR11MB3735.namprd11.prod.outlook.com\n ([fe80::2571:24e3:140b:d78c]) by BYAPR11MB3735.namprd11.prod.outlook.com\n ([fe80::2571:24e3:140b:d78c%7]) with mapi id 15.20.3216.020; Thu, 23 Jul 2020\n 06:17:03 +0000" ], "IronPort-SDR": [ "\n 2JkqMdM8COWjSC+3D9jJp1yDE7q7nPsn8+nzwboPoryJGew2Zpds3NN7cMJMSa5jI46swRK1sO\n gZ418GfdC70w==", "\n zb3SgtuC4dyKsK9OZPfOvgagvLuYeA5TztGJUBCyuzbpY8eNIm2atRIGqU+H4YDX+IC/fKhGZl\n agRLasUOr+xw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9690\"; a=\"150456163\"", "E=Sophos;i=\"5.75,385,1589266800\"; d=\"scan'208\";a=\"150456163\"", "E=Sophos;i=\"5.75,385,1589266800\"; d=\"scan'208\";a=\"302197952\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=VGzfSeYLhCmodueHq+GkrlMRryNSwDMmaL4R9JJ/dTqu6mA7VgYLxWiTxg7N40dubXnql9uyl2TLKVxxZuocVY8TZRcBZ3xh/1nlwv41sivSnmoUh2bfCnX/Bl648kGxH0+WDXhnEOSVrPtMFKbuI8mEJYGypcG1QDicl1IFWvHL7ngjb1WIDhcY0jwWiX4MejOWJnWM6EWN/C/I8uxVwLdZM1l6dU3TVMZtxBXCZZqYhHHcYXyxEF97eo6yzfs/lThn4dYiF1TQU7N1iLVpC3ntrvK/PRwoLnTyf0XkWBVyG+ae4KHyZRFuWtHesy0mJogQ2segbjGd0M73U2bqZw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=xdfp87o3xHHUGY06EpHO+028Dnd1z9nnrjRz86qUbB8=;\n b=QIKKgUoBqbaY2xhRZ4OHPXqQlER1GvODP8B9f/YyDW9atQAzTyow3+C8W3Vg5BuWPJScuXPISWJbq/os5zngt3hqSk/9J0cLYXssa40jb1hshRQ7ed2Uyd94dhqeNusjUu0BcNj4+ojm5/57o7IeGm2LPMS2/mXN3E9afWd7QOZnCIVyjA4YW4LBWIrCIjHe6zEqJq/W0wZ4HbcU5iNjN/Y8QlP3po8myBqffgowV2SVIQqtYrdHy73jypgqjLCwe+4F5vt3ps+btiyk02YaQoQ1Jpvdl4U+xkwpzNnlxaDbPL42GYcCjYOY2g8LOhoUtJTw9joPaNZvl6/l7q+Onw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;\n s=selector2-intel-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=xdfp87o3xHHUGY06EpHO+028Dnd1z9nnrjRz86qUbB8=;\n b=dNSM+N+p3Z4ZkLfJR4bO/48OLYR3ONipdaekArkZWe2GcRxnPofymyIK+rV9ziiuljTmweI4Z0PJr8kLc9yoicsQkws9lTBL9oNd41IOY3IjfUu2m6+VJizDuzD6IO7QqhYbvNsgVDPY6CKDl9W1tMqv/lqhDNuQ0cWvqT95vcM=", "From": "\"Fu, Patrick\" <patrick.fu@intel.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>, \"maxime.coquelin@redhat.com\"\n <maxime.coquelin@redhat.com>, \"Xia, Chenbo\" <chenbo.xia@intel.com>", "Thread-Topic": "[PATCH v1] vhost: fix vring disable fail in async transfer", "Thread-Index": "AQHWYLPNHWgrkk0TO0SBKY57U6Zw7KkUr34w", "Date": "Thu, 23 Jul 2020 06:17:03 +0000", "Message-ID": "\n <BYAPR11MB37356EAC250E36EA7EC86F0084760@BYAPR11MB3735.namprd11.prod.outlook.com>", "References": "<20200723053801.3616928-1-patrick.fu@intel.com>", "In-Reply-To": "<20200723053801.3616928-1-patrick.fu@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "dlp-version": "11.2.0.6", "dlp-product": "dlpe-windows", "dlp-reaction": "no-action", "authentication-results": "dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com;", "x-originating-ip": "[192.198.147.200]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "5b3063f6-0648-4b20-80b0-08d82ed00483", "x-ms-traffictypediagnostic": "BY5PR11MB3861:", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <BY5PR11MB38617827B3A66DAC66B6357784760@BY5PR11MB3861.namprd11.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:9508;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n UM+SvTOY5iDK44VL0huOBXtvUJfzqpmHDQ20pXKQZJpzWCBXmeu7auPkG9kDRHE1dvHB2VeEz9FdR1xmHgljXTxcuI0a3l2xZSckOMeRR3giLofeYlrAM0UVKJ5TDPSGulHynrTLJ8ckq1ZZdj6OkAHJqA/Yqusl5Bcc/7+0SYVNCG6Yo/+4ftd07i8iNa96xbuM8/pVVgtgtWn59WqkcVKVLGXoezM5IqaA8uX7Tj/iMUsludb/tMKnoNZcVHIajfF/TiInjikHTxbFrobYTDzdEp4A0FlMJGHmWYZsD2o8i/IgZLNebFmtc+OVnJa1zx7KoJ8tbl5JdjK9/3P0hQ==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:BYAPR11MB3735.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(346002)(376002)(136003)(366004)(39860400002)(396003)(52536014)(8936002)(76116006)(53546011)(186003)(5660300002)(6506007)(66946007)(2906002)(64756008)(86362001)(66556008)(66476007)(8676002)(110136005)(316002)(66446008)(6636002)(9686003)(7696005)(478600001)(83380400001)(26005)(33656002)(55016002)(71200400001);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata": "\n yjlHM7s6hYaMoJjbTKLECLocK6YHO7R7N1sHql7NS20lF/Tpwf95RrlogO5V87h9bkH1Cw347f/9lLgEIcIyjAqtbqqWjRW9M4udu97D7KsUMYOB906TejZw7FypwHP8KkTGNFX3gW58rpptj8UWOHO/OyXNQ0vzv2vGg+m2Lo0RqNvTaOM+7RZHNkVP/Rzd1AYb8/gGEI9hCfKS9Ak/+6RQsotVVJeWXUfBtJ5Rprgg81+GdJq8d1dFv1TEoCLTFRI9QSjKZ/tyEz2FqDE8a7rhUdQm1aCqzJpKemDiGDdSAbWmVQBQzPus5v0zXvxJ79m+T23TdMmIfY60cW/Ukt9sasnZ9addxBwHmqy9D/m13AOorXQSlIeKJ+RneBBNVXMWV/W44CNE805RNnAy9/P/u6JHAxAEZslWyWrqpLI7xmJ85WpL0+ADn3rysUw//Fs40wrHVvcT0RGSEoZ15s7ao1v2BTZFeqUPhpxFh5G3SWaOfTJUwZpLooEqh3VX", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "BYAPR11MB3735.namprd11.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 5b3063f6-0648-4b20-80b0-08d82ed00483", "X-MS-Exchange-CrossTenant-originalarrivaltime": "23 Jul 2020 06:17:03.4988 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "46c98d88-e344-4ed4-8496-4ed7712e255d", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n 7/YjyQveijLhTFsR5oiAYw1juKa6kyZ+JvaR8vX+6Y8NnoMCEQ/0Ut40ZPeJr/ZjpjuYGDt41aVqRxD5GfyJgw==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BY5PR11MB3861", "X-OriginatorOrg": "intel.com", "Subject": "Re: [dpdk-dev] [PATCH v1] vhost: fix vring disable fail in async\n\ttransfer", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]