List comments

GET /api/patches/74626/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 116563,
        "web_url": "https://patches.dpdk.org/comment/116563/",
        "msgid": "<8CE3E05A3F976642AAB0F4675D0AD20E0BC83E75@SHSMSX101.ccr.corp.intel.com>",
        "date": "2020-07-24T01:31:08",
        "subject": "Re: [dts] [PATCH]test_plans: add ethertype flow to fdir",
        "submitter": {
            "id": 1098,
            "url": "https://patches.dpdk.org/api/people/1098/",
            "name": "Lijuan Tu",
            "email": "lijuan.tu@intel.com"
        },
        "content": "Applied, thanks\n\n> -----Original Message-----\n> From: dts <dts-bounces@dpdk.org> On Behalf Of Peng Yuan\n> Sent: 2020年7月23日 16:26\n> To: dts@dpdk.org\n> Cc: Peng, Yuan <yuan.peng@intel.com>\n> Subject: [dts] [PATCH]test_plans: add ethertype flow to fdir\n> \n> add ethertype flow to cvl fdir\n> add IPV6 pattern to conflict rule case.\n> \n> Signed-off-by: Peng Yuan <yuan.peng@intel.com>\n> \n> diff --git a/test_plans/cvl_fdir_test_plan.rst b/test_plans/cvl_fdir_test_plan.rst\n> index 63ad6f2..c1b9223 100644\n> --- a/test_plans/cvl_fdir_test_plan.rst\n> +++ b/test_plans/cvl_fdir_test_plan.rst\n> @@ -37,6 +37,7 @@ CVL:Classification:Flow Director  Enable fdir filter for\n> IPv4/IPv6 + TCP/UDP/SCTP  (OS default package)  Enable fdir filter for UDP\n> tunnel: Vxlan / NVGRE (OS default package)  Enable fdir filter for GTP (comm #1\n> package)\n> +Enable fdir filter for L2 Ethertype (comm #1 package)\n> \n>  Pattern and input set\n>  ---------------------\n> @@ -81,6 +82,8 @@ Pattern and input set\n>      +------------------------------+----------------------------+--------------------------------\n> -----------------------------------------------+\n>      |                              | MAC_IPV4_GTPU_EH           | [TEID], [QFI]\n> |\n>      +------------------------------+----------------------------+--------------------------------\n> -----------------------------------------------+\n> +    | L2 Ethertype                 |      L2 Ethertype          | [Ethertype]\n> |\n> +\n> + +------------------------------+----------------------------+---------\n> + ----------------------------------------------------------------------\n> + +\n> \n>  .. note::\n> \n> @@ -131,7 +134,7 @@ Prerequisites\n> \n>  5. Launch the app ``testpmd`` with the following arguments::\n> \n> -    ./testpmd -c 0xff -n 6 -w 86:00.0,,flow-mark-support=1 -- -i --portmask=0xff -\n> -rxq=64 --txq=64 --port-topology=loop\n> +    ./testpmd -c 0xff -n 6 -w 86:00.0,,flow-mark-support=1\n> + --log-level=\"ice,7\" -- -i --portmask=0xff --rxq=64 --txq=64\n> + --port-topology=loop\n>      testpmd> set fwd rxonly\n>      testpmd> set verbose 1\n> \n> @@ -142,7 +145,7 @@ Prerequisites\n> \n>     Notes: if need two ports environment, launch ``testpmd`` with the following\n> arguments::\n> \n> -    ./testpmd -c 0xff -n 6 -w 86:00.0,flow-mark-support=1 -w 86:00.1,flow-\n> mark-support=1 -- -i --portmask=0xff --rxq=64 --txq=64 --port-topology=loop\n> +    ./testpmd -c 0xff -n 6 -w 86:00.0,flow-mark-support=1 -w\n> + 86:00.1,flow-mark-support=1 --log-level=\"ice,7\" -- -i --portmask=0xff\n> + --rxq=64 --txq=64 --port-topology=loop\n> \n> \n>  Default parameters\n> @@ -185,6 +188,9 @@ Default parameters\n>      [TEID]: 0x12345678\n>      [QFI]: 0x34\n> \n> +   L2 Ethertype::\n> +\n> +    [Ethertype]: 0x8863 0x8864 0x0806 0x8100 0x88f7\n> \n>  Send packets\n>  ------------\n> @@ -440,6 +446,32 @@ Send packets\n>      p_gtpu14 = Ether(src=\"a4:bf:01:51:27:ca\",\n> dst=\"00:11:22:33:44:55\")/IP(src=\"192.168.0.20\",\n> dst=\"192.168.0.21\")/UDP(dport=2152)/GTP_U_Header(gtp_type=255,\n> teid=0x12345678)/IPv6()/SCTP()/Raw('x'*20)\n>      p_gtpu15 = Ether(src=\"a4:bf:01:51:27:ca\",\n> dst=\"00:11:22:33:44:55\")/IP(src=\"192.168.0.20\",\n> dst=\"192.168.0.21\")/UDP(dport=2152)/GTP_U_Header(gtp_type=255,\n> teid=0x1234567)/IP()/Raw('x'*20)\n> \n> +* L2 Ethertype\n> +\n> +   PPPoED packets::\n> +\n> +    sendp([Ether(dst=\"00:11:22:33:44:55\")/PPPoED()/PPP()/IP()/Raw('x'\n> *80)],iface=\"enp134s0f1\")\n> +    sendp([Ether(dst=\"00:11:22:33:44:55\", type=0x8863)/IP()/Raw('x' *\n> + 80)],iface=\"enp134s0f1\")\n> +\n> +   PPPoE packets::\n> +\n> +\n> sendp([Ether(dst=\"00:11:22:33:44:55\")/PPPoE()/PPP(proto=0x0021)/IP()/Raw('x'\n> * 80)],iface=\"enp134s0f1\")\n> +    sendp([Ether(dst=\"00:11:22:33:44:55\", type=0x8864)/IP()/Raw('x' *\n> + 80)],iface=\"enp134s0f1\")\n> +\n> +   ARP packets::\n> +\n> +\n> sendp([Ether(dst=\"00:11:22:33:44:55\")/ARP(pdst=\"192.168.1.1\")],iface=\"enp134\n> s0f1\")\n> +    sendp([Ether(dst=\"00:11:22:33:44:55\", type=0x0806)/Raw('x'\n> + *80)],iface=\"enp134s0f1\")\n> +\n> +   EAPS packets::\n> +\n> +    sendp([Ether(dst=\"00:11:22:33:44:55\",type=0x8100)],iface=\"enp134s0f1\")\n> +\n> + sendp([Ether(dst=\"00:11:22:33:44:55\")/Dot1Q(vlan=1)],iface=\"enp134s0f1\n> + \")\n> +\n> +   ieee1588 packet::\n> +\n> +    sendp([Ether(dst=\"00:11:22:33:44:55\",type=0x88f7)/\"\\\\x00\\\\x02\"],\n> + iface=\"enp134s0f1\")\n> +\n> \n>  Test case: flow validation\n>  ==========================\n> @@ -1705,6 +1737,175 @@ Subcase 6: MAC_IPV4_GTPU mark  2. repeat the\n> steps of passthru in subcase 3,\n>     get the same result.\n> \n> +Test case: L2 Ethertype pattern\n> +===============================\n> +\n> +Subcase 1: L2 Ethertype queue index\n> +-----------------------------------\n> +\n> +1. create rule for PPPoED::\n> +\n> +    flow create 0 ingress pattern eth type is 0x8863 / end actions\n> + queue index 1 / mark id 1 / end\n> +\n> +   send PPPoED packet,\n> +   check the packets are distributed to expected queue with specific FDIR\n> matched ID.\n> +\n> +2. create rule for PPPoE::\n> +\n> +    flow create 0 ingress pattern eth type is 0x8864 / end actions\n> + queue index 2 / mark id 2 / end\n> +\n> +   send PPPoE packet,\n> +   check the packets are distributed to expected queue with specific FDIR\n> matched ID.\n> +\n> +3. create rule for ARP::\n> +\n> +    flow create 0 ingress pattern eth type is 0x0806 / end actions\n> + queue index 3 / mark id 3 / end\n> +\n> +   send ARP packet,\n> +   Check the packets are distributed to expected queue with specific FDIR\n> matched ID.\n> +\n> +4. create rule for EAPS::\n> +\n> +    flow create 0 ingress pattern eth type is 0x8100 / end actions\n> + queue index 4 / mark id 4 / end\n> +\n> +   send EAPS packet,\n> +   check the packets are distributed to expected queue with specific FDIR\n> matched ID.\n> +\n> +5. create rule for ieee1588::\n> +\n> +    flow create 0 ingress pattern eth type is 0x88f7 / end actions\n> + queue index 5 / mark id 5 / end\n> +\n> +   send ieee1588 packet,\n> +   check the packets are distributed to expected queue with specific FDIR\n> matched ID.\n> +\n> +6. send a mismatched packet::\n> +\n> +\n> + sendp([Ether(dst=\"00:11:22:33:44:55\",type=0x8847)],iface=\"enp134s0f1\")\n> +\n> +   check the packet received has not FDIR matched ID.\n> +\n> +7. verify rules can be listed and destroyed::\n> +\n> +    testpmd> flow list 0\n> +\n> +   check the 5 rules listed.\n> +   flush all the rules::\n> +\n> +    testpmd> flow flush 0\n> +\n> +8. verify matched packets are received without FDIR matched ID.\n> +   Then check there is no rule listed.\n> +\n> +Subcase 2: L2 Ethertype rss queues\n> +----------------------------------\n> +\n> +1. create rules for PPPoED with rss queues action::\n> +\n> +    flow create 0 ingress pattern eth type is 0x8863 / end actions rss\n> + queues 2 3 end / mark id 2 / end\n> +\n> +2. send matched packet,\n> +   check the packets received have FDIR matched ID=0x2,\n> +   the packets are directed to queue 0,\n> +   because L2 Ethertype are not supported by RSS.\n> +\n> +3. Repeat step 1-2 with PPPoE/ARP/EAPS/ieee1588,\n> +   get the same result.\n> +\n> +4. repeat step 6-7 of subcase 1.\n> +\n> +5. verify matched packets received have not FDIR matched ID.\n> +   Then check there is no rule listed.\n> +\n> +Subcase 3: L2 Ethertype passthru\n> +--------------------------------\n> +\n> +1. create rules for PPPoED with passthru action::\n> +\n> +    flow create 0 ingress pattern eth type is 0x8863 / end actions\n> + passthru / mark id 2 / end\n> +\n> +2. send matched packet,\n> +   check the packets received have FDIR matched ID=0x2,\n> +   the packets are directed to queue 0,\n> +   because L2 Ethertype are not supported by RSS.\n> +\n> +3. Repeat step 1-2 with PPPoE/ARP/EAPS/ieee1588,\n> +   get the same result.\n> +\n> +4. repeat step 6-7 of subcase 1.\n> +\n> +5. verify matched packets received have not FDIR matched ID.\n> +   Then check there is no rule listed.\n> +\n> +Subcase 4: L2 Ethertype drop\n> +----------------------------\n> +\n> +1. create rules for PPPoED with drop action::\n> +\n> +    flow create 0 ingress pattern eth type is 0x8863 / end actions drop\n> + / end\n> +\n> +2. send matched packet,\n> +   check the packets are dropped,\n> +\n> +3. Repeat step 1-2 with PPPoE/ARP/EAPS/ieee1588,\n> +   get the same result.\n> +\n> +4. repeat step 6-7 of subcase 1.\n> +\n> +5. verify matched packets are received.\n> +   Then check there is no rule listed.\n> +\n> +Subcase 5: L2 Ethertype mark+rss\n> +--------------------------------\n> +\n> +1. create rules for PPPoED with rss queues action::\n> +\n> +    flow create 0 ingress pattern eth type is 0x8863 / end actions mark\n> + id 1 / rss / end\n> +\n> +2. send matched packet,\n> +   check the packets received have FDIR matched ID=0x1,\n> +   the packets are directed to queue 0,\n> +   because L2 Ethertype are not supported by RSS.\n> +\n> +3. Repeat step 1-2 with PPPoE/ARP/EAPS/ieee1588,\n> +   get the same result.\n> +\n> +4. repeat step 6-7 of subcase 1.\n> +\n> +5. verify matched packets received have not FDIR matched ID.\n> +   Then check there is no rule listed.\n> +\n> +Subcase 6: L2 Ethertype mark\n> +----------------------------\n> +\n> +1. create rules for PPPoED with mark action::\n> +\n> +    flow create 0 ingress pattern eth type is 0x8863 / end actions mark\n> + / end\n> +\n> +2. send matched packet,\n> +   check the packets received have FDIR matched ID=0x0,\n> +\n> +3. Repeat step 1-2 with PPPoE/ARP/EAPS/ieee1588,\n> +   get the same result.\n> +\n> +4. repeat step 6-7 of subcase 1.\n> +\n> +5. verify matched packets received have not FDIR matched ID.\n> +   Then check there is no rule listed.\n> +\n> +Subcase 7: unsupported Ethertype\n> +--------------------------------\n> +\n> +1. create rules for IP/IPV6::\n> +\n> +    flow create 0 ingress pattern eth type is 0x0800 / end actions queue index 1 /\n> end\n> +    flow create 0 ingress pattern eth type is 0x86dd / end actions\n> + queue index 1 / end\n> +\n> +   the two rules can be created successfully, but report below message::\n> +\n> +    ice_flow_create(): Succeeded to create (2) flow\n> +    Flow rule #0 created\n> +\n> +   the number \"2\" stands for switch rule, fdir doesn't support IPV4/IPV6\n> ethertype.\n> \n>  Test case: negative cases\n>  =========================\n> @@ -1812,6 +2013,7 @@ Subcase 6: conflicted rules  1. Create a FDIR rule::\n> \n>      flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv4 src is\n> 192.168.0.20 dst is 192.168.0.21 ttl is 2 tos is 4 / end actions queue index 1 / end\n> +    flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv6\n> + dst is CDCD:910A:2222:5498:8475:1111:3900:2020 src is 2001::2 / end\n> + actions queue index 1 / mark / end\n> \n>     the rule is created successfully.\n> \n> @@ -1821,12 +2023,17 @@ Subcase 6: conflicted rules\n>      flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv4 src is\n> 192.168.0.20 dst is 192.168.0.21 ttl is 2 tos is 4 / end actions drop / end\n>      flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv4 src is\n> 192.168.0.21 ttl is 2 tos is 4 / end actions queue index 3 / mark / end\n>      flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv4 src is\n> 192.168.0.20 dst is 192.168.0.21 ttl is 2 tos is 4 / udp src is 22 dst is 23 / end\n> actions queue index 3 / mark / end\n> +    flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv6 dst is\n> CDCD:910A:2222:5498:8475:1111:3900:2020 src is 2001::2 / end actions queue\n> index 2 / mark / end\n> +    flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv6 dst is\n> CDCD:910A:2222:5498:8475:1111:3900:2020 src is 2001::2 / end actions rss\n> queues 2 3 end / mark / end\n> +    flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv6 dst is\n> CDCD:910A:2222:5498:8475:1111:3900:2021 / end actions mark / end\n> +    flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv6\n> + dst is CDCD:910A:2222:5498:8475:1111:3900:2020 src is 2001::2 / udp\n> + src is 22 dst is 23 / end actions queue index 1 / mark / end\n> \n>     Failed to create the two flows, report message::\n> \n> -    first two rules:\n>      Rule already exists!: File exists\n> -    last two rules:\n> +\n> +   or::\n> +\n>      Invalid input action number: Invalid argument\n> \n>  3. check there is only one rule listed.\n> --\n> 2.7.4",
        "headers": {
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>",
            "Accept-Language": "zh-CN, en-US",
            "X-IronPort-AV": [
                "E=McAfee;i=\"6000,8403,9691\"; a=\"148565402\"",
                "E=Sophos;i=\"5.75,388,1589266800\"; d=\"scan'208\";a=\"148565402\"",
                "E=Sophos;i=\"5.75,388,1589266800\"; d=\"scan'208\";a=\"488572386\""
            ],
            "IronPort-SDR": [
                "\n xQZw9+R+L7JIim+MPnUAKbwxau/Yc9VLLbXTz7q+9+58njo/9Tm3omOGQkNqU6ZagOtoWLCi1w\n mIomKa1cisSA==",
                "\n dw6I6c0foJkPmZ6YQyJOtAZt2W8BAKdP1SeUOsmBpZCvdosLdGF0QKmxCHPsswkU5Zar4jQ3V/\n glVk3N7e8fVQ=="
            ],
            "Thread-Index": "AQHWYI91oy44vNf6okKhFJZb4TuiLKkV8wzQ",
            "CC": "\"Peng, Yuan\" <yuan.peng@intel.com>",
            "X-Amp-File-Uploaded": "False",
            "Precedence": "list",
            "Thread-Topic": "[dts] [PATCH]test_plans: add ethertype flow to fdir",
            "List-Id": "test suite reviews and discussions <dts.dpdk.org>",
            "List-Post": "<mailto:dts@dpdk.org>",
            "X-Original-To": "patchwork@inbox.dpdk.org",
            "Sender": "\"dts\" <dts-bounces@dpdk.org>",
            "X-Mailman-Version": "2.1.15",
            "MIME-Version": "1.0",
            "dlp-version": "11.2.0.6",
            "X-MS-TNEF-Correlator": "",
            "References": "<1595492760-4039-1-git-send-email-yuan.peng@intel.com>",
            "Subject": "Re: [dts] [PATCH]test_plans: add ethertype flow to fdir",
            "Content-Type": "text/plain; charset=\"iso-2022-jp\"",
            "Delivered-To": "patchwork@inbox.dpdk.org",
            "Received": [
                "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 84114A0518;\n\tFri, 24 Jul 2020 03:31:15 +0200 (CEST)",
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6A1E51C029;\n\tFri, 24 Jul 2020 03:31:15 +0200 (CEST)",
                "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by dpdk.org (Postfix) with ESMTP id 8B4451C025\n for <dts@dpdk.org>; Fri, 24 Jul 2020 03:31:13 +0200 (CEST)",
                "from fmsmga006.fm.intel.com ([10.253.24.20])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Jul 2020 18:31:12 -0700",
                "from fmsmsx103.amr.corp.intel.com ([10.18.124.201])\n by fmsmga006.fm.intel.com with ESMTP; 23 Jul 2020 18:31:12 -0700",
                "from fmsmsx612.amr.corp.intel.com (10.18.126.92) by\n FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Thu, 23 Jul 2020 18:31:12 -0700",
                "from fmsmsx612.amr.corp.intel.com (10.18.126.92) by\n fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.1713.5; Thu, 23 Jul 2020 18:31:12 -0700",
                "from shsmsx107.ccr.corp.intel.com (10.239.4.96) by\n fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5\n via Frontend Transport; Thu, 23 Jul 2020 18:31:11 -0700",
                "from shsmsx101.ccr.corp.intel.com ([169.254.1.22]) by\n SHSMSX107.ccr.corp.intel.com ([169.254.9.32]) with mapi id 14.03.0439.000;\n Fri, 24 Jul 2020 09:31:09 +0800"
            ],
            "x-originating-ip": "[10.239.127.40]",
            "List-Help": "<mailto:dts-request@dpdk.org?subject=help>",
            "X-Amp-Result": "SKIPPED(no attachment in message)",
            "List-Archive": "<http://mails.dpdk.org/archives/dts/>",
            "X-BeenThere": "dts@dpdk.org",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>",
            "X-ExtLoop1": "1",
            "Message-ID": "\n <8CE3E05A3F976642AAB0F4675D0AD20E0BC83E75@SHSMSX101.ccr.corp.intel.com>",
            "Date": "Fri, 24 Jul 2020 01:31:08 +0000",
            "Content-Transfer-Encoding": "quoted-printable",
            "To": "\"Peng, Yuan\" <yuan.peng@intel.com>, \"dts@dpdk.org\" <dts@dpdk.org>",
            "X-MS-Has-Attach": "",
            "Errors-To": "dts-bounces@dpdk.org",
            "From": "\"Tu, Lijuan\" <lijuan.tu@intel.com>",
            "dlp-reaction": "no-action",
            "In-Reply-To": "<1595492760-4039-1-git-send-email-yuan.peng@intel.com>",
            "Return-Path": "<dts-bounces@dpdk.org>",
            "dlp-product": "dlpe-windows",
            "Content-Language": "en-US"
        }
    }
]