Show a patch.

GET /api/patches/74626/
HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 74626,
    "url": "https://patches.dpdk.org/api/patches/74626/",
    "web_url": "https://patches.dpdk.org/patch/74626/",
    "project": {
        "id": 3,
        "url": "https://patches.dpdk.org/api/projects/3/",
        "name": "DTS",
        "link_name": "dts",
        "list_id": "dts.dpdk.org",
        "list_email": "dts@dpdk.org",
        "web_url": "",
        "scm_url": "git://dpdk.org/tools/dts",
        "webscm_url": "http://git.dpdk.org/tools/dts/"
    },
    "msgid": "<1595492760-4039-1-git-send-email-yuan.peng@intel.com>",
    "date": "2020-07-23T08:26:00",
    "name": "test_plans: add ethertype flow to fdir",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "1d544a6b0892de3f1cdc9bb1737e1cfcb6de5567",
    "submitter": {
        "id": 429,
        "url": "https://patches.dpdk.org/api/people/429/",
        "name": "Peng Yuan",
        "email": "yuan.peng@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/patch/74626/mbox/",
    "series": [
        {
            "id": 11241,
            "url": "https://patches.dpdk.org/api/series/11241/",
            "web_url": "https://patches.dpdk.org/project/dts/list/?series=11241",
            "date": "2020-07-23T08:26:00",
            "name": "test_plans: add ethertype flow to fdir",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/11241/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/74626/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/74626/checks/",
    "tags": {},
    "headers": {
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>",
        "X-IronPort-AV": [
            "E=McAfee;i=\"6000,8403,9690\"; a=\"148386848\"",
            "E=Sophos;i=\"5.75,383,1589266800\"; d=\"scan'208\";a=\"148386848\"",
            "E=Sophos;i=\"5.75,383,1589266800\"; d=\"scan'208\";a=\"488653444\""
        ],
        "IronPort-SDR": [
            "\n ABCcevTgJeKHXBw9/1qLOOVyHVbsBxtKBsDR6KE9VikRtU7Rp5QLf0ONH6O97JYXD9cqGhhOuE\n rASpcLL4wf6A==",
            "\n cDTLvP/GBakzOWoJt0n9RtlbHsCb4InhwqFHodcrl3Jv/XVeXy6eCMYM/7rU0f80+n33ydXFiH\n zTPnmknXM5/A=="
        ],
        "X-Amp-File-Uploaded": "False",
        "Precedence": "list",
        "X-Mailman-Version": "2.1.15",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "List-Post": "<mailto:dts@dpdk.org>",
        "X-BeenThere": "dts@dpdk.org",
        "List-Id": "test suite reviews and discussions <dts.dpdk.org>",
        "Subject": "[dts] [PATCH]test_plans: add ethertype flow to fdir",
        "Sender": "\"dts\" <dts-bounces@dpdk.org>",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5AEFDA0526;\n\tThu, 23 Jul 2020 03:20:14 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 111E41BFBA;\n\tThu, 23 Jul 2020 03:20:14 +0200 (CEST)",
            "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by dpdk.org (Postfix) with ESMTP id 7DCFF1BE9A\n for <dts@dpdk.org>; Thu, 23 Jul 2020 03:20:12 +0200 (CEST)",
            "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Jul 2020 18:20:11 -0700",
            "from npg_dpdk_nic_yuanpeng_tester62.sh.intel.com ([10.67.119.61])\n by fmsmga005.fm.intel.com with ESMTP; 22 Jul 2020 18:20:09 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "List-Archive": "<http://mails.dpdk.org/archives/dts/>",
        "X-Mailer": "git-send-email 2.7.4",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>",
        "X-ExtLoop1": "1",
        "Date": "Thu, 23 Jul 2020 08:26:00 +0000",
        "To": "dts@dpdk.org",
        "From": "Peng Yuan <yuan.peng@intel.com>",
        "Errors-To": "dts-bounces@dpdk.org",
        "Cc": "Peng Yuan <yuan.peng@intel.com>",
        "List-Help": "<mailto:dts-request@dpdk.org?subject=help>",
        "Message-Id": "<1595492760-4039-1-git-send-email-yuan.peng@intel.com>",
        "Return-Path": "<dts-bounces@dpdk.org>"
    },
    "content": "add ethertype flow to cvl fdir\nadd IPV6 pattern to conflict rule case.\n\nSigned-off-by: Peng Yuan <yuan.peng@intel.com>",
    "diff": "diff --git a/test_plans/cvl_fdir_test_plan.rst b/test_plans/cvl_fdir_test_plan.rst\nindex 63ad6f2..c1b9223 100644\n--- a/test_plans/cvl_fdir_test_plan.rst\n+++ b/test_plans/cvl_fdir_test_plan.rst\n@@ -37,6 +37,7 @@ CVL:Classification:Flow Director\n Enable fdir filter for IPv4/IPv6 + TCP/UDP/SCTP  (OS default package)\n Enable fdir filter for UDP tunnel: Vxlan / NVGRE (OS default package)\n Enable fdir filter for GTP (comm #1 package)\n+Enable fdir filter for L2 Ethertype (comm #1 package)\n \n Pattern and input set\n ---------------------\n@@ -81,6 +82,8 @@ Pattern and input set\n     +------------------------------+----------------------------+-------------------------------------------------------------------------------+\n     |                              | MAC_IPV4_GTPU_EH           | [TEID], [QFI]                                                                 |\n     +------------------------------+----------------------------+-------------------------------------------------------------------------------+\n+    | L2 Ethertype                 |      L2 Ethertype          | [Ethertype]                                                                   |\n+    +------------------------------+----------------------------+-------------------------------------------------------------------------------+\n \n .. note::\n \n@@ -131,7 +134,7 @@ Prerequisites\n \n 5. Launch the app ``testpmd`` with the following arguments::\n \n-    ./testpmd -c 0xff -n 6 -w 86:00.0,,flow-mark-support=1 -- -i --portmask=0xff --rxq=64 --txq=64 --port-topology=loop\n+    ./testpmd -c 0xff -n 6 -w 86:00.0,,flow-mark-support=1 --log-level=\"ice,7\" -- -i --portmask=0xff --rxq=64 --txq=64 --port-topology=loop\n     testpmd> set fwd rxonly\n     testpmd> set verbose 1\n \n@@ -142,7 +145,7 @@ Prerequisites\n \n    Notes: if need two ports environment, launch ``testpmd`` with the following arguments::\n \n-    ./testpmd -c 0xff -n 6 -w 86:00.0,flow-mark-support=1 -w 86:00.1,flow-mark-support=1 -- -i --portmask=0xff --rxq=64 --txq=64 --port-topology=loop\n+    ./testpmd -c 0xff -n 6 -w 86:00.0,flow-mark-support=1 -w 86:00.1,flow-mark-support=1 --log-level=\"ice,7\" -- -i --portmask=0xff --rxq=64 --txq=64 --port-topology=loop\n \n \n Default parameters\n@@ -185,6 +188,9 @@ Default parameters\n     [TEID]: 0x12345678\n     [QFI]: 0x34\n \n+   L2 Ethertype::\n+\n+    [Ethertype]: 0x8863 0x8864 0x0806 0x8100 0x88f7\n \n Send packets\n ------------\n@@ -440,6 +446,32 @@ Send packets\n     p_gtpu14 = Ether(src=\"a4:bf:01:51:27:ca\", dst=\"00:11:22:33:44:55\")/IP(src=\"192.168.0.20\", dst=\"192.168.0.21\")/UDP(dport=2152)/GTP_U_Header(gtp_type=255, teid=0x12345678)/IPv6()/SCTP()/Raw('x'*20)\n     p_gtpu15 = Ether(src=\"a4:bf:01:51:27:ca\", dst=\"00:11:22:33:44:55\")/IP(src=\"192.168.0.20\", dst=\"192.168.0.21\")/UDP(dport=2152)/GTP_U_Header(gtp_type=255, teid=0x1234567)/IP()/Raw('x'*20)\n \n+* L2 Ethertype\n+\n+   PPPoED packets::\n+\n+    sendp([Ether(dst=\"00:11:22:33:44:55\")/PPPoED()/PPP()/IP()/Raw('x' *80)],iface=\"enp134s0f1\")\n+    sendp([Ether(dst=\"00:11:22:33:44:55\", type=0x8863)/IP()/Raw('x' * 80)],iface=\"enp134s0f1\")\n+\n+   PPPoE packets::\n+\n+    sendp([Ether(dst=\"00:11:22:33:44:55\")/PPPoE()/PPP(proto=0x0021)/IP()/Raw('x' * 80)],iface=\"enp134s0f1\")\n+    sendp([Ether(dst=\"00:11:22:33:44:55\", type=0x8864)/IP()/Raw('x' * 80)],iface=\"enp134s0f1\")\n+\n+   ARP packets::\n+\n+    sendp([Ether(dst=\"00:11:22:33:44:55\")/ARP(pdst=\"192.168.1.1\")],iface=\"enp134s0f1\")\n+    sendp([Ether(dst=\"00:11:22:33:44:55\", type=0x0806)/Raw('x' *80)],iface=\"enp134s0f1\")\n+\n+   EAPS packets::\n+\n+    sendp([Ether(dst=\"00:11:22:33:44:55\",type=0x8100)],iface=\"enp134s0f1\")\n+    sendp([Ether(dst=\"00:11:22:33:44:55\")/Dot1Q(vlan=1)],iface=\"enp134s0f1\")\n+\n+   ieee1588 packet::\n+\n+    sendp([Ether(dst=\"00:11:22:33:44:55\",type=0x88f7)/\"\\\\x00\\\\x02\"], iface=\"enp134s0f1\")\n+\n \n Test case: flow validation\n ==========================\n@@ -1705,6 +1737,175 @@ Subcase 6: MAC_IPV4_GTPU mark\n 2. repeat the steps of passthru in subcase 3,\n    get the same result.\n \n+Test case: L2 Ethertype pattern\n+===============================\n+\n+Subcase 1: L2 Ethertype queue index\n+-----------------------------------\n+\n+1. create rule for PPPoED::\n+\n+    flow create 0 ingress pattern eth type is 0x8863 / end actions queue index 1 / mark id 1 / end\n+\n+   send PPPoED packet,\n+   check the packets are distributed to expected queue with specific FDIR matched ID.\n+\n+2. create rule for PPPoE::\n+\n+    flow create 0 ingress pattern eth type is 0x8864 / end actions queue index 2 / mark id 2 / end\n+\n+   send PPPoE packet,\n+   check the packets are distributed to expected queue with specific FDIR matched ID.\n+\n+3. create rule for ARP::\n+\n+    flow create 0 ingress pattern eth type is 0x0806 / end actions queue index 3 / mark id 3 / end\n+\n+   send ARP packet,\n+   Check the packets are distributed to expected queue with specific FDIR matched ID.\n+\n+4. create rule for EAPS::\n+\n+    flow create 0 ingress pattern eth type is 0x8100 / end actions queue index 4 / mark id 4 / end\n+\n+   send EAPS packet,\n+   check the packets are distributed to expected queue with specific FDIR matched ID.\n+\n+5. create rule for ieee1588::\n+\n+    flow create 0 ingress pattern eth type is 0x88f7 / end actions queue index 5 / mark id 5 / end\n+\n+   send ieee1588 packet,\n+   check the packets are distributed to expected queue with specific FDIR matched ID.\n+\n+6. send a mismatched packet::\n+\n+    sendp([Ether(dst=\"00:11:22:33:44:55\",type=0x8847)],iface=\"enp134s0f1\")\n+\n+   check the packet received has not FDIR matched ID.\n+\n+7. verify rules can be listed and destroyed::\n+\n+    testpmd> flow list 0\n+\n+   check the 5 rules listed.\n+   flush all the rules::\n+\n+    testpmd> flow flush 0\n+\n+8. verify matched packets are received without FDIR matched ID.\n+   Then check there is no rule listed.\n+\n+Subcase 2: L2 Ethertype rss queues\n+----------------------------------\n+\n+1. create rules for PPPoED with rss queues action::\n+\n+    flow create 0 ingress pattern eth type is 0x8863 / end actions rss queues 2 3 end / mark id 2 / end\n+\n+2. send matched packet,\n+   check the packets received have FDIR matched ID=0x2,\n+   the packets are directed to queue 0,\n+   because L2 Ethertype are not supported by RSS.\n+\n+3. Repeat step 1-2 with PPPoE/ARP/EAPS/ieee1588,\n+   get the same result.\n+\n+4. repeat step 6-7 of subcase 1.\n+\n+5. verify matched packets received have not FDIR matched ID.\n+   Then check there is no rule listed.\n+\n+Subcase 3: L2 Ethertype passthru\n+--------------------------------\n+\n+1. create rules for PPPoED with passthru action::\n+\n+    flow create 0 ingress pattern eth type is 0x8863 / end actions passthru / mark id 2 / end\n+\n+2. send matched packet,\n+   check the packets received have FDIR matched ID=0x2,\n+   the packets are directed to queue 0,\n+   because L2 Ethertype are not supported by RSS.\n+\n+3. Repeat step 1-2 with PPPoE/ARP/EAPS/ieee1588,\n+   get the same result.\n+\n+4. repeat step 6-7 of subcase 1.\n+\n+5. verify matched packets received have not FDIR matched ID.\n+   Then check there is no rule listed.\n+\n+Subcase 4: L2 Ethertype drop\n+----------------------------\n+\n+1. create rules for PPPoED with drop action::\n+\n+    flow create 0 ingress pattern eth type is 0x8863 / end actions drop / end\n+\n+2. send matched packet,\n+   check the packets are dropped,\n+\n+3. Repeat step 1-2 with PPPoE/ARP/EAPS/ieee1588,\n+   get the same result.\n+\n+4. repeat step 6-7 of subcase 1.\n+\n+5. verify matched packets are received.\n+   Then check there is no rule listed.\n+\n+Subcase 5: L2 Ethertype mark+rss\n+--------------------------------\n+\n+1. create rules for PPPoED with rss queues action::\n+\n+    flow create 0 ingress pattern eth type is 0x8863 / end actions mark id 1 / rss / end\n+\n+2. send matched packet,\n+   check the packets received have FDIR matched ID=0x1,\n+   the packets are directed to queue 0,\n+   because L2 Ethertype are not supported by RSS.\n+\n+3. Repeat step 1-2 with PPPoE/ARP/EAPS/ieee1588,\n+   get the same result.\n+\n+4. repeat step 6-7 of subcase 1.\n+\n+5. verify matched packets received have not FDIR matched ID.\n+   Then check there is no rule listed.\n+\n+Subcase 6: L2 Ethertype mark\n+----------------------------\n+\n+1. create rules for PPPoED with mark action::\n+\n+    flow create 0 ingress pattern eth type is 0x8863 / end actions mark / end\n+\n+2. send matched packet,\n+   check the packets received have FDIR matched ID=0x0,\n+\n+3. Repeat step 1-2 with PPPoE/ARP/EAPS/ieee1588,\n+   get the same result.\n+\n+4. repeat step 6-7 of subcase 1.\n+\n+5. verify matched packets received have not FDIR matched ID.\n+   Then check there is no rule listed.\n+\n+Subcase 7: unsupported Ethertype\n+--------------------------------\n+\n+1. create rules for IP/IPV6::\n+\n+    flow create 0 ingress pattern eth type is 0x0800 / end actions queue index 1 / end\n+    flow create 0 ingress pattern eth type is 0x86dd / end actions queue index 1 / end\n+\n+   the two rules can be created successfully, but report below message::\n+\n+    ice_flow_create(): Succeeded to create (2) flow\n+    Flow rule #0 created\n+\n+   the number \"2\" stands for switch rule, fdir doesn't support IPV4/IPV6 ethertype.\n \n Test case: negative cases\n =========================\n@@ -1812,6 +2013,7 @@ Subcase 6: conflicted rules\n 1. Create a FDIR rule::\n \n     flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv4 src is 192.168.0.20 dst is 192.168.0.21 ttl is 2 tos is 4 / end actions queue index 1 / end\n+    flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv6 dst is CDCD:910A:2222:5498:8475:1111:3900:2020 src is 2001::2 / end actions queue index 1 / mark / end\n \n    the rule is created successfully.\n \n@@ -1821,12 +2023,17 @@ Subcase 6: conflicted rules\n     flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv4 src is 192.168.0.20 dst is 192.168.0.21 ttl is 2 tos is 4 / end actions drop / end\n     flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv4 src is 192.168.0.21 ttl is 2 tos is 4 / end actions queue index 3 / mark / end\n     flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv4 src is 192.168.0.20 dst is 192.168.0.21 ttl is 2 tos is 4 / udp src is 22 dst is 23 / end actions queue index 3 / mark / end\n+    flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv6 dst is CDCD:910A:2222:5498:8475:1111:3900:2020 src is 2001::2 / end actions queue index 2 / mark / end\n+    flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv6 dst is CDCD:910A:2222:5498:8475:1111:3900:2020 src is 2001::2 / end actions rss queues 2 3 end / mark / end\n+    flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv6 dst is CDCD:910A:2222:5498:8475:1111:3900:2021 / end actions mark / end\n+    flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv6 dst is CDCD:910A:2222:5498:8475:1111:3900:2020 src is 2001::2 / udp src is 22 dst is 23 / end actions queue index 1 / mark / end\n \n    Failed to create the two flows, report message::\n \n-    first two rules:\n     Rule already exists!: File exists\n-    last two rules:\n+\n+   or::\n+\n     Invalid input action number: Invalid argument\n \n 3. check there is only one rule listed.\n",
    "prefixes": []
}