Patch Comment List
List patch comments
GET /api/patches/74620/comments/?format=api
[ { "id": 116953, "web_url": "https://patches.dpdk.org/comment/116953/", "msgid": "<3232006.abz6jIGztJ@thomas>", "list_archive_url": "https://inbox.dpdk.org/dev/3232006.abz6jIGztJ@thomas", "date": "2020-07-30T21:15:21", "subject": "Re: [dpdk-dev] [PATCH 2/2] examples/l2fwd-crypto: Free resources on\n\texit", "submitter": { "id": 685, "url": "https://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "content": "Declan is not reviewing patches anymore.\nAdding more maintainers in Cc.\n\nPS: Maybe we should update the file MAINTAINERS\nto avoid patches being stuck.\n\n\n22/07/2020 14:50, Ibtisam Tariq:\n> When exiting the application, resources should be cleared.\n> \n> Signed-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com>\n> ---\n> examples/l2fwd-crypto/main.c | 31 ++++++++++++++++++++++++++++++-\n> 1 file changed, 30 insertions(+), 1 deletion(-)\n> \n> diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c\n> index 827da9b3e..5b00e2ade 100644\n> --- a/examples/l2fwd-crypto/main.c\n> +++ b/examples/l2fwd-crypto/main.c\n> @@ -18,6 +18,7 @@\n> #include <getopt.h>\n> #include <fcntl.h>\n> #include <unistd.h>\n> +#include <signal.h>\n> \n> #include <rte_string_fns.h>\n> #include <rte_atomic.h>\n> @@ -47,6 +48,8 @@\n> #include <rte_cryptodev_scheduler.h>\n> #endif\n> \n> +static volatile bool force_quit;\n> +\n> enum cdev_type {\n> \tCDEV_TYPE_ANY,\n> \tCDEV_TYPE_HW,\n> @@ -838,7 +841,7 @@ l2fwd_main_loop(struct l2fwd_crypto_options *options)\n> \t * so user can see the crypto information.\n> \t */\n> \tprev_tsc = rte_rdtsc();\n> -\twhile (1) {\n> +\twhile (!force_quit) {\n> \n> \t\tcur_tsc = rte_rdtsc();\n> \n> @@ -1738,8 +1741,12 @@ check_all_ports_link_status(uint32_t port_mask)\n> \tprintf(\"\\nChecking link status\");\n> \tfflush(stdout);\n> \tfor (count = 0; count <= MAX_CHECK_TIME; count++) {\n> +\t\tif (force_quit)\n> +\t\t\treturn;\n> \t\tall_ports_up = 1;\n> \t\tRTE_ETH_FOREACH_DEV(portid) {\n> +\t\t\tif (force_quit)\n> +\t\t\t\treturn;\n> \t\t\tif ((port_mask & (1 << portid)) == 0)\n> \t\t\t\tcontinue;\n> \t\t\tmemset(&link, 0, sizeof(link));\n> @@ -2662,6 +2669,16 @@ reserve_key_memory(struct l2fwd_crypto_options *options)\n> \toptions->aad.phys_addr = rte_malloc_virt2iova(options->aad.data);\n> }\n> \n> +static void\n> +signal_handler(int signum)\n> +{\n> +\tif (signum == SIGINT || signum == SIGTERM) {\n> +\t\tprintf(\"\\n\\nSignal %d received, preparing to exit...\\n\",\n> +\t\t\t\tsignum);\n> +\t\tforce_quit = true;\n> +\t}\n> +}\n> +\n> int\n> main(int argc, char **argv)\n> {\n> @@ -2681,6 +2698,10 @@ main(int argc, char **argv)\n> \targc -= ret;\n> \targv += ret;\n> \n> +\tforce_quit = false;\n> +\tsignal(SIGINT, signal_handler);\n> +\tsignal(SIGTERM, signal_handler);\n> +\n> \t/* reserve memory for Cipher/Auth key and IV */\n> \treserve_key_memory(&options);\n> \n> @@ -2807,6 +2828,14 @@ main(int argc, char **argv)\n> \t\tif (rte_eal_wait_lcore(lcore_id) < 0)\n> \t\t\treturn -1;\n> \t}\n> +\tRTE_ETH_FOREACH_DEV(portid) {\n> +\t\tprintf(\"Closing port %d...\", portid);\n> +\t\trte_eth_dev_stop(portid);\n> +\t\trte_eth_dev_close(portid);\n> +\t\tprintf(\" Done\\n\");\n> +\t}\n> +\trte_eal_cleanup();\n> +\tprintf(\"Bye...\\n\");\n> \n> \treturn 0;\n> }\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 07C80A052B;\n\tThu, 30 Jul 2020 23:15:29 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BE0402BB8;\n\tThu, 30 Jul 2020 23:15:28 +0200 (CEST)", "from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com\n [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id C6E8010A3\n for <dev@dpdk.org>; Thu, 30 Jul 2020 23:15:26 +0200 (CEST)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailout.nyi.internal (Postfix) with ESMTP id 12EE65C0189;\n Thu, 30 Jul 2020 17:15:25 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n by compute7.internal (MEProxy); Thu, 30 Jul 2020 17:15:25 -0400", "from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id DA9EF3280060;\n Thu, 30 Jul 2020 17:15:22 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding:content-type; s=fm1; bh=\n 0MhvvsnI33N2dgfJFR5DyXcX/3/fYo+r8zUopEsFkDQ=; b=GyKgGo98ALbzNeXs\n empN/CHXjljQeAUpXfOovNJWfzyyn6MLF0KMZ4p7LLxutcMS6z6Z37OnrKmkpkKM\n G7lQbF/1SP+6bi5fr2vKVUkjWqsxLuXN/xBGaPb4vY8afrgudUnqwiOJvfG268Oc\n MnE7nJSTM/3dWFBcwtdiHIHqc/5AyhhlVPwNiLtP2G1iFhHOQJnYCGa9o9wO+5lK\n LSbY8+jEaFLbCK3AUQ2qxUEHYugXZNRkPwhTxjIvWn/4fBqATvuhkbxJfIqfSWtx\n XpEynFcAqr+QDg2U0qoxroU3x/2MhyOdFkSfAZ8jlCmGmvi1O8CINQe1m1GEjo2/\n Y8fZVA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:content-type\n :date:from:in-reply-to:message-id:mime-version:references\n :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender\n :x-sasl-enc; s=fm3; bh=0MhvvsnI33N2dgfJFR5DyXcX/3/fYo+r8zUopEsFk\n DQ=; b=Mp5SsPMBgCfOjcPfkjZihToNfx0TyRMyvP+58agQnqDHBtZjFZ/K9NNDi\n HLLTDzvKOl5Npg7UHRYXcRSlvuXIfhTcf1S3HKDtcYa7qo/3PoLYo55gjlaUylQJ\n k08ZffWe5qkg4osbqqsRVg3u6hdgECe8EQ2xeSUFT7rN2nZScseB97NKLs/tHzxF\n 2K/66kDRq5lHApQYWTkd+fr/B3qmLGaaKMV7M5nwdOyg+py2VGe6VarYODmbyG/+\n /E3Tg16a4kDFdmZUwIUOf/5H/IaJnWZh3LiSpdHj7ojVq+GfCbyMyEp6uhEQFaoL\n L9vJvP+tHuUhJumEPO1M9fPe+Redw==" ], "X-ME-Sender": "<xms:azgjX1Yhnv-YMMkZkDaRVxPPeLs_Fwh5XmHSXa_FGHFt3XRwh_byMQ>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduiedrieeigdduiedtucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu\n ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl\n ohhnrdhnvght", "X-ME-Proxy": "<xmx:azgjX8aRhX9XNBblLi1o0UKqbYypvpBEE6tAMwts9YsQrXaJH4PpeQ>\n <xmx:azgjX39Nv1r2TzbwkPhmvOpymTUbNE8m1o2wRyZHqkFVldHErLwPkw>\n <xmx:azgjXzqFC1sypEKN2y5nwVFPvGT3WVf6SHpL9FKuCeYl9abpPv99Xw>\n <xmx:bTgjX1ARu5cr8LcMo4qn8CNems4RuXorjxSTYU-APdRJqmubvuJqvQ>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "Ibtisam Tariq <ibtisam.tariq@emumba.com>", "Cc": "declan.doherty@intel.com, dev@dpdk.org, akhil.goyal@nxp.com,\n anoobj@marvell.com, bruce.richardson@intel.com, fiona.trahe@intel.com,\n ruifeng.wang@arm.com, pablo.de.lara.guarch@intel.com", "Date": "Thu, 30 Jul 2020 23:15:21 +0200", "Message-ID": "<3232006.abz6jIGztJ@thomas>", "In-Reply-To": "<20200722125026.2595-2-ibtisam.tariq@emumba.com>", "References": "<20200722125026.2595-1-ibtisam.tariq@emumba.com>\n <20200722125026.2595-2-ibtisam.tariq@emumba.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Subject": "Re: [dpdk-dev] [PATCH 2/2] examples/l2fwd-crypto: Free resources on\n\texit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 124798, "web_url": "https://patches.dpdk.org/comment/124798/", "msgid": "<3656795.J7gPOmSi4Y@thomas>", "list_archive_url": "https://inbox.dpdk.org/dev/3656795.J7gPOmSi4Y@thomas", "date": "2020-11-22T18:05:26", "subject": "Re: [dpdk-dev] [PATCH 2/2] examples/l2fwd-crypto: Free resources on\n\texit", "submitter": { "id": 685, "url": "https://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "content": "30/07/2020 23:15, Thomas Monjalon:\n> Declan is not reviewing patches anymore.\n> Adding more maintainers in Cc.\n> \n> PS: Maybe we should update the file MAINTAINERS\n> to avoid patches being stuck.\n\nNo progress since July.\n\nI will apply this series and all others not reviewed patches\non the same topic after 20.11, so the risk will be low.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9B427A04B1;\n\tSun, 22 Nov 2020 19:05:35 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 71E6872DD;\n\tSun, 22 Nov 2020 19:05:33 +0100 (CET)", "from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com\n [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 9AA7B72D8\n for <dev@dpdk.org>; Sun, 22 Nov 2020 19:05:30 +0100 (CET)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailnew.nyi.internal (Postfix) with ESMTP id E3200580682;\n Sun, 22 Nov 2020 13:05:29 -0500 (EST)", "from mailfrontend1 ([10.202.2.162])\n by compute2.internal (MEProxy); Sun, 22 Nov 2020 13:05:29 -0500", "from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id F1D2C3280059;\n Sun, 22 Nov 2020 13:05:27 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding:content-type; s=fm2; bh=\n GQj8wmerWQzq2Fi5BoPim2L0dCun41MageYJtljH4Gc=; b=SYrpmxgrJ6HSwQqK\n tmeEZ49WDox9elZdqETRXsZm6SULuZL1nUGhQ5xQ3lteafgVflB0KdEGRzppWQ5T\n AqiVJi+uuhBj7BPlMkwBX7M/CVk07eFms+VTWFzc8vC4TVBYGvpRZSTeKyxcB3aK\n jfedV0alPkSMWoP2e4fDyKnspzwVnbr8uglguMJ4IDlMJ6G283MZSZQKcl7sfGC6\n YOWMZkyKk3GGiYvDuFAilHj6WxakGZCOyh6nRlycgH2tOtJ6ngFJovnpL5CJQs2Z\n f/fHb1eRcMFepcNd4EpPtf3CVU8vLRx9HGUv1Sww2JEhl2D80WXgrpAXMex85d0H\n 6gsmKg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:content-type\n :date:from:in-reply-to:message-id:mime-version:references\n :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender\n :x-sasl-enc; s=fm1; bh=GQj8wmerWQzq2Fi5BoPim2L0dCun41MageYJtljH4\n Gc=; b=KVQCsfhRgSTiFvOu499r7O8p5tAwfs+R36ytvutQkcwEGvuV3iWSunQHZ\n XMkVSHv8wHeptCPgF/5Lq3ypZnW5lPPQSCveqMk1RiQam+vNrdTZlNNPAmEJvOe9\n EdYAoQEW5I+1xMJQLRFSXHdXKBGg12ILQdwMuTKoGGhSlXE0Fho7DHZ8HnP70QXi\n SfTk3di59T0iou5JgAP17aDECJld3lHp8UBxhIGGrkM8EFX4d+dplPDGyD9kdL36\n oo5FZzsNfQNX1PhIteUU/8eps6PJR5i9B1J9OOuVsxgeJ4Il2T71RF7y34tH7Gbc\n u3bBdhz4QyZWnMer9PKAw54E/x1MA==" ], "X-ME-Sender": "<xms:aai6X0P-sbc9vRGNUuIMPv8Rq9elz7GHW597j47eAdt-tbIL80dTAw>\n <xme:aai6X6-Q8-ieQMxbHHc_HrEZvcgk-3BQia6wxkeohQZPtoO7769NQ8RzALwkYguz8\n 9oevAi66eZ9CsFCow>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedujedrudeggedgudduudcutefuodetggdotefrod\n ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh\n necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd\n enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm\n rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc\n ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej\n ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh\n fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr\n lhhonhdrnhgvth", "X-ME-Proxy": "<xmx:aai6X7QsZh5Zz4eWCBOFTX0w0HMqQSX6P-ZnBXr3T1Nl8KKlFF3-0Q>\n <xmx:aai6X8ssflCosDPfcovNoQuRCDNGQOTx2Hs-yP-JitPDVHO5HwlHMw>\n <xmx:aai6X8c4XzN8Ky1UYubCnt1JtSdqZBvpC5Jqhc-4PX8MyeuQAS28FQ>\n <xmx:aai6X04WdPX4_nPZUTstP3Hc1mQ1YqWVnl8TGQPcTRjtC1fWY9un-A>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "Ibtisam Tariq <ibtisam.tariq@emumba.com>", "Cc": "dev@dpdk.org, declan.doherty@intel.com, akhil.goyal@nxp.com,\n anoobj@marvell.com, bruce.richardson@intel.com, fiona.trahe@intel.com,\n ruifeng.wang@arm.com, pablo.de.lara.guarch@intel.com,\n david.marchand@redhat.com, sarosh.arif@emumba.com, m.bilal@emumba.com", "Date": "Sun, 22 Nov 2020 19:05:26 +0100", "Message-ID": "<3656795.J7gPOmSi4Y@thomas>", "In-Reply-To": "<3232006.abz6jIGztJ@thomas>", "References": "<20200722125026.2595-1-ibtisam.tariq@emumba.com>\n <20200722125026.2595-2-ibtisam.tariq@emumba.com> <3232006.abz6jIGztJ@thomas>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Subject": "Re: [dpdk-dev] [PATCH 2/2] examples/l2fwd-crypto: Free resources on\n\texit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 124846, "web_url": "https://patches.dpdk.org/comment/124846/", "msgid": "<BL0PR11MB30431A2DD750B18EFABF50E1B8FC0@BL0PR11MB3043.namprd11.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/BL0PR11MB30431A2DD750B18EFABF50E1B8FC0@BL0PR11MB3043.namprd11.prod.outlook.com", "date": "2020-11-23T15:44:36", "subject": "Re: [dpdk-dev] [PATCH 2/2] examples/l2fwd-crypto: Free resources on\n exit", "submitter": { "id": 304, "url": "https://patches.dpdk.org/api/people/304/?format=api", "name": "Fan Zhang", "email": "roy.fan.zhang@intel.com" }, "content": "Hi Ibtisam,\n\n> -----Original Message-----\n> From: dev <dev-bounces@dpdk.org> On Behalf Of Ibtisam Tariq\n> Sent: Wednesday, July 22, 2020 1:50 PM\n> To: Doherty, Declan <declan.doherty@intel.com>\n> Cc: dev@dpdk.org; Ibtisam Tariq <ibtisam.tariq@emumba.com>\n> Subject: [dpdk-dev] [PATCH 2/2] examples/l2fwd-crypto: Free resources on\n> exit\n> \n> When exiting the application, resources should be cleared.\n> \n> Signed-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com>\n> ---\n> examples/l2fwd-crypto/main.c | 31 ++++++++++++++++++++++++++++++-\n> 1 file changed, 30 insertions(+), 1 deletion(-)\n> \n> diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c\n> index 827da9b3e..5b00e2ade 100644\n> --- a/examples/l2fwd-crypto/main.c\n> +++ b/examples/l2fwd-crypto/main.c\n> @@ -18,6 +18,7 @@\n> #include <getopt.h>\n> #include <fcntl.h>\n> #include <unistd.h>\n> +#include <signal.h>\n> \n> #include <rte_string_fns.h>\n> #include <rte_atomic.h>\n> @@ -47,6 +48,8 @@\n> #include <rte_cryptodev_scheduler.h>\n> #endif\n> \n> +static volatile bool force_quit;\n> +\n> enum cdev_type {\n> \tCDEV_TYPE_ANY,\n> \tCDEV_TYPE_HW,\n> @@ -838,7 +841,7 @@ l2fwd_main_loop(struct l2fwd_crypto_options\n> *options)\n> \t * so user can see the crypto information.\n> \t */\n> \tprev_tsc = rte_rdtsc();\n> -\twhile (1) {\n> +\twhile (!force_quit) {\n> \n> \t\tcur_tsc = rte_rdtsc();\n> \n> @@ -1738,8 +1741,12 @@ check_all_ports_link_status(uint32_t port_mask)\n> \tprintf(\"\\nChecking link status\");\n> \tfflush(stdout);\n> \tfor (count = 0; count <= MAX_CHECK_TIME; count++) {\n> +\t\tif (force_quit)\n> +\t\t\treturn;\n> \t\tall_ports_up = 1;\n> \t\tRTE_ETH_FOREACH_DEV(portid) {\n> +\t\t\tif (force_quit)\n> +\t\t\t\treturn;\n> \t\t\tif ((port_mask & (1 << portid)) == 0)\n> \t\t\t\tcontinue;\n> \t\t\tmemset(&link, 0, sizeof(link));\n> @@ -2662,6 +2669,16 @@ reserve_key_memory(struct\n> l2fwd_crypto_options *options)\n> \toptions->aad.phys_addr = rte_malloc_virt2iova(options->aad.data);\n> }\n> \n> +static void\n> +signal_handler(int signum)\n> +{\n> +\tif (signum == SIGINT || signum == SIGTERM) {\n> +\t\tprintf(\"\\n\\nSignal %d received, preparing to exit...\\n\",\n> +\t\t\t\tsignum);\n> +\t\tforce_quit = true;\n> +\t}\n> +}\n> +\n> int\n> main(int argc, char **argv)\n> {\n> @@ -2681,6 +2698,10 @@ main(int argc, char **argv)\n> \targc -= ret;\n> \targv += ret;\n> \n> +\tforce_quit = false;\n> +\tsignal(SIGINT, signal_handler);\n> +\tsignal(SIGTERM, signal_handler);\n> +\n> \t/* reserve memory for Cipher/Auth key and IV */\n> \treserve_key_memory(&options);\n> \n> @@ -2807,6 +2828,14 @@ main(int argc, char **argv)\n> \t\tif (rte_eal_wait_lcore(lcore_id) < 0)\n> \t\t\treturn -1;\n> \t}\n> +\tRTE_ETH_FOREACH_DEV(portid) {\n> +\t\tprintf(\"Closing port %d...\", portid);\n> +\t\trte_eth_dev_stop(portid);\n> +\t\trte_eth_dev_close(portid);\n> +\t\tprintf(\" Done\\n\");\n> +\t}\n> +\trte_eal_cleanup();\n> +\tprintf(\"Bye...\\n\");\n> \n> \treturn 0;\n> }\n> --\n> 2.17.1\n\nThanks for the patch and sorry for not reviewing for so long.\nIn addition to Ethdev resources, some Cryptodev resource may need to be cleaned too, e.g. draining all pending crypto operations from Cryptodev queue and stop/close the device before closing the application. For SW Crypto PMDs and QAT not doing the above steps are fine. But I am not sure about if it is a necessary step for other vendor's PMDs.\n\nOther than that the patch looks good to me.\n\nAkhil what do you think?\n\nRegards,\nFan", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3F432A04B1;\n\tMon, 23 Nov 2020 16:44:47 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1C176C8F6;\n\tMon, 23 Nov 2020 16:44:46 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by dpdk.org (Postfix) with ESMTP id A70DCC8F4\n for <dev@dpdk.org>; Mon, 23 Nov 2020 16:44:43 +0100 (CET)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Nov 2020 07:44:41 -0800", "from fmsmsx602.amr.corp.intel.com ([10.18.126.82])\n by fmsmga006.fm.intel.com with ESMTP; 23 Nov 2020 07:44:41 -0800", "from fmsmsx610.amr.corp.intel.com (10.18.126.90) by\n fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.1713.5; Mon, 23 Nov 2020 07:44:40 -0800", "from fmsmsx612.amr.corp.intel.com (10.18.126.92) by\n fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.1713.5; Mon, 23 Nov 2020 07:44:40 -0800", "from fmsedg602.ED.cps.intel.com (10.1.192.136) by\n fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5\n via Frontend Transport; Mon, 23 Nov 2020 07:44:40 -0800", "from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106)\n by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.1.1713.5; Mon, 23 Nov 2020 07:44:39 -0800", "from BL0PR11MB3043.namprd11.prod.outlook.com (2603:10b6:208:33::19)\n by MN2PR11MB4272.namprd11.prod.outlook.com (2603:10b6:208:196::31)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.25; Mon, 23 Nov\n 2020 15:44:36 +0000", "from BL0PR11MB3043.namprd11.prod.outlook.com\n ([fe80::cad:4bf2:7678:568d]) by BL0PR11MB3043.namprd11.prod.outlook.com\n ([fe80::cad:4bf2:7678:568d%3]) with mapi id 15.20.3589.029; Mon, 23 Nov 2020\n 15:44:36 +0000" ], "IronPort-SDR": [ "\n Lgw7qmp9Y1mLLPH2T59Ulpf5zHX5IioeLJGO7wwsc4EwHIofTJcrr19bWL7rcv5JYg+41Cu8dy\n MNErur8MZ46w==", "\n dC0umRcGyhX4iA5JqCmd4m5EpUcH+kYAih9GRnsl9PTsOvEmDzathPpR3Z88hypMuTKxroAenT\n pgUTdTMCbq7A==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9813\"; a=\"171004543\"", "E=Sophos;i=\"5.78,363,1599548400\"; d=\"scan'208\";a=\"171004543\"", "E=Sophos;i=\"5.78,363,1599548400\"; d=\"scan'208\";a=\"534500590\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Pp0CtThm+SnnLZIlxsBzlWmU3H79fiAtQAVbxMDYJ3TtlngDWGyq4tNlLq8STHCVGbHXBk0cm1D9Al5QijcpAUNqfJIQH31v4iiWRVE2FX7/4EUrzFop+DEmGwLDMPZL/lkBRjFpInqtGidB4kUZLBrI5p708vjRclUM3R15L8O0a/wfc2GlLbZaJJWDVQ4zSRSgVyXo7jds3o33dIn/+83RgqCDbUg+bMOdKqwGG4Hpf9XRqLP98J7U1c+wbnbnFrJuZcDncDlcBnirLfAi7PQ2UXpH2p1sa9TostgwkOcprS5ed8TfNXQle3nOje4+37Omn8GFxHC0xBwJzfIhig==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=HJxH0pyULaC6VkrJd8ZkZJjhkw23Vuxdgrbj5Hgsdv4=;\n b=jXpy5+ERhuSiidSt5fimx0o7WpHDyYz8vcDQl+tK8Lvf3s+iG/JyYiJcOBgsLm8Mp6ZluG2nrq49uV37y85joZEFnE3gTpmGPoPZmJdx/RGIbM9zRYPDql7ga4BRVj6MNCo/0ED4HgPtB4Ff7jxXodMV5918yWKsYz67r4DvngnrWtKYhJwSsjHE3WiLpW92q+YFVuqsREgNnLFj7Qy9aIiyNbdH+3WrHY+tZlD9dCiWoOSjwR/HuC4uC3r+SBxZDKOiyUivaWcG4ySYV7w6osunFcYkzRSO5PG052K/5++EbOkH3wAv/x0nvTiu0wHzHom4Sbwb+AUO0ZFrzVngOw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;\n s=selector2-intel-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=HJxH0pyULaC6VkrJd8ZkZJjhkw23Vuxdgrbj5Hgsdv4=;\n b=rppa9wIWHEm9GN7ovu73d02hRkaHBClLjfGZdQ9nDYPh4JY4pm+ev68EZnLysq2nbZNDYFphz7YVgTaH9SWdSob7Z8Nn0UtOkMATjYYp7tkL5SnrlK81lf7iQ4ekoiupPt5q/NDjS6ZtfM97wdfk/yu9bg8ax1wFkCyr+pzttoo=", "From": "\"Zhang, Roy Fan\" <roy.fan.zhang@intel.com>", "To": "Ibtisam Tariq <ibtisam.tariq@emumba.com>, \"Doherty, Declan\"\n <declan.doherty@intel.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,\n \"Trahe, Fiona\" <fiona.trahe@intel.com>, Akhil Goyal <akhil.goyal@nxp.com>", "Thread-Topic": "[dpdk-dev] [PATCH 2/2] examples/l2fwd-crypto: Free resources on\n exit", "Thread-Index": "AQHWYCcLDKFtCg9qI0iy1S8I18ikoanWm/9A", "Date": "Mon, 23 Nov 2020 15:44:36 +0000", "Message-ID": "\n <BL0PR11MB30431A2DD750B18EFABF50E1B8FC0@BL0PR11MB3043.namprd11.prod.outlook.com>", "References": "<20200722125026.2595-1-ibtisam.tariq@emumba.com>\n <20200722125026.2595-2-ibtisam.tariq@emumba.com>", "In-Reply-To": "<20200722125026.2595-2-ibtisam.tariq@emumba.com>", "Accept-Language": "zh-Hans-HK, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "dlp-version": "11.5.1.3", "dlp-reaction": "no-action", "dlp-product": "dlpe-windows", "authentication-results": "emumba.com; dkim=none (message not signed)\n header.d=none;emumba.com; dmarc=none action=none header.from=intel.com;", "x-originating-ip": "[95.44.220.85]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "0618e051-d057-4be1-f9ec-08d88fc6ae5a", "x-ms-traffictypediagnostic": "MN2PR11MB4272:", "x-ld-processed": "46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <MN2PR11MB42725206DBB0FF234E66945EB8FC0@MN2PR11MB4272.namprd11.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:1002;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n iLgvjTOnPEmj77q1koEus82Mo0BZ6BUa+gxfKpssDaTqbB23p8DMbPqeeylSoFa2UgXuIPVJOEpMpRW/9TGuVC6/0MNjHHb7ZWt5hVwqlu8TsQmDW3v+zFzwy0n6btrRQ/YOU1eNqjgd/srnZmHghFeCSiXJsLBMfMwijHvTFbcQCFVOIsML1JWhFTM+Ot4TamJFgjUb2uNbOn7JzFjjbExdQCnk3JqHY/OYtlcLFjBxbL2VhY4xKYrwwfbRaaytJcuS7CRPQV0PmFZad7vRwN/vm96Tc9axfULyfdvv0PsiIuT68NSGFbq96xA20YPmyPRqKyxUhA87c9+ZOcpFcg==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:BL0PR11MB3043.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(4636009)(39860400002)(396003)(366004)(136003)(346002)(376002)(66446008)(52536014)(5660300002)(71200400001)(64756008)(2906002)(76116006)(66556008)(83380400001)(66476007)(66946007)(86362001)(33656002)(110136005)(54906003)(4326008)(9686003)(186003)(316002)(26005)(6506007)(53546011)(478600001)(55016002)(7696005)(8676002)(6636002)(8936002);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata": "=?windows-1252?q?GeOcGWxjBN3hgFfLu5H/+uI?=\n\t=?windows-1252?q?SWy4gGGG5k235btMVgor661lt6+hShZSjOdzAz2TV45l7kPjGvdouQETvy?=\n\t=?windows-1252?q?MMeMLTsLJeZqw7qKrgS0Vw684sD2fhXi6P3RL7JWtRDy5o8kRAOSAtXXOe?=\n\t=?windows-1252?q?J0857zPQ8lwO3/gXeht1OP95jx4r1h4kNUaJlMxg1RbdIJNtAh+xsELZOI?=\n\t=?windows-1252?q?vsxHYsfZ51Q7py0IlUo1M83GxAdLmiJqP7RFhPdAiNAtlTzaGcPG0g3Yk6?=\n\t=?windows-1252?q?crYTaw+S1GJhpxXBsend7Pn5icv5NjcWULhPi9SN2twnVp7WwY6IVLiqDf?=\n\t=?windows-1252?q?6KHpS3FVLinjZDAMi0NWNTTRa5yKzr65FlNX7oJ8EXXqrWBFJkXAVcPEqj?=\n\t=?windows-1252?q?Pat+XyT8hvELumIr3xvCbNuCV2aUSrWgQTlydeNknugGb+mqRhJPI3bOCw?=\n\t=?windows-1252?q?gStuUu4a7W/fzPwcSjA5ZMmjB+iRNwvf2I/rwVhR6idGe0cLzCikIFcEjJ?=\n\t=?windows-1252?q?wNwLKDTANJsf3NEwugQFt6qHAteZ0toICkxZfFPiMF/Pmvo03P15BFxqUu?=\n\t=?windows-1252?q?vFLowiEWDuph+ukDCyWtwjf/cUeoqckd0Ut1ZFYUTfdgByAF7yZoMbGerA?=\n\t=?windows-1252?q?gdcXTdJu3U02YvEtj/DOHzudYZyjpGZ386hLZVNBeptyQybg9MLIoz93Tp?=\n\t=?windows-1252?q?5K1FQ7vBD0We/vO64b0QZt3jnQ7yWjtNfku7tLDgigxjvIuFlBOLdqMU++?=\n\t=?windows-1252?q?UQdQrh+IZCu2ZLD+/QOur9MGK3CH64G9DqtBIPWl9h9oZwI+gAii5Jc0lY?=\n\t=?windows-1252?q?Zj3kFFnYTJMO/mQrjPUQYktRhpijiKysnXHmb3s87++8VDbRIWVAtcOpSn?=\n\t=?windows-1252?q?KTEEsqyFHFu6ztqfDka6gEYdLrTISKqdP0rCxZ+efIWqF5NtljSy+VRCiF?=\n\t=?windows-1252?q?aD6xgimVQsIlb8bZnuRfb3FxtCsg0xAQRCLWI2S3v7Vj2cNmu17LDRy7mX?=\n\t=?windows-1252?q?ny3wFEVs/XA+DLeIcFlnDlXg+rFe9H6PA+J+PwaI/4Ity8RXad1U=3D?=", "Content-Type": "text/plain; charset=\"Windows-1252\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "BL0PR11MB3043.namprd11.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 0618e051-d057-4be1-f9ec-08d88fc6ae5a", "X-MS-Exchange-CrossTenant-originalarrivaltime": "23 Nov 2020 15:44:36.2710 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "46c98d88-e344-4ed4-8496-4ed7712e255d", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n S9gO7M/Jdd9+FUWBhsgoNuSmtzwtAUdSVQn23iBYCU0eNuOPWCIKvCTOPSOoiTr+3Ea+oevtuW+q1sdLpc5cdA==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN2PR11MB4272", "X-OriginatorOrg": "intel.com", "Subject": "Re: [dpdk-dev] [PATCH 2/2] examples/l2fwd-crypto: Free resources on\n exit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]