Patch Comment List
List patch comments
GET /api/patches/74614/comments/?format=api
[ { "id": 116525, "web_url": "https://patches.dpdk.org/comment/116525/", "msgid": "<DB6PR0802MB2216141E36D01AE4936D02E298790@DB6PR0802MB2216.eurprd08.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/DB6PR0802MB2216141E36D01AE4936D02E298790@DB6PR0802MB2216.eurprd08.prod.outlook.com", "date": "2020-07-22T21:40:37", "subject": "Re: [dpdk-dev] [PATCH v3 2/2] test/service: fix race condition on\n\tstopping lcore", "submitter": { "id": 1045, "url": "https://patches.dpdk.org/api/people/1045/?format=api", "name": "Honnappa Nagarahalli", "email": "honnappa.nagarahalli@arm.com" }, "content": "<snip>\n\n> Subject: [PATCH v3 2/2] test/service: fix race condition on stopping lcore\n> \n> This commit fixes a potential race condition in the tests where the lcore\n> running a service would increment a counter that was already reset by the\n> test-suite thread. The resulting race-condition incremented value could cause\n> CI failures, as indicated by DPDK's CI.\n> \n> This patch fixes the race-condition by making use of the added\n> rte_service_lcore_active() API, which indicates when a service-core is no\n> longer in the service-core polling loop.\n> \n> The unit test makes use of the above function to detect when all statistics\n> increments are done in the service-core thread, and then the unit test\n> continues finalizing and checking state.\n> \n> Fixes: f28f3594ded2 (\"service: add attribute API\")\n> \n> Reported-by: David Marchand <david.marchand@redhat.com>\n> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n> Reviewed-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n\n> \n> ---\n> \n> v3:\n> - Refactor while() to for() to simplify (Harry)\n> - Use SERVICE_DELAY instead of magic const 1 (Phil)\n> - Add Phil's reviewed by tag from ML\n> \n> v2:\n> Thanks for discussion on v1, this v2 fixup for the CI including previous\n> feedback on ML.\n> ---\n> app/test/test_service_cores.c | 20 +++++++++++++++++++-\n> 1 file changed, 19 insertions(+), 1 deletion(-)\n> \n> diff --git a/app/test/test_service_cores.c b/app/test/test_service_cores.c index\n> ef1d8fcb9..a6bc4487e 100644\n> --- a/app/test/test_service_cores.c\n> +++ b/app/test/test_service_cores.c\n> @@ -362,6 +362,9 @@ service_lcore_attr_get(void)\n> \t\t\t\"Service core add did not return zero\");\n> \tTEST_ASSERT_EQUAL(0, rte_service_map_lcore_set(id, slcore_id, 1),\n> \t\t\t\"Enabling valid service and core failed\");\n> +\t/* Ensure service is not active before starting */\n> +\tTEST_ASSERT_EQUAL(0, rte_service_lcore_active(slcore_id),\n> +\t\t\t\"Not-active service core reported as active\");\n> \tTEST_ASSERT_EQUAL(0, rte_service_lcore_start(slcore_id),\n> \t\t\t\"Starting service core failed\");\n> \n> @@ -382,7 +385,22 @@ service_lcore_attr_get(void)\n> \t\t\tlcore_attr_id, &lcore_attr_value),\n> \t\t\t\"Invalid lcore attr didn't return -EINVAL\");\n> \n> -\trte_service_lcore_stop(slcore_id);\n> +\t/* Ensure service is active */\n> +\tTEST_ASSERT_EQUAL(1, rte_service_lcore_active(slcore_id),\n> +\t\t\t\"Active service core reported as not-active\");\n> +\n> +\tTEST_ASSERT_EQUAL(0, rte_service_map_lcore_set(id, slcore_id, 0),\n> +\t\t\t\"Disabling valid service and core failed\");\n> +\tTEST_ASSERT_EQUAL(0, rte_service_lcore_stop(slcore_id),\n> +\t\t\t\"Failed to stop service lcore\");\n> +\n> +\t/* Wait until service lcore not active, or for 100x SERVICE_DELAY */\n> +\tfor (int i = 0; i < 100 && rte_service_lcore_active(slcore_id) == 1;\n> +\t\t\ti++)\n> +\t\trte_delay_ms(SERVICE_DELAY);\n> +\n> +\tTEST_ASSERT_EQUAL(0, rte_service_lcore_active(slcore_id),\n> +\t\t\t \"Service lcore not stopped after waiting.\");\n> \n> \tTEST_ASSERT_EQUAL(0, rte_service_lcore_attr_reset_all(slcore_id),\n> \t\t\t \"Valid lcore_attr_reset_all() didn't return success\");\n> --\n> 2.17.1", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 91851A0526;\n\tWed, 22 Jul 2020 23:40:55 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 645151BFD4;\n\tWed, 22 Jul 2020 23:40:55 +0200 (CEST)", "from EUR03-VE1-obe.outbound.protection.outlook.com\n (mail-eopbgr50082.outbound.protection.outlook.com [40.107.5.82])\n by dpdk.org (Postfix) with ESMTP id EA1CA1BFBB\n for <dev@dpdk.org>; Wed, 22 Jul 2020 23:40:53 +0200 (CEST)", "from MR2P264CA0011.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:1::23) by\n AM0PR08MB3380.eurprd08.prod.outlook.com (2603:10a6:208:e4::25) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.3195.23; Wed, 22 Jul 2020 21:40:45 +0000", "from VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com\n (2603:10a6:500:1:cafe::b8) by MR2P264CA0011.outlook.office365.com\n (2603:10a6:500:1::23) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20 via Frontend\n Transport; Wed, 22 Jul 2020 21:40:45 +0000", "from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by\n VE1EUR03FT041.mail.protection.outlook.com (10.152.19.163) with\n Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.3216.10 via Frontend Transport; Wed, 22 Jul 2020 21:40:45 +0000", "(\"Tessian outbound c83312565ef4:v62\");\n Wed, 22 Jul 2020 21:40:44 +0000", "from fb7c59bc0ac7.3\n by 64aa7808-outbound-1.mta.getcheckrecipient.com id\n F7495555-A1DF-4C3C-AE7B-5147B70BF6C5.1;\n Wed, 22 Jul 2020 21:40:39 +0000", "from EUR05-VI1-obe.outbound.protection.outlook.com\n by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id\n fb7c59bc0ac7.3\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);\n Wed, 22 Jul 2020 21:40:39 +0000", "from DB6PR0802MB2216.eurprd08.prod.outlook.com (2603:10a6:4:85::9)\n by DB8PR08MB4105.eurprd08.prod.outlook.com (2603:10a6:10:b0::12) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Wed, 22 Jul\n 2020 21:40:37 +0000", "from DB6PR0802MB2216.eurprd08.prod.outlook.com\n ([fe80::9d1d:207b:e89d:199d]) by DB6PR0802MB2216.eurprd08.prod.outlook.com\n ([fe80::9d1d:207b:e89d:199d%10]) with mapi id 15.20.3195.028; Wed, 22 Jul\n 2020 21:40:37 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;\n s=selector2-armh-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=HdDoozArlyAluYD0TjGXZRUynuknaju52QQYC3yQ74A=;\n b=nEFlVSNWXEz9OxlRI+M9yJSRwM98fA2TEqQC/2V8NmYPUB0HbI2HdaK+6X0GytzIu4ZlkRALyf7KIalSMNpRh1Qko3MQOjd9SR84hBepXM/ZdFjijqikWZH+YZasVKbBM1XOTgZHeYpSVlzCCd6qNnY3FV9GgEBh4/rZ5zM2lH8=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;\n s=selector2-armh-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=HdDoozArlyAluYD0TjGXZRUynuknaju52QQYC3yQ74A=;\n b=nEFlVSNWXEz9OxlRI+M9yJSRwM98fA2TEqQC/2V8NmYPUB0HbI2HdaK+6X0GytzIu4ZlkRALyf7KIalSMNpRh1Qko3MQOjd9SR84hBepXM/ZdFjijqikWZH+YZasVKbBM1XOTgZHeYpSVlzCCd6qNnY3FV9GgEBh4/rZ5zM2lH8=" ], "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 63.35.35.123)\n smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified)\n header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none\n header.from=arm.com;", "Received-SPF": "Pass (protection.outlook.com: domain of arm.com designates\n 63.35.35.123 as permitted sender) receiver=protection.outlook.com;\n client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;", "X-CR-MTA-TID": "64aa7808", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=cDLsleWesW0UWbmG5Rfr2J230Sh5BOZ8NkmESCzcozdK25YgdGqGiZ5z1zEa2xZfcHTucNovvNPEqXjgtM4SuG5FLHQXfPKR9dTNI8tMyHVfK9hhwymNb4N9A3FmIJUTU6n5v/xYu13Ng4lRSXLKXqsWnF7Hsb1MnB9b0muvF+7GaSoJu+SiczHVo6qQY0kkK15MMwMIQuweb8OeXMAUCklRddKbYgQ8XIFkNunDnsK49pbwwlN4HqRa0wcgQGmosAx04gu08Mn7feGhAdturQ42CsvSubVde7x5Fuk5jWZ9epYTWByvQ06A8vtR+4/N9yrfvNqRh1Zm4TbIv8WMdw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=HdDoozArlyAluYD0TjGXZRUynuknaju52QQYC3yQ74A=;\n b=kAyTmpTmGBb5BISuhhiiHpUgzhQ5VlY8dsBKLF9zzxAGyiIJq/z6fmDSVKuISAUy+tqfa79g3/9tiukJA2wKguqcnWToOi3t1XQS7lXO6w0uAs2wioIVAK5cUyDgvryhTX08FYVN+XzTaXBecgi9fXZ+W0yOzMGhTjjX3z6ctJtveB3RiWcQSWaF2+ACmGIi9ryk3LObnDY/Cwzpyxz2xwTCwF+PSv+p7FPmb8uQNKgwzf3i0sJ8ewJ5c7OyxpyJMglBit13XympiC+jDGrKbMRjy97fdQS8Ngy/9uabCFBhAEJuOP5RQY2ops7J9j6y6TeoYH1fIu8fHBkLH1Tqzw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass\n header.d=arm.com; arc=none", "From": "Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>", "To": "Harry van Haaren <harry.van.haaren@intel.com>, \"dev@dpdk.org\"\n <dev@dpdk.org>", "CC": "\"david.marchand@redhat.com\" <david.marchand@redhat.com>,\n \"igor.romanov@oktetlabs.ru\" <igor.romanov@oktetlabs.ru>,\n \"ferruh.yigit@intel.com\" <ferruh.yigit@intel.com>, nd <nd@arm.com>,\n \"aconole@redhat.com\" <aconole@redhat.com>, \"l.wojciechow@partner.samsung.com\"\n <l.wojciechow@partner.samsung.com>, Phil Yang <Phil.Yang@arm.com>, Honnappa\n Nagarahalli <Honnappa.Nagarahalli@arm.com>, nd <nd@arm.com>", "Thread-Topic": "[PATCH v3 2/2] test/service: fix race condition on stopping\n lcore", "Thread-Index": "AQHWYBP1XaoosJ90+0aDkiA52ipRyakUIQYw", "Date": "Wed, 22 Jul 2020 21:40:37 +0000", "Message-ID": "\n <DB6PR0802MB2216141E36D01AE4936D02E298790@DB6PR0802MB2216.eurprd08.prod.outlook.com>", "References": "<20200720143829.46280-1-harry.van.haaren@intel.com>\n <20200722103701.7244-1-harry.van.haaren@intel.com>\n <20200722103701.7244-2-harry.van.haaren@intel.com>", "In-Reply-To": "<20200722103701.7244-2-harry.van.haaren@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-ts-tracking-id": "71b0131b-f1d0-4f41-a10c-9c6269578ccb.0", "x-checkrecipientchecked": "true", "Authentication-Results-Original": "intel.com; dkim=none (message not signed)\n header.d=none;intel.com; dmarc=none action=none header.from=arm.com;", "x-originating-ip": "[217.140.111.135]", "x-ms-publictraffictype": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "fa2b0081-ba6d-404c-2c53-08d82e87e40f", "x-ms-traffictypediagnostic": "DB8PR08MB4105:|AM0PR08MB3380:", "x-ms-exchange-transport-forked": "True", "X-Microsoft-Antispam-PRVS": "\n <AM0PR08MB33802EE2F90F34F307A9C96E98790@AM0PR08MB3380.eurprd08.prod.outlook.com>", "x-checkrecipientrouted": "true", "nodisclaimer": "true", "x-ms-oob-tlc-oobclassifiers": "OLM:8273;OLM:8273;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam-Untrusted": "BCL:0;", "X-Microsoft-Antispam-Message-Info-Original": "\n C8io1UtIoLoMTGzn3myC/Tc6RqyvWbjEMbKYDwBGD0QhTho9eX9bX8yFrXK6PYowhM7GO47E7nhYnsFasnnsG8Y0C9d1DquOjDzLFy1qwKRkPDlF8zI0RRuf/KCj/OLwBaEzZzqtl0e9eIWl6ewqcF3ZIcAvbZvOvI+CIDWmUvqtJLCR4QmZTMP22w+F/GhGB3oGccZzitJq9XmBTlWkV/VeY1tSEjlgGLKcIogdLiI85kXUHosI25qheSCnEDYohYhcnFYOv93KNnRNnvNhhlC5zlTdRcS7CVf/6EFtRHgq2GURa+rLHs3eV32m3uhiXKZqQGJowW2XXK0XNP5j2g==", "X-Forefront-Antispam-Report-Untrusted": "CIP:255.255.255.255; CTRY:; LANG:en;\n SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0802MB2216.eurprd08.prod.outlook.com;\n PTR:; CAT:NONE; SFTY:;\n SFS:(4636009)(376002)(136003)(396003)(366004)(346002)(39860400002)(316002)(9686003)(86362001)(8936002)(6506007)(55016002)(7696005)(71200400001)(186003)(4326008)(66946007)(66556008)(64756008)(66446008)(110136005)(52536014)(5660300002)(76116006)(2906002)(54906003)(8676002)(26005)(478600001)(66476007)(33656002)(83380400001);\n DIR:OUT; SFP:1101;", "x-ms-exchange-antispam-messagedata": "\n vnCPdp8UoH/EkrsQPmsJGyyFLmAlIr4sJdE7AZ7TsYILsodZRBpLwbIWiPPaVJJ4Qgi0YMUhYwPvV17lccw3n5bUL4i2w7er+Sy2647FH2gEnm0kGE6e0vuw0ATSzK0Qs2IHnKIFpfCZgx22JOJ3KQfzYGuERNt8MXxvaBNDZuxlAlsEPyNOMEko5zgKTtTA5z9nU48b79fmZuEFe+4aAvAIKcy163thc4OdSIwWfODa7zFXOKNBwrt3+utND/lUMd/Wx1dQvSfsaSeZmHqiH4VQ0idUMGVz3is7re3JWz2UEtryCUl1u41T5mcu4Qi90PB/9LpMCJEDr3A/LKYTNpjW9Y3nv0ZJmKje4OezvdmlYJwQ8n1gEVCz5fBFArDNnIVfsS3ppR3Uz++iBlm5lzf8zl31OIo+l9EVAMTeF1zN26RXnH/Tj0en3KVDkE2URuQ/YTpg6I2pDpZfBRBJku0NqPZJNmK9U20vmfB/ZEF5NyxhYzqyK+ZYNrvr8Fhf", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": [ "DB8PR08MB4105", "AM0PR08MB3380" ], "Original-Authentication-Results": "intel.com; dkim=none (message not signed)\n header.d=none;intel.com; dmarc=none action=none header.from=arm.com;", "X-EOPAttributedMessage": "0", "X-MS-Exchange-Transport-CrossTenantHeadersStripped": "\n VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com", "X-MS-Office365-Filtering-Correlation-Id-Prvs": "\n 01b6c1bf-e38e-4c2f-ce79-08d82e87df80", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n huEfaDtlj5j69Vgi38j4+6LEM66R1khb5LYG7BDh+t6XObx8mHHvc8LhcNPsPtUlGa87xQ6IldSYZ7X/j4oL5fDoMCcasuj350UC0QdxK6StrjvHbZGnC3MCzwlj0jh9oZoXMZM1RXN4SamqzDqqekOk7GGvtUdEMYUmEn4e2kdvMmw/b2zUCppgQrli7N08zkBPLQ3gAODnGRNbWgq0mnMZjFVXgTYCzhh6yMz0/i1yxmsabpB++yr2EIwUvpArpqm4jOaG/xzucazCcc0H9C10t8fNj+ddwIMyeB2PV2vsGCFpqCcx/6DnAj1lrAJK1OETkCl+r16JedDQV8teZKqG4NiVzx5GCjkh0AVLbqIyOolwJyJJC957zL6ewkGAmF9LbJzQwqUqcPN63uJWvw==", "X-Forefront-Antispam-Report": "CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com;\n PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:;\n SFS:(4636009)(396003)(376002)(136003)(346002)(39860400002)(46966005)(6506007)(186003)(36906005)(336012)(4326008)(316002)(26005)(8936002)(55016002)(9686003)(110136005)(33656002)(478600001)(2906002)(54906003)(86362001)(5660300002)(52536014)(70206006)(8676002)(70586007)(7696005)(82740400003)(47076004)(83380400001)(81166007)(82310400002)(356005);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "arm.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "22 Jul 2020 21:40:45.3078 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n fa2b0081-ba6d-404c-2c53-08d82e87e40f", "X-MS-Exchange-CrossTenant-Id": "f34e5979-57d9-4aaa-ad4d-b122a662184d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123];\n Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "Subject": "Re: [dpdk-dev] [PATCH v3 2/2] test/service: fix race condition on\n\tstopping lcore", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]