Patch Comment List
List patch comments
GET /api/patches/74611/comments/?format=api
[ { "id": 116537, "web_url": "https://patches.dpdk.org/comment/116537/", "msgid": "<AM0PR05MB6707654670B0BC05013494F2C2760@AM0PR05MB6707.eurprd05.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/AM0PR05MB6707654670B0BC05013494F2C2760@AM0PR05MB6707.eurprd05.prod.outlook.com", "date": "2020-07-23T08:57:26", "subject": "Re: [dpdk-dev] [PATCH] net/mlx5: fix VF MAC address set over\n Bluefield", "submitter": { "id": 513, "url": "https://patches.dpdk.org/api/people/513/?format=api", "name": "Raslan Darawsheh", "email": "rasland@mellanox.com" }, "content": "Hi,\n\n> -----Original Message-----\n> From: dev <dev-bounces@dpdk.org> On Behalf Of Raslan Darawsheh\n> Sent: Wednesday, July 22, 2020 12:08 PM\n> To: dev@dpdk.org\n> Cc: stable@dpdk.org; Slava Ovsiienko <viacheslavo@mellanox.com>\n> Subject: [dpdk-dev] [PATCH] net/mlx5: fix VF MAC address set over Bluefield\n> \n> When trying to set MAC address of an ethethet device and if it was\n> a representor, PMD sets the MAC over the corresponding VF instead.\n> \n> For the case of HPF (Host PF representor on BluueField), PMD shouldn't\n> attempt to set it, since it doesn't have any corresponding VF and fails.\n> \n> This will fix the issue by setting the MAC on the dev directly.\n> \n> Fixes: 0d1d73170820 (\"net/mlx5: set VF MAC address from host\")\n> Cc: stable@dpdk.org\n> \n> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>\n> Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n> ---\n> drivers/net/mlx5/mlx5_mac.c | 7 +++++--\n> 1 file changed, 5 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/net/mlx5/mlx5_mac.c b/drivers/net/mlx5/mlx5_mac.c\n> index 2d808d629..c75b1a169 100644\n> --- a/drivers/net/mlx5/mlx5_mac.c\n> +++ b/drivers/net/mlx5/mlx5_mac.c\n> @@ -157,8 +157,11 @@ mlx5_mac_addr_set(struct rte_eth_dev *dev, struct\n> rte_ether_addr *mac_addr)\n> \tuint16_t port_id;\n> \tstruct mlx5_priv *priv = dev->data->dev_private;\n> \n> -\t/* Configuring the VF instead of its representor. */\n> -\tif (priv->representor) {\n> +\t/*\n> +\t * Configuring the VF instead of its representor,\n> +\t * need to skip the special case of HPF on Bluefield.\n> +\t */\n> +\tif (priv->representor && priv->representor >= 0) {\n> \t\tDRV_LOG(DEBUG, \"VF represented by port %u setting\n> primary MAC address\",\n> \t\t\tdev->data->port_id);\n> \t\tRTE_ETH_FOREACH_DEV_SIBLING(port_id, dev->data-\n> >port_id) {\n> --\n> 2.27.0\n\n\nPatch applied to next-net-mlx,\n\nKindest regards,\nRaslan Darawsheh", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 34229A053D;\n\tThu, 23 Jul 2020 10:57:33 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CFFFD1BF94;\n\tThu, 23 Jul 2020 10:57:31 +0200 (CEST)", "from EUR05-DB8-obe.outbound.protection.outlook.com\n (mail-db8eur05on2056.outbound.protection.outlook.com [40.107.20.56])\n by dpdk.org (Postfix) with ESMTP id 9C5471BE9A;\n Thu, 23 Jul 2020 10:57:29 +0200 (CEST)", "from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17)\n by AM0PR05MB4402.eurprd05.prod.outlook.com (2603:10a6:208:5c::31)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.24; Thu, 23 Jul\n 2020 08:57:26 +0000", "from AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.028; Thu, 23 Jul 2020\n 08:57:26 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=OkQPd4DnH/XE7si6Jxldm9nCnqw7/el1lqLoP2z67xjOmitYp9xzDsG3ucdM++H/GVNfWq+28u8qMmfOnr6ZdW1Us+FFsc58fLZodALwIjb3wD/5WRi8LincDUeuQWhhcSL4KM2KaqEHZXqGxmKX6eoTpHYWbeN4haZxkPLJpmM9jJzAQLBaYWuqpTu00fQnTcooT9JLZzCz+jHdmqBbYd66zNcO2cTnj76fg1LYeB7ylxA3vZ4BzxfhOlDvQFurwIv+M8rUoX1nwMCxGisSvyf4nWDb43UnPzJHQVCq07MXXOLCR6o5U/UZSjjGvQD/yjv9wIRtiX2H4GYATgvk4g==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=oTAW4xB/BMollCfcjL7TrNam93tiqm2gVXD9xe6gvzQ=;\n b=Yc9XGCcKRYi3oQwTnU+KyDDE0+lcxbiSjfGlSMfO+x2rQF465YojvaMwUJLPmmM/paUgJqwtSE8PNpK52ePzIcXgUMSTF+UxCiQL2cBxQTzSbsOOB5+wW6K/psrpjS44kW3CR1ussvVbbuRnYa2XOXZShw0mqQJeDF6Rm30+EImhKduKElL5j2aYd2TceQKMvzdlP/ti88jq5MtT7/MYeoRzGzekCgFsugjoegXSsoJ5JMiT8GQl4Db+7LD+BqTh3sOz/Fq+ierqSZ2xOXSOcxHAylX+IWHDtdYrsZlEaKG8SV7euyVZKJ0h1b7/HW/Iz3tW9i62Td4XOzzcvkwalw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=oTAW4xB/BMollCfcjL7TrNam93tiqm2gVXD9xe6gvzQ=;\n b=iW1flUoakuoA8REBQte04+35WPPAA4JoL2QcPIQc7/RHKd7V7wuAyM3WJtjlbZyP1zOcxfINoftlgBRX9B2etBgExnkirlFyXvbFgvizJjaCNmnH8UGiE25OHQAIuXpLYilbavzPMXkoLqHeHnX7jPsQCBO1yVFj7OaibbXGlbc=", "From": "Raslan Darawsheh <rasland@mellanox.com>", "To": "Raslan Darawsheh <rasland@mellanox.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"stable@dpdk.org\" <stable@dpdk.org>, Slava Ovsiienko\n <viacheslavo@mellanox.com>", "Thread-Topic": "[dpdk-dev] [PATCH] net/mlx5: fix VF MAC address set over\n Bluefield", "Thread-Index": "AQHWYAee2/nsNo2AQU6ZatqaJZBWqakU3gjA", "Date": "Thu, 23 Jul 2020 08:57:26 +0000", "Message-ID": "\n <AM0PR05MB6707654670B0BC05013494F2C2760@AM0PR05MB6707.eurprd05.prod.outlook.com>", "References": "<20200722090755.26103-1-rasland@mellanox.com>", "In-Reply-To": "<20200722090755.26103-1-rasland@mellanox.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "mellanox.com; dkim=none (message not signed)\n header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com;", "x-originating-ip": "[84.242.49.134]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-ht": "Tenant", "x-ms-office365-filtering-correlation-id": "4a2bb748-1047-448d-383f-08d82ee66c0c", "x-ms-traffictypediagnostic": "AM0PR05MB4402:", "x-ld-processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <AM0PR05MB440206FA880027D1510AE4A3C2760@AM0PR05MB4402.eurprd05.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:1923;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n q9/IVt6f9OvbWnmAksadHE/lQ42ckFC1duyT/KXblFItGqnvtFAmRIvRBCwjVNBIQDCHvAJjPvFeHU0+umX+TGcVQuDVLtVNa8SqSMPJMqFev678xCxxQabRXINMbcUsSfds+PY9Z5ONszVgVExyeWEVxq/oePGK8Y0Sl+xsJmA5Sn2DQ9IcnYlPKcetj9D41jRhSmC4tkhsCT77xIk5rAZi6KL326BlALOB9kKhxYOjLyExuYUETCAqHHkH6zWqC7lvTjrEHBfYFr+zwdBUHwRlPbiEdNDjkOa2g4JaPw46Q2ZqT0bbspyAFdA3KH/Q2fi7Cy/tyxgpC68MF9Pvzg==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(366004)(136003)(396003)(376002)(346002)(39860400002)(107886003)(110136005)(5660300002)(316002)(54906003)(8676002)(9686003)(66446008)(66946007)(8936002)(66476007)(450100002)(64756008)(66556008)(76116006)(55016002)(4326008)(7696005)(33656002)(26005)(2906002)(186003)(478600001)(53546011)(6506007)(86362001)(52536014)(83380400001)(71200400001);\n DIR:OUT; SFP:1101;", "x-ms-exchange-antispam-messagedata": "\n 4gXkqZ5FpRskl1pizpjpgpBzKM44IZW4f117TK+GO0izlcJONsRHgh4F568KFRva4IUvGciaRbeolRKvFCOFcuhLAeikrVtwQ1q53m8k8T9KUXbL7qP5se0a6tTRIL+AV7NkmAISMWePEW3IR3mnadhGI+quJ2aJZ2B0ir8ab2XypGwIPmwhOrBhtBTpNwlZtpFMuvN2nLhzii4dhkzkfSGc45B0NHdVhD3Q1U4KGoOSKTgn2IEUf3dbq9xXjrqvafFffDD1Pxbiml6aerZ3DWhvYvJ+VqAWxAhgL6Pk/UTVfxmBurIpuh1RbG+HjBWE91dRQIiJIg9QLXwnKB9/MQWsrChoEKBpTQQ2lM9zZSW/tc170HWlGxQ5hzVhN6apAD5nouMREWckFF9FgzG31AgbNwUAhptH4BzRp0hUUwbN9/ula/5FIj+D1XozcaZ+Aji33Igf/mmxVDF9+QNBQPrBiF9el4m+x3IIliMmm5tv3nTlYXR+GQOERbppDM0Z", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB6707.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 4a2bb748-1047-448d-383f-08d82ee66c0c", "X-MS-Exchange-CrossTenant-originalarrivaltime": "23 Jul 2020 08:57:26.0990 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n KwuYwGd33oUbwEiem/T9xpH+ngt9cZL9VV1AqdodSBcIQ6AOGICXXNneY2NXk8LOxH2GX5s6AufMdktYZaItRw==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR05MB4402", "Subject": "Re: [dpdk-dev] [PATCH] net/mlx5: fix VF MAC address set over\n Bluefield", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116541, "web_url": "https://patches.dpdk.org/comment/116541/", "msgid": "<a2cbf48f-5188-691c-600b-1f72a1e18250@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/a2cbf48f-5188-691c-600b-1f72a1e18250@intel.com", "date": "2020-07-23T10:43:47", "subject": "Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix VF MAC address\n set over Bluefield", "submitter": { "id": 324, "url": "https://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "content": "On 7/22/2020 10:07 AM, Raslan Darawsheh wrote:\n> When trying to set MAC address of an ethethet device and if it was\n> a representor, PMD sets the MAC over the corresponding VF instead.\n> \n> For the case of HPF (Host PF representor on BluueField), PMD shouldn't\n> attempt to set it, since it doesn't have any corresponding VF and fails.\n> \n> This will fix the issue by setting the MAC on the dev directly.\n> \n> Fixes: 0d1d73170820 (\"net/mlx5: set VF MAC address from host\")\n> Cc: stable@dpdk.org\n> \n> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>\n> Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n> ---\n> drivers/net/mlx5/mlx5_mac.c | 7 +++++--\n> 1 file changed, 5 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/net/mlx5/mlx5_mac.c b/drivers/net/mlx5/mlx5_mac.c\n> index 2d808d629..c75b1a169 100644\n> --- a/drivers/net/mlx5/mlx5_mac.c\n> +++ b/drivers/net/mlx5/mlx5_mac.c\n> @@ -157,8 +157,11 @@ mlx5_mac_addr_set(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr)\n> \tuint16_t port_id;\n> \tstruct mlx5_priv *priv = dev->data->dev_private;\n> \n> -\t/* Configuring the VF instead of its representor. */\n> -\tif (priv->representor) {\n> +\t/*\n> +\t * Configuring the VF instead of its representor,\n> +\t * need to skip the special case of HPF on Bluefield.\n> +\t */\n> +\tif (priv->representor && priv->representor >= 0) {\n\n\n'priv->representor' is 1 bit size bitfield (unsigned int representor:1), what is\nthe point of additional \">=0\" check?\nCan it be \"representor_id >= 0\" by any chance?", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 290C6A0521;\n\tThu, 23 Jul 2020 12:43:57 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BB8F81BF7B;\n\tThu, 23 Jul 2020 12:43:55 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id 6EB631BE90;\n Thu, 23 Jul 2020 12:43:54 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Jul 2020 03:43:52 -0700", "from fyigit-mobl.ger.corp.intel.com (HELO [10.213.221.45])\n ([10.213.221.45])\n by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Jul 2020 03:43:51 -0700" ], "IronPort-SDR": [ "\n LaQTw9jBRuDDoO1+dDZA2FWJXzSpCG9paEA67lb9uq5jmhzvOt1cLtC/NEc+9o5LhVJBVXEdV9\n jK4Nx6TlqlDQ==", "\n nHUXyKKHMhtoYsLIzcLPpLt7eBAz/gjJ4JnpfBcwOoWOKg8Rw52BPoe4JVjXM+foLriJI/xnAs\n Ucl1WsHq2TyQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9690\"; a=\"151805662\"", "E=Sophos;i=\"5.75,386,1589266800\"; d=\"scan'208\";a=\"151805662\"", "E=Sophos;i=\"5.75,386,1589266800\"; d=\"scan'208\";a=\"462800305\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "To": "Raslan Darawsheh <rasland@mellanox.com>, dev@dpdk.org", "Cc": "stable@dpdk.org, Viacheslav Ovsiienko <viacheslavo@mellanox.com>", "References": "<20200722090755.26103-1-rasland@mellanox.com>", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "Autocrypt": "addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata=\n mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy\n qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ\n +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9\n GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb\n +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF\n YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy\n ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX\n CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1\n 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz\n cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln\n aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK\n CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl\n eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk\n UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT\n PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO\n lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC\n ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2\n 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H\n 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo\n cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx\n Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp\n e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59\n gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES\n YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai\n bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD\n UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/\n 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj\n sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc\n q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7\n 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB\n VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI\n 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC\n GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b\n cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz\n EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H\n o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2\n 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA\n WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA\n 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T\n GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n\n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv\n ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae\n dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ==", "Message-ID": "<a2cbf48f-5188-691c-600b-1f72a1e18250@intel.com>", "Date": "Thu, 23 Jul 2020 11:43:47 +0100", "MIME-Version": "1.0", "In-Reply-To": "<20200722090755.26103-1-rasland@mellanox.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "8bit", "Subject": "Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix VF MAC address\n set over Bluefield", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116542, "web_url": "https://patches.dpdk.org/comment/116542/", "msgid": "<AM0PR05MB6707E3063B33DB6EBEA9EDDAC2760@AM0PR05MB6707.eurprd05.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/AM0PR05MB6707E3063B33DB6EBEA9EDDAC2760@AM0PR05MB6707.eurprd05.prod.outlook.com", "date": "2020-07-23T10:55:35", "subject": "Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix VF MAC address\n set over Bluefield", "submitter": { "id": 513, "url": "https://patches.dpdk.org/api/people/513/?format=api", "name": "Raslan Darawsheh", "email": "rasland@mellanox.com" }, "content": "Hi,\n\n> -----Original Message-----\n> From: Ferruh Yigit <ferruh.yigit@intel.com>\n> Sent: Thursday, July 23, 2020 1:44 PM\n> To: Raslan Darawsheh <rasland@mellanox.com>; dev@dpdk.org\n> Cc: stable@dpdk.org; Slava Ovsiienko <viacheslavo@mellanox.com>\n> Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix VF MAC address set over\n> Bluefield\n> \n> On 7/22/2020 10:07 AM, Raslan Darawsheh wrote:\n> > When trying to set MAC address of an ethethet device and if it was\n> > a representor, PMD sets the MAC over the corresponding VF instead.\n> >\n> > For the case of HPF (Host PF representor on BluueField), PMD shouldn't\n> > attempt to set it, since it doesn't have any corresponding VF and fails.\n> >\n> > This will fix the issue by setting the MAC on the dev directly.\n> >\n> > Fixes: 0d1d73170820 (\"net/mlx5: set VF MAC address from host\")\n> > Cc: stable@dpdk.org\n> >\n> > Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>\n> > Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n> > ---\n> > drivers/net/mlx5/mlx5_mac.c | 7 +++++--\n> > 1 file changed, 5 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/drivers/net/mlx5/mlx5_mac.c b/drivers/net/mlx5/mlx5_mac.c\n> > index 2d808d629..c75b1a169 100644\n> > --- a/drivers/net/mlx5/mlx5_mac.c\n> > +++ b/drivers/net/mlx5/mlx5_mac.c\n> > @@ -157,8 +157,11 @@ mlx5_mac_addr_set(struct rte_eth_dev *dev,\n> struct rte_ether_addr *mac_addr)\n> > \tuint16_t port_id;\n> > \tstruct mlx5_priv *priv = dev->data->dev_private;\n> >\n> > -\t/* Configuring the VF instead of its representor. */\n> > -\tif (priv->representor) {\n> > +\t/*\n> > +\t * Configuring the VF instead of its representor,\n> > +\t * need to skip the special case of HPF on Bluefield.\n> > +\t */\n> > +\tif (priv->representor && priv->representor >= 0) {\n> \n> \n> 'priv->representor' is 1 bit size bitfield (unsigned int representor:1), what is\n> the point of additional \">=0\" check?\n> Can it be \"representor_id >= 0\" by any chance?\nYes it should be representor_id >= 0, will fix \n\nKindest regards\nRaslan Darawsheh", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6FC2EA0521;\n\tThu, 23 Jul 2020 12:55:43 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3D8841BFD7;\n\tThu, 23 Jul 2020 12:55:42 +0200 (CEST)", "from EUR02-HE1-obe.outbound.protection.outlook.com\n (mail-eopbgr10047.outbound.protection.outlook.com [40.107.1.47])\n by dpdk.org (Postfix) with ESMTP id B592B1BE90;\n Thu, 23 Jul 2020 12:55:40 +0200 (CEST)", "from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17)\n by AM4PR0501MB2722.eurprd05.prod.outlook.com (2603:10a6:200:5a::19)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.24; Thu, 23 Jul\n 2020 10:55:35 +0000", "from AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.028; Thu, 23 Jul 2020\n 10:55:35 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=S/1LeoFsR6Z/QsD33ER4032YiiUYxWccNCXiI/v2LxQ9adoQXBAoq7CQaYIOfxYdb1gDOddOZK+5QYXtgMcpE4uy08pq3/G5X1DdWU7ACB5UXPJ5BSmKJVYKdEM9KKzvsqJk8bFjbMPghh0TnZw5OHifi61DalPl97ZSe5cV2tU1wA21on9O3n6ho07FfKaeBdwqtxWNzCnIR7HdpNUPxgdYocNyOMjqbjR3qBymwSEVzkdFf3lLJYVmtmQuQzz36qYgQSGxVUTgkQqRddZGi+Q5I0K2S4TTT4r7E8gtVQYlM8DX+pFCP+XQ6KuMtDgocCCOOOxXAfOZSCxkdJ70hw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=DdXnJXg68/ntLlB+R7jdX5PRrP/MoAbEjMB8wUGMWOs=;\n b=VBd9bGhq66TcbecXxa84SHfKwGool0Wa0mV8DFcxRINUKCkgeJiOFFzO0O/8lQy4X4YuTTqIKg3PD/8zXwyCjexAEq6YzzLhwKk6+2Rx1ecSuVfGFAvFLdzJDtpfqSAVreOBpHoJFVe3mSKE4/OeQQzj2+ux/nheH9p5JcDAWSazA8x6Ue+P4sGqrtjrYMEc7vB1qAvh6j+64+lsFrTtDPUB2CR2wtrjfb9PlRw4vqY77JME0YiCZGnlM1QcvjAM7zkGiA+E77A3AikwItJgqdkQxhKoRDdMw9wdR7N/gLQwTDGMSCK/tcAoFOSbwTEr2Admc9490htQPHT5RmC/eQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=DdXnJXg68/ntLlB+R7jdX5PRrP/MoAbEjMB8wUGMWOs=;\n b=j07Pp20gNAnTm5N3UAkupyU3Ts2Frum2l3jqxgGhlDnYziBj7V055DrNElKVBjuFt3g2Ih9niKDfFDfBUgVIqStnerBGcfXm1f44qdL57F2oWppmD4oaIh1fk8q1lScEjdTqEoLlDLIpmOhrvOP+Je6cH1R3e0t7kvLEO5mQa6o=", "From": "Raslan Darawsheh <rasland@mellanox.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"stable@dpdk.org\" <stable@dpdk.org>, Slava Ovsiienko\n <viacheslavo@mellanox.com>", "Thread-Topic": "[dpdk-stable] [PATCH] net/mlx5: fix VF MAC address set over\n Bluefield", "Thread-Index": "AQHWYAee2/nsNo2AQU6ZatqaJZBWqakU/DqAgAADG4A=", "Date": "Thu, 23 Jul 2020 10:55:35 +0000", "Message-ID": "\n <AM0PR05MB6707E3063B33DB6EBEA9EDDAC2760@AM0PR05MB6707.eurprd05.prod.outlook.com>", "References": "<20200722090755.26103-1-rasland@mellanox.com>\n <a2cbf48f-5188-691c-600b-1f72a1e18250@intel.com>", "In-Reply-To": "<a2cbf48f-5188-691c-600b-1f72a1e18250@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "intel.com; dkim=none (message not signed)\n header.d=none;intel.com; dmarc=none action=none header.from=mellanox.com;", "x-originating-ip": "[84.242.49.134]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-ht": "Tenant", "x-ms-office365-filtering-correlation-id": "dfc7ce38-2279-4a9d-42f7-08d82ef6ed6c", "x-ms-traffictypediagnostic": "AM4PR0501MB2722:", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <AM4PR0501MB2722251EF3F5472836E3F890C2760@AM4PR0501MB2722.eurprd05.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:1728;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n k/TzzXAlEnmnSAhM81eHnV2NNho2jN6RXNwOyv7VyQFRWH3tL233Qo0cXFJNfuV79GTDXPM6IPWA0+OW00Rqnat89/DXoM8EqikOaBPKvtY8G9CzQwVTOTeP4omQxIqaOYXg1g0Uh02ELJRZZE7iGg9tOGISq9CwIeuumzCuqDxTu2f3uWVlPF7MUgiBueFc7ZoRIMj8Df8Lej1SuDn+GirB3d8e8o21SZiIj/7KmRiIGuvkE83WJPFNzPzKIS88nK9nvAkheeRLG6XOlT0RNZyimamIDhQAlH6ilFhH+hrR8DakhUvLIwynDXVhb4mtS/V5hqRwPylcvGMELcdO7w==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(376002)(346002)(39860400002)(136003)(396003)(366004)(55016002)(478600001)(86362001)(8676002)(9686003)(8936002)(4326008)(186003)(110136005)(7696005)(83380400001)(53546011)(33656002)(6506007)(76116006)(66476007)(54906003)(66556008)(66446008)(64756008)(71200400001)(66946007)(26005)(316002)(52536014)(2906002)(5660300002)(107886003);\n DIR:OUT; SFP:1101;", "x-ms-exchange-antispam-messagedata": "\n 03Zs5JPIdnL/PxXwAJSmumi2UFiTTJpgOUjp3WrHOnBkXdXpNTfLdxxTN/5PPwHIih3W2Meuc+mNq41QK9g3sTPrVssyCclxWbgt38QLFdSFHaYCMzU5pYYTT3fTzXdh5QORLzRHKEuyBKVHhlkelL3cgpiBlcsAcrHKi+vDmU5ynMsQ0+tD4YaQuKd8G3pXaIXouxuGRMb6UoWCNOjcz8VU+Bn48jfLu5iSb3hH31nJnw8tRvXu9gBFTtavtPqauR/ByQf0dEppO99mLga9MmLAt+vsoCowcyjWJMHud5+KL3+LLnhDQ0GDCgOjb59lCv9ruG/yRsp8srXBEaeWx2n3Mqvsr93GrVTJMataZMeLPI0cUu0H9Kd54SMmeUfuF6Q1OH+S6x/aG8RJVHJHx2DgT66E9P4yUtKr05NEc6JkSQULBUHWQmrld+v11P8+cYR91QXGYEIL55YGbbNbhz8UuLad1Owdm2j+gdRPiHbSzbPg/5Px7STpluce/O89", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB6707.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n dfc7ce38-2279-4a9d-42f7-08d82ef6ed6c", "X-MS-Exchange-CrossTenant-originalarrivaltime": "23 Jul 2020 10:55:35.1947 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n Y1Skrh82KYkAT5UEVQzLEarZDKgvBecqmzzXRWtrSx3qwgelawiJEvCmgc7dwYbpOstJ0spO453rekc3ZwrEAQ==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM4PR0501MB2722", "Subject": "Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix VF MAC address\n set over Bluefield", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]