Patch Comment List
List patch comments
GET /api/patches/74610/comments/?format=api&order=-date
[ { "id": 116565, "web_url": "https://patches.dpdk.org/comment/116565/", "msgid": "<BYAPR11MB3477A02730D77D5AC29B4E6088770@BYAPR11MB3477.namprd11.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/BYAPR11MB3477A02730D77D5AC29B4E6088770@BYAPR11MB3477.namprd11.prod.outlook.com", "date": "2020-07-24T02:34:41", "subject": "Re: [dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look up table", "submitter": { "id": 1418, "url": "https://patches.dpdk.org/api/people/1418/?format=api", "name": "Shougang Wang", "email": "shougangx.wang@intel.com" }, "content": "> -----Original Message-----\n> From: Zhang, Qi Z <qi.z.zhang@intel.com>\n> Sent: Thursday, July 23, 2020 8:53 PM\n> To: Yang, Qiming <qiming.yang@intel.com>; Wang, ShougangX\n> <shougangx.wang@intel.com>; dev@dpdk.org\n> Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>; Wang,\n> ShougangX <shougangx.wang@intel.com>; stable@dpdk.org\n> Subject: RE: [dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look up table\n> \n> \n> \n> > -----Original Message-----\n> > From: dev <dev-bounces@dpdk.org> On Behalf Of Yang, Qiming\n> > Sent: Thursday, July 23, 2020 9:57 AM\n> > To: Wang, ShougangX <shougangx.wang@intel.com>; dev@dpdk.org\n> > Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia\n> > <jia.guo@intel.com>; Wang, ShougangX <shougangx.wang@intel.com>;\n> > stable@dpdk.org\n> > Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look\n> > up table\n> >\n> > I don't understand why you add new function and new function mostly do\n> > the same thing.\n> > Why don't add fix in original code.\n> >\n<snip>\n> > > static int\n> > > i40e_pf_config_mq_rx(struct i40e_pf *pf) {\n> > > -\tint ret = 0;\n> > > +\tint ret;\n> > > \tenum rte_eth_rx_mq_mode mq_mode = pf->dev_data-\n> > > >dev_conf.rxmode.mq_mode;\n> > >\n> > > +\t/* Initialize hash look up table */\n> > > +\tret = i40e_pf_init_rss_lut(pf);\n> > > +\tif (ret)\n> > > +\t\treturn ret;\n> > > +\n> > > \t/* RSS setup */\n> > > \tif (mq_mode & ETH_MQ_RX_RSS_FLAG)\n> \n> I agree with Qiming, if we move this check into i40e_pf_config_rss, dose that\n> looks we don't need to create a new function?\nIndeed, I will do like this.\n> \n> > > \t\tret = i40e_pf_config_rss(pf);\n> > > --\n> > > 2.17.1\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A29D7A0518;\n\tFri, 24 Jul 2020 04:34:49 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4952D1D5F7;\n\tFri, 24 Jul 2020 04:34:49 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id AB5511D5F6;\n Fri, 24 Jul 2020 04:34:47 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Jul 2020 19:34:46 -0700", "from orsmsx601.amr.corp.intel.com ([10.22.229.14])\n by fmsmga002.fm.intel.com with ESMTP; 23 Jul 2020 19:34:46 -0700", "from orsmsx604.amr.corp.intel.com (10.22.229.17) by\n ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.1713.5; Thu, 23 Jul 2020 19:34:45 -0700", "from ORSEDG001.ED.cps.intel.com (10.7.248.4) by\n orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5\n via Frontend Transport; Thu, 23 Jul 2020 19:34:45 -0700", "from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.52) by\n edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server\n (TLS) id 14.3.439.0; Thu, 23 Jul 2020 19:34:44 -0700", "from BYAPR11MB3477.namprd11.prod.outlook.com (2603:10b6:a03:7c::28)\n by BY5PR11MB4104.namprd11.prod.outlook.com (2603:10b6:a03:18f::12)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Fri, 24 Jul\n 2020 02:34:41 +0000", "from BYAPR11MB3477.namprd11.prod.outlook.com\n ([fe80::11b9:abd9:39e0:f26a]) by BYAPR11MB3477.namprd11.prod.outlook.com\n ([fe80::11b9:abd9:39e0:f26a%3]) with mapi id 15.20.3195.025; Fri, 24 Jul 2020\n 02:34:41 +0000" ], "IronPort-SDR": [ "\n 1PsdF0vBolujCFBEJ9/76NTE6pl0Y6Vse1JNKOo7R8Gaz5j2u6Jg9eLO21W2pJ/O4tSEvA2zqH\n 09K5CmgjliOQ==", "\n HZV+/Y1lUfdOEGpSrmW6dymX/KBYEGfpZXw5fi6rFRNkQV4EO0xVLTRhVBCKbQMgZNnWvipkry\n DomGUKJL2hrA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9691\"; a=\"138149301\"", "E=Sophos;i=\"5.75,389,1589266800\"; d=\"scan'208\";a=\"138149301\"", "E=Sophos;i=\"5.75,389,1589266800\"; d=\"scan'208\";a=\"320865893\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=gzSsGe+ca4qoaT7jkMwu1aLRh+SF/h8btTqlqbl0shVk8ZYWuI2Wqqki/2dd0wPGnwoU0UcqGyANaSv0S2vxUj5nW8v+jeiD+2JwjM1yxk4UfgrG1a2gYGddQ5ig7f1EEdFbCJO0r/PalL34l0Fi0ety5U1DaJ1xMnpuDxDV+GYiGCBjQvje+hLmt6JEA2NVjHKYsYz67LEXNPKhOPhYpUHLt6YeTzOidYqmOn0Gvl0d8hhv536/N3cuk5dBL9tiGkiDpTjseCxkh+Y2dDwLkceBms8ms0APwovcncHCqUyrKh3V+YzYieU8GAlT2Sb2lPzyuOh7vHeh2FuwkcQIhQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=3Jo+x90FsE5X3FTIE9B2apcwEOIVyVII4t9GkN51ikI=;\n b=Kr1ZZJ2SThkDfNcq0R4ix+NwpZgOZRoXhjdR5yvItixtrR1fDK4LPXA/2YHAvr7S7mk5ODggPCB4kE1STzbc1ZGbAO7nvkj1iJeM3SHq1nRd7FqtH9nFMg1Yua+SEdDcb5imCS/XnR/hQaUq8fiRJeULn5G/A/d3YIoUAtM2dhYmLrFK49x5U0+An4s9/7Ue8xsT21ZCW8KNFgVvgG9Yp/miBuKERhQseUauVuGB9gJ1cohlZF5bCppCrwFxkT6VsHDHxIjeDm8tQq8d6ZepWvJk1mA2ltfO3UB5+l0CoX7z3XC1ig4O4Hv/Odw8U3TEfAf0beyhLQr3RfC/oij54Q==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;\n s=selector2-intel-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=3Jo+x90FsE5X3FTIE9B2apcwEOIVyVII4t9GkN51ikI=;\n b=qywjOQD7zoqA1cMofbHmVwfkqOQBYnwmo306SnydE5tuTautJc5TUPToDmKRsHHVhw2CyMznQfgQhrPqRzTjR7yHgN8RpkwCQLUKZTUINSGT7QWrxzChYrO1nJaqura6vRwNk9EtVp83fnjNB8+9G8gSua6OzdZBhtYNgm6RxZU=", "From": "\"Wang, ShougangX\" <shougangx.wang@intel.com>", "To": "\"Zhang, Qi Z\" <qi.z.zhang@intel.com>, \"Yang, Qiming\"\n <qiming.yang@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"Xing, Beilei\" <beilei.xing@intel.com>, \"Guo, Jia\" <jia.guo@intel.com>,\n \"stable@dpdk.org\" <stable@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look up table", "Thread-Index": "AQHWYALKaaCtjgyuVU6tPDq42bQ4mKkUaRmAgAC3YICAAOIScA==", "Date": "Fri, 24 Jul 2020 02:34:41 +0000", "Message-ID": "\n <BYAPR11MB3477A02730D77D5AC29B4E6088770@BYAPR11MB3477.namprd11.prod.outlook.com>", "References": "<20200715063515.9262-1-shougangx.wang@intel.com>\n <20200722081543.52396-1-shougangx.wang@intel.com>\n <BN6PR11MB0017E2387CBB71123F8F74DFE5760@BN6PR11MB0017.namprd11.prod.outlook.com>\n <039ED4275CED7440929022BC67E7061154864F86@SHSMSX103.ccr.corp.intel.com>", "In-Reply-To": "\n <039ED4275CED7440929022BC67E7061154864F86@SHSMSX103.ccr.corp.intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "intel.com; dkim=none (message not signed)\n header.d=none;intel.com; dmarc=none action=none header.from=intel.com;", "x-originating-ip": "[192.55.46.46]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "82f77296-559a-4189-e083-08d82f7a1e84", "x-ms-traffictypediagnostic": "BY5PR11MB4104:", "x-ld-processed": "46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <BY5PR11MB410458D552B75CF5B207D69188770@BY5PR11MB4104.namprd11.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:2449;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n Vz75K40QQHk0/OBpy+XiJmUKh3o8wO0ie+XAEOE4N5GI2TIbcLl06ZxPJ/4XO2yMPLixcyagqbrKOlg20f/IAiMYWklgfKgr17D8WSrfnkOiXCXOZmyuB9vruYkA9y4kUpsoHyNqzycG1vUicF0sJnss93TRMibSdCq2H60PeLQv9jEabH0kTdduXYlBzLBo+xNt2lvQd5OV6XdihUOTLcwUpKgpP6xXmM5fxfx4+4rTnU4g1eD7k3U1iFWQJPn4WLk3mtPKDXPuwcPHbSd1/s3NewlZDQPDcnlH7qTaooVtBo3o0K4btOxjiaHDe9wcw+pGsxjVTkcYH8jJjA33vg==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:BYAPR11MB3477.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(39860400002)(366004)(136003)(346002)(396003)(376002)(66476007)(64756008)(66556008)(450100002)(66446008)(478600001)(83380400001)(53546011)(186003)(8676002)(5660300002)(9686003)(33656002)(6506007)(110136005)(2906002)(52536014)(4326008)(7696005)(55016002)(71200400001)(54906003)(66946007)(76116006)(86362001)(8936002)(316002)(26005);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata": "\n RSFEqNkwR5FT8TBNPqnKVHi9gJlHbI00af3H7Hp15VPLY7zzPP+BF6w9tYs6HvUJXxOGAhN5+4TK2swFA3s9ssn10+8QtIfRUEdSixpL3QbqXA3U62/REOsA1JnQRcckyX6TZtYo8tuFrUqdjaXhyxPsYikPmHHRpFq+zwRTZZtGGXs/LZ83ePmaM5CEWp+3rvMRSsJRdt6XZcHjqfrQA+aZKuTBiJPoXEC1RDS9wTyf54BDSruxG3nNqpseck+RdQ0JsjxrtuJDZ89VFTWGGVTakZNLg6ta+L+GBnv57LdafF/Ndv7R6cnnBoSUZJD/oxNMLWDUY1TWuyVcQU8oAcAJpLQ4Sfmn1qZBC0mjcsVigRtSLhOj3oJrqY4Pgt4xhx0qUeYm9Vjht0pCDIWmAYVqYKLIaDm3WH6ENSVgGHlMiG/zO5NJU+QBRj143csxTD1zOJnypQIqPwOG5Yc0AMKeEE5K/TqkvNbfI2tikGg=", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "BYAPR11MB3477.namprd11.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 82f77296-559a-4189-e083-08d82f7a1e84", "X-MS-Exchange-CrossTenant-originalarrivaltime": "24 Jul 2020 02:34:41.6426 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "46c98d88-e344-4ed4-8496-4ed7712e255d", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n yp/DKFmJUjZID/aL3VUUE15PufczRVyGMA33tv4o7hI70UgE3kB7jAXuE0OCVa5SJdRjd3oo5NC3I7qBHdjF4sRx4Ymq6FkDgVgqjZmQp+0=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BY5PR11MB4104", "X-OriginatorOrg": "intel.com", "Subject": "Re: [dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look up table", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116550, "web_url": "https://patches.dpdk.org/comment/116550/", "msgid": "<039ED4275CED7440929022BC67E7061154864F86@SHSMSX103.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/039ED4275CED7440929022BC67E7061154864F86@SHSMSX103.ccr.corp.intel.com", "date": "2020-07-23T12:53:23", "subject": "Re: [dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look up table", "submitter": { "id": 504, "url": "https://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "content": "> -----Original Message-----\n> From: dev <dev-bounces@dpdk.org> On Behalf Of Yang, Qiming\n> Sent: Thursday, July 23, 2020 9:57 AM\n> To: Wang, ShougangX <shougangx.wang@intel.com>; dev@dpdk.org\n> Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>; Wang,\n> ShougangX <shougangx.wang@intel.com>; stable@dpdk.org\n> Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look up table\n> \n> I don't understand why you add new function and new function mostly do the\n> same thing.\n> Why don't add fix in original code.\n> \n> > -----Original Message-----\n> > From: dev <dev-bounces@dpdk.org> On Behalf Of Shougang Wang\n> > Sent: Wednesday, July 22, 2020 16:16\n> > To: dev@dpdk.org\n> > Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia\n> > <jia.guo@intel.com>; Wang, ShougangX <shougangx.wang@intel.com>;\n> > stable@dpdk.org\n> > Subject: [dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look up\n> > table\n> >\n> > The hash look up table (LUT) is managed by global register but it is\n> > not initialized when RSS is disabled. Once user wants to enable RSS\n> > during runtime, the LUT will not be initialized.\n> > This patch fixes the issue by initializing the LUT whether RSS enabled or not.\n> >\n> > Fixes: feaae285b342 (\"net/i40e: support hash configuration in RSS\n> > flow\")\n> > Cc: stable@dpdk.org\n> >\n> > Signed-off-by: Shougang Wang <shougangx.wang@intel.com>\n> > ---\n> > v3:\n> > -Updated the time of initializing the look up table\n> > ---\n> > drivers/net/i40e/i40e_ethdev.c | 85\n> > ++++++++++++++++++++--------------\n> > 1 file changed, 49 insertions(+), 36 deletions(-)\n> >\n> > diff --git a/drivers/net/i40e/i40e_ethdev.c\n> > b/drivers/net/i40e/i40e_ethdev.c index 05d5f2861..e35590d96 100644\n> > --- a/drivers/net/i40e/i40e_ethdev.c\n> > +++ b/drivers/net/i40e/i40e_ethdev.c\n> > @@ -8984,42 +8984,7 @@ i40e_pf_calc_configured_queues_num(struct\n> > i40e_pf *pf) static int i40e_pf_config_rss(struct i40e_pf *pf) {\n> > -\tstruct i40e_hw *hw = I40E_PF_TO_HW(pf);\n> > \tstruct rte_eth_rss_conf rss_conf;\n> > -\tuint32_t i, lut = 0;\n> > -\tuint16_t j, num;\n> > -\n> > -\t/*\n> > -\t * If both VMDQ and RSS enabled, not all of PF queues are\n> > configured.\n> > -\t * It's necessary to calculate the actual PF queues that are configured.\n> > -\t */\n> > -\tif (pf->dev_data->dev_conf.rxmode.mq_mode &\n> > ETH_MQ_RX_VMDQ_FLAG)\n> > -\t\tnum = i40e_pf_calc_configured_queues_num(pf);\n> > -\telse\n> > -\t\tnum = pf->dev_data->nb_rx_queues;\n> > -\n> > -\tnum = RTE_MIN(num, I40E_MAX_Q_PER_TC);\n> > -\tPMD_INIT_LOG(INFO, \"Max of contiguous %u PF queues are\n> > configured\",\n> > -\t\t\tnum);\n> > -\n> > -\tif (num == 0) {\n> > -\t\tPMD_INIT_LOG(ERR,\n> > -\t\t\t\"No PF queues are configured to enable RSS for port\n> > %u\",\n> > -\t\t\tpf->dev_data->port_id);\n> > -\t\treturn -ENOTSUP;\n> > -\t}\n> > -\n> > -\tif (pf->adapter->rss_reta_updated == 0) {\n> > -\t\tfor (i = 0, j = 0; i < hw->func_caps.rss_table_size; i++, j++) {\n> > -\t\t\tif (j == num)\n> > -\t\t\t\tj = 0;\n> > -\t\t\tlut = (lut << 8) | (j & ((0x1 <<\n> > -\t\t\t\thw->func_caps.rss_table_entry_width) - 1));\n> > -\t\t\tif ((i & 3) == 3)\n> > -\t\t\t\tI40E_WRITE_REG(hw, I40E_PFQF_HLUT(i >>\n> > 2),\n> > -\t\t\t\t\t rte_bswap32(lut));\n> > -\t\t}\n> > -\t}\n> >\n> > \trss_conf = pf->dev_data->dev_conf.rx_adv_conf.rss_conf;\n> > \tif ((rss_conf.rss_hf & pf->adapter->flow_types_mask) == 0) { @@ -\n> > 9195,12 +9160,60 @@ i40e_tunnel_filter_handle(struct rte_eth_dev *dev,\n> > \treturn ret;\n> > }\n> >\n> > +/* Initialize the hash look up table */ static int\n> > +i40e_pf_init_rss_lut(struct i40e_pf *pf) {\n> > +\tstruct i40e_hw *hw = I40E_PF_TO_HW(pf);\n> > +\tuint32_t lut = 0;\n> > +\tuint16_t j, num;\n> > +\tuint32_t i;\n> > +\n> > +\t/* If both VMDQ and RSS enabled, not all of PF queues are\n> > configured.\n> > +\t * It's necessary to calculate the actual PF queues that are configured.\n> > +\t */\n> > +\tif (pf->dev_data->dev_conf.rxmode.mq_mode &\n> > ETH_MQ_RX_VMDQ_FLAG)\n> > +\t\tnum = i40e_pf_calc_configured_queues_num(pf);\n> > +\telse\n> > +\t\tnum = pf->dev_data->nb_rx_queues;\n> > +\n> > +\tnum = RTE_MIN(num, I40E_MAX_Q_PER_TC);\n> > +\tPMD_INIT_LOG(INFO, \"Max of contiguous %u PF queues are\n> > configured\",\n> > +\t\t num);\n> > +\n> > +\tif (num == 0) {\n> > +\t\tPMD_INIT_LOG(ERR,\n> > +\t\t\t\"No PF queues are configured to enable RSS for port\n> > %u\",\n> > +\t\t\tpf->dev_data->port_id);\n> > +\t\treturn -ENOTSUP;\n> > +\t}\n> > +\n> > +\tif (pf->adapter->rss_reta_updated == 0) {\n> > +\t\tfor (i = 0, j = 0; i < hw->func_caps.rss_table_size; i++, j++) {\n> > +\t\t\tif (j == num)\n> > +\t\t\t\tj = 0;\n> > +\t\t\tlut = (lut << 8) | (j & ((0x1 <<\n> > +\t\t\t\thw->func_caps.rss_table_entry_width) - 1));\n> > +\t\t\tif ((i & 3) == 3)\n> > +\t\t\t\tI40E_WRITE_REG(hw, I40E_PFQF_HLUT(i >>\n> > 2),\n> > +\t\t\t\t\t rte_bswap32(lut));\n> > +\t\t}\n> > +\t}\n> > +\n> > +\treturn 0;\n> > +}\n> > +\n> > static int\n> > i40e_pf_config_mq_rx(struct i40e_pf *pf) {\n> > -\tint ret = 0;\n> > +\tint ret;\n> > \tenum rte_eth_rx_mq_mode mq_mode = pf->dev_data-\n> > >dev_conf.rxmode.mq_mode;\n> >\n> > +\t/* Initialize hash look up table */\n> > +\tret = i40e_pf_init_rss_lut(pf);\n> > +\tif (ret)\n> > +\t\treturn ret;\n> > +\n> > \t/* RSS setup */\n> > \tif (mq_mode & ETH_MQ_RX_RSS_FLAG)\n\nI agree with Qiming, if we move this check into i40e_pf_config_rss, dose that looks we don't need to create a new function?\n\n> > \t\tret = i40e_pf_config_rss(pf);\n> > --\n> > 2.17.1", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6CB7BA0521;\n\tThu, 23 Jul 2020 14:53:32 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E12F71BFFE;\n\tThu, 23 Jul 2020 14:53:30 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by dpdk.org (Postfix) with ESMTP id B1DA31BFFD;\n Thu, 23 Jul 2020 14:53:28 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Jul 2020 05:53:27 -0700", "from fmsmsx103.amr.corp.intel.com ([10.18.124.201])\n by fmsmga005.fm.intel.com with ESMTP; 23 Jul 2020 05:53:27 -0700", "from fmsmsx154.amr.corp.intel.com (10.18.116.70) by\n FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Thu, 23 Jul 2020 05:53:27 -0700", "from shsmsx102.ccr.corp.intel.com (10.239.4.154) by\n FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Thu, 23 Jul 2020 05:53:26 -0700", "from shsmsx103.ccr.corp.intel.com ([169.254.4.22]) by\n shsmsx102.ccr.corp.intel.com ([169.254.2.43]) with mapi id 14.03.0439.000;\n Thu, 23 Jul 2020 20:53:23 +0800" ], "IronPort-SDR": [ "\n D2UG80dpyxLvL8H9YCz/sj32RNLBRcuvMNU1qb4kbQNliZnTESQVcfPzjmDaiP1eZXa1k+8m9g\n Cvby0FiV6j9A==", "\n z6TVyjogXOuov3jrfvyFgIG4S/GAWpyka+XPtemttViXpwYDslJ4Fs2DVoHYkeDxHB+haSqH+c\n Uyg0cGJiiwfA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9690\"; a=\"130584952\"", "E=Sophos;i=\"5.75,386,1589266800\"; d=\"scan'208\";a=\"130584952\"", "E=Sophos;i=\"5.75,386,1589266800\"; d=\"scan'208\";a=\"488819830\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "\"Zhang, Qi Z\" <qi.z.zhang@intel.com>", "To": "\"Yang, Qiming\" <qiming.yang@intel.com>, \"Wang, ShougangX\"\n <shougangx.wang@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"Xing, Beilei\" <beilei.xing@intel.com>, \"Guo, Jia\" <jia.guo@intel.com>,\n \"Wang, ShougangX\" <shougangx.wang@intel.com>, \"stable@dpdk.org\"\n <stable@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look up table", "Thread-Index": "AQHWYALWKcxnSmLLsU+pXE7TqxoMoKkT4vyAgAE8kSA=", "Date": "Thu, 23 Jul 2020 12:53:23 +0000", "Message-ID": "\n <039ED4275CED7440929022BC67E7061154864F86@SHSMSX103.ccr.corp.intel.com>", "References": "<20200715063515.9262-1-shougangx.wang@intel.com>\n <20200722081543.52396-1-shougangx.wang@intel.com>\n <BN6PR11MB0017E2387CBB71123F8F74DFE5760@BN6PR11MB0017.namprd11.prod.outlook.com>", "In-Reply-To": "\n <BN6PR11MB0017E2387CBB71123F8F74DFE5760@BN6PR11MB0017.namprd11.prod.outlook.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "dlp-product": "dlpe-windows", "dlp-version": "11.2.0.6", "dlp-reaction": "no-action", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look up table", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116527, "web_url": "https://patches.dpdk.org/comment/116527/", "msgid": "<BN6PR11MB0017E2387CBB71123F8F74DFE5760@BN6PR11MB0017.namprd11.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/BN6PR11MB0017E2387CBB71123F8F74DFE5760@BN6PR11MB0017.namprd11.prod.outlook.com", "date": "2020-07-23T01:57:03", "subject": "Re: [dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look up table", "submitter": { "id": 522, "url": "https://patches.dpdk.org/api/people/522/?format=api", "name": "Qiming Yang", "email": "qiming.yang@intel.com" }, "content": "I don't understand why you add new function and new function mostly do the same thing.\nWhy don't add fix in original code.\n\n> -----Original Message-----\n> From: dev <dev-bounces@dpdk.org> On Behalf Of Shougang Wang\n> Sent: Wednesday, July 22, 2020 16:16\n> To: dev@dpdk.org\n> Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>; Wang,\n> ShougangX <shougangx.wang@intel.com>; stable@dpdk.org\n> Subject: [dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look up table\n> \n> The hash look up table (LUT) is managed by global register but it is not\n> initialized when RSS is disabled. Once user wants to enable RSS during\n> runtime, the LUT will not be initialized.\n> This patch fixes the issue by initializing the LUT whether RSS enabled or not.\n> \n> Fixes: feaae285b342 (\"net/i40e: support hash configuration in RSS flow\")\n> Cc: stable@dpdk.org\n> \n> Signed-off-by: Shougang Wang <shougangx.wang@intel.com>\n> ---\n> v3:\n> -Updated the time of initializing the look up table\n> ---\n> drivers/net/i40e/i40e_ethdev.c | 85 ++++++++++++++++++++--------------\n> 1 file changed, 49 insertions(+), 36 deletions(-)\n> \n> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\n> index 05d5f2861..e35590d96 100644\n> --- a/drivers/net/i40e/i40e_ethdev.c\n> +++ b/drivers/net/i40e/i40e_ethdev.c\n> @@ -8984,42 +8984,7 @@ i40e_pf_calc_configured_queues_num(struct\n> i40e_pf *pf) static int i40e_pf_config_rss(struct i40e_pf *pf) {\n> -\tstruct i40e_hw *hw = I40E_PF_TO_HW(pf);\n> \tstruct rte_eth_rss_conf rss_conf;\n> -\tuint32_t i, lut = 0;\n> -\tuint16_t j, num;\n> -\n> -\t/*\n> -\t * If both VMDQ and RSS enabled, not all of PF queues are\n> configured.\n> -\t * It's necessary to calculate the actual PF queues that are configured.\n> -\t */\n> -\tif (pf->dev_data->dev_conf.rxmode.mq_mode &\n> ETH_MQ_RX_VMDQ_FLAG)\n> -\t\tnum = i40e_pf_calc_configured_queues_num(pf);\n> -\telse\n> -\t\tnum = pf->dev_data->nb_rx_queues;\n> -\n> -\tnum = RTE_MIN(num, I40E_MAX_Q_PER_TC);\n> -\tPMD_INIT_LOG(INFO, \"Max of contiguous %u PF queues are\n> configured\",\n> -\t\t\tnum);\n> -\n> -\tif (num == 0) {\n> -\t\tPMD_INIT_LOG(ERR,\n> -\t\t\t\"No PF queues are configured to enable RSS for port\n> %u\",\n> -\t\t\tpf->dev_data->port_id);\n> -\t\treturn -ENOTSUP;\n> -\t}\n> -\n> -\tif (pf->adapter->rss_reta_updated == 0) {\n> -\t\tfor (i = 0, j = 0; i < hw->func_caps.rss_table_size; i++, j++) {\n> -\t\t\tif (j == num)\n> -\t\t\t\tj = 0;\n> -\t\t\tlut = (lut << 8) | (j & ((0x1 <<\n> -\t\t\t\thw->func_caps.rss_table_entry_width) - 1));\n> -\t\t\tif ((i & 3) == 3)\n> -\t\t\t\tI40E_WRITE_REG(hw, I40E_PFQF_HLUT(i >>\n> 2),\n> -\t\t\t\t\t rte_bswap32(lut));\n> -\t\t}\n> -\t}\n> \n> \trss_conf = pf->dev_data->dev_conf.rx_adv_conf.rss_conf;\n> \tif ((rss_conf.rss_hf & pf->adapter->flow_types_mask) == 0) { @@ -\n> 9195,12 +9160,60 @@ i40e_tunnel_filter_handle(struct rte_eth_dev *dev,\n> \treturn ret;\n> }\n> \n> +/* Initialize the hash look up table */ static int\n> +i40e_pf_init_rss_lut(struct i40e_pf *pf) {\n> +\tstruct i40e_hw *hw = I40E_PF_TO_HW(pf);\n> +\tuint32_t lut = 0;\n> +\tuint16_t j, num;\n> +\tuint32_t i;\n> +\n> +\t/* If both VMDQ and RSS enabled, not all of PF queues are\n> configured.\n> +\t * It's necessary to calculate the actual PF queues that are configured.\n> +\t */\n> +\tif (pf->dev_data->dev_conf.rxmode.mq_mode &\n> ETH_MQ_RX_VMDQ_FLAG)\n> +\t\tnum = i40e_pf_calc_configured_queues_num(pf);\n> +\telse\n> +\t\tnum = pf->dev_data->nb_rx_queues;\n> +\n> +\tnum = RTE_MIN(num, I40E_MAX_Q_PER_TC);\n> +\tPMD_INIT_LOG(INFO, \"Max of contiguous %u PF queues are\n> configured\",\n> +\t\t num);\n> +\n> +\tif (num == 0) {\n> +\t\tPMD_INIT_LOG(ERR,\n> +\t\t\t\"No PF queues are configured to enable RSS for port\n> %u\",\n> +\t\t\tpf->dev_data->port_id);\n> +\t\treturn -ENOTSUP;\n> +\t}\n> +\n> +\tif (pf->adapter->rss_reta_updated == 0) {\n> +\t\tfor (i = 0, j = 0; i < hw->func_caps.rss_table_size; i++, j++) {\n> +\t\t\tif (j == num)\n> +\t\t\t\tj = 0;\n> +\t\t\tlut = (lut << 8) | (j & ((0x1 <<\n> +\t\t\t\thw->func_caps.rss_table_entry_width) - 1));\n> +\t\t\tif ((i & 3) == 3)\n> +\t\t\t\tI40E_WRITE_REG(hw, I40E_PFQF_HLUT(i >>\n> 2),\n> +\t\t\t\t\t rte_bswap32(lut));\n> +\t\t}\n> +\t}\n> +\n> +\treturn 0;\n> +}\n> +\n> static int\n> i40e_pf_config_mq_rx(struct i40e_pf *pf) {\n> -\tint ret = 0;\n> +\tint ret;\n> \tenum rte_eth_rx_mq_mode mq_mode = pf->dev_data-\n> >dev_conf.rxmode.mq_mode;\n> \n> +\t/* Initialize hash look up table */\n> +\tret = i40e_pf_init_rss_lut(pf);\n> +\tif (ret)\n> +\t\treturn ret;\n> +\n> \t/* RSS setup */\n> \tif (mq_mode & ETH_MQ_RX_RSS_FLAG)\n> \t\tret = i40e_pf_config_rss(pf);\n> --\n> 2.17.1", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 31573A0526;\n\tThu, 23 Jul 2020 03:57:11 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0B99B1BFDA;\n\tThu, 23 Jul 2020 03:57:11 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by dpdk.org (Postfix) with ESMTP id D8AAE1BE9A;\n Thu, 23 Jul 2020 03:57:08 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Jul 2020 18:57:07 -0700", "from fmsmsx603.amr.corp.intel.com ([10.18.126.83])\n by orsmga008.jf.intel.com with ESMTP; 22 Jul 2020 18:57:07 -0700", "from fmsmsx603.amr.corp.intel.com (10.18.126.83) by\n fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.1713.5; Wed, 22 Jul 2020 18:57:07 -0700", "from FMSEDG001.ED.cps.intel.com (10.1.192.133) by\n fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5\n via Frontend Transport; Wed, 22 Jul 2020 18:57:07 -0700", "from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.59) by\n edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server\n (TLS) id 14.3.439.0; Wed, 22 Jul 2020 18:57:07 -0700", "from BN6PR11MB0017.namprd11.prod.outlook.com (2603:10b6:405:6c::34)\n by BN6PR11MB1313.namprd11.prod.outlook.com (2603:10b6:404:48::19)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20; Thu, 23 Jul\n 2020 01:57:03 +0000", "from BN6PR11MB0017.namprd11.prod.outlook.com\n ([fe80::c8eb:f4c9:5b58:3120]) by BN6PR11MB0017.namprd11.prod.outlook.com\n ([fe80::c8eb:f4c9:5b58:3120%6]) with mapi id 15.20.3195.023; Thu, 23 Jul 2020\n 01:57:03 +0000" ], "IronPort-SDR": [ "\n +34kZ8HcO4t89wOmqTFl+bpzyqg9RHF3XjIkuWBo32p3zlLA8zriWFS4DhVfDp2pGRpD67++Lj\n 5YlDtcSGui4g==", "\n dbwvhckSSLuk4Llt2IzzMs0q2+GUA1mTW58koMr2igJZuKFFbRxBQwHlGxd703B1H5dHNJ/o0d\n bOcOyRcNwGug==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9690\"; a=\"151762504\"", "E=Sophos;i=\"5.75,385,1589266800\"; d=\"scan'208\";a=\"151762504\"", "E=Sophos;i=\"5.75,385,1589266800\"; d=\"scan'208\";a=\"318841039\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=YmyF7GNxpX4rcdANNBuDxR4EesTMjfHeulLdqylgLmXUJkeuJDn8uWlg6//XQZhFJiN9J2t/izbOPBmkW3H9PIgofKIXiXVjtWsA6d5G6yxr9rx004Jqks7KSC1ByFG6pKxkp89hoOdtf9iz94+sEJqMBh8ddVlv34wz5VOHGxjz5KXNei74KWOiwH9Su3z3WDI48h3Xa3ugux3TqAwkoDruEs0MPg4wJPqB0ZEey5QMfBU+dAo7vvV+5TYC5lK82sNvH0KuM2u23KjWSXAVp3K3qccnbspZpm6ENjneJfmeKzk7+E/qKODNeDBQY/tuuksTv07w3I5+cevRULm2xw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=lwoeOWsOD3Hbc56p2OX0PAj/a8rct3KwRtoZkRHuWY4=;\n b=TroVlUgC5Po4YHeguRrQyCgNj857KNQDBqrzhLaBYbrpTg3+ETnFc1l2bEV3ED1/iXqKzTqszAX1gU9Pc1MaiDMUodwUDE+E+hqoDm9a0q5PN8fEU9i0D9Lkralk7L+2FGEhzBLyFvUTJHDSykv1C4i/DBrrokyGvIeDgNoaUC/02BemLh9Ip/0ieLT9p8bJ2kSjK0YeDSbt5Ol0grMrnjZzepDgCMDA4oRxc0pB3ZkCrC6ugcTm/6gY+mP+3e9EPZkJHhAFAN2VqamuLMBoAc2lhocS/XOg9Mwnde8ewQMx/cv9j9WCIsnNqUP+NX0wEmSYakf+VrUkQlH4H7Haiw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;\n s=selector2-intel-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=lwoeOWsOD3Hbc56p2OX0PAj/a8rct3KwRtoZkRHuWY4=;\n b=w6xHC/kjqcYiby5B4m/0huQXLS7C2sriBR2joDJ6gI8RaNYYHuDZ+fJgABChM3y7AxsuY4J49csnu+QP9jM4ACZ2JA9PCD/UgtrPqIp7Wdc86jgBo8eNw6qK8hLQqWCw07opED3f+JhApviBCjlRZ9CJP1JtKnvLC9XwsNGGGbo=", "From": "\"Yang, Qiming\" <qiming.yang@intel.com>", "To": "\"Wang, ShougangX\" <shougangx.wang@intel.com>,\n \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"Xing, Beilei\" <beilei.xing@intel.com>, \"Guo, Jia\" <jia.guo@intel.com>,\n \"Wang, ShougangX\" <shougangx.wang@intel.com>, \"stable@dpdk.org\"\n <stable@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look up table", "Thread-Index": "AQHWYALZy2sRjXuV50ilSElK4Ihay6kUaNbg", "Date": "Thu, 23 Jul 2020 01:57:03 +0000", "Message-ID": "\n <BN6PR11MB0017E2387CBB71123F8F74DFE5760@BN6PR11MB0017.namprd11.prod.outlook.com>", "References": "<20200715063515.9262-1-shougangx.wang@intel.com>\n <20200722081543.52396-1-shougangx.wang@intel.com>", "In-Reply-To": "<20200722081543.52396-1-shougangx.wang@intel.com>", "Accept-Language": "en-US, zh-CN", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "intel.com; dkim=none (message not signed)\n header.d=none;intel.com; dmarc=none action=none header.from=intel.com;", "x-originating-ip": "[192.102.204.45]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "33524859-13d4-41a1-4900-08d82eabb239", "x-ms-traffictypediagnostic": "BN6PR11MB1313:", "x-ld-processed": "46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <BN6PR11MB1313410AD74AEB4F8227BB67E5760@BN6PR11MB1313.namprd11.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:8882;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n hqwK9mO2TlhzaGhpAO49Q27pf6h55WaBdxmUma6dq35RTIDswD0aYBZATswIsACnk43dcbB+hxodTNOE+jp1bx+k4L3ULLsp+M5gT7OJD2Co/RA89lbazaA9i3zagZ8YWeH4mZzEKfLgy5WGQLZ3n3Th9ycng+YLLR8jIJCgMa/ZyQCrMtU8Ej81OxPLi0lZmdVzOPz5kq7JbBMz14bC4j8A2OKYjvOKaT7gSXn7fwm0eS24JvW10ibLM9Jpq49JAdhKqGeTNPXVOnTVd/rlC3eNNIJdA70ISuyhTfT2l6tYCAFdkJ4TbP7VuQJGY7Dg", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:BN6PR11MB0017.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(346002)(376002)(136003)(366004)(396003)(39860400002)(71200400001)(4326008)(450100002)(8676002)(33656002)(64756008)(66476007)(66946007)(66556008)(76116006)(86362001)(66446008)(8936002)(55016002)(52536014)(53546011)(7696005)(186003)(26005)(83380400001)(9686003)(5660300002)(6506007)(54906003)(478600001)(2906002)(316002)(110136005);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata": "\n aPecAli6zeohdEvgBaC2UFgZYpTkeyWQW4cWKR2i48KmF03ovAv4iFVveZgzogUG+LbglB9x9NUtuc7VpPiY5c9LnTLVBxvToIjrA9TprTfuGeHi6MPSDjuGmrfSO0i5Ifb68XRBC8l6o3bnLHkPffXm/oFsUY5ZuAUuw/oHjyOSaZN0AuHmIli2ZSah604iHlAYV5ZSG8N3V7i4iqd8JO5ygMR9e8McTyYYs1ANK0yQZ+mPs/KLFPiLQLScaCoCJVGuwuzDBCM1L8QboQwD25647WbdvWjCFJfJk6UwZ/YfCR6KuArDmMefghFdbNGFX3nwi++oZMvbfaDl4dRdocNCRO6QbuZtZDjUqU7LM9UICAa+Gms9xG6iZdcp8NVLHR8gfZj3a8CCbqKNaRLqXKPOqlGK6Fttay73rNM07iP6kyCkKlCaXWEiA2dAoAE5assKIsKz/zPQ5BPjqc0VCxvaVQrkAIBIlbhr/IEhkZbhplnOZFG89Ah8+IaVjbnj", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "BN6PR11MB0017.namprd11.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 33524859-13d4-41a1-4900-08d82eabb239", "X-MS-Exchange-CrossTenant-originalarrivaltime": "23 Jul 2020 01:57:03.5380 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "46c98d88-e344-4ed4-8496-4ed7712e255d", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n cWpAdmWxNz45xSyeBUYm4dOOkTtRf1cbbH62ywf4HyOgUIMii1NzyFZQYy7tjCMrdQguh+ggCg5n5mx/Rlf/dw==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN6PR11MB1313", "X-OriginatorOrg": "intel.com", "Subject": "Re: [dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look up table", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]