Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74598/?format=api
https://patches.dpdk.org/api/patches/74598/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200722175738.32490-2-maox.jiang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200722175738.32490-2-maox.jiang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200722175738.32490-2-maox.jiang@intel.com", "date": "2020-07-22T17:57:38", "name": "[v3,2/2] net/i40e: fix fdir allocating msix resource error", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "2c6437b262c821b1b59c09be5df7caea51523302", "submitter": { "id": 1630, "url": "https://patches.dpdk.org/api/people/1630/?format=api", "name": "Jiang Mao", "email": "maox.jiang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200722175738.32490-2-maox.jiang@intel.com/mbox/", "series": [ { "id": 11225, "url": "https://patches.dpdk.org/api/series/11225/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11225", "date": "2020-07-22T17:57:37", "name": "[v3,1/2] net/i40e: fix binding interrupt without msix vectors", "version": 3, "mbox": "https://patches.dpdk.org/series/11225/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/74598/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/74598/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 41A2FA0526;\n\tWed, 22 Jul 2020 08:08:13 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 993431C00D;\n\tWed, 22 Jul 2020 08:08:05 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id 0C44D1BFBB;\n Wed, 22 Jul 2020 08:07:58 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jul 2020 23:07:58 -0700", "from dut85.sh.intel.com ([10.240.183.157])\n by orsmga002.jf.intel.com with ESMTP; 21 Jul 2020 23:07:57 -0700" ], "IronPort-SDR": [ "\n uwPdvK+9Vo0Tgpj6zHbvX9y1cBm78XAPRGCYCbV4nkf+KK5WwyH3WotjBD/ra3S2hRjqefDrfV\n u3mp+HDmc52w==", "\n D4F4dhD7tdI9IdLOmlmNznvClFpaY3x2Z5TQD3xRXTpwieOGlvOApmU3SFPUSXK2DJau+ve4GE\n 30PEoRcrsYiA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9689\"; a=\"214918289\"", "E=Sophos;i=\"5.75,381,1589266800\"; d=\"scan'208\";a=\"214918289\"", "E=Sophos;i=\"5.75,381,1589266800\"; d=\"scan'208\";a=\"301850402\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Jiang Mao <maox.jiang@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org,\n\tstable@dpdk.org,\n\tJiang Mao <maox.jiang@intel.com>", "Date": "Thu, 23 Jul 2020 01:57:38 +0800", "Message-Id": "<20200722175738.32490-2-maox.jiang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200722175738.32490-1-maox.jiang@intel.com>", "References": "<20200708195034.4495-1-maox.jiang@intel.com>\n <20200722175738.32490-1-maox.jiang@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 2/2] net/i40e: fix fdir allocating msix\n\tresource error", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fdir allocating msix resource is not strictly necessary, if no\nresource left, jump the error.\n\nFixes: 4861cde461 (i40e: new poll mode driver)\nCc: stable@dpdk.org\n\nSigned-off-by: Jiang Mao <maox.jiang@intel.com>\n---\nV3: Move type I40E_VSI_FDIR branch into !I40E_VSI_SRIOV branch.\n---\n drivers/net/i40e/i40e_ethdev.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 16fcb8d24e..c19bf868ea 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -5736,10 +5736,14 @@ i40e_vsi_setup(struct i40e_pf *pf,\n \t\tret = i40e_res_pool_alloc(&pf->msix_pool, 1);\n \t\tif (ret < 0) {\n \t\t\tPMD_DRV_LOG(ERR, \"VSI %d get heap failed %d\", vsi->seid, ret);\n-\t\t\tgoto fail_queue_alloc;\n+\t\t\tif (type != I40E_VSI_FDIR)\n+\t\t\t\tgoto fail_queue_alloc;\n+\t\t\tvsi->msix_intr = 0;\n+\t\t\tvsi->nb_msix = 0;\n+\t\t} else {\n+\t\t\tvsi->msix_intr = ret;\n+\t\t\tvsi->nb_msix = 1;\n \t\t}\n-\t\tvsi->msix_intr = ret;\n-\t\tvsi->nb_msix = 1;\n \t} else {\n \t\tvsi->msix_intr = 0;\n \t\tvsi->nb_msix = 0;\n", "prefixes": [ "v3", "2/2" ] }{ "id": 74598, "url": "