Patch Comment List
List patch comments
GET /api/patches/74584/comments/?format=api
[ { "id": 116455, "web_url": "https://patches.dpdk.org/comment/116455/", "msgid": "<6e27fb42-4e42-96a7-d025-6a49f0a30395@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/6e27fb42-4e42-96a7-d025-6a49f0a30395@intel.com", "date": "2020-07-21T23:09:52", "subject": "Re: [dpdk-dev] [PATCH 1/2] net/bnxt: add meson build option", "submitter": { "id": 324, "url": "https://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "content": "On 7/21/2020 6:47 PM, Ajit Khaparde wrote:\n> Add an option in meson build to indicate the memory management scheme.\n> bnxt_eem_system is set to false by default.\n> \n> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n\n<...>\n\n> --- a/meson_options.txt\n> +++ b/meson_options.txt\n> @@ -2,6 +2,8 @@\n> \n> option('armv8_crypto_dir', type: 'string', value: '',\n> \tdescription: 'path to the armv8_crypto library installation directory')\n> +option('bnxt_eem_system', type: 'boolean', value: false,\n> +\tdescription: 'EEM system memory support')\n> option('disable_drivers', type: 'string', value: '',\n> \tdescription: 'Comma-separated list of drivers to explicitly disable.')\n> option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>',\n> \n\nI think it was a design decision to not have all Make config options to meson\nbuild, and reduce compile time configuration as much as possible.\n\nFor a while we are pushing back new compile time config options unless they are\nreally must, the 'RTE_LIBRTE_BNXT_PMD_SYSTEM' has been merged mostly because it\nhas been missed.\n\nInstead of introducing this PMD level compile time option to meson, can it be\npossible to convert the config to runtime config. In the past we have used the\ndevice arguments many times for same reason, can something similar be used here?", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0E3AFA0526;\n\tWed, 22 Jul 2020 01:09:59 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B6D021C0C2;\n\tWed, 22 Jul 2020 01:09:57 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id 945541C0C0\n for <dev@dpdk.org>; Wed, 22 Jul 2020 01:09:56 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jul 2020 16:09:55 -0700", "from fyigit-mobl.ger.corp.intel.com (HELO [10.213.221.17])\n ([10.213.221.17])\n by fmsmga007.fm.intel.com with ESMTP; 21 Jul 2020 16:09:53 -0700" ], "IronPort-SDR": [ "\n HAdcaWGcaVh2vlvr1xpwGi166xpViXaC03P43q9VkNY/dtUtqp634FhZ+WPrafQjoZHK9exhJb\n aAfTRw+RjU2Q==", "\n r9hjBBd6mNvg6L1PjaQoGQynRp7UE8tqq6s02Rt+q8MeoH1qMbZSi8GwPJ4ER74MJ0i7z0xk8H\n RtLyEEk3I/uQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9689\"; a=\"138328798\"", "E=Sophos;i=\"5.75,380,1589266800\"; d=\"scan'208\";a=\"138328798\"", "E=Sophos;i=\"5.75,380,1589266800\"; d=\"scan'208\";a=\"270576827\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "To": "Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org,\n Bruce Richardson <bruce.richardson@intel.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n David Marchand <david.marchand@redhat.com>", "References": "<20200721174712.48625-1-ajit.khaparde@broadcom.com>", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "Autocrypt": "addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata=\n mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy\n qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ\n +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9\n GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb\n +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF\n YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy\n ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX\n CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1\n 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz\n cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln\n aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK\n CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl\n eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk\n UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT\n PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO\n lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC\n ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2\n 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H\n 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo\n cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx\n Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp\n e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59\n gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES\n YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai\n bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD\n UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/\n 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj\n sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc\n q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7\n 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB\n VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI\n 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC\n GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b\n cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz\n EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H\n o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2\n 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA\n WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA\n 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T\n GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n\n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv\n ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae\n dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ==", "Message-ID": "<6e27fb42-4e42-96a7-d025-6a49f0a30395@intel.com>", "Date": "Wed, 22 Jul 2020 00:09:52 +0100", "MIME-Version": "1.0", "In-Reply-To": "<20200721174712.48625-1-ajit.khaparde@broadcom.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "8bit", "Subject": "Re: [dpdk-dev] [PATCH 1/2] net/bnxt: add meson build option", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116460, "web_url": "https://patches.dpdk.org/comment/116460/", "msgid": "<CACZ4nhuerYSguH0rEYdoK5Nf2QLU_8KNfc6KxZ4faQjfZCUY=g@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CACZ4nhuerYSguH0rEYdoK5Nf2QLU_8KNfc6KxZ4faQjfZCUY=g@mail.gmail.com", "date": "2020-07-22T00:18:41", "subject": "Re: [dpdk-dev] [PATCH 1/2] net/bnxt: add meson build option", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "content": "On Tue, Jul 21, 2020 at 4:09 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:\n\n> On 7/21/2020 6:47 PM, Ajit Khaparde wrote:\n> > Add an option in meson build to indicate the memory management scheme.\n> > bnxt_eem_system is set to false by default.\n> >\n> > Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n>\n> <...>\n>\n> > --- a/meson_options.txt\n> > +++ b/meson_options.txt\n> > @@ -2,6 +2,8 @@\n> >\n> > option('armv8_crypto_dir', type: 'string', value: '',\n> > description: 'path to the armv8_crypto library installation\n> directory')\n> > +option('bnxt_eem_system', type: 'boolean', value: false,\n> > + description: 'EEM system memory support')\n> > option('disable_drivers', type: 'string', value: '',\n> > description: 'Comma-separated list of drivers to explicitly\n> disable.')\n> > option('drivers_install_subdir', type: 'string', value:\n> 'dpdk/pmds-<VERSION>',\n> >\n>\n> I think it was a design decision to not have all Make config options to\n> meson\n> build, and reduce compile time configuration as much as possible.\n>\n> For a while we are pushing back new compile time config options unless\n> they are\n> really must, the 'RTE_LIBRTE_BNXT_PMD_SYSTEM' has been merged mostly\n> because it\n> has been missed.\n>\n> Instead of introducing this PMD level compile time option to meson, can it\n> be\n> possible to convert the config to runtime config. In the past we have used\n> the\n> device arguments many times for same reason, can something similar be used\n> here?\n>\nSure. I can take a look at that.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 38B86A0526;\n\tWed, 22 Jul 2020 02:19:01 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4ECD71C0C5;\n\tWed, 22 Jul 2020 02:19:00 +0200 (CEST)", "from mail-ot1-f66.google.com (mail-ot1-f66.google.com\n [209.85.210.66]) by dpdk.org (Postfix) with ESMTP id B16671C0B1\n for <dev@dpdk.org>; Wed, 22 Jul 2020 02:18:58 +0200 (CEST)", "by mail-ot1-f66.google.com with SMTP id n24so495479otr.13\n for <dev@dpdk.org>; Tue, 21 Jul 2020 17:18:58 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=mime-version:references:in-reply-to:from:date:message-id:subject:to\n :cc; bh=EIobJnJuP96ZI/SlfoFdQUcp/sdGAC9POXy/gXwnKHI=;\n b=dCxmw42hOuzfx6rTZUaGlo/FPhNojvT19Bg97oqJit+iGPzgSZTB54zod867ECWfGu\n O6uuyMiWDT8tif8s/PdiaNkcryfpDacxWJUoNgqoy1pcDTA+jx87xr5ZgkWP1nTDv+da\n vN0elk4WyB6amtPS0+QcVf4ksYKKJoKRKBOo8=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:mime-version:references:in-reply-to:from:date\n :message-id:subject:to:cc;\n bh=EIobJnJuP96ZI/SlfoFdQUcp/sdGAC9POXy/gXwnKHI=;\n b=r1UEPyReG7z+gf1odi8NbSQowtRBe+IxwkpigYBIDmwn4GB41FShCYpdDaN+YE2wyZ\n rW9Y32+OhmeGL5jEy0WuqLbEMyE1BwINOkWg7TjRr0jNCTxk+Wj3Bgs1n7936nUF4EEF\n l4OyS/wJ4tnYb2N1w0Av+OaPWc4oFBy59h8gJRdy8981BnArjEqzJohlCSVq2az2SDMH\n HYah+o/RcEYBaPKuBrNabpuXoigTpgIZBQlREbXuxi7Pa3WFvNBGhrMqwqTFbP+qMW6D\n St6WZREbIpo/VW+Qot0gdrZYbips58iL/vVpmAYR4VbkhIHSKFcDwX8qd/1PXYjZuSjz\n CbxA==", "X-Gm-Message-State": "AOAM532oCTuv1pgmiIpjJaTqfuJhY2g0JX5o1fFnSBRmAJuOi8lUpS44\n uAnpvKfN569K22iT29C/a/+hYmtxzTEM8FVWHBB4Hg==", "X-Google-Smtp-Source": "\n ABdhPJwM97ZLnvlCNvpvgfmOhRwsCsCkNjkHVMM08hQiqpWbpRykViODixjaABLK2yZsuyVSqqbvrwW3XeBVPVTL7U0=", "X-Received": "by 2002:a9d:3b1:: with SMTP id f46mr28579338otf.154.1595377137507;\n Tue, 21 Jul 2020 17:18:57 -0700 (PDT)", "MIME-Version": "1.0", "References": "<20200721174712.48625-1-ajit.khaparde@broadcom.com>\n <6e27fb42-4e42-96a7-d025-6a49f0a30395@intel.com>", "In-Reply-To": "<6e27fb42-4e42-96a7-d025-6a49f0a30395@intel.com>", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "Date": "Tue, 21 Jul 2020 17:18:41 -0700", "Message-ID": "\n <CACZ4nhuerYSguH0rEYdoK5Nf2QLU_8KNfc6KxZ4faQjfZCUY=g@mail.gmail.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "dpdk-dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n David Marchand <david.marchand@redhat.com>", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "Re: [dpdk-dev] [PATCH 1/2] net/bnxt: add meson build option", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]