Patch Comment List
List patch comments
GET /api/patches/74577/comments/?format=api
[ { "id": 116485, "web_url": "https://patches.dpdk.org/comment/116485/", "msgid": "<AM0PR05MB6707CBB3AD2DD1EBAD53B2CFC2790@AM0PR05MB6707.eurprd05.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/AM0PR05MB6707CBB3AD2DD1EBAD53B2CFC2790@AM0PR05MB6707.eurprd05.prod.outlook.com", "date": "2020-07-22T09:11:38", "subject": "Re: [dpdk-dev] [PATCH v3] net/mlx5: return EAGAIN on premature\n disable interrupt calls", "submitter": { "id": 513, "url": "https://patches.dpdk.org/api/people/513/?format=api", "name": "Raslan Darawsheh", "email": "rasland@mellanox.com" }, "content": "Hi,\n\n> -----Original Message-----\n> From: Ophir Munk <ophirmu@mellanox.com>\n> Sent: Tuesday, July 21, 2020 5:41 PM\n> To: dev@dpdk.org\n> Cc: Raslan Darawsheh <rasland@mellanox.com>; Ophir Munk\n> <ophirmu@mellanox.com>; Matan Azrad <matan@mellanox.com>\n> Subject: [PATCH v3] net/mlx5: return EAGAIN on premature disable interrupt\n> calls\n> \n> RXQ interrupts under Linux are based on the epoll mechanism. An\n> expected order of operations is as follows:\n> 1. Call rte_eth_dev_rx_intr_enable(), to arm the CQ for receiving events\n> on data input.\n> 2. Block on rte_epoll_wait() with an array of file descriptors\n> representing the CQ events. Upon data arrival the kernel will signal an\n> input event on the corresponding CQ fd.\n> 3. Call rte_eth_dev_rx_intr_disable() after the event was received and\n> continue in polling mode. The mlx5 implementation of\n> rte_eth_dev_rx_intr_disable() is to get the CQ event and ack it.\n> \n> In practice applications may wake up from rte_epoll_wait() due to\n> timeout with no event to ack but still call\n> rte_eth_dev_rx_intr_disable() unconditionally. In such cases the call\n> should return EAGAIN (since the file descriptors are non-blocked), as\n> opposed to EINVAL which indicates a real failure. In case of EAGAIN the\n> PMD should not warn on \"Unable to disable interrupt on Rx queue\".\n> \n> This commit fixes a earlier commit where the returned value 0 from\n> function devx_get_event() - was considered an error.\n> \n> Fixes: 19e429e5c7c2 (\"net/mlx5: implement CQ for RxQ using DevX API\")\n> \n> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>\n> Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n> Acked-by: Raslan Darawsheh <rasland@mellanox.com>\n> ---\n\n\nPatch applied to next-net-mlx,\n\nKindest regards,\nRaslan Darawsheh", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6DBC0A0526;\n\tWed, 22 Jul 2020 11:11:42 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 85DB71BFCA;\n\tWed, 22 Jul 2020 11:11:41 +0200 (CEST)", "from EUR01-HE1-obe.outbound.protection.outlook.com\n (mail-eopbgr130089.outbound.protection.outlook.com [40.107.13.89])\n by dpdk.org (Postfix) with ESMTP id D8F26199BC\n for <dev@dpdk.org>; Wed, 22 Jul 2020 11:11:39 +0200 (CEST)", "from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17)\n by AM0PR05MB5795.eurprd05.prod.outlook.com (2603:10a6:208:111::26)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.25; Wed, 22 Jul\n 2020 09:11:38 +0000", "from AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.028; Wed, 22 Jul 2020\n 09:11:38 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Bo/tLyKgRHuHVuIhEb6FA1OiSD40ZfuUOjnCCq/2G1UXBk4jor1/vZsdEI2OBLOYRSTO4prXKq/9N0YWdo8jnccXzyhBTbj6yQsiiIsG6O2fdvWSOOlKakecVhBv5lHE+u0MSxx6S2cs5SfjlytaRN8g//0/tkj9/p8IBWYuvrL5kwq3Cr90rnIbX6BkdVXac0bos3rhM+vfmP+M66X4UbX8ebasxglvo7+SmCn2qTepqcIILkqeJY8UTdiqpcdyGr+ovH7mtNzqxnT1MUhLXm6Qe4Nv7x+zfosUj9RKoR+iy9RvBdqHl8RnWQ0usbsTvzGtlWiWfNqF6V82Zbq0gA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=P2nkOSTSMXLJPONIAemBbBha/e6IBP1g2vn2YagA1IU=;\n b=W23jh7ztov7rAo+qeS2krJCg/PJzUGgZ2Zo0SHYVAnPN7B+KDjrMzkyUlpeqvk7Z4owWsZGZzYbqRo6RjdnTUuGKkHHGAHdLED+RwOACqF1LEirjZTNEH6AA0G9yzwT5GSfTob9DMwuii9wnMHFoEudMVhKc9qDBnIDZKCLpCFY/6c1ARSCfeE7ek3jjsKDjeTlfndsAvDpIQSbd3o6+vy9UySq4BLWQE/Azh00Bog17713TzmWXSQ+1ysyJ58g1vc6qc/mpqdvE9z5gMijX06mQHIe/CLL6dPrz+kDj2nN7u29UWa5dCPAIWelTh9S7sb/XE/WbZKNJ/vWTVT8uig==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=P2nkOSTSMXLJPONIAemBbBha/e6IBP1g2vn2YagA1IU=;\n b=fzH7qsl5fFK6Si6NHTqf86mD5MSPb3Ng8XM5WfbdXrPv9jo3CbSfQYK+Szm8YjPKwZcHa6Jv7UwfEv0YXnAeJue8yqnUgmMjECjMTKOcBt8TFECJG2xzhuzUBNZE+3I5nEIySyJUH40FPNmiuPOvmEVRTfjCPVwlfp+CNpofkw8=", "From": "Raslan Darawsheh <rasland@mellanox.com>", "To": "Ophir Munk <ophirmu@mellanox.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "Matan Azrad <matan@mellanox.com>", "Thread-Topic": "[PATCH v3] net/mlx5: return EAGAIN on premature disable\n interrupt calls", "Thread-Index": "AQHWX2z8Ryt9EKMfJkuyBYWzs4tq8akTUPSw", "Date": "Wed, 22 Jul 2020 09:11:38 +0000", "Message-ID": "\n <AM0PR05MB6707CBB3AD2DD1EBAD53B2CFC2790@AM0PR05MB6707.eurprd05.prod.outlook.com>", "References": "<20200721142449.24767-2-ophirmu@mellanox.com>\n <20200721144107.25550-1-ophirmu@mellanox.com>\n <20200721144107.25550-2-ophirmu@mellanox.com>", "In-Reply-To": "<20200721144107.25550-2-ophirmu@mellanox.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "mellanox.com; dkim=none (message not signed)\n header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com;", "x-originating-ip": "[84.242.49.134]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-ht": "Tenant", "x-ms-office365-filtering-correlation-id": "1bc60510-3767-4c3f-405c-08d82e1f3da8", "x-ms-traffictypediagnostic": "AM0PR05MB5795:", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <AM0PR05MB5795023B57A3404BA8B88DDFC2790@AM0PR05MB5795.eurprd05.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:1284;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n IvzUJrwYrVOhtFLkZdDcVEJCW9a7EvNQDvagnfGFbHTThBVzap7n1jglLEzW/BNq+JcUd6CQEyDmh0RUDvdrbo2c5dHXPdPf6b0SBVzTkWE3+FJIzfyCtOIDhDJW2jG2Z+Eri9RMwKmTICFvrS/d3+0BWHN6HviuC9Ys8pHdXdQ4sOdu5N9AeanFNxyCpXbfK7iNYMHac7zvCSwJM4CbZGo4RgOM1I4B0xt0vPoAjvg521Wh3GCcLND+TbnkYHutvLIxnm1TvKmjHTl2Po9PW/K6JgrsYryMjJ0aj2SABJkuHtisFwSnpog2M+QD2CQTATcTsU4+TXVleeckcLloxg==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(39860400002)(136003)(396003)(376002)(346002)(366004)(4326008)(107886003)(83380400001)(478600001)(316002)(7696005)(9686003)(6506007)(53546011)(110136005)(33656002)(8936002)(186003)(5660300002)(8676002)(26005)(52536014)(55016002)(86362001)(2906002)(66446008)(66556008)(66946007)(66476007)(76116006)(71200400001)(64756008);\n DIR:OUT; SFP:1101;", "x-ms-exchange-antispam-messagedata": "\n JalpELXBLq+UGSgq4DDAkZLQbosjT+117eEbdNEDSGU8jMVDobDw11LayAdg4SNkS2E3UdvBHRjoAL0KFGEY4lTaaAkDchr45sS7uvb1HCCJ4yRdjMd2O1v+FH2qFSluXjEpJvwzrpQ48ln5s4SS1oNQ9V/q9R9lM0HitMtoameiDPdSyUkQG3eJQb2P3sEReliIHAezS4pGShYSplPzTQkLD2agwR7QTxob7WAZvhvHok0KfzMr5RSM7y9Gtpn9NHXqskGrPBgdBwQ8LUUvgruoXp2cBDksYyIsbI7WtGaGOMIGzpPsuEkcJOO/KtWEylhHKJ3mWDph5tJ9gOnKUMYhhKn6d8/3N4ZLAX2dyR7fxNVemQjUBv9w+vQ5KiHatlZGVXPDYtWbUFEoQGepWFtQ4MRUpAewqoenxA+Pbe3d/IMBnA2FiKtV+x2hWttMKuTRiqEaNKoa+TM2wfZSRRUP74ivsnpy6d5WIFoF3NpYnLZB4u/bHDKNCMnqQNJV", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB6707.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 1bc60510-3767-4c3f-405c-08d82e1f3da8", "X-MS-Exchange-CrossTenant-originalarrivaltime": "22 Jul 2020 09:11:38.5528 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n dUFrXH48oX5ChPPXAv90NOVdQ7oWO+GuCIrpYyyV/Z8VIpupKD6rUS8xi++i+vPfpQpQeqObbEBQL4kG01/kdQ==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR05MB5795", "Subject": "Re: [dpdk-dev] [PATCH v3] net/mlx5: return EAGAIN on premature\n disable interrupt calls", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]