Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74575/?format=api
{ "id": 74575, "url": "https://patches.dpdk.org/api/patches/74575/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200721133658.3227-1-adamx.dybkowski@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200721133658.3227-1-adamx.dybkowski@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200721133658.3227-1-adamx.dybkowski@intel.com", "date": "2020-07-21T13:36:58", "name": "common/qat: remove unused fields", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "69868f2a82c937186121d5c1604bf4a4037991f2", "submitter": { "id": 1322, "url": "https://patches.dpdk.org/api/people/1322/?format=api", "name": "Dybkowski, AdamX", "email": "adamx.dybkowski@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200721133658.3227-1-adamx.dybkowski@intel.com/mbox/", "series": [ { "id": 11212, "url": "https://patches.dpdk.org/api/series/11212/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11212", "date": "2020-07-21T13:36:58", "name": "common/qat: remove unused fields", "version": 1, "mbox": "https://patches.dpdk.org/series/11212/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/74575/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/74575/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D42C3A0526;\n\tTue, 21 Jul 2020 15:37:46 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B57021BFEE;\n\tTue, 21 Jul 2020 15:37:45 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by dpdk.org (Postfix) with ESMTP id C3F411BFEB\n for <dev@dpdk.org>; Tue, 21 Jul 2020 15:37:43 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jul 2020 06:37:42 -0700", "from adamdybx-mobl.ger.corp.intel.com ([10.104.125.42])\n by orsmga002.jf.intel.com with ESMTP; 21 Jul 2020 06:37:41 -0700" ], "IronPort-SDR": [ "\n IWHGBa4ANS7z7mwyiySZNtRTJM+3pVyYs1wykSfVDoZNlL7yeaOan+cYSVPAJdLIlIBc7pr0r/\n c36Tr+/9JRkg==", "\n N1peF52djozPNy9Xoy3JUD8dXqYd2aNVZkmzyebkZgI1UOWmwfHDXmw6qNzDZn8MgsDwXQAn4t\n eIP7I6OIRfwg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9688\"; a=\"129693855\"", "E=Sophos;i=\"5.75,379,1589266800\"; d=\"scan'208\";a=\"129693855\"", "E=Sophos;i=\"5.75,379,1589266800\"; d=\"scan'208\";a=\"301615048\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Adam Dybkowski <adamx.dybkowski@intel.com>", "To": "dev@dpdk.org,\n\tfiona.trahe@intel.com,\n\takhil.goyal@nxp.com", "Cc": "Adam Dybkowski <adamx.dybkowski@intel.com>", "Date": "Tue, 21 Jul 2020 15:36:58 +0200", "Message-Id": "<20200721133658.3227-1-adamx.dybkowski@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] common/qat: remove unused fields", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch removes unused fields from structs qat_qp and\nqat_qp_config, together with their initializations.\n\nSigned-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>\n---\n drivers/common/qat/qat_qp.c | 1 -\n drivers/common/qat/qat_qp.h | 8 +-------\n drivers/compress/qat/qat_comp_pmd.c | 1 -\n drivers/crypto/qat/qat_asym_pmd.c | 1 -\n drivers/crypto/qat/qat_sym_pmd.c | 1 -\n 5 files changed, 1 insertion(+), 11 deletions(-)", "diff": "diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c\nindex aacd4ab21..f7e478a4f 100644\n--- a/drivers/common/qat/qat_qp.c\n+++ b/drivers/common/qat/qat_qp.c\n@@ -292,7 +292,6 @@ int qat_qp_setup(struct qat_pci_device *qat_dev,\n \t}\n \n \tqp->qat_dev_gen = qat_dev->qat_dev_gen;\n-\tqp->build_request = qat_qp_conf->build_request;\n \tqp->service_type = qat_qp_conf->hw->service_type;\n \tqp->qat_dev = qat_dev;\n \ndiff --git a/drivers/common/qat/qat_qp.h b/drivers/common/qat/qat_qp.h\nindex 575d69059..74f7e7dae 100644\n--- a/drivers/common/qat/qat_qp.h\n+++ b/drivers/common/qat/qat_qp.h\n@@ -14,11 +14,6 @@ struct qat_pci_device;\n \n #define QAT_QP_MIN_INFL_THRESHOLD\t256\n \n-typedef int (*build_request_t)(void *op,\n-\t\tuint8_t *req, void *op_cookie,\n-\t\tenum qat_device_gen qat_dev_gen);\n-/**< Build a request from an op. */\n-\n /**\n * Structure with data needed for creation of queue pair.\n */\n@@ -30,6 +25,7 @@ struct qat_qp_hw_data {\n \tuint16_t tx_msg_size;\n \tuint16_t rx_msg_size;\n };\n+\n /**\n * Structure with data needed for creation of queue pair.\n */\n@@ -38,7 +34,6 @@ struct qat_qp_config {\n \tuint32_t nb_descriptors;\n \tuint32_t cookie_size;\n \tint socket_id;\n-\tbuild_request_t build_request;\n \tconst char *service_str;\n };\n \n@@ -73,7 +68,6 @@ struct qat_qp {\n \tvoid **op_cookies;\n \tuint32_t nb_descriptors;\n \tenum qat_device_gen qat_dev_gen;\n-\tbuild_request_t build_request;\n \tenum qat_service_type service_type;\n \tstruct qat_pci_device *qat_dev;\n \t/**< qat device this qp is on */\ndiff --git a/drivers/compress/qat/qat_comp_pmd.c b/drivers/compress/qat/qat_comp_pmd.c\nindex 73e23c018..311e56168 100644\n--- a/drivers/compress/qat/qat_comp_pmd.c\n+++ b/drivers/compress/qat/qat_comp_pmd.c\n@@ -124,7 +124,6 @@ qat_comp_qp_setup(struct rte_compressdev *dev, uint16_t qp_id,\n \t}\n \n \tqat_qp_conf.hw = qp_hw_data;\n-\tqat_qp_conf.build_request = qat_comp_build_request;\n \tqat_qp_conf.cookie_size = sizeof(struct qat_comp_op_cookie);\n \tqat_qp_conf.nb_descriptors = max_inflight_ops;\n \tqat_qp_conf.socket_id = socket_id;\ndiff --git a/drivers/crypto/qat/qat_asym_pmd.c b/drivers/crypto/qat/qat_asym_pmd.c\nindex 968ec54ee..ed8a2a50b 100644\n--- a/drivers/crypto/qat/qat_asym_pmd.c\n+++ b/drivers/crypto/qat/qat_asym_pmd.c\n@@ -145,7 +145,6 @@ static int qat_asym_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \t}\n \n \tqat_qp_conf.hw = qp_hw_data;\n-\tqat_qp_conf.build_request = qat_asym_build_request;\n \tqat_qp_conf.cookie_size = sizeof(struct qat_asym_op_cookie);\n \tqat_qp_conf.nb_descriptors = qp_conf->nb_descriptors;\n \tqat_qp_conf.socket_id = socket_id;\ndiff --git a/drivers/crypto/qat/qat_sym_pmd.c b/drivers/crypto/qat/qat_sym_pmd.c\nindex c7e323cce..50626754b 100644\n--- a/drivers/crypto/qat/qat_sym_pmd.c\n+++ b/drivers/crypto/qat/qat_sym_pmd.c\n@@ -181,7 +181,6 @@ static int qat_sym_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \t}\n \n \tqat_qp_conf.hw = qp_hw_data;\n-\tqat_qp_conf.build_request = qat_sym_build_request;\n \tqat_qp_conf.cookie_size = sizeof(struct qat_sym_op_cookie);\n \tqat_qp_conf.nb_descriptors = qp_conf->nb_descriptors;\n \tqat_qp_conf.socket_id = socket_id;\n", "prefixes": [] }