Patch Comment List
List patch comments
GET /api/patches/74574/comments/?format=api
[ { "id": 116434, "web_url": "https://patches.dpdk.org/comment/116434/", "msgid": "<DB6PR0802MB2216A19D97A481DB7A85DF8198780@DB6PR0802MB2216.eurprd08.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/DB6PR0802MB2216A19D97A481DB7A85DF8198780@DB6PR0802MB2216.eurprd08.prod.outlook.com", "date": "2020-07-21T17:26:59", "subject": "Re: [dpdk-dev] [PATCH] hash: fix return value of null not checked", "submitter": { "id": 1045, "url": "https://patches.dpdk.org/api/people/1045/?format=api", "name": "Honnappa Nagarahalli", "email": "honnappa.nagarahalli@arm.com" }, "content": "> -----Original Message-----\n> From: dev <dev-bounces@dpdk.org> On Behalf Of wangyunjian\n> Sent: Tuesday, July 21, 2020 8:32 AM\n> To: dev@dpdk.org\n> Cc: yipeng1.wang@intel.com; sameh.gobriel@intel.com;\n> bruce.richardson@intel.com; jerry.lilijun@huawei.com;\n> xudingke@huawei.com; Yunjian Wang <wangyunjian@huawei.com>;\n> stable@dpdk.org\n> Subject: [dpdk-dev] [PATCH] hash: fix return value of null not checked\n> \n> From: Yunjian Wang <wangyunjian@huawei.com>\n> \n> The function rte_zmalloc_socket() could return NULL, the return value need to\n> be checked.\n> \n> Fixes: 5915699153d7 (\"hash: fix scaling by reducing contention\")\n> Cc: stable@dpdk.org\n> \n> Reported-by: HuangBin <brian.huangbin@huawei.com>\n> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>\nGood catch\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n\n> ---\n> lib/librte_hash/rte_cuckoo_hash.c | 9 ++++++++-\n> 1 file changed, 8 insertions(+), 1 deletion(-)\n> \n> diff --git a/lib/librte_hash/rte_cuckoo_hash.c\n> b/lib/librte_hash/rte_cuckoo_hash.c\n> index 5f701d579..0a6d47471 100644\n> --- a/lib/librte_hash/rte_cuckoo_hash.c\n> +++ b/lib/librte_hash/rte_cuckoo_hash.c\n> @@ -151,6 +151,7 @@ rte_hash_create(const struct rte_hash_parameters\n> *params)\n> \tunsigned int no_free_on_del = 0;\n> \tuint32_t *ext_bkt_to_free = NULL;\n> \tuint32_t *tbl_chng_cnt = NULL;\n> +\tstruct lcore_cache *local_free_slots = NULL;\n> \tunsigned int readwrite_concur_lf_support = 0;\n> \tuint32_t i;\n> \n> @@ -383,9 +384,13 @@ rte_hash_create(const struct rte_hash_parameters\n> *params) #endif\n> \n> \tif (use_local_cache) {\n> -\t\th->local_free_slots = rte_zmalloc_socket(NULL,\n> +\t\tlocal_free_slots = rte_zmalloc_socket(NULL,\n> \t\t\t\tsizeof(struct lcore_cache) * RTE_MAX_LCORE,\n> \t\t\t\tRTE_CACHE_LINE_SIZE, params->socket_id);\n> +\t\tif (local_free_slots == NULL) {\n> +\t\t\tRTE_LOG(ERR, HASH, \"local free slots memory\n> allocation failed\\n\");\n> +\t\t\tgoto err_unlock;\n> +\t\t}\n> \t}\n> \n> \t/* Default hash function */\n> @@ -416,6 +421,7 @@ rte_hash_create(const struct rte_hash_parameters\n> *params)\n> \t*h->tbl_chng_cnt = 0;\n> \th->hw_trans_mem_support = hw_trans_mem_support;\n> \th->use_local_cache = use_local_cache;\n> +\th->local_free_slots = local_free_slots;\n> \th->readwrite_concur_support = readwrite_concur_support;\n> \th->ext_table_support = ext_table_support;\n> \th->writer_takes_lock = writer_takes_lock; @@ -461,6 +467,7 @@\n> rte_hash_create(const struct rte_hash_parameters *params)\n> \trte_ring_free(r);\n> \trte_ring_free(r_ext);\n> \trte_free(te);\n> +\trte_free(local_free_slots);\n> \trte_free(h);\n> \trte_free(buckets);\n> \trte_free(buckets_ext);\n> --\n> 2.23.0\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 439A2A0526;\n\tTue, 21 Jul 2020 19:27:11 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 256C81BFEF;\n\tTue, 21 Jul 2020 19:27:11 +0200 (CEST)", "from EUR05-AM6-obe.outbound.protection.outlook.com\n (mail-am6eur05on2079.outbound.protection.outlook.com [40.107.22.79])\n by dpdk.org (Postfix) with ESMTP id A2EA7E07;\n Tue, 21 Jul 2020 19:27:09 +0200 (CEST)", "from AM6P193CA0139.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::44)\n by VE1PR08MB5118.eurprd08.prod.outlook.com (2603:10a6:803:107::33) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Tue, 21 Jul\n 2020 17:27:07 +0000", "from VE1EUR03FT047.eop-EUR03.prod.protection.outlook.com\n (2603:10a6:209:85:cafe::ac) by AM6P193CA0139.outlook.office365.com\n (2603:10a6:209:85::44) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.21 via Frontend\n Transport; Tue, 21 Jul 2020 17:27:07 +0000", "from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by\n VE1EUR03FT047.mail.protection.outlook.com (10.152.19.218) with\n Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.3195.18 via Frontend Transport; Tue, 21 Jul 2020 17:27:06 +0000", "(\"Tessian outbound 8f45de5545d6:v62\");\n Tue, 21 Jul 2020 17:27:05 +0000", "from 5bac6a548d42.1\n by 64aa7808-outbound-1.mta.getcheckrecipient.com id\n 811A1FCB-F132-4CD4-B3FE-25A3BD75237A.1;\n Tue, 21 Jul 2020 17:26:59 +0000", "from EUR04-DB3-obe.outbound.protection.outlook.com\n by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id\n 5bac6a548d42.1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);\n Tue, 21 Jul 2020 17:26:59 +0000", "from DB6PR0802MB2216.eurprd08.prod.outlook.com (2603:10a6:4:85::9)\n by DB6PR0801MB1830.eurprd08.prod.outlook.com (2603:10a6:4:35::8) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.25; Tue, 21 Jul\n 2020 17:26:59 +0000", "from DB6PR0802MB2216.eurprd08.prod.outlook.com\n ([fe80::9d1d:207b:e89d:199d]) by DB6PR0802MB2216.eurprd08.prod.outlook.com\n ([fe80::9d1d:207b:e89d:199d%10]) with mapi id 15.20.3195.026; Tue, 21 Jul\n 2020 17:26:59 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;\n s=selector2-armh-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=HGf4z2yQQco5W1LoKncqt/7/ktgZ1m8JtvL/WL7wm5E=;\n b=SGjaiS49EVG5lM69cNjNs1FMiTiRhN8maLa7cEFYxr/hLhIR0NVuYfWeob82M4iCtVl55YiD9KriBd3DmJANJdvWAmu63+V4X4hrMskOTeDXMi+eKpWcQ5rau3IDB05WlD868xSWatu9RFFP9/R6KNb/pLGlzMR6dqkRbxnobeQ=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;\n s=selector2-armh-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=HGf4z2yQQco5W1LoKncqt/7/ktgZ1m8JtvL/WL7wm5E=;\n b=SGjaiS49EVG5lM69cNjNs1FMiTiRhN8maLa7cEFYxr/hLhIR0NVuYfWeob82M4iCtVl55YiD9KriBd3DmJANJdvWAmu63+V4X4hrMskOTeDXMi+eKpWcQ5rau3IDB05WlD868xSWatu9RFFP9/R6KNb/pLGlzMR6dqkRbxnobeQ=" ], "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 63.35.35.123)\n smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified)\n header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none\n header.from=arm.com;", "Received-SPF": "Pass (protection.outlook.com: domain of arm.com designates\n 63.35.35.123 as permitted sender) receiver=protection.outlook.com;\n client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;", "X-CR-MTA-TID": "64aa7808", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=G5TRSbcTCOzEK+3QVKE8ql8VOBuDqmBDkad1OyK1cKRQwrIZrXvLmh/4/pKBWy7c0v4XQxtPyhNx+THrbuRMuuhWrW5rUkPlin9gQxyu9cOIT1EHa8RVzy2bPC/4NcbE2LOdDBHRumEYLE6CLx512nicBlfU/5/8sgdP3ohfbBS4Mhcb5lrpgnrfr3waFBUMR9Nkm8k0AidfR8n6XkEhq2H5lyq2ODsM0kAnRQCDeBLVi2VLD2jpxxLzAc0ABw9InZsoo/unV3kcwj9yCkUCfnya1OZxUZC/Va/jwOOZw5jHEdtt2QTx1NsUu3N58UCdLHLU7DPtQuXF/mdl/csJpg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=HGf4z2yQQco5W1LoKncqt/7/ktgZ1m8JtvL/WL7wm5E=;\n b=klNIfXAIhG1jXWSc0YGmp29H7B5BgIWZb/TGeME/s/E7C6r0ttDIvTzV4LM/9cQWSNjQ+mTgElIMrLBaER567/ru3fpSKKdc6Um7SKaqy0gyVn6ENKCYGJ4MZLLnlkjcGsgYp5HYgnsuJknTFxghuqizlV1EUUKOutZktpFzLltHr4yEKCCfx+FHHSaw1tETrnDRbFj6T8rjYfO+SMhPdmN56UIMiXYM2PQ5OT+UWoVVL4k7JMxZndcISgDM4IJ5DQdGKw7+lhYqZtc9ICVZPIjeYLnxyRO8S17phBhylkBL+UkeRXoe+/HerepbA7Be5ny/HmRQQqwMKHModwxc7A==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass\n header.d=arm.com; arc=none", "From": "Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>", "To": "wangyunjian <wangyunjian@huawei.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"yipeng1.wang@intel.com\" <yipeng1.wang@intel.com>,\n \"sameh.gobriel@intel.com\" <sameh.gobriel@intel.com>,\n \"bruce.richardson@intel.com\" <bruce.richardson@intel.com>,\n \"jerry.lilijun@huawei.com\" <jerry.lilijun@huawei.com>, \"xudingke@huawei.com\"\n <xudingke@huawei.com>, \"stable@dpdk.org\" <stable@dpdk.org>, nd <nd@arm.com>,\n Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, nd <nd@arm.com>", "Thread-Topic": "[dpdk-dev] [PATCH] hash: fix return value of null not checked", "Thread-Index": "AQHWX2Njk9zMmmExek+h8Go88G37fakSRpVw", "Date": "Tue, 21 Jul 2020 17:26:59 +0000", "Message-ID": "\n <DB6PR0802MB2216A19D97A481DB7A85DF8198780@DB6PR0802MB2216.eurprd08.prod.outlook.com>", "References": "\n <d87e2f714999b83c69685950d43a85350dc1441c.1595335031.git.wangyunjian@huawei.com>", "In-Reply-To": "\n <d87e2f714999b83c69685950d43a85350dc1441c.1595335031.git.wangyunjian@huawei.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-ts-tracking-id": "ece6cf73-fc91-4fa4-921d-8cca2112cf7c.0", "x-checkrecipientchecked": "true", "Authentication-Results-Original": "huawei.com; dkim=none (message not signed)\n header.d=none;huawei.com; dmarc=none action=none header.from=arm.com;", "x-originating-ip": "[70.112.90.121]", "x-ms-publictraffictype": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "d71dca8c-cc27-42d8-abfa-08d82d9b4ab0", "x-ms-traffictypediagnostic": "DB6PR0801MB1830:|VE1PR08MB5118:", "x-ms-exchange-transport-forked": "True", "X-Microsoft-Antispam-PRVS": "\n <VE1PR08MB5118CF483215223E5241654698780@VE1PR08MB5118.eurprd08.prod.outlook.com>", "x-checkrecipientrouted": "true", "nodisclaimer": "true", "x-ms-oob-tlc-oobclassifiers": "OLM:862;OLM:862;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam-Untrusted": "BCL:0;", "X-Microsoft-Antispam-Message-Info-Original": "\n yfqFngoU+v1hHfga4CE3mJWgTyR89EZNafxsWv3GqKYM5fJo8qWb09gjFYeHtM5wmKtp6W5LNJ8zpou1SJKA3V/sujqwyUjs+JzCYnqaeyDXuF1xxhhLpy8Kg1lAHPFb+42k4v94HX4Yn8W7ybjipzosln2qGaXN0sWgCLiXO1uK/32DP6di/MiewLOjfTrUZ9yYWrNIhUDF6FWfS5nwoK6BA0QTrbWJP/dNpoMneffu/9B/3/DbZiGGX1CVMt1KaqPG/GLE6zhhxUL3HOvsndAPZ2jzZncCiseOMxQgrDDZcWAkzapfQfw1MIzjrR12aH3hK0zupI5TSx4tuf7dcg==", "X-Forefront-Antispam-Report-Untrusted": "CIP:255.255.255.255; CTRY:; LANG:en;\n SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0802MB2216.eurprd08.prod.outlook.com;\n PTR:; CAT:NONE; SFTY:;\n SFS:(4636009)(366004)(39860400002)(396003)(136003)(346002)(376002)(55016002)(5660300002)(52536014)(64756008)(66556008)(66446008)(66476007)(33656002)(478600001)(71200400001)(4326008)(2906002)(54906003)(8936002)(8676002)(76116006)(9686003)(66946007)(86362001)(6506007)(53546011)(26005)(83380400001)(316002)(110136005)(7696005)(186003);\n DIR:OUT; SFP:1101;", "x-ms-exchange-antispam-messagedata": "\n OYVur4BOG0Ebe+ZWE/5US/TcTKWd/oiJ4orJtEER7BHSmvDRSjDEDzes+I/0kE9AaGaxIwB/In+MVuWAiJ10eGJzJARLDF3Vbehy3YQzlK/uLzP+h7j354RFBfyvRyYcB4fvFyQr0DhDz6kfaNxJtUSwEjIqX9M5l8W+44oizvqj3aJm05CBe+vMfcZ9gu1wdMBTAN3OuYZfyEu7/wLn6kx2MEUoStAHXWcadnvg5v6iZgSoWfakcc9BzF7SZsyDjrPP8gIcFRueSeqt+jO1mOqzyrAkEmlMeIpKTHXD4szulok7ySy85c/MZUJS0Sv3Lhlib2a2oHq8EYlj6NN15/ACE4GEZJIeGFV9bism2jrBUMKpl07n/JWchiWbrv1EMfRjiA/Z9AorZwoeKe1XAFEVhKfTm6eZ0A2sIilwypPsWsBR9J9j5kjxhDRNI2jp5u6xVp1MC9Cq11cP1idA4ATB2YTGdDvSahZJDIXZsMBaPkT4MpceW/H5kkqH++bZ", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": [ "DB6PR0801MB1830", "VE1PR08MB5118" ], "Original-Authentication-Results": "huawei.com; dkim=none (message not signed)\n header.d=none;huawei.com; dmarc=none action=none header.from=arm.com;", "X-EOPAttributedMessage": "0", "X-MS-Exchange-Transport-CrossTenantHeadersStripped": "\n VE1EUR03FT047.eop-EUR03.prod.protection.outlook.com", "X-Forefront-Antispam-Report": "CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com;\n PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:;\n SFS:(4636009)(346002)(136003)(396003)(376002)(39860400002)(46966005)(7696005)(5660300002)(8936002)(8676002)(336012)(52536014)(2906002)(33656002)(4326008)(26005)(47076004)(53546011)(450100002)(86362001)(316002)(9686003)(81166007)(83380400001)(186003)(70206006)(356005)(478600001)(82310400002)(36906005)(110136005)(6506007)(54906003)(82740400003)(70586007)(55016002);\n DIR:OUT; SFP:1101;", "X-MS-Office365-Filtering-Correlation-Id-Prvs": "\n 493e0a67-fb82-4493-bf8f-08d82d9b461d", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 129eZI9DPRhGgO0QBMwXkg7NwakVJUX7DfvLMLsnA0nPIoe5GWhzQZw890l8Sce14wqJZYgckxKNek9aAGmHbv6MkC4a53+U2NY5EYFaECOCtuK0xC6UwRPhFY34zDnS/ZnEKDlb32Ywb5jVJcenXCKuM+e/sfLQ/ciTkE74dZV8cvr9X6F8bwgAUtvrsJWyfYJ9ucuDiGkP0hf20T4azpgB617tQ0Z/OLfiE8OFxSqzLexN4DWnAObsCHrLGHLtphFJoI2I5xyXu3VGkuljkrNqgLDpfMG6vyyPUZCh+5zCHGihje1hjIT2NSyH6xG3Z8qDkcqL23Aw0F1y7FmrOSZ3K0tLA3apygW9qBIYP3jRsj7p/GwMvUYHbNA5oB3E29TVpiynvjJX/Jv2XN1EiA==", "X-OriginatorOrg": "arm.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "21 Jul 2020 17:27:06.6378 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n d71dca8c-cc27-42d8-abfa-08d82d9b4ab0", "X-MS-Exchange-CrossTenant-Id": "f34e5979-57d9-4aaa-ad4d-b122a662184d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123];\n Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n VE1EUR03FT047.eop-EUR03.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "Subject": "Re: [dpdk-dev] [PATCH] hash: fix return value of null not checked", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116447, "web_url": "https://patches.dpdk.org/comment/116447/", "msgid": "<BYAPR11MB3494D5D8D224B6E134305B81C3780@BYAPR11MB3494.namprd11.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/BYAPR11MB3494D5D8D224B6E134305B81C3780@BYAPR11MB3494.namprd11.prod.outlook.com", "date": "2020-07-21T20:24:11", "subject": "Re: [dpdk-dev] [PATCH] hash: fix return value of null not checked", "submitter": { "id": 754, "url": "https://patches.dpdk.org/api/people/754/?format=api", "name": "Wang, Yipeng1", "email": "yipeng1.wang@intel.com" }, "content": "> -----Original Message-----\n> From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>\n> Sent: Tuesday, July 21, 2020 10:27 AM\n> To: wangyunjian <wangyunjian@huawei.com>; dev@dpdk.org\n> Cc: Wang, Yipeng1 <yipeng1.wang@intel.com>; Gobriel, Sameh\n> <sameh.gobriel@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>;\n> jerry.lilijun@huawei.com; xudingke@huawei.com; stable@dpdk.org; nd\n> <nd@arm.com>; Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>;\n> nd <nd@arm.com>\n> Subject: RE: [dpdk-dev] [PATCH] hash: fix return value of null not checked\n> \n> \n> \n> > -----Original Message-----\n> > From: dev <dev-bounces@dpdk.org> On Behalf Of wangyunjian\n> > Sent: Tuesday, July 21, 2020 8:32 AM\n> > To: dev@dpdk.org\n> > Cc: yipeng1.wang@intel.com; sameh.gobriel@intel.com;\n> > bruce.richardson@intel.com; jerry.lilijun@huawei.com;\n> > xudingke@huawei.com; Yunjian Wang <wangyunjian@huawei.com>;\n> > stable@dpdk.org\n> > Subject: [dpdk-dev] [PATCH] hash: fix return value of null not checked\n> >\n> > From: Yunjian Wang <wangyunjian@huawei.com>\n> >\n> > The function rte_zmalloc_socket() could return NULL, the return value\n> > need to be checked.\n> >\n> > Fixes: 5915699153d7 (\"hash: fix scaling by reducing contention\")\n> > Cc: stable@dpdk.org\n> >\n> > Reported-by: HuangBin <brian.huangbin@huawei.com>\n[Wang, Yipeng] missed a space in name?\n\n> > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>\n> Good catch\n> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n[Wang, Yipeng] \nThanks for the fix!\n\nAcked-by: Yipeng Wang <yipeng1.wang@intel.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 59DC3A0526;\n\tTue, 21 Jul 2020 22:24:18 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 36FAB1C0B1;\n\tTue, 21 Jul 2020 22:24:18 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id 4F94B1C030;\n Tue, 21 Jul 2020 22:24:16 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jul 2020 13:24:15 -0700", "from orsmsx106.amr.corp.intel.com ([10.22.225.133])\n by orsmga002.jf.intel.com with ESMTP; 21 Jul 2020 13:24:15 -0700", "from ORSEDG001.ED.cps.intel.com (10.7.248.4) by\n ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Tue, 21 Jul 2020 13:24:14 -0700", "from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175)\n by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Tue, 21 Jul 2020 13:24:14 -0700", "from BYAPR11MB3494.namprd11.prod.outlook.com (2603:10b6:a03:86::15)\n by BY5PR11MB3941.namprd11.prod.outlook.com (2603:10b6:a03:183::14)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20; Tue, 21 Jul\n 2020 20:24:12 +0000", "from BYAPR11MB3494.namprd11.prod.outlook.com\n ([fe80::69d4:7531:329e:ec8c]) by BYAPR11MB3494.namprd11.prod.outlook.com\n ([fe80::69d4:7531:329e:ec8c%7]) with mapi id 15.20.3195.026; Tue, 21 Jul 2020\n 20:24:12 +0000" ], "IronPort-SDR": [ "\n 9nd7qxYxK3+Ozm+Tn0rECKF2/5vwcZJHiaCVF+XZzZhtIcl8vW+Ji2bkhnZEOjRmnOPdWAP7Wp\n vCtb/g3qBJlg==", "\n rxxUx+TXHDvJvZ6+Sv6ZZu8Xuxo2EtDudeTshLiktlvYq7d8qqo+odZJ+I5luknoSd/F+LDCRE\n CeBnBLT2NTgw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9689\"; a=\"211769058\"", "E=Sophos;i=\"5.75,380,1589266800\"; d=\"scan'208\";a=\"211769058\"", "E=Sophos;i=\"5.75,380,1589266800\"; d=\"scan'208\";a=\"301728330\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=hpAwgB23ZXTYsRPfebcPGGXb0S0sJkzkOWA6w53oe/nB+mb34kNsZBM9wi9bjNQ/fFdIYMqSPp5dyJGfiEvgsy5qB2WLvAYO28nY6xZuGK4JcSoh4TyCDcoZTh/nhdeTteFng39LQf43ZkmXB9r4GL+mtPevp8Ysj0WVjr+keOgkf6QB5BByREaey/NwcX73bslvbLcPJR25Wgb8tsX1DO3ef0hK5aMMd/14a7vAPWVGcfJ7o7K3fWIFPmOy0jqnFiEglyZdmcNh+pHWIOVUiEyOs0pb+pRgsydvWj52MNPYPOsDbjhSudoZCUVIZmxBgkixbgkMmhdQ7DED8rVVZA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=CM9CgbS5noSwy7h9g2uH/Is0e1PkjDknp3xzzOnmzJQ=;\n b=LWXghxaMk3iH9J0qryEazsrbzXq/oRBK95xTLrQ7eBru4mRwcbGU2i+wPDwd7zb+tqy+Usn6DTEjS7i8ExfOKTgu/O7eszzkgNfTW2ek8/wmu+zQKt30Php1pMmFWhMYRRxSda0osBaNZTPFxkRTJoweyz7Pbfs4J36jxB7y2I1YCvm9Hmw/1rHgMZQxHKapSOyueUzxvIKEsyygY/cZpv6mxTrArgdaZ3zMUbwsAaw9SbBg8gIoVSR25xvJE7VFk3Vlr+CAmcCBA2YGB6O+YBPV6Da1p0w68/kF8qOg+DCb55Qbxk5ClgUrpxTU7uzGzB2ffSFMMqYkcnDDD9fWQA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;\n s=selector2-intel-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=CM9CgbS5noSwy7h9g2uH/Is0e1PkjDknp3xzzOnmzJQ=;\n b=bTkO8b/pPa001q0SM76VOSPxuzvgv/+MsIX8kH/bEWJBkt5oL5BB0VdNk8askn5lM1nbbuLaIKDLT0R9ebhEBnt//bx5je4nhSJ9qBJL399o9CUA2oTIGYcLeZeyaSO8n1zwQe/pGCsr5AfMAvGFNHHECUy5jjfG+l3eWYvsylQ=", "From": "\"Wang, Yipeng1\" <yipeng1.wang@intel.com>", "To": "Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, wangyunjian\n <wangyunjian@huawei.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"Gobriel, Sameh\" <sameh.gobriel@intel.com>, \"Richardson, Bruce\"\n <bruce.richardson@intel.com>, \"jerry.lilijun@huawei.com\"\n <jerry.lilijun@huawei.com>, \"xudingke@huawei.com\" <xudingke@huawei.com>,\n \"stable@dpdk.org\" <stable@dpdk.org>, nd <nd@arm.com>", "Thread-Topic": "[dpdk-dev] [PATCH] hash: fix return value of null not checked", "Thread-Index": "AQHWX4QzWFgPoNTG8kuIpJFvxkt0PakSee9A", "Date": "Tue, 21 Jul 2020 20:24:11 +0000", "Message-ID": "\n <BYAPR11MB3494D5D8D224B6E134305B81C3780@BYAPR11MB3494.namprd11.prod.outlook.com>", "References": "\n <d87e2f714999b83c69685950d43a85350dc1441c.1595335031.git.wangyunjian@huawei.com>\n <DB6PR0802MB2216A19D97A481DB7A85DF8198780@DB6PR0802MB2216.eurprd08.prod.outlook.com>", "In-Reply-To": "\n <DB6PR0802MB2216A19D97A481DB7A85DF8198780@DB6PR0802MB2216.eurprd08.prod.outlook.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "dlp-reaction": "no-action", "dlp-version": "11.2.0.6", "dlp-product": "dlpe-windows", "authentication-results": "arm.com; dkim=none (message not signed)\n header.d=none;arm.com; dmarc=none action=none header.from=intel.com;", "x-originating-ip": "[108.161.24.24]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "9f97a38e-5925-4417-721e-08d82db407dd", "x-ms-traffictypediagnostic": "BY5PR11MB3941:", "x-ld-processed": "46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <BY5PR11MB39410B9243AF923615AAA2E3C3780@BY5PR11MB3941.namprd11.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:4303;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n umHNeUTVliOI/F6vaxv840PRIFpnAHC5vmDwe8A5Qsc3dOkrc37ZaUDQTLgS4AH6XP8PGASFLKa1IFF2hoSYpKWjxHRDvHCKcgLDZISvKPc32ubt2A3iDuqe7yx9lLIZNtelxGv5rBs1T6V8hqjylsfIDUYCD8Ai7RLPpWq+FHEP25sd7ffn1e0FcifjLC0YSOdQlwjLlFKFQvLk1HvpubEVPJDOeVDFmYPzYrbTjaQnwQxdHrXlr9da4B5jlqQNxDkpA4DpcSKyV1el/HyR4ZRsLO1/THr1+SZeijg7zFDxRBoFwa1EGSdjfECLdxaET/i6dtih//+bOwkmZ5GyWw==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:BYAPR11MB3494.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(136003)(346002)(376002)(396003)(366004)(39860400002)(71200400001)(4326008)(86362001)(33656002)(64756008)(66476007)(66946007)(66556008)(76116006)(66446008)(8676002)(8936002)(478600001)(54906003)(53546011)(7696005)(186003)(26005)(83380400001)(9686003)(55016002)(5660300002)(2906002)(6506007)(52536014)(110136005)(316002);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata": "\n M5FYtKHkg4rVrcBdkcwX/VeqA3fF3dz1Vx/sKe/P+OpDsbQL6OkzLxWUS0PkdWcKcBr8XIDuKJpnCk6sfa1BHaoj5ua+oT7tU1OMIpR4ZD86tnsItN59kbqwsAmfy++48tHeKxBFX9qfjOxfAh1Yh76QnhK0EgEeGdUjFeLu6wI8g6SuILwdStr86JsUVZQGOLqrjJDETmsA8/Q+aAxcefcCfVkTYRD4TzsO2xLjhpMANEEGZ0QDskuCxCbYkZO79xfi5Or8oDS1J8TK9hsqdRYLP/jtVhhYZHjCV+IP+359c2t5SlfHN8lzvGrHthvm5+aKsm67JUF1TSpmzNUJ3KxSJg+wjXMdK2q6hH+gegV/SHy1BkheoD8x2YyOsQ2DkxBezfHovyh/6WbnHqztQqJZswUmR3pXusnrnJH0yQ1FV4U74mIbVgi5kUFNHnGor6N9wz1kqto9h7ZisQddO/UF6moGs821iFMPuCyivag=", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "BYAPR11MB3494.namprd11.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 9f97a38e-5925-4417-721e-08d82db407dd", "X-MS-Exchange-CrossTenant-originalarrivaltime": "21 Jul 2020 20:24:12.0272 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "46c98d88-e344-4ed4-8496-4ed7712e255d", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n WaKnwJ0Oxu1vYzQESwcy70XZBrCHqJQ3b/viVnm6eWhJ9yaMPzIypwm8CgiH4Ya2054ljrFWtPukbq6OJjgo4w==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BY5PR11MB3941", "X-OriginatorOrg": "intel.com", "Subject": "Re: [dpdk-dev] [PATCH] hash: fix return value of null not checked", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116465, "web_url": "https://patches.dpdk.org/comment/116465/", "msgid": "<34EFBCA9F01B0748BEB6B629CE643AE60D0DD1B7@DGGEMM533-MBX.china.huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/34EFBCA9F01B0748BEB6B629CE643AE60D0DD1B7@DGGEMM533-MBX.china.huawei.com", "date": "2020-07-22T03:20:26", "subject": "Re: [dpdk-dev] [PATCH] hash: fix return value of null not checked", "submitter": { "id": 551, "url": "https://patches.dpdk.org/api/people/551/?format=api", "name": "Yunjian Wang", "email": "wangyunjian@huawei.com" }, "content": "> -----Original Message-----\n> From: Wang, Yipeng1 [mailto:yipeng1.wang@intel.com]\n> Sent: Wednesday, July 22, 2020 4:24 AM\n> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; wangyunjian\n> <wangyunjian@huawei.com>; dev@dpdk.org\n> Cc: Gobriel, Sameh <sameh.gobriel@intel.com>; Richardson, Bruce\n> <bruce.richardson@intel.com>; Lilijun (Jerry) <jerry.lilijun@huawei.com>;\n> xudingke <xudingke@huawei.com>; stable@dpdk.org; nd <nd@arm.com>\n> Subject: RE: [dpdk-dev] [PATCH] hash: fix return value of null not checked\n> \n> > -----Original Message-----\n> > From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>\n> > Sent: Tuesday, July 21, 2020 10:27 AM\n> > To: wangyunjian <wangyunjian@huawei.com>; dev@dpdk.org\n> > Cc: Wang, Yipeng1 <yipeng1.wang@intel.com>; Gobriel, Sameh\n> > <sameh.gobriel@intel.com>; Richardson, Bruce\n> > <bruce.richardson@intel.com>; jerry.lilijun@huawei.com;\n> > xudingke@huawei.com; stable@dpdk.org; nd <nd@arm.com>; Honnappa\n> > Nagarahalli <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>\n> > Subject: RE: [dpdk-dev] [PATCH] hash: fix return value of null not\n> > checked\n> >\n> >\n> >\n> > > -----Original Message-----\n> > > From: dev <dev-bounces@dpdk.org> On Behalf Of wangyunjian\n> > > Sent: Tuesday, July 21, 2020 8:32 AM\n> > > To: dev@dpdk.org\n> > > Cc: yipeng1.wang@intel.com; sameh.gobriel@intel.com;\n> > > bruce.richardson@intel.com; jerry.lilijun@huawei.com;\n> > > xudingke@huawei.com; Yunjian Wang <wangyunjian@huawei.com>;\n> > > stable@dpdk.org\n> > > Subject: [dpdk-dev] [PATCH] hash: fix return value of null not\n> > > checked\n> > >\n> > > From: Yunjian Wang <wangyunjian@huawei.com>\n> > >\n> > > The function rte_zmalloc_socket() could return NULL, the return\n> > > value need to be checked.\n> > >\n> > > Fixes: 5915699153d7 (\"hash: fix scaling by reducing contention\")\n> > > Cc: stable@dpdk.org\n> > >\n> > > Reported-by: HuangBin <brian.huangbin@huawei.com>\n> [Wang, Yipeng] missed a space in name?\n\nThanks, I will send v2 with correction.\n\nYunjian\n\n> \n> > > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>\n> > Good catch\n> > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n> [Wang, Yipeng]\n> Thanks for the fix!\n> \n> Acked-by: Yipeng Wang <yipeng1.wang@intel.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A1472A0526;\n\tWed, 22 Jul 2020 05:20:42 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1C3531BFCA;\n\tWed, 22 Jul 2020 05:20:41 +0200 (CEST)", "from huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by dpdk.org (Postfix) with ESMTP id 0A9891BFCA;\n Wed, 22 Jul 2020 05:20:38 +0200 (CEST)", "from DGGEMM406-HUB.china.huawei.com (unknown [172.30.72.54])\n by Forcepoint Email with ESMTP id 18E301A63BC05244BD0E;\n Wed, 22 Jul 2020 11:20:37 +0800 (CST)", "from DGGEMM533-MBX.china.huawei.com ([169.254.5.165]) by\n DGGEMM406-HUB.china.huawei.com ([10.3.20.214]) with mapi id 14.03.0487.000;\n Wed, 22 Jul 2020 11:20:26 +0800" ], "From": "wangyunjian <wangyunjian@huawei.com>", "To": "\"Wang, Yipeng1\" <yipeng1.wang@intel.com>, Honnappa Nagarahalli\n <Honnappa.Nagarahalli@arm.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"Gobriel, Sameh\" <sameh.gobriel@intel.com>, \"Richardson, Bruce\"\n <bruce.richardson@intel.com>, \"Lilijun (Jerry)\" <jerry.lilijun@huawei.com>,\n xudingke <xudingke@huawei.com>, \"stable@dpdk.org\" <stable@dpdk.org>, nd\n <nd@arm.com>", "Thread-Topic": "[dpdk-dev] [PATCH] hash: fix return value of null not checked", "Thread-Index": "AQHWX4QtdZ8j12ENZUyzTOfMOZVrA6kR9KSAgADxfTA=", "Date": "Wed, 22 Jul 2020 03:20:26 +0000", "Message-ID": "\n <34EFBCA9F01B0748BEB6B629CE643AE60D0DD1B7@DGGEMM533-MBX.china.huawei.com>", "References": "\n <d87e2f714999b83c69685950d43a85350dc1441c.1595335031.git.wangyunjian@huawei.com>\n <DB6PR0802MB2216A19D97A481DB7A85DF8198780@DB6PR0802MB2216.eurprd08.prod.outlook.com>\n <BYAPR11MB3494D5D8D224B6E134305B81C3780@BYAPR11MB3494.namprd11.prod.outlook.com>", "In-Reply-To": "\n <BYAPR11MB3494D5D8D224B6E134305B81C3780@BYAPR11MB3494.namprd11.prod.outlook.com>", "Accept-Language": "en-US", "Content-Language": "zh-CN", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.174.185.168]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-CFilter-Loop": "Reflected", "Subject": "Re: [dpdk-dev] [PATCH] hash: fix return value of null not checked", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]