List comments

GET /api/patches/74572/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 116518,
        "web_url": "https://patches.dpdk.org/comment/116518/",
        "msgid": "<AM0PR05MB6707A32D469308E897CEA085C2790@AM0PR05MB6707.eurprd05.prod.outlook.com>",
        "date": "2020-07-22T15:30:51",
        "subject": "Re: [dpdk-dev] [PATCH] net/mlx5: fix unnecessary init in MARK\n\taction\tconversion",
        "submitter": {
            "id": 513,
            "url": "https://patches.dpdk.org/api/people/513/",
            "name": "Raslan Darawsheh",
            "email": "rasland@mellanox.com"
        },
        "content": "Hi,\n\n> -----Original Message-----\n> From: dev <dev-bounces@dpdk.org> On Behalf Of Michael Baum\n> Sent: Tuesday, July 21, 2020 3:05 PM\n> To: dev@dpdk.org\n> Cc: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko\n> <viacheslavo@mellanox.com>; stable@dpdk.org\n> Subject: [dpdk-dev] [PATCH] net/mlx5: fix unnecessary init in MARK action\n> conversion\n> \n> The flow_dv_convert_action_mark function defines an array of\n> field_modify_info structures and initializes the first entity.\n> \n> In the first entity id field, it initializes to 0, even though its type\n> is an enum that has no value of 0.\n> In fact, the function does not use this id field before assigning the\n> appropriate register id into it, so the initialization is unnecessary.\n> Moreover, this initialization is int into enum, and it would be better\n> not to create a type conflict for no reason.\n> \n> Wait for the first entity initialization until the appropriate register\n> id is already known.\n> \n> Fixes: 55deee1715f0 (\"net/mlx5: extend flow mark support\")\n> Cc: stable@dpdk.org\n> \n> Signed-off-by: Michael Baum <michaelba@mellanox.com>\n> Acked-by: Matan Azrad <matan@mellanox.com>\n> ---\n>  drivers/net/mlx5/mlx5_flow_dv.c | 5 ++---\n>  1 file changed, 2 insertions(+), 3 deletions(-)\n> \n> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c\n> b/drivers/net/mlx5/mlx5_flow_dv.c\n> index caeafd9..0f258b4 100644\n> --- a/drivers/net/mlx5/mlx5_flow_dv.c\n> +++ b/drivers/net/mlx5/mlx5_flow_dv.c\n> @@ -1151,8 +1151,7 @@ struct field_modify_info modify_tcp[] = {\n>  \t\t.mask = &mask,\n>  \t};\n>  \tstruct field_modify_info reg_c_x[] = {\n> -\t\t{4, 0, 0}, /* dynamic instead of\n> MLX5_MODI_META_REG_C_1. */\n> -\t\t{0, 0, 0},\n> +\t\t[1] = {0, 0, 0},\n>  \t};\n>  \tint reg;\n> \n> @@ -1172,7 +1171,7 @@ struct field_modify_info modify_tcp[] = {\n>  \t\tmask = rte_cpu_to_be_32(mask) & msk_c0;\n>  \t\tmask = rte_cpu_to_be_32(mask << shl_c0);\n>  \t}\n> -\treg_c_x[0].id = reg_to_field[reg];\n> +\treg_c_x[0] = (struct field_modify_info){4, 0, reg_to_field[reg]};\n>  \treturn flow_dv_convert_modify_action(&item, reg_c_x, NULL,\n> resource,\n>  \t\t\t\t\t     MLX5_MODIFICATION_TYPE_SET,\n> error);\n>  }\n> --\n> 1.8.3.1\n\nPatch applied to next-net-mlx,\n\nKindest regards,\nRaslan Darawsheh",
        "headers": {
            "Accept-Language": "en-US",
            "X-Mailman-Version": "2.1.15",
            "x-ms-oob-tlc-oobclassifiers": "OLM:6790;",
            "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR05MB4401",
            "authentication-results": "mellanox.com; dkim=none (message not signed)\n header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com;",
            "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED",
            "Precedence": "list",
            "List-Post": "<mailto:dev@dpdk.org>",
            "x-ms-exchange-senderadcheck": "1",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Subject": "Re: [dpdk-dev] [PATCH] net/mlx5: fix unnecessary init in MARK\n\taction\tconversion",
            "X-MS-Exchange-CrossTenant-AuthAs": "Internal",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "Delivered-To": "patchwork@inbox.dpdk.org",
            "Received": [
                "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6716DA0526;\n\tWed, 22 Jul 2020 17:32:05 +0200 (CEST)",
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9DB4D1C068;\n\tWed, 22 Jul 2020 17:31:01 +0200 (CEST)",
                "from EUR05-AM6-obe.outbound.protection.outlook.com\n (mail-am6eur05on2064.outbound.protection.outlook.com [40.107.22.64])\n by dpdk.org (Postfix) with ESMTP id 1C4141BFE7;\n Wed, 22 Jul 2020 17:30:52 +0200 (CEST)",
                "from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17)\n by AM0PR05MB4401.eurprd05.prod.outlook.com (2603:10a6:208:62::20)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Wed, 22 Jul\n 2020 15:30:51 +0000",
                "from AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.028; Wed, 22 Jul 2020\n 15:30:51 +0000"
            ],
            "x-originating-ip": "[84.242.49.134]",
            "x-microsoft-antispam": "BCL:0;",
            "x-ms-exchange-transport-forked": "True",
            "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB6707.eurprd05.prod.outlook.com",
            "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=RMEDb7BUwgeVz+HeQMOqEYgTVpcTrRzwx7sFo3SZXNg=;\n b=Quy+2hKSQhqsYzMxemiRdtT5zpMzTTb89qiFb9gKAyNvGIqFqp5hYjH9HqRGGqA10JlDKUIffghEzj0VMk4G66UW2Reg2CuojXmR4HKRYpVaOmmouLiEV9qoMd9EBJRUIO2NjT8z/8KSo8YmQ0CZaHR9CLfQ23HAEFjYN1l5wh6BHmk3ho5tyuDipJfvdQEuTI09ERnuyFiNXM+fmj9FxDVuXFQz7kf9z0R3c7DAx74r6ZD6x7ZkyrvngdbpCKgR/1A03J01/LjSXrbDmy07mNKLrzHbbA7tKS25PnUT/fBmf9RLPG6GI8O3p0mSfosS6ATY4QG1lgd7mixB/lz58Q==",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted",
            "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=RMEDb7BUwgeVz+HeQMOqEYgTVpcTrRzwx7sFo3SZXNg=;\n b=WKigE1WUAIdmQnqBONHpSXhiAdGtBPtvqWZ84ZG5jBHKdeKCTZSbYAyEs+TVDkXHD/otSMfZPWPC+Sv0XH5PWK4rB6jXGMbrNTAgF5QYsqWItyJiYVcrVwyM3QfqnWE7u9UqgcHzJVT4U1FMvvCoucyXXXoaPME7K7UFGVHPMXw=",
            "Message-ID": "\n <AM0PR05MB6707A32D469308E897CEA085C2790@AM0PR05MB6707.eurprd05.prod.outlook.com>",
            "X-MS-Exchange-CrossTenant-userprincipalname": "\n 706IEQTQlKx9Nh6HKNztmEJe1VC8ZnebYcH5Vc6QErQAocHQnqDv29Wup4fJ85HZm9cGn6+7attGRT8BjhFnqg==",
            "To": "Michael Baum <michaelba@mellanox.com>, \"dev@dpdk.org\" <dev@dpdk.org>",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
            "From": "Raslan Darawsheh <rasland@mellanox.com>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "x-ms-publictraffictype": "Email",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none",
            "X-MS-TNEF-Correlator": "",
            "Thread-Index": "AQHWX1ciE82yOT9zC0yy6mLpXSoPrqkTuxDA",
            "CC": "Matan Azrad <matan@mellanox.com>, Slava Ovsiienko\n <viacheslavo@mellanox.com>, \"stable@dpdk.org\" <stable@dpdk.org>",
            "X-OriginatorOrg": "Mellanox.com",
            "Thread-Topic": "[dpdk-dev] [PATCH] net/mlx5: fix unnecessary init in MARK action\n conversion",
            "X-Original-To": "patchwork@inbox.dpdk.org",
            "x-microsoft-antispam-message-info": "\n KryNu8UrzlbKHtM6OR775e2jf07RXs9rKygeWqCfExKlxKkxZDBKjpfcY0jjXB1Fz51KBIQQaB4dYCa/vMdZd4YKnbzDyYwJO2Ww20OQ4yOepS4Z+sDh8K1Q1ivdTYRt20iFfzq7O6Xth0oyCwMwe+mAdMkOVPSVR9rv4OhoJ4AnUY18p/b5ZRdLARgqJuT9LF/humVufJjpb1dYz1fSzAfaSdDqT5a0Gy+nyLmuTTrStWD4Daj4aJEsLTIDwr93zMk2OUPd01N1ONtgTL5SoH6M+8rR6ny82vJRpifeONCKvUiuyDL95J/ropLAQaFS4dF4wEG1UAYkoOE2Sfdu5w==",
            "x-ms-office365-filtering-ht": "Tenant",
            "MIME-Version": "1.0",
            "In-Reply-To": "<1595333077-7179-1-git-send-email-michaelba@mellanox.com>",
            "X-BeenThere": "dev@dpdk.org",
            "References": "<1595333077-7179-1-git-send-email-michaelba@mellanox.com>",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b",
            "x-ms-office365-filtering-correlation-id": "72a3f495-6242-4b88-9ce5-08d82e543774",
            "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 72a3f495-6242-4b88-9ce5-08d82e543774",
            "Date": "Wed, 22 Jul 2020 15:30:51 +0000",
            "Content-Transfer-Encoding": "quoted-printable",
            "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(396003)(376002)(39860400002)(136003)(366004)(346002)(316002)(8936002)(6506007)(26005)(4326008)(7696005)(53546011)(450100002)(478600001)(54906003)(110136005)(186003)(86362001)(2906002)(52536014)(5660300002)(55016002)(83380400001)(33656002)(76116006)(66946007)(66476007)(66556008)(64756008)(66446008)(9686003)(71200400001);\n DIR:OUT; SFP:1101;",
            "X-MS-Has-Attach": "",
            "x-ms-traffictypediagnostic": "AM0PR05MB4401:",
            "x-ms-exchange-antispam-messagedata": "\n ErxrHo4d6MJlBg+xlo3Ri3JvOzmhxy+Z0WURdu385WtCaNJl8aThAXVCYKm/ZdoPNjzEflfIGXIOdHZ18KM7Ffi3o+ix7/xDRaDDm9Qp/yyT1kAIr3Mlx0tiHyKQq4m4saGBqUiY3XRbPuVn0aJYaRfh6AnfhJcnRhLTB8X58hGGlKKK8wF/Y+zy/ZUhd3laT7sMmUE8QTP9z2IDiNhMQxb5Jz5n3d9aLbtTvEmAzkp5OLx1d/D+V0hQJeIZxfVaxyfotkU+mj10jTgRjE2H8SuJ126DwAqPrfCTfmuXpFQkC8cCLzWlDLGJ1bmHr9A9FRfs7Uz4TDIShQduJDQb1DGi5JVIqBpnX/RziErTy2BM/KT6XHsTH6A/Rdq385SbfKajWeJiSnWpw6i8QTWHajvST3kM3TaxbW1iHdZLft/OZTsXbmSyQUHWyA3wIZaWxe0xBzII/jLPvQRt12DRZX31tIgBF3d8dF1vB4x1xOMygM6glxH06WkfdSeJLRCM",
            "X-MS-Exchange-CrossTenant-originalarrivaltime": "22 Jul 2020 15:30:51.4618 (UTC)",
            "Content-Language": "en-US",
            "Errors-To": "dev-bounces@dpdk.org",
            "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=etY0C8apgI7Sebfi/u/0oO/DePMoj6BRxnmNPKwKzlAFxY8BUbNirtOGce9Yw52JBrzIBE2Ph28FAzigbo5IUCNCLIFJF+RdgBTgU45Ano+qtQ/cfvUDNYsRCSj6r+2QfyL73fb9E/8tmhLQNaVALZp20bSAbkR1QFPYczPGxyRZo3wa1Tem0uelx3O88Y8xnSugXxbKvkQE97MHHMIsoPSQmz4k98iyGa3mPaWxNqsTrB9MJhPrviZZ+idUADkYFSEA2Nh0iZMvYjyHtqUEfckh7ewD2emHYZhi4WjItMl7EncrjLJkkZ64yIucHJdgmzcezEBPnb6ZD9LlvtQh7Q==",
            "x-microsoft-antispam-prvs": "\n <AM0PR05MB4401FD8EED6B314F467F2B36C2790@AM0PR05MB4401.eurprd05.prod.outlook.com>"
        }
    }
]