Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74572/?format=api
{ "id": 74572, "url": "https://patches.dpdk.org/api/patches/74572/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1595333077-7179-1-git-send-email-michaelba@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1595333077-7179-1-git-send-email-michaelba@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1595333077-7179-1-git-send-email-michaelba@mellanox.com", "date": "2020-07-21T12:04:37", "name": "net/mlx5: fix unnecessary init in MARK action conversion", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "db966ef5eb47b8351797d7cf3bebda0a884135e5", "submitter": { "id": 1582, "url": "https://patches.dpdk.org/api/people/1582/?format=api", "name": "Michael Baum", "email": "michaelba@mellanox.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1595333077-7179-1-git-send-email-michaelba@mellanox.com/mbox/", "series": [ { "id": 11209, "url": "https://patches.dpdk.org/api/series/11209/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11209", "date": "2020-07-21T12:04:37", "name": "net/mlx5: fix unnecessary init in MARK action conversion", "version": 1, "mbox": "https://patches.dpdk.org/series/11209/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/74572/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/74572/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C97AEA0526;\n\tTue, 21 Jul 2020 14:04:43 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AA5D11BFF9;\n\tTue, 21 Jul 2020 14:04:43 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 6F0B91BFF9\n for <dev@dpdk.org>; Tue, 21 Jul 2020 14:04:42 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n matan@mellanox.com) with SMTP; 21 Jul 2020 15:04:41 +0300", "from pegasus07.mtr.labs.mlnx (pegasus07.mtr.labs.mlnx\n [10.210.16.112])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 06LC4ffn026049;\n Tue, 21 Jul 2020 15:04:41 +0300" ], "From": "Michael Baum <michaelba@mellanox.com>", "To": "dev@dpdk.org", "Cc": "matan@mellanox.com, viacheslavo@mellanox.com, stable@dpdk.org", "Date": "Tue, 21 Jul 2020 12:04:37 +0000", "Message-Id": "<1595333077-7179-1-git-send-email-michaelba@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "Subject": "[dpdk-dev] [PATCH] net/mlx5: fix unnecessary init in MARK action\n\tconversion", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The flow_dv_convert_action_mark function defines an array of\nfield_modify_info structures and initializes the first entity.\n\nIn the first entity id field, it initializes to 0, even though its type\nis an enum that has no value of 0.\nIn fact, the function does not use this id field before assigning the\nappropriate register id into it, so the initialization is unnecessary.\nMoreover, this initialization is int into enum, and it would be better\nnot to create a type conflict for no reason.\n\nWait for the first entity initialization until the appropriate register\nid is already known.\n\nFixes: 55deee1715f0 (\"net/mlx5: extend flow mark support\")\nCc: stable@dpdk.org\n\nSigned-off-by: Michael Baum <michaelba@mellanox.com>\nAcked-by: Matan Azrad <matan@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow_dv.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex caeafd9..0f258b4 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -1151,8 +1151,7 @@ struct field_modify_info modify_tcp[] = {\n \t\t.mask = &mask,\n \t};\n \tstruct field_modify_info reg_c_x[] = {\n-\t\t{4, 0, 0}, /* dynamic instead of MLX5_MODI_META_REG_C_1. */\n-\t\t{0, 0, 0},\n+\t\t[1] = {0, 0, 0},\n \t};\n \tint reg;\n \n@@ -1172,7 +1171,7 @@ struct field_modify_info modify_tcp[] = {\n \t\tmask = rte_cpu_to_be_32(mask) & msk_c0;\n \t\tmask = rte_cpu_to_be_32(mask << shl_c0);\n \t}\n-\treg_c_x[0].id = reg_to_field[reg];\n+\treg_c_x[0] = (struct field_modify_info){4, 0, reg_to_field[reg]};\n \treturn flow_dv_convert_modify_action(&item, reg_c_x, NULL, resource,\n \t\t\t\t\t MLX5_MODIFICATION_TYPE_SET, error);\n }\n", "prefixes": [] }