Patch Comment List
List patch comments
GET /api/patches/74571/comments/?format=api
[ { "id": 116517, "web_url": "https://patches.dpdk.org/comment/116517/", "msgid": "<AM0PR05MB6707C002D56F9AF0C0885574C2790@AM0PR05MB6707.eurprd05.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/AM0PR05MB6707C002D56F9AF0C0885574C2790@AM0PR05MB6707.eurprd05.prod.outlook.com", "date": "2020-07-22T15:30:50", "subject": "Re: [dpdk-dev] [PATCH] net/mlx5: optimize critical section in\n\tdevice\tfree", "submitter": { "id": 513, "url": "https://patches.dpdk.org/api/people/513/?format=api", "name": "Raslan Darawsheh", "email": "rasland@mellanox.com" }, "content": "Hi,\n\n> -----Original Message-----\n> From: dev <dev-bounces@dpdk.org> On Behalf Of Michael Baum\n> Sent: Tuesday, July 21, 2020 3:04 PM\n> To: dev@dpdk.org\n> Cc: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko\n> <viacheslavo@mellanox.com>\n> Subject: [dpdk-dev] [PATCH] net/mlx5: optimize critical section in device free\n> \n> When PMD releases shared IB device context, It locks the\n> mlx5_ibv_list_mutex lock throughout the function so that it does not\n> happen while removing a device from the list, another process will try\n> to insert another device into it.\n> On the other hand, having removed the device from the list even if it\n> has not yet released all of its resources, it should not care about\n> other processes and can release the lock.\n> \n> However, the PMD does not release the lock even though it can, and\n> performs a number of operations, some of which include sleep and may be\n> long.\n> To improve this, shorten the lock time to the minimum necessary.\n> \n> Signed-off-by: Michael Baum <michaelba@mellanox.com>\n> Acked-by: Matan Azrad <matan@mellanox.com>\n> ---\n> drivers/net/mlx5/mlx5.c | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\n> index 846398d..70338e5 100644\n> --- a/drivers/net/mlx5/mlx5.c\n> +++ b/drivers/net/mlx5/mlx5.c\n> @@ -939,6 +939,7 @@ struct mlx5_dev_ctx_shared *\n> \tmlx5_mr_release_cache(&sh->share_cache);\n> \t/* Remove context from the global device list. */\n> \tLIST_REMOVE(sh, next);\n> +\tpthread_mutex_unlock(&mlx5_dev_ctx_list_mutex);\n> \t/*\n> \t * Ensure there is no async event handler installed.\n> \t * Only primary process handles async device events.\n> @@ -968,6 +969,7 @@ struct mlx5_dev_ctx_shared *\n> \t\tmlx5_flow_id_pool_release(sh->flow_id_pool);\n> \tpthread_mutex_destroy(&sh->txpp.mutex);\n> \tmlx5_free(sh);\n> +\treturn;\n> exit:\n> \tpthread_mutex_unlock(&mlx5_dev_ctx_list_mutex);\n> }\n> --\n> 1.8.3.1\n\nPatch applied to next-net-mlx,\n\nKindest regards,\nRaslan Darawsheh", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DA29DA0526;\n\tWed, 22 Jul 2020 17:31:52 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1A3261C044;\n\tWed, 22 Jul 2020 17:31:00 +0200 (CEST)", "from EUR05-DB8-obe.outbound.protection.outlook.com\n (mail-db8eur05on2079.outbound.protection.outlook.com [40.107.20.79])\n by dpdk.org (Postfix) with ESMTP id 89A581BFD4\n for <dev@dpdk.org>; Wed, 22 Jul 2020 17:30:51 +0200 (CEST)", "from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17)\n by AM0PR05MB4401.eurprd05.prod.outlook.com (2603:10a6:208:62::20)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Wed, 22 Jul\n 2020 15:30:50 +0000", "from AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.028; Wed, 22 Jul 2020\n 15:30:50 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Jl4jb68C6MQ++cT3c3QDLI0RF0sr37UOqnANG/NgBtlpLdCcgFLHKxaM9+Cg/2MQBAK/JYxHbbYtUgL+Soo+qK5Z5nhoER1m5w7LKtKm35IPPumElMKIL5uFi4lcxSh6Amm9oijxJyijiJjJi8KBo+1960mlOrfoN3iGwbOzz+IlvGbkLE/XzJZ9TEt0pjQYaLkZn40kN1eySTTOQ5C6ZofW8BKKUxu8OZxMR+G2HzcwekNl+7tDh7TgFclULJK7RBX1MujUpKPWU0vCa7NSQyBf2Q83vhy3zNb1FHDPCA7uLfkMfl58sj7AtFhwh/cH7qMJpre4ZVk+v7VgSvOY0Q==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=yaZjrHBKLUZhmulhM3ldsQlK8q98aEL7pgfeN9NIveg=;\n b=M/Mgm4m/pugdRq/rzyohXSE3fPdyYraDBBPxErkz0jRGBWqEf1+Chytj+QFNxB3RYIPj7B+PTL0f5L7RDuBQBGUwh37fHIFSvK0KjLH3CLq2Tw8ncdg1b4w1UOmcDOnIEQSKc8Yi+ENKFmWMH9NxhH+mF7vaBCoKMNtCnwdpjr6qwJx3HsT2ec1L29rImnibG9QH8jr7BSbxzKhjtAUP6pbRco2AEvlezg/n0AGQBejRb4twpEmsp6iBNejwCbwSg+yurL+MV5la7iGbAiQOkbscKNIKVIHwSEjVXUv+Y5u/bmt4WadXIFTULk/0bzFzAJ4xze7q54w429XxbzeX5A==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=yaZjrHBKLUZhmulhM3ldsQlK8q98aEL7pgfeN9NIveg=;\n b=SeXsokoVHtLP7vR/KjmVeAZDvMci1xYOCLOxWaAFU/ThlxmbEO0Ik7EdXTOIS/H6+evto4hu2PYlsmsdjOGiriMeI7uFH4lgWqC8xkaBbpmU4mEjuR1P3bABfMmwK/4XbFDF95gvqqdYuV9eMlSjNf4K7BN5kS+pLKQbdOQGolI=", "From": "Raslan Darawsheh <rasland@mellanox.com>", "To": "Michael Baum <michaelba@mellanox.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "Matan Azrad <matan@mellanox.com>, Slava Ovsiienko\n <viacheslavo@mellanox.com>", "Thread-Topic": "[dpdk-dev] [PATCH] net/mlx5: optimize critical section in device\n free", "Thread-Index": "AQHWX1b/200T1FSRdEGrp93FMyBhoKkTuweg", "Date": "Wed, 22 Jul 2020 15:30:50 +0000", "Message-ID": "\n <AM0PR05MB6707C002D56F9AF0C0885574C2790@AM0PR05MB6707.eurprd05.prod.outlook.com>", "References": "<1595333018-7119-1-git-send-email-michaelba@mellanox.com>", "In-Reply-To": "<1595333018-7119-1-git-send-email-michaelba@mellanox.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "mellanox.com; dkim=none (message not signed)\n header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com;", "x-originating-ip": "[84.242.49.134]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-ht": "Tenant", "x-ms-office365-filtering-correlation-id": "3839f0d8-16e4-487d-a34c-08d82e543717", "x-ms-traffictypediagnostic": "AM0PR05MB4401:", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <AM0PR05MB4401740B5841D392BB67E4C8C2790@AM0PR05MB4401.eurprd05.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:5236;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n yntE/t80aGz1jY02FPwFlnDfdoJSbCHk2eAbyzJvuWawdkkWmOAvBTX41krWKGl0fZ7U3TikpaVQXbn0Iy/4/Xr8GbbKsiFh4oRhrTE2YeAt3fkedGU4/QfrnWzLTSuoS5MrFG+HG3DPKgwxK52Lq38gQ3aHrD0An/IZcbXObnOmmHQHIUh9J3+SGJsXQtRg0EnBeOIoredYPXVcOD8GL772oyXRW2DBdkUF5akoD9QEiZYWAmNLitRHId/VgcF2we/75bljG4QVRk681LM4G0jeBG118paBRA/SusjXLfyTf+1Z62yJcKM5bOuXYZfHrMr5y9mUey0Q9rNhya9muw==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(396003)(376002)(39860400002)(136003)(366004)(346002)(316002)(8936002)(107886003)(6506007)(26005)(4326008)(7696005)(53546011)(478600001)(54906003)(110136005)(186003)(86362001)(2906002)(52536014)(5660300002)(55016002)(83380400001)(33656002)(76116006)(66946007)(66476007)(66556008)(64756008)(66446008)(9686003)(71200400001);\n DIR:OUT; SFP:1101;", "x-ms-exchange-antispam-messagedata": "\n N5t1EeFPF88muYd5rdmyxgkqFNORjYI1kfEfqdfFGZHxKMDPb/9NQ0+/O77x/wFZGUQO/WScF65aIxoxJvIONB+BuTYXktSfLbu9ox1+rfuYimaNYoO3fIQJrdPNc5Ris0a9DILfTgjgti+PEIUmiblBpuomZqqNJNF+x7w4A8snt9iTUdfb6kYSPipymg+atqlY3zgr60RR2j9FjVv0ZeOpfYgv/QPcjg/bonpFdp8n+MEj+4pt6Stb7/CW1QB90ptKGVoBXMCnO+mTU5tw/pAjgxaCttSvnb6STqntzbDsR69jfPn3qGAUiSfnPnAfqw9iVPXyDtUxCufRALUfXbfitK0KCFDJJJyvfuLkEIVT06+30BOuTdBWvlKpzgEJQZEfZQTwNoB1pay9InKH4vG2I6xyz9xGtJ+M1qNsK+lBIIbukWVW+MnQ4zo32o8eRpM35mz+T+hU29FSmesKyyeGx6f5jp2ecKH6Wn6j9EqvHYm/f5SnSNNgtdVnTHQZ", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB6707.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 3839f0d8-16e4-487d-a34c-08d82e543717", "X-MS-Exchange-CrossTenant-originalarrivaltime": "22 Jul 2020 15:30:50.8425 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n ynKz7EbT3lWct7W80MXaSZYYyzrSORgjAF0zdnl7jkR2tKbMaOAHWr5EO7RETu8WxpIBkAaDkjLAAcqbJqB7Aw==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR05MB4401", "Subject": "Re: [dpdk-dev] [PATCH] net/mlx5: optimize critical section in\n\tdevice\tfree", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]