List comments

GET /api/patches/74570/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 116516,
        "web_url": "https://patches.dpdk.org/comment/116516/",
        "msgid": "<AM0PR05MB6707D37B4B62AED9B547321EC2790@AM0PR05MB6707.eurprd05.prod.outlook.com>",
        "date": "2020-07-22T15:30:50",
        "subject": "Re: [dpdk-dev] [PATCH] net/mlx5: fix unlimited scan in switch\n\tinfo\tdetection",
        "submitter": {
            "id": 513,
            "url": "https://patches.dpdk.org/api/people/513/",
            "name": "Raslan Darawsheh",
            "email": "rasland@mellanox.com"
        },
        "content": "Hi,\n\n> -----Original Message-----\n> From: dev <dev-bounces@dpdk.org> On Behalf Of Michael Baum\n> Sent: Tuesday, July 21, 2020 3:03 PM\n> To: dev@dpdk.org\n> Cc: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko\n> <viacheslavo@mellanox.com>; stable@dpdk.org\n> Subject: [dpdk-dev] [PATCH] net/mlx5: fix unlimited scan in switch info\n> detection\n> \n> In mlx5_sysfs_switch_info function, the driver gets switch information\n> associated with network interface.\n> \n> The driver writes the port name into buffer and translates it.\n> However, when it writes the name, it does not limit writing to the\n> buffer size.\n> \n> Limit writing to the size of the buffer.\n> \n> Fixes: 1256805dd54d (\"net/mlx5: move Linux-specific functions\")\n> Cc: stable@dpdk.org\n> \n> Signed-off-by: Michael Baum <michaelba@mellanox.com>\n> Acked-by: Matan Azrad <matan@mellanox.com>\n> ---\n>  drivers/net/mlx5/linux/mlx5_ethdev_os.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c\n> b/drivers/net/mlx5/linux/mlx5_ethdev_os.c\n> index 1735157..3d3dd2e 100644\n> --- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c\n> +++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c\n> @@ -1067,7 +1067,7 @@ struct ethtool_link_settings {\n> \n>  \tfile = fopen(phys_port_name, \"rb\");\n>  \tif (file != NULL) {\n> -\t\tret = fscanf(file, \"%s\", port_name);\n> +\t\tret = fscanf(file, \"%\" RTE_STR(IF_NAMESIZE) \"s\",\n> port_name);\n>  \t\tfclose(file);\n>  \t\tif (ret == 1)\n>  \t\t\tmlx5_translate_port_name(port_name, &data);\n> --\n> 1.8.3.1\n\nPatch applied to next-net-mlx,\n\nKindest regards,\nRaslan Darawsheh",
        "headers": {
            "Accept-Language": "en-US",
            "X-Mailman-Version": "2.1.15",
            "x-ms-oob-tlc-oobclassifiers": "OLM:883;",
            "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR05MB4401",
            "authentication-results": "mellanox.com; dkim=none (message not signed)\n header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com;",
            "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED",
            "Precedence": "list",
            "List-Post": "<mailto:dev@dpdk.org>",
            "x-ms-exchange-senderadcheck": "1",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Subject": "Re: [dpdk-dev] [PATCH] net/mlx5: fix unlimited scan in switch\n\tinfo\tdetection",
            "X-MS-Exchange-CrossTenant-AuthAs": "Internal",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "Delivered-To": "patchwork@inbox.dpdk.org",
            "Received": [
                "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 71066A0526;\n\tWed, 22 Jul 2020 17:31:41 +0200 (CEST)",
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B3F181C036;\n\tWed, 22 Jul 2020 17:30:58 +0200 (CEST)",
                "from EUR05-DB8-obe.outbound.protection.outlook.com\n (mail-db8eur05on2049.outbound.protection.outlook.com [40.107.20.49])\n by dpdk.org (Postfix) with ESMTP id 203491BFE4;\n Wed, 22 Jul 2020 17:30:51 +0200 (CEST)",
                "from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17)\n by AM0PR05MB4401.eurprd05.prod.outlook.com (2603:10a6:208:62::20)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Wed, 22 Jul\n 2020 15:30:50 +0000",
                "from AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.028; Wed, 22 Jul 2020\n 15:30:50 +0000"
            ],
            "x-originating-ip": "[84.242.49.134]",
            "x-microsoft-antispam": "BCL:0;",
            "x-ms-exchange-transport-forked": "True",
            "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB6707.eurprd05.prod.outlook.com",
            "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=iPhK5NBG+5CLZkX8weCU2Pqy3h7BjFA0RRrfqtF77Go=;\n b=fs1HPd1D/s9od2Hk1nZ7TxAv5agGqKPu9jQMh/mfqaC4ulxAFfkUqgVPEStuCeXIOuEcOwnGXsAI1aZQ7PVi0OhMo5BCLVXL0HfmgvKBQKDdTk8F31WYhwqkTeo+d4Nx2IlNP6r8FXCcI0TSTi0nl0n/h2qQ1xtRnWeNGBBXcfjevjDSxx3mbxLROkuyLjmEaVS46YBS9DFcVRkYqXJHw9yXHUxspOztn8Rl0ux95HdXZDyMsBXmYeEWt+YDxA3Qt8jKOXN7ebBdg29VqOH2wagR/XCq3iIvvz3PJ9nOpF+daGgb59A5XlOHxP+/CTpybkJgXMZVe8KGGyf6Rau9Zw==",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted",
            "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=iPhK5NBG+5CLZkX8weCU2Pqy3h7BjFA0RRrfqtF77Go=;\n b=sBmYJXPrKmh4FJeccRrD6BrUQcZDELQ9lgbKFjvyvYYs8ffOjCKS7P99PonuX94Iyrq63BDiCr+uqKoX7zRbVI3RH2xUfPCitPXO7gut+O0C+6jMe9TRE+5IIDH9DOKGE/FDmJQw07Oa/rmgRY8NDsi4qpkDvBEza4rufK4GDik=",
            "Message-ID": "\n <AM0PR05MB6707D37B4B62AED9B547321EC2790@AM0PR05MB6707.eurprd05.prod.outlook.com>",
            "X-MS-Exchange-CrossTenant-userprincipalname": "\n cwsBYG12XSAEJ56dcSlb3zhVA4EWtnjy59G8zmFafEwgusYqqVKJAzWWW9kfpS+KsJs7oNJAYz0QOuWAt3u7ow==",
            "To": "Michael Baum <michaelba@mellanox.com>, \"dev@dpdk.org\" <dev@dpdk.org>",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
            "From": "Raslan Darawsheh <rasland@mellanox.com>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "x-ms-publictraffictype": "Email",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none",
            "X-MS-TNEF-Correlator": "",
            "Thread-Index": "AQHWX1bYKTyPlYeIs060NgxHGmhxz6kTuvEw",
            "CC": "Matan Azrad <matan@mellanox.com>, Slava Ovsiienko\n <viacheslavo@mellanox.com>, \"stable@dpdk.org\" <stable@dpdk.org>",
            "X-OriginatorOrg": "Mellanox.com",
            "Thread-Topic": "[dpdk-dev] [PATCH] net/mlx5: fix unlimited scan in switch info\n detection",
            "X-Original-To": "patchwork@inbox.dpdk.org",
            "x-microsoft-antispam-message-info": "\n zCqNo2CS4/XaCNXxxjAo10RDCQqKnIqJjk9u/xmejDfR4B/jvqdy9JFGW+63brfrsG6JETUPzj6CF2MzqfOd0btli00t+CfchbVm1JWfxwZUg07EYZwOrqiIS2MmWayJHYg6sJwTIW0DsPhqIGkNYvNdh1aKSuA19lt4GMRemgSfRSQXEL14/jYNl6VMGfOTUtYschTj23YpoecIJxdSb1r6ctVKBw70D5q+uTFxZZfkjVZomUMMihBCpZM0s+5xNegOrtm9j6YzO3WWFlBdVmNTTHDNbZCVpV0+D4LsEcgh/J2N53kyVX89ngXdC0A5y+hz0mDmGWXaGmjw1EWzOQ==",
            "x-ms-office365-filtering-ht": "Tenant",
            "MIME-Version": "1.0",
            "In-Reply-To": "<1595332952-7035-1-git-send-email-michaelba@mellanox.com>",
            "X-BeenThere": "dev@dpdk.org",
            "References": "<1595332952-7035-1-git-send-email-michaelba@mellanox.com>",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b",
            "x-ms-office365-filtering-correlation-id": "32e12a6b-8acd-4c79-1e5a-08d82e5436bb",
            "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 32e12a6b-8acd-4c79-1e5a-08d82e5436bb",
            "Date": "Wed, 22 Jul 2020 15:30:50 +0000",
            "Content-Transfer-Encoding": "quoted-printable",
            "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(396003)(376002)(39860400002)(136003)(366004)(346002)(316002)(8936002)(6506007)(26005)(4326008)(7696005)(53546011)(450100002)(478600001)(54906003)(110136005)(186003)(86362001)(2906002)(52536014)(5660300002)(55016002)(83380400001)(33656002)(76116006)(66946007)(66476007)(66556008)(64756008)(66446008)(9686003)(71200400001);\n DIR:OUT; SFP:1101;",
            "X-MS-Has-Attach": "",
            "x-ms-traffictypediagnostic": "AM0PR05MB4401:",
            "x-ms-exchange-antispam-messagedata": "\n sbZF9WRNXuu3Ey1QWCh5KSkXlfKwQn1sRLYZix06FCR7cXs74E8VExYzIjNrO+sf8xe3k/DDn+D7x3Uovp+SXffYLXvMAc1RkzLSZ5XjFG5U1vi2y9BX6sOlJ3x8WfFeCYR/bDCU0xzonRmXwe27Y4Yqtq8KGfc9LF0xrMbnOsBCcdp+Ld3dNFao09qdexAbGV8ykoxusJSZEgw9K2fPBLQaLCa6mBEg+4Gzad1+6eI3NY7uxk4hDZIFANeFj0Hawkpaddpkb9G0HMH2RmZdwIppSmi/9c5X+1WX93NrixTTGsq3Vp+2EJHFyXR3Wn/VF9Ak7/CuIQFFAW4UOo+BTAcsZYv4qKFjvWN760/CLcKC/71P2g2UVvpLM/Rxy/CO0ddkEbWzjmWI2AdDEI+se8KMibrxWWU/ra1iL5ACqIOnxfO8aRHVaaE+pisoH3oTDAAmCeL/TXRBqucG1ZU3+1HPJl9ceRJQZOeAXaA+dFVckxm5I+5BCl7OJK6tUdwe",
            "X-MS-Exchange-CrossTenant-originalarrivaltime": "22 Jul 2020 15:30:50.2252 (UTC)",
            "Content-Language": "en-US",
            "Errors-To": "dev-bounces@dpdk.org",
            "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=nqe61kemPh/JrJ9yKjz3+h8IT5BE6xYvc1FMtfwh0sA+U17ABs8EjNuf4c1RVCjfmHXYME1kYeTNwcaRkLcq9CiwlFW9Rm1a+zJ63UIXu1ASD8x8wTDt2meTkZt7TxscuA3LlQX1suJp+2pLtrSppNISd9qDW7hXaLaHc+1X9uKd56YIQaHlb63mJoPZjhQVYe3xXd+OkEa57lamy0o6ijGLW+G+17n7ZODtBkYqiQ5YVlvxIh8cwqvbe14J7z0DLNZWw3Xc+SXQi1G7UIgeJ8Q5nGKfOc5UGl5ilnYLcTiCym7yCa09lDrM44XXnqERWrFpkqymURLpAEyPAAa+6A==",
            "x-microsoft-antispam-prvs": "\n <AM0PR05MB4401418FFD96CB6D1F5FC8BBC2790@AM0PR05MB4401.eurprd05.prod.outlook.com>"
        }
    }
]