Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 7457,
    "url": "https://patches.dpdk.org/api/patches/7457/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1444067795-29748-2-git-send-email-adrien.mazarguil@6wind.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1444067795-29748-2-git-send-email-adrien.mazarguil@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1444067795-29748-2-git-send-email-adrien.mazarguil@6wind.com",
    "date": "2015-10-05T17:56:33",
    "name": "[dpdk-dev,1/3] eal: new interrupt handler type",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "b03c36f8e87b649cb44d52da5ce72597e9b1dabb",
    "submitter": {
        "id": 165,
        "url": "https://patches.dpdk.org/api/people/165/?format=api",
        "name": "Adrien Mazarguil",
        "email": "adrien.mazarguil@6wind.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1444067795-29748-2-git-send-email-adrien.mazarguil@6wind.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/7457/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/7457/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 8FF579221;\n\tMon,  5 Oct 2015 19:56:57 +0200 (CEST)",
            "from mail-wi0-f180.google.com (mail-wi0-f180.google.com\n\t[209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 674A29368\n\tfor <dev@dpdk.org>; Mon,  5 Oct 2015 19:56:55 +0200 (CEST)",
            "by wiclk2 with SMTP id lk2so126068023wic.1\n\tfor <dev@dpdk.org>; Mon, 05 Oct 2015 10:56:55 -0700 (PDT)",
            "from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by smtp.gmail.com with ESMTPSA id\n\tjj8sm15858017wid.2.2015.10.05.10.56.54\n\t(version=TLSv1.2 cipher=RC4-SHA bits=128/128);\n\tMon, 05 Oct 2015 10:56:54 -0700 (PDT)"
        ],
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=JsEWsZQ4w90tyoJHEyD7PC8aiA2OoBhIWwPIJ88yRDk=;\n\tb=BXO56DJXM2gvixR5IZYE15zwJgD6C9gfD6TDU/YEaN+nyqvPzVJNjoSo4dUNqHrHRB\n\tbWljHnFWSJ07yqfqISuHn/4ZSwS1OwU4vl0hKsukvr5Dr5CE0yRy8VimixtrQnn//vBM\n\tYykf6LpzerMSL05wloxLIhTbCr93ushTBZYSfBzzLLySxnCEFWGUu92WJgQe6n1chjzS\n\tufE0gp5ez8UFNSnRBPqTnXrYocIRXWuzkiJOAyMYruwgSfPR4P7WTzRxFBWeOfdsIX/+\n\tz94095vVuXFFrXc/+X0//9vocOU3d+1PC2+SnCQB8dRu3N8+mJt0zBDsxmef//YYF8fd\n\tzFuA==",
        "X-Gm-Message-State": "ALoCoQlpyy298KI3gSS/D2jfS4dDvtuDZS0NRgE+H8mDKnyskWsUiz5mMrV8cH6CT11BNrPNWtGx",
        "X-Received": "by 10.180.75.38 with SMTP id z6mr11931533wiv.36.1444067814980;\n\tMon, 05 Oct 2015 10:56:54 -0700 (PDT)",
        "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>",
        "To": "dev@dpdk.org",
        "Date": "Mon,  5 Oct 2015 19:56:33 +0200",
        "Message-Id": "<1444067795-29748-2-git-send-email-adrien.mazarguil@6wind.com>",
        "X-Mailer": "git-send-email 2.1.0",
        "In-Reply-To": "<1444067795-29748-1-git-send-email-adrien.mazarguil@6wind.com>",
        "References": "<1444067795-29748-1-git-send-email-adrien.mazarguil@6wind.com>",
        "Subject": "[dpdk-dev] [PATCH 1/3] eal: new interrupt handler type",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\n\nAdd RTE_INTR_HANDLE_EXT handler type for PMDs that do not support VFIO or\nUIO.  Those are expected to manage the file descriptor themselves.\n\nSigned-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\n---\n lib/librte_eal/linuxapp/eal/eal_interrupts.c       | 34 ++++++++++++----------\n .../linuxapp/eal/include/exec-env/rte_interrupts.h |  1 +\n 2 files changed, 20 insertions(+), 15 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal_interrupts.c b/lib/librte_eal/linuxapp/eal/eal_interrupts.c\nindex 078318c..79eedaf 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_interrupts.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_interrupts.c\n@@ -691,26 +691,30 @@ eal_intr_process_interrupts(struct epoll_event *events, int nfds)\n \t\t\tbytes_read = sizeof(buf.vfio_intr_count);\n \t\t\tbreak;\n #endif\n+\t\tcase RTE_INTR_HANDLE_EXT:\n \t\tdefault:\n \t\t\tbytes_read = 1;\n \t\t\tbreak;\n \t\t}\n \n-\t\t/**\n-\t\t * read out to clear the ready-to-be-read flag\n-\t\t * for epoll_wait.\n-\t\t */\n-\t\tbytes_read = read(events[n].data.fd, &buf, bytes_read);\n-\t\tif (bytes_read < 0) {\n-\t\t\tif (errno == EINTR || errno == EWOULDBLOCK)\n-\t\t\t\tcontinue;\n-\n-\t\t\tRTE_LOG(ERR, EAL, \"Error reading from file \"\n-\t\t\t\t\"descriptor %d: %s\\n\", events[n].data.fd,\n-\t\t\t\t\t\t\tstrerror(errno));\n-\t\t} else if (bytes_read == 0)\n-\t\t\tRTE_LOG(ERR, EAL, \"Read nothing from file \"\n-\t\t\t\t\"descriptor %d\\n\", events[n].data.fd);\n+\t\tif (src->intr_handle.type != RTE_INTR_HANDLE_EXT) {\n+\t\t\t/**\n+\t\t\t * read out to clear the ready-to-be-read flag\n+\t\t\t * for epoll_wait.\n+\t\t\t */\n+\t\t\tbytes_read = read(events[n].data.fd, &buf, bytes_read);\n+\t\t\tif (bytes_read < 0) {\n+\t\t\t\tif (errno == EINTR || errno == EWOULDBLOCK)\n+\t\t\t\t\tcontinue;\n+\n+\t\t\t\tRTE_LOG(ERR, EAL, \"Error reading from file \"\n+\t\t\t\t\t\"descriptor %d: %s\\n\",\n+\t\t\t\t\tevents[n].data.fd,\n+\t\t\t\t\tstrerror(errno));\n+\t\t\t} else if (bytes_read == 0)\n+\t\t\t\tRTE_LOG(ERR, EAL, \"Read nothing from file \"\n+\t\t\t\t\t\"descriptor %d\\n\", events[n].data.fd);\n+\t\t}\n \n \t\t/* grab a lock, again to call callbacks and update status. */\n \t\trte_spinlock_lock(&intr_lock);\ndiff --git a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h\nindex 45071b7..b095b86 100644\n--- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h\n+++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h\n@@ -48,6 +48,7 @@ enum rte_intr_handle_type {\n \tRTE_INTR_HANDLE_VFIO_MSI,     /**< vfio device handle (MSI) */\n \tRTE_INTR_HANDLE_VFIO_MSIX,    /**< vfio device handle (MSIX) */\n \tRTE_INTR_HANDLE_ALARM,    /**< alarm handle */\n+\tRTE_INTR_HANDLE_EXT, /**< external handler */\n \tRTE_INTR_HANDLE_MAX\n };\n \n",
    "prefixes": [
        "dpdk-dev",
        "1/3"
    ]
}