Patch Comment List
List patch comments
GET /api/patches/74569/comments/?format=api
[ { "id": 116514, "web_url": "https://patches.dpdk.org/comment/116514/", "msgid": "<AM0PR05MB670744B41739BD62B63EDEFEC2790@AM0PR05MB6707.eurprd05.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/AM0PR05MB670744B41739BD62B63EDEFEC2790@AM0PR05MB6707.eurprd05.prod.outlook.com", "date": "2020-07-22T15:30:49", "subject": "Re: [dpdk-dev] [PATCH] net/mlx4: optimize stuck memory size in probe", "submitter": { "id": 513, "url": "https://patches.dpdk.org/api/people/513/?format=api", "name": "Raslan Darawsheh", "email": "rasland@mellanox.com" }, "content": "Hi,\n\n> -----Original Message-----\n> From: dev <dev-bounces@dpdk.org> On Behalf Of Michael Baum\n> Sent: Tuesday, July 21, 2020 3:01 PM\n> To: dev@dpdk.org\n> Cc: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko\n> <viacheslavo@mellanox.com>; stable@dpdk.org\n> Subject: [dpdk-dev] [PATCH] net/mlx4: optimize stuck memory size in probe\n> \n> The mlx4_pci_probe function sets a pointer to the mlx4_priv structure,\n> and during that function fills its fields one by one with relevant\n> values.\n> \n> It wants to put a value in the intr_handle field that has all its fields\n> zero except 2. To do so, it initializes a local struct rte_intr_handle\n> type variable and updates it only 2 fields and assigns it into the\n> appropriate field. However, it initializes a very large structure on the\n> stack while not at all certain that this place exists and in any case it\n> is very wasteful.\n> \n> Reset all fields directly to the pointer by memset, then format the 2\n> fields to the relevant values.\n> \n> Fixes: 63c2f23c852a (\"net/mlx4: use a single interrupt handle\")\n> Cc: stable@dpdk.org\n> \n> Signed-off-by: Michael Baum <michaelba@mellanox.com>\n> Acked-by: Matan Azrad <matan@mellanox.com>\n> ---\n> drivers/net/mlx4/mlx4.c | 7 +++----\n> 1 file changed, 3 insertions(+), 4 deletions(-)\n> \n> diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c\n> index e619a74..71061a7 100644\n> --- a/drivers/net/mlx4/mlx4.c\n> +++ b/drivers/net/mlx4/mlx4.c\n> @@ -1029,10 +1029,9 @@ struct mlx4_conf {\n> \t\teth_dev->device = &pci_dev->device;\n> \t\trte_eth_copy_pci_info(eth_dev, pci_dev);\n> \t\t/* Initialize local interrupt handle for current port. */\n> -\t\tpriv->intr_handle = (struct rte_intr_handle){\n> -\t\t\t.fd = -1,\n> -\t\t\t.type = RTE_INTR_HANDLE_EXT,\n> -\t\t};\n> +\t\tmemset(&priv->intr_handle, 0, sizeof(struct\n> rte_intr_handle));\n> +\t\tpriv->intr_handle.fd = -1;\n> +\t\tpriv->intr_handle.type = RTE_INTR_HANDLE_EXT;\n> \t\t/*\n> \t\t * Override ethdev interrupt handle pointer with private\n> \t\t * handle instead of that of the parent PCI device used by\n> --\n> 1.8.3.1\n\n\nPatch applied to next-net-mlx\n\nKindest regards,\nRaslan Darawsheh", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B1156A0526;\n\tWed, 22 Jul 2020 17:31:15 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AEA081BFE7;\n\tWed, 22 Jul 2020 17:30:55 +0200 (CEST)", "from EUR05-AM6-obe.outbound.protection.outlook.com\n (mail-am6eur05on2051.outbound.protection.outlook.com [40.107.22.51])\n by dpdk.org (Postfix) with ESMTP id 3721B2C6E;\n Wed, 22 Jul 2020 17:30:50 +0200 (CEST)", "from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17)\n by AM0PR05MB4401.eurprd05.prod.outlook.com (2603:10a6:208:62::20)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Wed, 22 Jul\n 2020 15:30:49 +0000", "from AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.028; Wed, 22 Jul 2020\n 15:30:49 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=WaHNrap5hA7goAFW9O730BOUwyA8Lot9ExHShgzaCKhdJPT9jrOzL3lPZ/ak/XcJxNVkRsKGRj98P6aIjRPupGsSAwi5udLjfv4n5eRg85jtBpAFlvJe+XBQvTtk51AvsQY+Ja3KKiz8dinQdm5kp5QQSkUEt65i6yWt03M+Jvwjubouv7Gs6hXMpmtGvxcVILgtTdIZgBk0OS+Z94iheXBegPbYm9vu+GmTnmWMV+EgWmgZ+ed1QG96UqSlw/ggcr2F+qbddh0668muvN0uWCEJXebHadF8hBRhh8IRHH3QIAXhZY5nnOifiswsvz6mgK7oQNZm46WcZamzmPjtuA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=lP+S9JkbccUeUfyio0P4XtzH3l6QvbYpSD7OL6BwnpQ=;\n b=ScJ3U7A9/MqNL2++sXHdifgt+svgv+mp4X5oriV1vgCACOunpSbF+avKY7boHOY0AaMZYMfgZ1d9PnBNPyYU6YfR23YBowLZ0O0Wpmi6k95KXYK+2C1FnHru7KSybN3RcqJMv6WFs/bRExvBODAj2zyF0yEU/3/s5M3+Qot3zCrFoCWKEaJVAje3hmWe/PAWkabWdtJjb3vA//D7ft/Nqy8eGh3BVBjvkAIKTaX2vbAK16sVGf8stxBQsD5dnY0fvVp0SW/r3HQz2weKXhEjC+mqF9j7QnfYCXOYw63ejoNNv0e57vSbpyUMbm4xt3ucT04jmOrmzDxtKZvm5ZbcFg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=lP+S9JkbccUeUfyio0P4XtzH3l6QvbYpSD7OL6BwnpQ=;\n b=eRR+2jRwzKBkXVQpeQXODC+vDtPHnYIYpoxQ3UT4lfxrT++SdnjB5CNg8hup5VQZnNxvWfwsvlbY1mUkUzkIgOEN4SAyjMSX4sVSSERstojjNA3tTSd6a3P70I0xAnj4ZOVJs+Aim/prwJS4sXFiSayGZyhH8tDWr3kllckhcLs=", "From": "Raslan Darawsheh <rasland@mellanox.com>", "To": "Michael Baum <michaelba@mellanox.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "Matan Azrad <matan@mellanox.com>, Slava Ovsiienko\n <viacheslavo@mellanox.com>, \"stable@dpdk.org\" <stable@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH] net/mlx4: optimize stuck memory size in probe", "Thread-Index": "AQHWX1arTDhOiTaZd0alelRM7Hpi1qkTuuFA", "Date": "Wed, 22 Jul 2020 15:30:49 +0000", "Message-ID": "\n <AM0PR05MB670744B41739BD62B63EDEFEC2790@AM0PR05MB6707.eurprd05.prod.outlook.com>", "References": "<1595332869-6942-1-git-send-email-michaelba@mellanox.com>", "In-Reply-To": "<1595332869-6942-1-git-send-email-michaelba@mellanox.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "mellanox.com; dkim=none (message not signed)\n header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com;", "x-originating-ip": "[84.242.49.134]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-ht": "Tenant", "x-ms-office365-filtering-correlation-id": "9e4e2384-4c3e-44ac-9fcc-08d82e54365c", "x-ms-traffictypediagnostic": "AM0PR05MB4401:", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <AM0PR05MB44013FEBD342D4EAFF571DA1C2790@AM0PR05MB4401.eurprd05.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:7691;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n rIwFrr5xVIPIgqtiPFigIitJh/8WVYYa+xaajrkL1Z9I3GbFdtv00dsgVzFFkTmEj2/wJJ6PIaLC8dMzhHy+tNW1y3QTcNebmSMmruVERy80YgmGhYaA9DSXDwooP8z+RzJ8znnV5zZKxTEoGsm75YxZEmisgfc+AzmYIiJ6YFbvBPZhoNJ2x9vaayey4/v5Kqm3M/oi8udm5Ttfh7EL4yTkDY/GmapH8BGn9OHkgLCFXUDNy0ikJwYbJrSPO89lGK1eg5dIZMR/1NPhd1+IPmHOt1hWEQ0x76scvo0cXg+bMI7ais84ybnMS7i3K7D3e4cwrGmj3f+GT9mvDTMvyg==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(396003)(376002)(39860400002)(136003)(366004)(346002)(316002)(8936002)(6506007)(26005)(4326008)(7696005)(53546011)(450100002)(478600001)(8676002)(54906003)(110136005)(186003)(86362001)(2906002)(52536014)(5660300002)(55016002)(83380400001)(33656002)(76116006)(66946007)(66476007)(66556008)(64756008)(66446008)(9686003)(71200400001);\n DIR:OUT; SFP:1101;", "x-ms-exchange-antispam-messagedata": "\n SwU4VTyYUeYB+qJFjdS1d5HScsiAFjQpj236vlRbU9sZrhlQ51EajOMUY2GdBbe5xBuri0YOpW1NUy+AaVZem1S0QFrJ6OU061UZYn+lXrQwMDLSdoplIi9txWjh8rsFGjySd/VHJhThDg9nTXcxT4nkipLNT8S6iqtQ41KRCWBdsuffFFcomgJpk0iLFjsnsJSPJtaaPMLT0FFk2+9pMqcIZor1zEkRK9tUe5uS0iqGOsVw5xkfJRDSG6TTLHVdolvYvZQvOpGFCody2u31VkOUOVb0G30C74KR21AF495vLw3ZqRj/+E3WjlFyH139kucBKTIWAwT+16rTbIdXZ1l33I7KUV7TnMwL0A+d++6C+Av6tVFi3QMbfQb1mevjV5CCpu5sewexxkAwKRzUy/RiDK7mZlHTEusrn5W7zkp+uCQV5ak69Vgd2rMZN6O9b5srEZvKNIy4IaQbC2GK43MB9A9qJvhiewJI6grKcsXRcNR0piAo0ZW/hhoA7c2m", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB6707.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 9e4e2384-4c3e-44ac-9fcc-08d82e54365c", "X-MS-Exchange-CrossTenant-originalarrivaltime": "22 Jul 2020 15:30:49.6478 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n qCCvbElkUUybMhgc4MXQTF7N24aC27DEAKadYG/jYO4blQS9BvfISvRE85iZjWuIG7zkjMD+J1K+SVkbElThWQ==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR05MB4401", "Subject": "Re: [dpdk-dev] [PATCH] net/mlx4: optimize stuck memory size in probe", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]