Patch Comment List
List patch comments
GET /api/patches/74568/comments/?format=api
[ { "id": 116515, "web_url": "https://patches.dpdk.org/comment/116515/", "msgid": "<AM0PR05MB67079EBB86A435AF5108D9BBC2790@AM0PR05MB6707.eurprd05.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/AM0PR05MB67079EBB86A435AF5108D9BBC2790@AM0PR05MB6707.eurprd05.prod.outlook.com", "date": "2020-07-22T15:30:49", "subject": "Re: [dpdk-dev] [PATCH] net/mlx5: fix an ineffective calculation\n\tin\thairpin splitter", "submitter": { "id": 513, "url": "https://patches.dpdk.org/api/people/513/?format=api", "name": "Raslan Darawsheh", "email": "rasland@mellanox.com" }, "content": "Hi,\n\n> -----Original Message-----\n> From: dev <dev-bounces@dpdk.org> On Behalf Of Michael Baum\n> Sent: Tuesday, July 21, 2020 3:00 PM\n> To: dev@dpdk.org\n> Cc: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko\n> <viacheslavo@mellanox.com>; stable@dpdk.org\n> Subject: [dpdk-dev] [PATCH] net/mlx5: fix an ineffective calculation in hairpin\n> splitter\n> \n> The flow_hairpin_split function defines a pointer called addr that\n> points to the list of items.\n> When the function wants to progress in the list, it adds the size of an\n> item to the pointer.\n> \n> At the end of the function, it precedes the pointer one more time even\n> though it is not used afterwards. In fact, this line is unaffected and\n> the operation of the function would have been no different without it.\n> \n> Remove the line where the pointer is preceded unnecessarily.\n> \n> Fixes: d85c7b5ea59f (\"net/mlx5: split hairpin flows\")\n> Cc: stable@dpdk.org\n> \n> Signed-off-by: Michael Baum <michaelba@mellanox.com>\n> Acked-by: Matan Azrad <matan@mellanox.com>\n> ---\n> drivers/net/mlx5/mlx5_flow.c | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\n> index aba8f41..cf7052b 100644\n> --- a/drivers/net/mlx5/mlx5_flow.c\n> +++ b/drivers/net/mlx5/mlx5_flow.c\n> @@ -3518,7 +3518,6 @@ struct mlx5_flow_tunnel_info {\n> \ttag_item->data = UINT32_MAX;\n> \ttag_item->id = UINT16_MAX;\n> \titem->mask = tag_item;\n> -\taddr += sizeof(struct mlx5_rte_flow_item_tag);\n> \titem->last = NULL;\n> \titem++;\n> \titem->type = RTE_FLOW_ITEM_TYPE_END;\n> --\n> 1.8.3.1\n\n\nPatch applied to next-net-mlx,\n\nKindest regards,\nRaslan Darawsheh", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8F3A8A0526;\n\tWed, 22 Jul 2020 17:31:27 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 263E51C025;\n\tWed, 22 Jul 2020 17:30:57 +0200 (CEST)", "from EUR04-HE1-obe.outbound.protection.outlook.com\n (mail-eopbgr70075.outbound.protection.outlook.com [40.107.7.75])\n by dpdk.org (Postfix) with ESMTP id ABD821BFD4;\n Wed, 22 Jul 2020 17:30:50 +0200 (CEST)", "from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17)\n by AM0PR0502MB3636.eurprd05.prod.outlook.com (2603:10a6:208:19::24)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Wed, 22 Jul\n 2020 15:30:49 +0000", "from AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.028; Wed, 22 Jul 2020\n 15:30:49 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=jaHHawryG8A1YD+NKqNX9mHyuHAd3dBgt30KhdadTuGxzQbfP7Nxuj1V0lJFnW3X7rdc1BANcSaMDjtuWhWkuDK3vE4/7p9an3fjlsmwK/SsULgOo3VuQdExVYTvQTgx4SsyZ2Ta7KyP66CjoKgFYjNQWwnr/5cqHrcHFM6RbcpGUBm0IGZdNJ6cPaozlumMxR0xsIDRWqyVEhWQNG7riHrr9SmmP1P/+oIQQdZ70HhESPoFE6fQQCgTgGYyROKWl5bMDWDHS400WmHheouPi7bdkI92RJLkqG8dbukmic1lY/cpHczXPhmhDsoymWDPxLKG84rUbby11iwhjwKxyg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=eNBBO3pR89WK7cgIyeSl06yRas4pnY6cgEN3fvlRD70=;\n b=XSxxZRd8c2SXETB8YZDEz3zoGtyOBLnbftGifiXnb1L8inkhyU7rY2QEiABg/BNtIJOzAiAE0CUEwy/GS9nM02yomoonHCvxNC9CNWYG0vn8HkORthtxdTcGm8K2sE0+nTc7pdGyS2eQRORRYrspx8eHxnn7x/KsYXM7utrdPR/ku2j01KGMhaLjO5eMJPRZBSBHvkGc1Z7g36sc+XfNAmFSeNlLKfWJCnOx884N05eNhgBPsos22MOfg/sSt6DFsORiO1A9B4LQX5RXm9xyG3v/wuddZEEt9y0L3VR96PQTjBEHfC3g2Pa/sEE0XFqAowyIWPKJjvytSNyEBeVWpw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=eNBBO3pR89WK7cgIyeSl06yRas4pnY6cgEN3fvlRD70=;\n b=g3Bj8aA9wka+ElDqCWxczurXeVi4yxNqDq1W6NBzvfmASm/2qH4IPosV+a1MHbjrSSSszp39qR6wAaH/xJIffErvILH+KJ8JhDyemTJLmXaY5XP5yUgZkadRF52LwS+0UpkOgaUaKtsxa0WptF7ZdijzJM5GsUX17D7erG4vGZs=", "From": "Raslan Darawsheh <rasland@mellanox.com>", "To": "Michael Baum <michaelba@mellanox.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "Matan Azrad <matan@mellanox.com>, Slava Ovsiienko\n <viacheslavo@mellanox.com>, \"stable@dpdk.org\" <stable@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH] net/mlx5: fix an ineffective calculation in\n hairpin splitter", "Thread-Index": "AQHWX1aFYGJc5h6erEa6/FKFK0xYe6kTusQA", "Date": "Wed, 22 Jul 2020 15:30:49 +0000", "Message-ID": "\n <AM0PR05MB67079EBB86A435AF5108D9BBC2790@AM0PR05MB6707.eurprd05.prod.outlook.com>", "References": "<1595332804-6860-1-git-send-email-michaelba@mellanox.com>", "In-Reply-To": "<1595332804-6860-1-git-send-email-michaelba@mellanox.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "mellanox.com; dkim=none (message not signed)\n header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com;", "x-originating-ip": "[84.242.49.134]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-ht": "Tenant", "x-ms-office365-filtering-correlation-id": "3679700d-7a1e-42fe-f3f3-08d82e5435ff", "x-ms-traffictypediagnostic": "AM0PR0502MB3636:", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <AM0PR0502MB36368B3F2B8EEF647AAE8274C2790@AM0PR0502MB3636.eurprd05.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:7691;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n yGhxfdacfLnDUAQOTTJw2MHLLyLCwo3d/JayP9XQbXFCf+Q5LazryRrvcSjOJlSf9MFUS5SvQPwLaze7ffEhlGe76YDqc0ne0J5CQtfrD8vw7UwYSFT/7Zbbd6PDXZfkd3RGkLEqkX9JkvzRk8j+0zQm3zlG3TWnrXOQWY54CzCm9k/e1rw0z90pZ6wKRcBMi6FatejYxVg5VN9I+cXvP1FjnKcKrNGIOm27BXfmJlmLb3JFLuvimCj4UAz+SVDzdqTefG38immEcYLUWtfYWJ6qmXfOhKx8uzfCSldLE/sBW931TOzgpioz3P39o/ZL", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(39860400002)(366004)(136003)(396003)(376002)(346002)(83380400001)(2906002)(316002)(8936002)(9686003)(86362001)(110136005)(54906003)(4326008)(5660300002)(33656002)(186003)(66946007)(66476007)(64756008)(66556008)(66446008)(76116006)(71200400001)(450100002)(53546011)(52536014)(6506007)(7696005)(55016002)(478600001)(26005);\n DIR:OUT; SFP:1101;", "x-ms-exchange-antispam-messagedata": "\n 0NxE8EMHs2nzx3nG7KSHZn7avn92rnlYoazJ8I5Cy95aDEG6aIHJ1y/zIDxcp0DaGCQSm5ChILRgMr5HNhRtwvRUvlM2jxzsGQjfmpZ8Z+RO2au1nsTAppm2P8o9XoNiQzFEz4gfg7ier2JNkvoIC11WsX7VAmbGC6wxtDkFeozxnq9ZaWMzOY5p6ufOoUnc2+tPrShrtkT9C3ffVUD5f+ibhaVp8VbTWodkPYrGNa5x/bCLd+Wu1qOwy3Xp+299mgbz744hE54dI5Yc/MsxBEYsq4A4HzrxVPX+VUpmZ7e0flUwDoeqm2MySMyfs3GZ2cRzBVd9lrP975BW61jdTCBQgM8rQ7YTz1C8sbyzqUxO7WzNYWNnQZFVs1ism7dbGHqbkKEzqqq8V0r59Dgb/OqvRpN7bwrsit38x1mk7cCfiLxzYaSg5jkkU2FDvx9B6ywZ8jo0H76RkJuWLROafMmTCL9REO+bZpdtzh7YGTnbwKXrLNYTd0DCKO3srQ1T", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB6707.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 3679700d-7a1e-42fe-f3f3-08d82e5435ff", "X-MS-Exchange-CrossTenant-originalarrivaltime": "22 Jul 2020 15:30:49.0454 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n d8szysESF7OUJytW1a9D+VPSrgJpjKaCkWrd/4hgUbEsMxvgaM8pCdkhF6OitxIT90NMldbZ1FpqpkTj6rkR3Q==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR0502MB3636", "Subject": "Re: [dpdk-dev] [PATCH] net/mlx5: fix an ineffective calculation\n\tin\thairpin splitter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]