Patch Comment List
List patch comments
GET /api/patches/74566/comments/?format=api
[ { "id": 116512, "web_url": "https://patches.dpdk.org/comment/116512/", "msgid": "<AM0PR05MB6707DE48A146596D3EECEECBC2790@AM0PR05MB6707.eurprd05.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/AM0PR05MB6707DE48A146596D3EECEECBC2790@AM0PR05MB6707.eurprd05.prod.outlook.com", "date": "2020-07-22T15:30:47", "subject": "Re: [dpdk-dev] [PATCH] net/mlx5: fix enum misusing for\n\tsteering\tregisters", "submitter": { "id": 513, "url": "https://patches.dpdk.org/api/people/513/?format=api", "name": "Raslan Darawsheh", "email": "rasland@mellanox.com" }, "content": "Hi,\n\n> -----Original Message-----\n> From: dev <dev-bounces@dpdk.org> On Behalf Of Michael Baum\n> Sent: Tuesday, July 21, 2020 2:57 PM\n> To: dev@dpdk.org\n> Cc: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko\n> <viacheslavo@mellanox.com>; stable@dpdk.org\n> Subject: [dpdk-dev] [PATCH] net/mlx5: fix enum misusing for steering\n> registers\n> \n> The mlx5_flow_action_copy_mreg structure contains a field called src\n> type enum modify_reg, similarly the mlx5_rte_flow_item_tag field\n> contains a field called id type enum modify_reg.\n> The enum modify_reg variable represents different registers in the\n> system and it also has a field called REG_NONE whose value is 0 which\n> means that the register does not exist.\n> \n> The flow_mreg_add_copy_action function sets a variable of struct\n> mlx5_flow_action_copy_mreg type, and initializes the src field to be 0.\n> similarly the flow_create_split_metadata function sets a variable of\n> struct mlx5_rte_flow_item_tag type and initializes the id field to be 0.\n> In both functions, they initialize a enum modify_reg type variable with\n> an int type value while modify_reg has an appropriate field for that\n> value (REG_NONE).\n> \n> Replace assigning 0 with REG_NONE in both functions.\n> \n> Fixes: dd3c774f6ffb (\"net/mlx5: add metadata register copy table\")\n> Fixes: 71e254bc0294 (\"net/mlx5: split Rx flows to provide metadata copy\")\n> Cc: stable@dpdk.org\n> \n> Signed-off-by: Michael Baum <michaelba@mellanox.com>\n> Acked-by: Matan Azrad <matan@mellanox.com>\n> ---\n> drivers/net/mlx5/mlx5_flow.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\n> index b56bee4..aba8f41 100644\n> --- a/drivers/net/mlx5/mlx5_flow.c\n> +++ b/drivers/net/mlx5/mlx5_flow.c\n> @@ -3011,7 +3011,7 @@ struct mlx5_flow_tunnel_info {\n> \t};\n> \tstruct mlx5_flow_action_copy_mreg cp_mreg = {\n> \t\t.dst = REG_B,\n> -\t\t.src = 0,\n> +\t\t.src = REG_NONE,\n> \t};\n> \tstruct rte_flow_action_jump jump = {\n> \t\t.group = MLX5_FLOW_MREG_ACT_TABLE_GROUP,\n> @@ -4067,7 +4067,7 @@ struct mlx5_flow_tunnel_info {\n> \t\t/* Internal PMD action to set register. */\n> \t\tstruct mlx5_rte_flow_item_tag q_tag_spec = {\n> \t\t\t.data = qrss_id,\n> -\t\t\t.id = 0,\n> +\t\t\t.id = REG_NONE,\n> \t\t};\n> \t\tstruct rte_flow_item q_items[] = {\n> \t\t\t{\n> --\n> 1.8.3.1\n\n\nPatch applied to next-net-mlx,\n\nKindest regards,\nRaslan Darawsheh", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 12A27A0526;\n\tWed, 22 Jul 2020 17:30:52 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5CC7A1BFCA;\n\tWed, 22 Jul 2020 17:30:50 +0200 (CEST)", "from EUR03-VE1-obe.outbound.protection.outlook.com\n (mail-eopbgr50072.outbound.protection.outlook.com [40.107.5.72])\n by dpdk.org (Postfix) with ESMTP id 58B882C6E;\n Wed, 22 Jul 2020 17:30:48 +0200 (CEST)", "from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17)\n by AM0PR05MB4401.eurprd05.prod.outlook.com (2603:10a6:208:62::20)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Wed, 22 Jul\n 2020 15:30:47 +0000", "from AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.028; Wed, 22 Jul 2020\n 15:30:47 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=QsKm7ZBnsQGXiRSmrJnAK7NltKASpSVWB2UFgkMg5sIuqCYLdwBLXxlRFAcpg8269Oqj2sRC4c9G/9KiW8apD8yNXW3iviTMJMCtsHEOSKXtPNe7HI9wmLb5YhbSMqHv6X/BqHAfxSKJaxk7kE4ehhMugs5owmJzqb0ChTvOjuDdqZKA+PAwAHWEZGuN09lAfRBH24xMkJEdKbwAbz8GpYPR4ppXtgEKZsdemehQoIiKCtN1Pljs+tc8JgoJQtp1eolLM+OdUuYYWGu0cKpqnU48rGrzv5uoMF4vxuFn4VLB3T3+FnBlyIfy2iW/E4TGMgIWSeNHa8ySBOtCMVYZ9Q==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=N0zpD7NY8S8yk7RdFdqMzU9DSArb6Zf7QRl3egd/UOQ=;\n b=Q6aF2phWNT1QnsInc4toIJn02PYZq9wOYSH72fBxPr6ssnlGhaenPXEmeQmSzPKnNNZ4M6IDQ1jmDptG1wLdw8mii7TdqlzT9P3tmDBJxAhr90Ite+Z+Liu+DVdM286gaINqPCu707gy2VeP2GQBO/p5HAgbBKUDBEiq/asnld7/UzepoT9ze9sMQa2XOQ+sJPX3jvbYf0knDZs8tYUTH8ezbvz3byl8VZvFY0YW/w9M3VTUGwcdDFyQNENFDEmeAQP18TczgigvkNwjURX0EWoUMAKkszUunkTntlaBN+kZP4qtTqzimfMIm83YfPoWjoRuDI+MTjno8nBQDc+k4Q==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=N0zpD7NY8S8yk7RdFdqMzU9DSArb6Zf7QRl3egd/UOQ=;\n b=tqX/tyX3IDHMp4s60XafvKu9P9MiQKVgTw2eCbwciRA0lz2/QqDoVPeUc+r1OxNtURdrKrW8obs3FtWfKdqXDlBX5pxKZknfXA0R1veYx3FwC9qd9waalPyoRp1+Ad3YRwTj73kAg7aBozARYDGpjtq5VLU1o3Zo5MEWITGa06w=", "From": "Raslan Darawsheh <rasland@mellanox.com>", "To": "Michael Baum <michaelba@mellanox.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "Matan Azrad <matan@mellanox.com>, Slava Ovsiienko\n <viacheslavo@mellanox.com>, \"stable@dpdk.org\" <stable@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH] net/mlx5: fix enum misusing for steering\n registers", "Thread-Index": "AQHWX1Yjd1BpF2Z8WUSo7M8JxU1t8akTuqeA", "Date": "Wed, 22 Jul 2020 15:30:47 +0000", "Message-ID": "\n <AM0PR05MB6707DE48A146596D3EECEECBC2790@AM0PR05MB6707.eurprd05.prod.outlook.com>", "References": "<1595332641-6144-1-git-send-email-michaelba@mellanox.com>", "In-Reply-To": "<1595332641-6144-1-git-send-email-michaelba@mellanox.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "mellanox.com; dkim=none (message not signed)\n header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com;", "x-originating-ip": "[84.242.49.134]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-ht": "Tenant", "x-ms-office365-filtering-correlation-id": "bbd1a0b6-1463-4194-3842-08d82e5434f8", "x-ms-traffictypediagnostic": "AM0PR05MB4401:", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <AM0PR05MB440133E1A05FAA8456F894F0C2790@AM0PR05MB4401.eurprd05.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:6790;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n fsJDdQVA4gpJES7RrSEUy4B447Bz16ID3i72HGxjOfM1DaoYK0H2eugk6qBM+Y+C4BjHIiwpGt3+dQkeXOV+d+qpUL02MZyL6xKmyPym+qkulMypyejhzD6BpV6VHaVYFBtYi0Mwintpjhq3B7OSe4kaURWxpnBoEOR+bFAjYU1PfjgvkIHx9JtLYobOQ9XYs6Tw+7SJXPywzMvE7PZzALvX67o2NIPZW2w+LX1DEpNnJ7OketdApHZjcv2tuPJeySphkYEJgETrdlFiSXl5QFF9CJNRz4bkIO/Vstl/TauFCssN5irtUD+/+XybWphE53rB3X8gBmK4H/mlScejuQ==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(396003)(376002)(39860400002)(136003)(366004)(346002)(316002)(8936002)(6506007)(26005)(4326008)(7696005)(53546011)(450100002)(478600001)(54906003)(110136005)(186003)(86362001)(2906002)(52536014)(5660300002)(55016002)(83380400001)(33656002)(76116006)(66946007)(66476007)(66556008)(64756008)(66446008)(9686003)(71200400001);\n DIR:OUT; SFP:1101;", "x-ms-exchange-antispam-messagedata": "\n K2YF3i5be9sFdWGoDSWXuEDDsJ+pOdyzokMEEycgLmDeU5A2dZBLWkNKW5jrrmYEDUfgXcxZOhje3wug7+gj5YGT2yAcN/b5/O6QaAbon2JFq6+fmtqip3//b62okUzJTBHfUOrKPGoi57RUqRyL0RQPg44f3w5WPY25ZBqTmPpWA3jZdcDHb091Z8XriJhwMyYUVCxJADy1pLgNSdbsNOPzG4U5Daite4huKNNllCTdqyyCaJ/iTg70pR6zKJg/jonJr3ViNmGNZMhz0U2bS+OJ8ybCM1KtEOId0514X2q75YJDHvfSkKgZLodkxyEQMVJcYmLhWysVzuNn037ibjRQV3COLHDK5i/2XHZVLil7F6W+pmgcvttLq4MaLgF/549NwQJwFXBc7WoD1RghEhzSvlIOEd1YoWAaLweW3LkriGJnOg3zFtOlqIo4Iwon6rm0l1eb1mP/mcP4mRkhlXihYJnfv1s6K5nzB8cCHIs77i8KrKxe3dJRu2137PXx", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB6707.eurprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n bbd1a0b6-1463-4194-3842-08d82e5434f8", "X-MS-Exchange-CrossTenant-originalarrivaltime": "22 Jul 2020 15:30:47.2523 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n olic+OdRdM7ZVhLOvIjOUPk2r/0DACctcILI5DKDfBiqatMzAMpvRwKg58xpMUBH5tsy3QrkVjIPZ/Xy8yHMGg==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR05MB4401", "Subject": "Re: [dpdk-dev] [PATCH] net/mlx5: fix enum misusing for\n\tsteering\tregisters", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]