List comments

GET /api/patches/74560/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 116487,
        "web_url": "https://patches.dpdk.org/comment/116487/",
        "msgid": "<AM0PR05MB6707F17FFB6B42A5B78EB735C2790@AM0PR05MB6707.eurprd05.prod.outlook.com>",
        "date": "2020-07-22T09:17:19",
        "subject": "Re: [dpdk-dev] [PATCH v2] common/mlx5: fix Rx/Tx queue doorbell\n\trecord size",
        "submitter": {
            "id": 513,
            "url": "https://patches.dpdk.org/api/people/513/",
            "name": "Raslan Darawsheh",
            "email": "rasland@mellanox.com"
        },
        "content": "Hi,\n> -----Original Message-----\n> From: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n> Sent: Tuesday, July 21, 2020 2:11 PM\n> To: dev@dpdk.org\n> Cc: Matan Azrad <matan@mellanox.com>; Raslan Darawsheh\n> <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>;\n> Dekel Peled <dekelp@mellanox.com>; stable@dpdk.org\n> Subject: [PATCH v2] common/mlx5: fix Rx/Tx queue doorbell record size\n> \n> When Rx/Tx queue was being created with DevX the allocated\n> doorbell record size was only uint64_t. That was definitely\n> less than size of CPU cacheline and it might have happened the\n> doorbell records attached to different queues handled by\n> different cores were allocated within same cacheline. It might\n> have caused the contention on doorbell record writing.\n> \n> This patch extends the allocated memory size for doorbell\n> record to cacheline size.\n> \n> Fixes: 21cae8580fd0 (\"net/mlx5: allocate door-bells via DevX\")\n> Cc: stable@dpdk.org\n> \n> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n> Acked-by: Matan Azrad <matan@mellanox.com>\n> \n> ---\n> v2: - rebase\n>     - clarify commit message, register is replaced with record\n> \n>  drivers/common/mlx5/mlx5_common.c |  2 +-\n>  drivers/common/mlx5/mlx5_common.h | 10 ++++++----\n>  2 files changed, 7 insertions(+), 5 deletions(-)\n> \n> diff --git a/drivers/common/mlx5/mlx5_common.c\n> b/drivers/common/mlx5/mlx5_common.c\n> index 79cd5ba..193e73b 100644\n> --- a/drivers/common/mlx5/mlx5_common.c\n> +++ b/drivers/common/mlx5/mlx5_common.c\n> @@ -187,7 +187,7 @@ static inline void mlx5_cpu_id(unsigned int level,\n>  \tpage->dbr_bitmap[i] |= (UINT64_C(1) << j);\n>  \tpage->dbr_count++;\n>  \t*dbr_page = page;\n> -\treturn (((i * 64) + j) * sizeof(uint64_t));\n> +\treturn (i * CHAR_BIT * sizeof(uint64_t) + j) * MLX5_DBR_SIZE;\n>  }\n> \n>  /**\n> diff --git a/drivers/common/mlx5/mlx5_common.h\n> b/drivers/common/mlx5/mlx5_common.h\n> index 5b9b7bd..ef7b61b 100644\n> --- a/drivers/common/mlx5/mlx5_common.h\n> +++ b/drivers/common/mlx5/mlx5_common.h\n> @@ -214,10 +214,12 @@ enum mlx5_class {\n>  \tMLX5_CLASS_VDPA = RTE_BIT64(1),\n>  };\n> \n> -#define MLX5_DBR_PAGE_SIZE 4096 /* Must be >= 512. */\n> -#define MLX5_DBR_SIZE 8\n> -#define MLX5_DBR_PER_PAGE (MLX5_DBR_PAGE_SIZE / MLX5_DBR_SIZE)\n> -#define MLX5_DBR_BITMAP_SIZE (MLX5_DBR_PER_PAGE / 64)\n> +#define MLX5_DBR_SIZE RTE_CACHE_LINE_SIZE\n> +#define MLX5_DBR_PER_PAGE 64\n> +/* Must be >= CHAR_BIT * sizeof(uint64_t) */\n> +#define MLX5_DBR_PAGE_SIZE (MLX5_DBR_PER_PAGE * MLX5_DBR_SIZE)\n> +/* Page size must be >= 512. */\n> +#define MLX5_DBR_BITMAP_SIZE (MLX5_DBR_PER_PAGE / (CHAR_BIT *\n> sizeof(uint64_t)))\n> \n>  struct mlx5_devx_dbr_page {\n>  \t/* Door-bell records, must be first member in structure. */\n> --\n> 1.8.3.1\n\nPatch applied to next-net-mlx,\n\nKindest regards,\nRaslan Darawsheh",
        "headers": {
            "Accept-Language": "en-US",
            "X-Mailman-Version": "2.1.15",
            "x-ms-oob-tlc-oobclassifiers": "OLM:457;",
            "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR05MB6468",
            "authentication-results": "mellanox.com; dkim=none (message not signed)\n header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com;",
            "x-ld-processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr",
            "Precedence": "list",
            "List-Post": "<mailto:dev@dpdk.org>",
            "x-ms-exchange-senderadcheck": "1",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "Subject": "Re: [dpdk-dev] [PATCH v2] common/mlx5: fix Rx/Tx queue doorbell\n\trecord size",
            "X-MS-Exchange-CrossTenant-AuthAs": "Internal",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "Delivered-To": "patchwork@inbox.dpdk.org",
            "Received": [
                "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5CC99A0526;\n\tWed, 22 Jul 2020 11:17:23 +0200 (CEST)",
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0F06A1BFBB;\n\tWed, 22 Jul 2020 11:17:22 +0200 (CEST)",
                "from EUR03-AM5-obe.outbound.protection.outlook.com\n (mail-eopbgr30085.outbound.protection.outlook.com [40.107.3.85])\n by dpdk.org (Postfix) with ESMTP id BC0541BE90;\n Wed, 22 Jul 2020 11:17:20 +0200 (CEST)",
                "from AM0PR05MB6707.eurprd05.prod.outlook.com (2603:10a6:20b:15b::17)\n by AM0PR05MB6468.eurprd05.prod.outlook.com (2603:10a6:208:139::10)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Wed, 22 Jul\n 2020 09:17:19 +0000",
                "from AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012]) by AM0PR05MB6707.eurprd05.prod.outlook.com\n ([fe80::ecd3:6008:3784:4012%5]) with mapi id 15.20.3195.028; Wed, 22 Jul 2020\n 09:17:19 +0000"
            ],
            "x-originating-ip": "[84.242.49.134]",
            "x-microsoft-antispam": "BCL:0;",
            "x-ms-exchange-transport-forked": "True",
            "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR05MB6707.eurprd05.prod.outlook.com",
            "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=WJYChS4gx4BGfX2xNrZcaUhCwf8e8zopAMqleH4j1Js=;\n b=IxsVL53TlQQt3/itpZfvbdDFrfLA1Ua6rDzzq3OccD5hIOFup1ePGvlohyNAHoG5QHzNEnJQCrxz0Fhil2C1dKAN0DzgV1qr/i0QELwDmeCbdfwEC0HyCmT8vHzoQpVr/nyNTIIOz7rj1+BEdl+Vx6Nv7H4CSiZnpr82KIoDzSKDOuMdKUEj4Z8nnISHAFKrMHRtBaXl3bXJX5dm0usoYRK3+Lx4X6MSuAfvWPTLDJ9zKn1melmgsEcyuUrFKl6JndZ8gi2mAmWAX9re1AxeFCIv8YqSQ9VgfvqSR0CCcASyp9KbY+dKl4EzwW5IHLSOYnDVP3s7oiuBLRftrfY85g==",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted",
            "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=WJYChS4gx4BGfX2xNrZcaUhCwf8e8zopAMqleH4j1Js=;\n b=smiwTOaWx4D4sfhLad5f1IXpLHr/mQ566a0L4d20FLgESDVHvfIASmiIF6h0AVszDcDJief+augPsa0o7Ur/7jU53Gqnhoi1SgsWK/0p20+T+7EzaQlYrRu+l6tT8kbTTepGzoZRaGjUkOvgEx4tgZ7vrvNtsnJoaEYfGb+4Cbo=",
            "Message-ID": "\n <AM0PR05MB6707F17FFB6B42A5B78EB735C2790@AM0PR05MB6707.eurprd05.prod.outlook.com>",
            "X-MS-Exchange-CrossTenant-userprincipalname": "\n DU9334SBe9614tF6rERKxSAljfZYdADXdg7zmre5vK1/Smnj+R5+kytdUhE+/YPd9lgYUxUA1Hw5uVIOegdB2Q==",
            "To": "Slava Ovsiienko <viacheslavo@mellanox.com>, \"dev@dpdk.org\" <dev@dpdk.org>",
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
            "From": "Raslan Darawsheh <rasland@mellanox.com>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "x-ms-publictraffictype": "Email",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none",
            "X-MS-TNEF-Correlator": "",
            "Thread-Index": "AQHWX0+zmF9OvwKUpEulZor6H6buDakTUa2w",
            "CC": "Matan Azrad <matan@mellanox.com>, Thomas Monjalon <thomas@monjalon.net>,\n Dekel Peled <dekelp@mellanox.com>, \"stable@dpdk.org\" <stable@dpdk.org>",
            "X-OriginatorOrg": "Mellanox.com",
            "X-MS-Exchange-CrossTenant-originalarrivaltime": "22 Jul 2020 09:17:19.4858 (UTC)",
            "Thread-Topic": "[PATCH v2] common/mlx5: fix Rx/Tx queue doorbell record size",
            "X-Original-To": "patchwork@inbox.dpdk.org",
            "x-microsoft-antispam-message-info": "\n i/wRoyiq5m60HdfhD4B8aurj8xCl3yW4CCjlvo2O8AQVZGaWjEISzddFxws7sP99sj2I8qUGYzDMAEIzsOMttNcbuLizAGrOOsC40m40Wx4K0IzmfGUYhaSRhlJTCIVOFqSlcmOX9Y6OI/zfQEap0uMeXCG4W0rw0BsQHEDp+gWRzwjRt7a8VzblJsDadmRK2i8iTrZcDIgEDtsSBxmy3X6Cnqyxgr1BTnZ4C+9ZnbuIDxm/lkBHbggUJ6j8u6poOKr68iIjnezoPQk80rlb7oGHewdYXBK0KPXhyoVVXVXElsJYw/IGkICPtpTBdAKbtlN/YgggqVFQvcb2vsGujw==",
            "x-ms-office365-filtering-ht": "Tenant",
            "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED",
            "MIME-Version": "1.0",
            "In-Reply-To": "<1595329889-31516-1-git-send-email-viacheslavo@mellanox.com>",
            "X-BeenThere": "dev@dpdk.org",
            "References": "<1595165997-12225-1-git-send-email-viacheslavo@mellanox.com>\n <1595329889-31516-1-git-send-email-viacheslavo@mellanox.com>",
            "Content-Type": "text/plain; charset=\"us-ascii\"",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b",
            "x-ms-office365-filtering-correlation-id": "0a99e43a-6a64-4b2b-5655-08d82e2008de",
            "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 0a99e43a-6a64-4b2b-5655-08d82e2008de",
            "Date": "Wed, 22 Jul 2020 09:17:19 +0000",
            "Content-Transfer-Encoding": "quoted-printable",
            "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB6707.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(39860400002)(366004)(136003)(346002)(376002)(396003)(53546011)(2906002)(5660300002)(33656002)(478600001)(110136005)(4326008)(186003)(316002)(6506007)(52536014)(55016002)(54906003)(9686003)(71200400001)(76116006)(26005)(64756008)(66446008)(8676002)(66556008)(7696005)(66946007)(83380400001)(8936002)(86362001)(66476007);\n DIR:OUT; SFP:1101;",
            "X-MS-Has-Attach": "",
            "x-ms-exchange-antispam-messagedata": "\n ih0RbGPoqH8q3hEVlfYRcYchm+ZPhkU4F/V0zqmpIJOmMCHecXUJGiDi/dA0MBG9jF0kn8HTKZPXn+9bx0QPCuiQpe0SwF66wzRRF4JR93Pm58IqcG5wFZbGT9MlLJx8oyE/FnPYLsADM4vPghigodaRj19eLFEv5RnbzH7lxsPczZlJdFp4rAM/YnvIhMzFCAPZJL0zUiRaEgY9v+8r4MlSUJOHsesf4+0P4q2H2YIQFOtSbz57DfU/przT0PYfYCdqDc5fXi8yasUl2GGPtabY6mEQpkednQbXJDubvKJGK2lN1Y6XmBAC9bn8x8NofWFOwNTZ87rVGn3K+DobQokDlTFoAQ7b993kGuIr1R6SsXwi3mSPCyEGIcxXtzL7rCREyDpVlnCjiWQG03pgcjLc7XMH/MknPm9oLpFgfTi2bM4Rz05ni9+DfKqvreOXR392Kvsgw2NKdDk4N3LG4s8mnCvsOSp1w+DnW/IrlFK/9xSKjnoxxJyp+Xkpvxcp",
            "x-ms-traffictypediagnostic": "AM0PR05MB6468:",
            "Content-Language": "en-US",
            "Errors-To": "dev-bounces@dpdk.org",
            "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=ijTQXcbzgr1+csy+S4rZcVBBxGK/skId0A3AHdl403jrUdN8M4RyWOqxK+VHDHHEoDV17dBr1C2PfFO1JhLKF16pRVBKGdiLmu8LaIMQMmeB3WP6S6fUgte3cPqBoZVfYfm/yizUG9R/PCDVvb9S6wzawFuf9O81WlOBqMbjVf9TuedhPlmlOkm8ixhWXXIMeXC4H7ffEIQBWZ61ACoTJr1ejhlcKc+mkkS3+yoLHswu6jx9SVOwULGPxaGfnJKxZ95vUAcfmdK5Fk1ABQN6qtA42S/MCIwnccs8Fd8fUT8oKXFfYCe00pezYxbosZ2ytwp7X5k+8+4P+g5lfPDTJA==",
            "x-microsoft-antispam-prvs": "\n <AM0PR05MB6468AE16CF7B5673DD2AFE4EC2790@AM0PR05MB6468.eurprd05.prod.outlook.com>"
        }
    }
]