Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74559/?format=api
{ "id": 74559, "url": "https://patches.dpdk.org/api/patches/74559/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200721095140.719297-21-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200721095140.719297-21-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200721095140.719297-21-bruce.richardson@intel.com", "date": "2020-07-21T09:51:40", "name": "[20.11,20/20] raw/ioat: clean up use of common test function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1b377a7e53713f7707195d2184af979d19168d5d", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200721095140.719297-21-bruce.richardson@intel.com/mbox/", "series": [ { "id": 11200, "url": "https://patches.dpdk.org/api/series/11200/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11200", "date": "2020-07-21T09:51:20", "name": "raw/ioat: enhancements and new hardware support", "version": 1, "mbox": "https://patches.dpdk.org/series/11200/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/74559/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/74559/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3B8F6A0526;\n\tTue, 21 Jul 2020 11:57:54 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6138F1C0DB;\n\tTue, 21 Jul 2020 11:56:31 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id D15561C0CC\n for <dev@dpdk.org>; Tue, 21 Jul 2020 11:56:28 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jul 2020 02:56:28 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.36])\n by fmsmga005.fm.intel.com with ESMTP; 21 Jul 2020 02:56:26 -0700" ], "IronPort-SDR": [ "\n He7l/yhF76amX28Mu1B47+sTyIHQtlxgTQHVZLa7adxU0w/9e6JnnUdi90n28+FlRnb0Imf+9w\n +IsXhhiTuLIA==", "\n xuH9gWtzOJ0vhiB3STLmCFEBj+pEqjf75J8xYQ83BdgpwDBaTns1T8+bFpLe3rN1P80WC81qAd\n BW0SYfnB9l6w==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9688\"; a=\"138191475\"", "E=Sophos;i=\"5.75,378,1589266800\"; d=\"scan'208\";a=\"138191475\"", "E=Sophos;i=\"5.75,378,1589266800\"; d=\"scan'208\";a=\"488024552\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "cheng1.jiang@intel.com, patrick.fu@intel.com, kevin.laatz@intel.com,\n Bruce Richardson <bruce.richardson@intel.com>", "Date": "Tue, 21 Jul 2020 10:51:40 +0100", "Message-Id": "<20200721095140.719297-21-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200721095140.719297-1-bruce.richardson@intel.com>", "References": "<20200721095140.719297-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 20.11 20/20] raw/ioat: clean up use of common\n\ttest function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Now that all devices can pass the same set of unit tests, elminate the\ntemporary idxd_rawdev_test function and move the prototype for\nioat_rawdev_test to the proper internal header file, to be used by all\ndevice instances.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/raw/ioat/idxd_pci.c | 2 +-\n drivers/raw/ioat/idxd_vdev.c | 2 +-\n drivers/raw/ioat/ioat_private.h | 4 ++--\n drivers/raw/ioat/ioat_rawdev.c | 2 --\n drivers/raw/ioat/ioat_rawdev_test.c | 7 -------\n 5 files changed, 4 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/raw/ioat/idxd_pci.c b/drivers/raw/ioat/idxd_pci.c\nindex a426897b2..d5e87d2e4 100644\n--- a/drivers/raw/ioat/idxd_pci.c\n+++ b/drivers/raw/ioat/idxd_pci.c\n@@ -102,7 +102,7 @@ idxd_pci_dev_start(struct rte_rawdev *dev)\n }\n \n static const struct rte_rawdev_ops idxd_pci_ops = {\n-\t\t.dev_selftest = idxd_rawdev_test,\n+\t\t.dev_selftest = ioat_rawdev_test,\n \t\t.dump = idxd_dev_dump,\n \t\t.dev_configure = idxd_dev_configure,\n \t\t.dev_start = idxd_pci_dev_start,\ndiff --git a/drivers/raw/ioat/idxd_vdev.c b/drivers/raw/ioat/idxd_vdev.c\nindex aa2693368..7c3c791ce 100644\n--- a/drivers/raw/ioat/idxd_vdev.c\n+++ b/drivers/raw/ioat/idxd_vdev.c\n@@ -81,7 +81,7 @@ idxd_vdev_start(struct rte_rawdev *dev)\n }\n \n static const struct rte_rawdev_ops idxd_vdev_ops = {\n-\t\t.dev_selftest = idxd_rawdev_test,\n+\t\t.dev_selftest = ioat_rawdev_test,\n \t\t.dump = idxd_dev_dump,\n \t\t.dev_configure = idxd_dev_configure,\n \t\t.dev_start = idxd_vdev_start,\ndiff --git a/drivers/raw/ioat/ioat_private.h b/drivers/raw/ioat/ioat_private.h\nindex 46465e675..0c626e6bf 100644\n--- a/drivers/raw/ioat/ioat_private.h\n+++ b/drivers/raw/ioat/ioat_private.h\n@@ -65,6 +65,8 @@ int ioat_xstats_get_names(const struct rte_rawdev *dev,\n int ioat_xstats_reset(struct rte_rawdev *dev, const uint32_t *ids,\n \t\tuint32_t nb_ids);\n \n+extern int ioat_rawdev_test(uint16_t dev_id);\n+\n extern int idxd_rawdev_create(const char *name, struct rte_device *dev,\n \t\t const struct idxd_rawdev *idxd,\n \t\t const struct rte_rawdev_ops *ops);\n@@ -75,8 +77,6 @@ extern int idxd_dev_configure(const struct rte_rawdev *dev,\n extern int idxd_dev_info_get(struct rte_rawdev *dev, rte_rawdev_obj_t dev_info,\n \t\tsize_t info_size);\n \n-extern int idxd_rawdev_test(uint16_t dev_id);\n-\n extern int idxd_dev_dump(struct rte_rawdev *dev, FILE *f);\n \n #endif /* _IOAT_PRIVATE_H_ */\ndiff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawdev.c\nindex e3c98a825..1b6a58073 100644\n--- a/drivers/raw/ioat/ioat_rawdev.c\n+++ b/drivers/raw/ioat/ioat_rawdev.c\n@@ -121,8 +121,6 @@ ioat_dev_info_get(struct rte_rawdev *dev, rte_rawdev_obj_t dev_info,\n \treturn 0;\n }\n \n-extern int ioat_rawdev_test(uint16_t dev_id);\n-\n static int\n ioat_rawdev_create(const char *name, struct rte_pci_device *dev)\n {\ndiff --git a/drivers/raw/ioat/ioat_rawdev_test.c b/drivers/raw/ioat/ioat_rawdev_test.c\nindex 678d135c4..626299525 100644\n--- a/drivers/raw/ioat/ioat_rawdev_test.c\n+++ b/drivers/raw/ioat/ioat_rawdev_test.c\n@@ -253,10 +253,3 @@ ioat_rawdev_test(uint16_t dev_id)\n \tfree(ids);\n \treturn -1;\n }\n-\n-int\n-idxd_rawdev_test(uint16_t dev_id)\n-{\n-\trte_rawdev_dump(dev_id, stdout);\n-\treturn ioat_rawdev_test(dev_id);\n-}\n", "prefixes": [ "20.11", "20/20" ] }