Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74552/?format=api
{ "id": 74552, "url": "https://patches.dpdk.org/api/patches/74552/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200721095140.719297-14-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200721095140.719297-14-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200721095140.719297-14-bruce.richardson@intel.com", "date": "2020-07-21T09:51:33", "name": "[20.11,13/20] raw/ioat: add configure function for idxd devices", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "12bf961844bfed96c7274ce75f35cf167d7f29de", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200721095140.719297-14-bruce.richardson@intel.com/mbox/", "series": [ { "id": 11200, "url": "https://patches.dpdk.org/api/series/11200/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11200", "date": "2020-07-21T09:51:20", "name": "raw/ioat: enhancements and new hardware support", "version": 1, "mbox": "https://patches.dpdk.org/series/11200/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/74552/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/74552/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5D784A0526;\n\tTue, 21 Jul 2020 11:56:37 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 131DB1C06C;\n\tTue, 21 Jul 2020 11:56:14 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id DAA611C02A\n for <dev@dpdk.org>; Tue, 21 Jul 2020 11:56:10 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jul 2020 02:56:10 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.36])\n by fmsmga005.fm.intel.com with ESMTP; 21 Jul 2020 02:56:09 -0700" ], "IronPort-SDR": [ "\n Eb1wQDJ8cnzdfR/00AiBJh6FtMKdU8gwpeEbsdDyQf+hntsyCqt+3dLFoPZ8mKeAgkEgouQihT\n L4oCFb3N3Mnw==", "\n Eu3VvohGhybdZ/dW/SOOEpHQxfppyQOXLySzTOiCvR6zj9nnFCrY5yeGleoY5+XvEDEEpy8lpq\n gIQNaAzx9LCA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9688\"; a=\"138191447\"", "E=Sophos;i=\"5.75,378,1589266800\"; d=\"scan'208\";a=\"138191447\"", "E=Sophos;i=\"5.75,378,1589266800\"; d=\"scan'208\";a=\"488024453\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "cheng1.jiang@intel.com, patrick.fu@intel.com, kevin.laatz@intel.com,\n Bruce Richardson <bruce.richardson@intel.com>", "Date": "Tue, 21 Jul 2020 10:51:33 +0100", "Message-Id": "<20200721095140.719297-14-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200721095140.719297-1-bruce.richardson@intel.com>", "References": "<20200721095140.719297-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 20.11 13/20] raw/ioat: add configure function for\n\tidxd devices", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add configure function for idxd devices, taking the same parameters as the\nexisting configure function for ioat. The ring_size parameter is used to\ncompute the maximum number of bursts to be supported by the driver, given\nthat the hardware works on individual bursts of descriptors at a time.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/raw/ioat/idxd_pci.c | 1 +\n drivers/raw/ioat/idxd_vdev.c | 1 +\n drivers/raw/ioat/ioat_common.c | 61 ++++++++++++++++++++++++++\n drivers/raw/ioat/ioat_private.h | 3 ++\n drivers/raw/ioat/rte_ioat_rawdev_fns.h | 1 +\n 5 files changed, 67 insertions(+)", "diff": "diff --git a/drivers/raw/ioat/idxd_pci.c b/drivers/raw/ioat/idxd_pci.c\nindex 78c443703..762efd5ac 100644\n--- a/drivers/raw/ioat/idxd_pci.c\n+++ b/drivers/raw/ioat/idxd_pci.c\n@@ -54,6 +54,7 @@ idxd_is_wq_enabled(struct idxd_rawdev *idxd)\n static const struct rte_rawdev_ops idxd_pci_ops = {\n \t\t.dev_selftest = idxd_rawdev_test,\n \t\t.dump = idxd_dev_dump,\n+\t\t.dev_configure = idxd_dev_configure,\n };\n \n /* each portal uses 4 x 4k pages */\ndiff --git a/drivers/raw/ioat/idxd_vdev.c b/drivers/raw/ioat/idxd_vdev.c\nindex 2b8122cbc..90ad11006 100644\n--- a/drivers/raw/ioat/idxd_vdev.c\n+++ b/drivers/raw/ioat/idxd_vdev.c\n@@ -35,6 +35,7 @@ struct idxd_vdev_args {\n static const struct rte_rawdev_ops idxd_vdev_ops = {\n \t\t.dev_selftest = idxd_rawdev_test,\n \t\t.dump = idxd_dev_dump,\n+\t\t.dev_configure = idxd_dev_configure,\n };\n \n static void *\ndiff --git a/drivers/raw/ioat/ioat_common.c b/drivers/raw/ioat/ioat_common.c\nindex 3dda4ab8e..699661e27 100644\n--- a/drivers/raw/ioat/ioat_common.c\n+++ b/drivers/raw/ioat/ioat_common.c\n@@ -37,6 +37,67 @@ idxd_dev_dump(struct rte_rawdev *dev, FILE *f)\n \treturn 0;\n }\n \n+int\n+idxd_dev_configure(const struct rte_rawdev *dev,\n+\t\trte_rawdev_obj_t config, size_t config_size)\n+{\n+\tstruct idxd_rawdev *idxd = dev->dev_private;\n+\tstruct rte_idxd_rawdev *rte_idxd = &idxd->public;\n+\tstruct rte_ioat_rawdev_config *cfg = config;\n+\tuint16_t max_desc = cfg->ring_size;\n+\tuint16_t max_batches = max_desc / BATCH_SIZE;\n+\tuint16_t i;\n+\n+\tif (config_size != sizeof(*cfg))\n+\t\treturn -EINVAL;\n+\n+\tif (dev->started) {\n+\t\tIOAT_PMD_ERR(\"%s: Error, device is started.\", __func__);\n+\t\treturn -EAGAIN;\n+\t}\n+\n+\trte_idxd->hdls_disable = cfg->hdls_disable;\n+\n+\t/* limit the batches to what can be stored in hardware */\n+\tif (max_batches > idxd->max_batches) {\n+\t\tIOAT_PMD_DEBUG(\"Ring size of %u is too large for this device, need to limit to %u batches of %u\",\n+\t\t\t\tmax_desc, idxd->max_batches, BATCH_SIZE);\n+\t\tmax_batches = idxd->max_batches;\n+\t\tmax_desc = max_batches * BATCH_SIZE;\n+\t}\n+\tif (!rte_is_power_of_2(max_desc))\n+\t\tmax_desc = rte_align32pow2(max_desc);\n+\tIOAT_PMD_DEBUG(\"Rawdev %u using %u descriptors in %u batches\",\n+\t\t\tdev->dev_id, max_desc, max_batches);\n+\n+\t/* TODO clean up if reconfiguring an existing device */\n+\trte_idxd->batch_ring = rte_zmalloc(NULL,\n+\t\t\tsizeof(*rte_idxd->batch_ring) * max_batches, 0);\n+\tif (rte_idxd->batch_ring == NULL)\n+\t\treturn -ENOMEM;\n+\n+\trte_idxd->hdl_ring = rte_zmalloc(NULL,\n+\t\t\tsizeof(*rte_idxd->hdl_ring) * max_desc, 0);\n+\tif (rte_idxd->hdl_ring == NULL) {\n+\t\trte_free(rte_idxd->batch_ring);\n+\t\trte_idxd->batch_ring = NULL;\n+\t\treturn -ENOMEM;\n+\t}\n+\trte_idxd->batch_ring_sz = max_batches;\n+\trte_idxd->hdl_ring_sz = max_desc;\n+\n+\tfor (i = 0; i < rte_idxd->batch_ring_sz; i++) {\n+\t\tstruct rte_idxd_desc_batch *b = &rte_idxd->batch_ring[i];\n+\t\tb->batch_desc.completion = rte_mem_virt2iova(&b->comp);\n+\t\tb->batch_desc.desc_addr = rte_mem_virt2iova(&b->null_desc);\n+\t\tb->batch_desc.op_flags = (idxd_op_batch << IDXD_CMD_OP_SHIFT) |\n+\t\t\t\tIDXD_FLAG_COMPLETION_ADDR_VALID |\n+\t\t\t\tIDXD_FLAG_REQUEST_COMPLETION;\n+\t}\n+\n+\treturn 0;\n+}\n+\n int\n idxd_rawdev_create(const char *name, struct rte_device *dev,\n \t\t const struct idxd_rawdev *base_idxd,\ndiff --git a/drivers/raw/ioat/ioat_private.h b/drivers/raw/ioat/ioat_private.h\nindex a873f3f2c..91ded444b 100644\n--- a/drivers/raw/ioat/ioat_private.h\n+++ b/drivers/raw/ioat/ioat_private.h\n@@ -59,6 +59,9 @@ extern int idxd_rawdev_create(const char *name, struct rte_device *dev,\n \t\t const struct idxd_rawdev *idxd,\n \t\t const struct rte_rawdev_ops *ops);\n \n+extern int idxd_dev_configure(const struct rte_rawdev *dev,\n+\t\trte_rawdev_obj_t config, size_t config_size);\n+\n extern int idxd_rawdev_test(uint16_t dev_id);\n \n extern int idxd_dev_dump(struct rte_rawdev *dev, FILE *f);\ndiff --git a/drivers/raw/ioat/rte_ioat_rawdev_fns.h b/drivers/raw/ioat/rte_ioat_rawdev_fns.h\nindex abd90514b..7090ac0a1 100644\n--- a/drivers/raw/ioat/rte_ioat_rawdev_fns.h\n+++ b/drivers/raw/ioat/rte_ioat_rawdev_fns.h\n@@ -185,6 +185,7 @@ struct rte_idxd_rawdev {\n \tuint16_t next_ret_hdl; /* the next user hdl to return */\n \tuint16_t last_completed_hdl; /* the last user hdl that has completed */\n \tuint16_t next_free_hdl; /* where the handle for next op will go */\n+\tuint16_t hdls_disable; /* disable tracking completion handles */\n \n \tstruct rte_idxd_user_hdl *hdl_ring;\n \tstruct rte_idxd_desc_batch *batch_ring;\n", "prefixes": [ "20.11", "13/20" ] }