Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74541/?format=api
{ "id": 74541, "url": "https://patches.dpdk.org/api/patches/74541/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200721095140.719297-3-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200721095140.719297-3-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200721095140.719297-3-bruce.richardson@intel.com", "date": "2020-07-21T09:51:22", "name": "[20.11,02/20] raw/ioat: support multiple devices being tested", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b70e92cd84f758883600397312792eaf19db39b5", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200721095140.719297-3-bruce.richardson@intel.com/mbox/", "series": [ { "id": 11200, "url": "https://patches.dpdk.org/api/series/11200/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11200", "date": "2020-07-21T09:51:20", "name": "raw/ioat: enhancements and new hardware support", "version": 1, "mbox": "https://patches.dpdk.org/series/11200/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/74541/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/74541/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C3C4AA0526;\n\tTue, 21 Jul 2020 11:52:14 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 96B631C00F;\n\tTue, 21 Jul 2020 11:52:10 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by dpdk.org (Postfix) with ESMTP id 8115D1C00D\n for <dev@dpdk.org>; Tue, 21 Jul 2020 11:52:08 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jul 2020 02:52:08 -0700", "from silpixa00399126.ir.intel.com ([10.237.222.36])\n by fmsmga005.fm.intel.com with ESMTP; 21 Jul 2020 02:52:06 -0700" ], "IronPort-SDR": [ "\n 0DIMkA+2KgVEEJNUErXURGyjv1PhFNqKsy+LcvxNZifRPTOVn5gPvoG+p01MiV3HGm64yHyGCH\n VXDGPqONrY0w==", "\n KSlq8q+9oU2tXpCWdT7hTmTSE24U+SeaMl7ObZskICErjL6lBARMUGSCI1T5jcYHGHtRkmiwrU\n 9ZHj0LlBd8ag==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9688\"; a=\"234952340\"", "E=Sophos;i=\"5.75,378,1589266800\"; d=\"scan'208\";a=\"234952340\"", "E=Sophos;i=\"5.75,378,1589266800\"; d=\"scan'208\";a=\"488023648\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "cheng1.jiang@intel.com, patrick.fu@intel.com, kevin.laatz@intel.com,\n Bruce Richardson <bruce.richardson@intel.com>", "Date": "Tue, 21 Jul 2020 10:51:22 +0100", "Message-Id": "<20200721095140.719297-3-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200721095140.719297-1-bruce.richardson@intel.com>", "References": "<20200721095140.719297-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 20.11 02/20] raw/ioat: support multiple devices\n\tbeing tested", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The current selftest function uses a single global variable to track state\nwhich implies that only a single instance can have the selftest function\ncalled on it. Change this to an array to allow multiple instances to be\ntested.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/raw/ioat/ioat_rawdev_test.c | 17 +++++++++++++----\n 1 file changed, 13 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/raw/ioat/ioat_rawdev_test.c b/drivers/raw/ioat/ioat_rawdev_test.c\nindex c463a82ad..e5b50ae9f 100644\n--- a/drivers/raw/ioat/ioat_rawdev_test.c\n+++ b/drivers/raw/ioat/ioat_rawdev_test.c\n@@ -8,10 +8,13 @@\n #include \"rte_rawdev.h\"\n #include \"rte_ioat_rawdev.h\"\n \n+#define MAX_SUPPORTED_RAWDEVS 64\n+#define TEST_SKIPPED 77\n+\n int ioat_rawdev_test(uint16_t dev_id); /* pre-define to keep compiler happy */\n \n static struct rte_mempool *pool;\n-static unsigned short expected_ring_size;\n+static unsigned short expected_ring_size[MAX_SUPPORTED_RAWDEVS];\n \n static int\n test_enqueue_copies(int dev_id)\n@@ -148,10 +151,16 @@ ioat_rawdev_test(uint16_t dev_id)\n \tunsigned int nb_xstats;\n \tunsigned int i;\n \n+\tif (dev_id >= MAX_SUPPORTED_RAWDEVS) {\n+\t\tprintf(\"Skipping test. Cannot test rawdevs with id's greater than %d\\n\",\n+\t\t\t\tMAX_SUPPORTED_RAWDEVS);\n+\t\treturn TEST_SKIPPED;\n+\t}\n+\n \trte_rawdev_info_get(dev_id, &info, sizeof(p));\n-\tif (p.ring_size != expected_ring_size) {\n+\tif (p.ring_size != expected_ring_size[dev_id]) {\n \t\tprintf(\"Error, initial ring size is not as expected (Actual: %d, Expected: %d)\\n\",\n-\t\t\t\t(int)p.ring_size, expected_ring_size);\n+\t\t\t\t(int)p.ring_size, expected_ring_size[dev_id]);\n \t\treturn -1;\n \t}\n \n@@ -166,7 +175,7 @@ ioat_rawdev_test(uint16_t dev_id)\n \t\t\t\tIOAT_TEST_RINGSIZE, (int)p.ring_size);\n \t\treturn -1;\n \t}\n-\texpected_ring_size = p.ring_size;\n+\texpected_ring_size[dev_id] = p.ring_size;\n \n \tif (rte_rawdev_start(dev_id) != 0) {\n \t\tprintf(\"Error with rte_rawdev_start()\\n\");\n", "prefixes": [ "20.11", "02/20" ] }