Patch Comment List
List patch comments
GET /api/patches/74538/comments/?format=api
[ { "id": 116467, "web_url": "https://patches.dpdk.org/comment/116467/", "msgid": "<039ED4275CED7440929022BC67E7061154863E56@SHSMSX103.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/039ED4275CED7440929022BC67E7061154863E56@SHSMSX103.ccr.corp.intel.com", "date": "2020-07-22T05:25:46", "subject": "Re: [dpdk-dev] [PATCH] net/ice: fix default RSS key configuration", "submitter": { "id": 504, "url": "https://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "content": "> -----Original Message-----\n> From: Wang, Xiao W <xiao.w.wang@intel.com>\n> Sent: Tuesday, July 21, 2020 5:03 PM\n> To: Zhang, Qi Z <qi.z.zhang@intel.com>\n> Cc: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Yao, Lei A\n> <lei.a.yao@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Wang, Xiao W\n> <xiao.w.wang@intel.com>; stable@dpdk.org\n> Subject: [PATCH] net/ice: fix default RSS key configuration\n> \n> There's chance that rte_rand() doesn't provision suitable values for RSS hash, an\n> extreme example could be a key with a lot of 0s in it.\n> \n> This patch adds a default RSS key which has been used in ixgbe driver and fm10k\n> driver.\n> \n> Fixes: 50370662b727 (\"net/ice: support device and queue ops\")\n> Cc: stable@dpdk.org\n> \n> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>\n\nAcked-by: Qi Zhang <qi.z.zhang@intel.com>\n\nApplied to dpdk-next-net-intel.\n\nThanks\nQi", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 904C9A0526;\n\tWed, 22 Jul 2020 07:25:57 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 198BA1BFE4;\n\tWed, 22 Jul 2020 07:25:56 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by dpdk.org (Postfix) with ESMTP id 7FEEB1BFBB;\n Wed, 22 Jul 2020 07:25:54 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jul 2020 22:25:53 -0700", "from fmsmsx108.amr.corp.intel.com ([10.18.124.206])\n by orsmga005.jf.intel.com with ESMTP; 21 Jul 2020 22:25:53 -0700", "from fmsmsx154.amr.corp.intel.com (10.18.116.70) by\n FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Tue, 21 Jul 2020 22:25:52 -0700", "from shsmsx102.ccr.corp.intel.com (10.239.4.154) by\n FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Tue, 21 Jul 2020 22:25:52 -0700", "from shsmsx103.ccr.corp.intel.com ([169.254.4.22]) by\n shsmsx102.ccr.corp.intel.com ([169.254.2.43]) with mapi id 14.03.0439.000;\n Wed, 22 Jul 2020 13:25:46 +0800" ], "IronPort-SDR": [ "\n xaZMTtVQ/9IaeF6U9cFVxeD31bWVVTFGb4eaMzHlkDzu7i3DydppIC9VIFT90ueqXfnGzy5r7D\n jE82Pv+TCf1w==", "\n sg+pPsdUBBL7V5tS0Qgb5XyBtCwZABD/hCTYOp2gXPJjNQo7KqoLG3+cZgV06s5NTcQSi7HA5y\n 8VzX+njnjOUA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9689\"; a=\"149438774\"", "E=Sophos;i=\"5.75,381,1589266800\"; d=\"scan'208\";a=\"149438774\"", "E=Sophos;i=\"5.75,381,1589266800\"; d=\"scan'208\";a=\"462334362\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "\"Zhang, Qi Z\" <qi.z.zhang@intel.com>", "To": "\"Wang, Xiao W\" <xiao.w.wang@intel.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, \"Yang, Qiming\" <qiming.yang@intel.com>,\n \"Yao, Lei A\" <lei.a.yao@intel.com>, \"Wu, Jingjing\" <jingjing.wu@intel.com>,\n \"stable@dpdk.org\" <stable@dpdk.org>", "Thread-Topic": "[PATCH] net/ice: fix default RSS key configuration", "Thread-Index": "AQHWXz67Bt3NSbuAn0WM6QcBqBhv0KkTEnwA", "Date": "Wed, 22 Jul 2020 05:25:46 +0000", "Message-ID": "\n <039ED4275CED7440929022BC67E7061154863E56@SHSMSX103.ccr.corp.intel.com>", "References": "<20200721090258.65715-1-xiao.w.wang@intel.com>", "In-Reply-To": "<20200721090258.65715-1-xiao.w.wang@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "dlp-product": "dlpe-windows", "dlp-version": "11.2.0.6", "dlp-reaction": "no-action", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH] net/ice: fix default RSS key configuration", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116540, "web_url": "https://patches.dpdk.org/comment/116540/", "msgid": "<039ED4275CED7440929022BC67E7061154864D3C@SHSMSX103.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/039ED4275CED7440929022BC67E7061154864D3C@SHSMSX103.ccr.corp.intel.com", "date": "2020-07-23T10:25:35", "subject": "Re: [dpdk-dev] [PATCH] net/ice: fix default RSS key configuration", "submitter": { "id": 504, "url": "https://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "content": "> -----Original Message-----\n> From: Zhang, Qi Z\n> Sent: Wednesday, July 22, 2020 1:26 PM\n> To: Wang, Xiao W <xiao.w.wang@intel.com>\n> Cc: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Yao, Lei A\n> <lei.a.yao@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; stable@dpdk.org\n> Subject: RE: [PATCH] net/ice: fix default RSS key configuration\n> \n> \n> \n> > -----Original Message-----\n> > From: Wang, Xiao W <xiao.w.wang@intel.com>\n> > Sent: Tuesday, July 21, 2020 5:03 PM\n> > To: Zhang, Qi Z <qi.z.zhang@intel.com>\n> > Cc: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Yao, Lei A\n> > <lei.a.yao@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Wang,\n> > Xiao W <xiao.w.wang@intel.com>; stable@dpdk.org\n> > Subject: [PATCH] net/ice: fix default RSS key configuration\n> >\n> > There's chance that rte_rand() doesn't provision suitable values for\n> > RSS hash, an extreme example could be a key with a lot of 0s in it.\n> >\n> > This patch adds a default RSS key which has been used in ixgbe driver\n> > and fm10k driver.\n> >\n> > Fixes: 50370662b727 (\"net/ice: support device and queue ops\")\n> > Cc: stable@dpdk.org\n> >\n> > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>\n> \n> Acked-by: Qi Zhang <qi.z.zhang@intel.com>\n> \n> Applied to dpdk-next-net-intel.\n\nAfter some internal discussion, we decide to keep the random key as default, and user can use rte_eth_dev_rss_hash_update to update a new key.\nSo the patch has been removed from dpdk-next-net-intel.\n\n\n> \n> Thanks\n> Qi", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ADBE4A0521;\n\tThu, 23 Jul 2020 12:25:43 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4F35D1BE9A;\n\tThu, 23 Jul 2020 12:25:42 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by dpdk.org (Postfix) with ESMTP id 277B42C01;\n Thu, 23 Jul 2020 12:25:40 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Jul 2020 03:25:39 -0700", "from fmsmsx103.amr.corp.intel.com ([10.18.124.201])\n by fmsmga004.fm.intel.com with ESMTP; 23 Jul 2020 03:25:39 -0700", "from fmsmsx607.amr.corp.intel.com (10.18.126.87) by\n FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Thu, 23 Jul 2020 03:25:38 -0700", "from fmsmsx607.amr.corp.intel.com (10.18.126.87) by\n fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.1713.5; Thu, 23 Jul 2020 03:25:38 -0700", "from shsmsx104.ccr.corp.intel.com (10.239.4.70) by\n fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5\n via Frontend Transport; Thu, 23 Jul 2020 03:25:38 -0700", "from shsmsx103.ccr.corp.intel.com ([169.254.4.22]) by\n SHSMSX104.ccr.corp.intel.com ([169.254.5.135]) with mapi id 14.03.0439.000;\n Thu, 23 Jul 2020 18:25:35 +0800" ], "IronPort-SDR": [ "\n BiXTRhjHAlK1glRrBHiAl4GplK1YUHzfb7pcEF0gQeBs9OokMXYaMzRU4/3WQTghZgT2AtdOLR\n UADDCdZjecKw==", "\n 43Etm/X2qJMk9tTVaZbQkJMjBdGhxrg9EQfaqO5qwQNPGqxa7k3zNnz9NNLeCCxwnowPuo/KxF\n dRxADyNAZucA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9690\"; a=\"235366069\"", "E=Sophos;i=\"5.75,386,1589266800\"; d=\"scan'208\";a=\"235366069\"", "E=Sophos;i=\"5.75,386,1589266800\"; d=\"scan'208\";a=\"310977328\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "\"Zhang, Qi Z\" <qi.z.zhang@intel.com>", "To": "\"Wang, Xiao W\" <xiao.w.wang@intel.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, \"Yang, Qiming\" <qiming.yang@intel.com>,\n \"Yao, Lei A\" <lei.a.yao@intel.com>, \"Wu, Jingjing\" <jingjing.wu@intel.com>,\n \"stable@dpdk.org\" <stable@dpdk.org>", "Thread-Topic": "[PATCH] net/ice: fix default RSS key configuration", "Thread-Index": "AQHWXz67Bt3NSbuAn0WM6QcBqBhv0KkTEnwAgAHlp/A=", "Date": "Thu, 23 Jul 2020 10:25:35 +0000", "Message-ID": "\n <039ED4275CED7440929022BC67E7061154864D3C@SHSMSX103.ccr.corp.intel.com>", "References": "<20200721090258.65715-1-xiao.w.wang@intel.com>\n <039ED4275CED7440929022BC67E7061154863E56@SHSMSX103.ccr.corp.intel.com>", "In-Reply-To": "\n <039ED4275CED7440929022BC67E7061154863E56@SHSMSX103.ccr.corp.intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "dlp-product": "dlpe-windows", "dlp-version": "11.2.0.6", "dlp-reaction": "no-action", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH] net/ice: fix default RSS key configuration", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]