Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74538/?format=api
{ "id": 74538, "url": "https://patches.dpdk.org/api/patches/74538/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200721090258.65715-1-xiao.w.wang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200721090258.65715-1-xiao.w.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200721090258.65715-1-xiao.w.wang@intel.com", "date": "2020-07-21T09:02:58", "name": "net/ice: fix default RSS key configuration", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "517c96b1f3bb7f3964fc59a74e3c36b19f083aa1", "submitter": { "id": 281, "url": "https://patches.dpdk.org/api/people/281/?format=api", "name": "Xiao Wang", "email": "xiao.w.wang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200721090258.65715-1-xiao.w.wang@intel.com/mbox/", "series": [ { "id": 11199, "url": "https://patches.dpdk.org/api/series/11199/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11199", "date": "2020-07-21T09:02:58", "name": "net/ice: fix default RSS key configuration", "version": 1, "mbox": "https://patches.dpdk.org/series/11199/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/74538/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/74538/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 40F62A0526;\n\tTue, 21 Jul 2020 11:10:06 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C3C401BFE9;\n\tTue, 21 Jul 2020 11:10:05 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by dpdk.org (Postfix) with ESMTP id 42D8E1BFE4;\n Tue, 21 Jul 2020 11:10:03 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jul 2020 02:10:02 -0700", "from dpdk-xiao1.sh.intel.com ([10.67.110.193])\n by orsmga003.jf.intel.com with ESMTP; 21 Jul 2020 02:10:00 -0700" ], "IronPort-SDR": [ "\n k/oVSEsGut77t53hvNuv0PHmznjxfxprqvQVAj7d1+CmE1pekj5wdBOn6zXFz+Wglk8nkQTNzh\n SMoE+/uAC3xg==", "\n MNUSCBQXIyeGIMlVJL6JJmAEWuO90dJL+pQzm/F+4g4YwXLEnQFAMYsm9nHzaJ1B+ujJXhqu1B\n P0Tz/RaI7dKg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9688\"; a=\"149246381\"", "E=Sophos;i=\"5.75,378,1589266800\"; d=\"scan'208\";a=\"149246381\"", "E=Sophos;i=\"5.75,378,1589266800\"; d=\"scan'208\";a=\"283801432\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Xiao Wang <xiao.w.wang@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org, qiming.yang@intel.com, lei.a.yao@intel.com,\n jingjing.wu@intel.com, Xiao Wang <xiao.w.wang@intel.com>, stable@dpdk.org", "Date": "Tue, 21 Jul 2020 17:02:58 +0800", "Message-Id": "<20200721090258.65715-1-xiao.w.wang@intel.com>", "X-Mailer": "git-send-email 2.15.1", "Subject": "[dpdk-dev] [PATCH] net/ice: fix default RSS key configuration", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There's chance that rte_rand() doesn't provision suitable values for\nRSS hash, an extreme example could be a key with a lot of 0s in it.\n\nThis patch adds a default RSS key which has been used in ixgbe driver\nand fm10k driver.\n\nFixes: 50370662b727 (\"net/ice: support device and queue ops\")\nCc: stable@dpdk.org\n\nSigned-off-by: Xiao Wang <xiao.w.wang@intel.com>\n---\n drivers/net/ice/ice_ethdev.c | 11 ++++++++++-\n 1 file changed, 10 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 3534d18..74d37c7 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -2628,11 +2628,20 @@ static int ice_init_rss(struct ice_pf *pf)\n \t\tvsi->rss_lut = rte_zmalloc(NULL,\n \t\t\t\t\t vsi->rss_lut_size, 0);\n \n+#define RSS_KEY_SIZE ICE_AQC_GET_SET_RSS_KEY_DATA_RSS_KEY_SIZE\n+\tstatic uint8_t rss_intel_key[RSS_KEY_SIZE] = {\n+\t\t0x6D, 0x5A, 0x56, 0xDA, 0x25, 0x5B, 0x0E, 0xC2,\n+\t\t0x41, 0x67, 0x25, 0x3D, 0x43, 0xA3, 0x8F, 0xB0,\n+\t\t0xD0, 0xCA, 0x2B, 0xCB, 0xAE, 0x7B, 0x30, 0xB4,\n+\t\t0x77, 0xCB, 0x2D, 0xA3, 0x80, 0x30, 0xF2, 0x0C,\n+\t\t0x6A, 0x42, 0xB7, 0x3B, 0xBE, 0xAC, 0x01, 0xFA,\n+\t};\n+\n \t/* configure RSS key */\n \tif (!rss_conf->rss_key) {\n \t\t/* Calculate the default hash key */\n \t\tfor (i = 0; i <= vsi->rss_key_size; i++)\n-\t\t\tvsi->rss_key[i] = (uint8_t)rte_rand();\n+\t\t\tvsi->rss_key[i] = rss_intel_key[i];\n \t} else {\n \t\trte_memcpy(vsi->rss_key, rss_conf->rss_key,\n \t\t\t RTE_MIN(rss_conf->rss_key_len,\n", "prefixes": [] }