List comments

GET /api/patches/74530/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 116659,
        "web_url": "https://patches.dpdk.org/comment/116659/",
        "msgid": "<a557d058-6669-bcf1-638e-fc1ffd45cddd@intel.com>",
        "date": "2020-07-27T04:32:24",
        "subject": "Re: [dpdk-dev] [PATCH 7/8] net/i40e/base: replace AQ command for\n\tNVM update",
        "submitter": {
            "id": 507,
            "url": "https://patches.dpdk.org/api/people/507/",
            "name": "Guo, Jia",
            "email": "jia.guo@intel.com"
        },
        "content": "Acked-by: Jeff Guo <jia.guo@intel.com>\n\nOn 7/21/2020 3:39 PM, Guinan Sun wrote:\n> Add AQ command \"NVM update in process\"\n> to replace the original AQ command \"NVM progress\".\n>\n> Signed-off-by: Jaroslaw Ilgiewicz <jaroslaw.ilgiewicz@intel.com>\n> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>\n> ---\n>   drivers/net/i40e/base/i40e_adminq_cmd.h | 12 +++++-\n>   drivers/net/i40e/base/i40e_common.c     | 53 +++++++++++++++----------\n>   drivers/net/i40e/base/i40e_prototype.h  |  6 ++-\n>   3 files changed, 46 insertions(+), 25 deletions(-)\n>\n> diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h\n> index c7686b0d3..0766e69a8 100644\n> --- a/drivers/net/i40e/base/i40e_adminq_cmd.h\n> +++ b/drivers/net/i40e/base/i40e_adminq_cmd.h\n> @@ -240,7 +240,7 @@ enum i40e_admin_queue_opc {\n>   \ti40e_aqc_opc_nvm_update\t\t\t= 0x0703,\n>   \ti40e_aqc_opc_nvm_config_read\t\t= 0x0704,\n>   \ti40e_aqc_opc_nvm_config_write\t\t= 0x0705,\n> -\ti40e_aqc_opc_nvm_progress\t\t= 0x0706,\n> +\ti40e_aqc_opc_nvm_update_in_process\t= 0x0706,\n>   \ti40e_aqc_opc_oem_post_update\t\t= 0x0720,\n>   \ti40e_aqc_opc_thermal_sensor\t\t= 0x0721,\n>   \n> @@ -2400,6 +2400,16 @@ struct i40e_aqc_nvm_config_data_feature {\n>   \n>   I40E_CHECK_STRUCT_LEN(0x6, i40e_aqc_nvm_config_data_feature);\n>   \n> +/* NVM Update in Process (direct 0x0706) */\n> +struct i40e_aqc_nvm_update_in_process {\n> +\tu8\tcommand;\n> +#define I40E_AQ_UPDATE_FLOW_END\t\t\t0x0\n> +#define I40E_AQ_UPDATE_FLOW_START\t\t0x1\n> +\tu8\treserved[15];\n> +};\n> +\n> +I40E_CHECK_CMD_LENGTH(i40e_aqc_nvm_update_in_process);\n> +\n>   struct i40e_aqc_nvm_config_data_immediate_field {\n>   \t__le32 field_id;\n>   \t__le32 field_value;\n> diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c\n> index 65317f6c6..6c6fb4de4 100644\n> --- a/drivers/net/i40e/base/i40e_common.c\n> +++ b/drivers/net/i40e/base/i40e_common.c\n> @@ -3686,6 +3686,37 @@ enum i40e_status_code i40e_aq_write_nvm_config(struct i40e_hw *hw,\n>   \treturn status;\n>   }\n>   \n> +/**\n> + * i40e_aq_nvm_update_in_process\n> + * @hw: pointer to the hw struct\n> + * @update_flow_state: True indicates that update flow starts, false that ends\n> + * @cmd_details: pointer to command details structure or NULL\n> + *\n> + * Indicate NVM update in process.\n> + **/\n> +enum i40e_status_code\n> +i40e_aq_nvm_update_in_process(struct i40e_hw *hw,\n> +\t\t\t      bool update_flow_state,\n> +\t\t\t      struct i40e_asq_cmd_details *cmd_details)\n> +{\n> +\tstruct i40e_aq_desc desc;\n> +\tstruct i40e_aqc_nvm_update_in_process *cmd =\n> +\t\t(struct i40e_aqc_nvm_update_in_process *)&desc.params.raw;\n> +\tenum i40e_status_code status;\n> +\n> +\ti40e_fill_default_direct_cmd_desc(&desc,\n> +\t\t\t\t\t  i40e_aqc_opc_nvm_update_in_process);\n> +\n> +\tcmd->command = I40E_AQ_UPDATE_FLOW_END;\n> +\n> +\tif (update_flow_state)\n> +\t\tcmd->command |= I40E_AQ_UPDATE_FLOW_START;\n> +\n> +\tstatus = i40e_asq_send_command(hw, &desc, NULL, 0, cmd_details);\n> +\n> +\treturn status;\n> +}\n> +\n>   /**\n>    * i40e_aq_oem_post_update - triggers an OEM specific flow after update\n>    * @hw: pointer to the hw struct\n> @@ -4257,28 +4288,6 @@ enum i40e_status_code i40e_aq_rearrange_nvm(struct i40e_hw *hw,\n>   \treturn status;\n>   }\n>   \n> -/**\n> - * i40e_aq_nvm_progress\n> - * @hw: pointer to the hw struct\n> - * @progress: pointer to progress returned from AQ\n> - * @cmd_details: pointer to command details structure or NULL\n> - *\n> - * Gets progress of flash rearrangement process\n> - **/\n> -enum i40e_status_code i40e_aq_nvm_progress(struct i40e_hw *hw, u8 *progress,\n> -\t\t\t\tstruct i40e_asq_cmd_details *cmd_details)\n> -{\n> -\tenum i40e_status_code status;\n> -\tstruct i40e_aq_desc desc;\n> -\n> -\tDEBUGFUNC(\"i40e_aq_nvm_progress\");\n> -\n> -\ti40e_fill_default_direct_cmd_desc(&desc, i40e_aqc_opc_nvm_progress);\n> -\tstatus = i40e_asq_send_command(hw, &desc, NULL, 0, cmd_details);\n> -\t*progress = desc.params.raw[0];\n> -\treturn status;\n> -}\n> -\n>   /**\n>    * i40e_aq_get_lldp_mib\n>    * @hw: pointer to the hw struct\n> diff --git a/drivers/net/i40e/base/i40e_prototype.h b/drivers/net/i40e/base/i40e_prototype.h\n> index 91fa23491..9a89f3002 100644\n> --- a/drivers/net/i40e/base/i40e_prototype.h\n> +++ b/drivers/net/i40e/base/i40e_prototype.h\n> @@ -254,8 +254,10 @@ enum i40e_status_code i40e_aq_update_nvm(struct i40e_hw *hw, u8 module_pointer,\n>   enum i40e_status_code i40e_aq_rearrange_nvm(struct i40e_hw *hw,\n>   \t\t\t\tu8 rearrange_nvm,\n>   \t\t\t\tstruct i40e_asq_cmd_details *cmd_details);\n> -enum i40e_status_code i40e_aq_nvm_progress(struct i40e_hw *hw, u8 *progress,\n> -\t\t\t\tstruct i40e_asq_cmd_details *cmd_details);\n> +enum i40e_status_code\n> +i40e_aq_nvm_update_in_process(struct i40e_hw *hw,\n> +\t\t\t      bool update_flow_state,\n> +\t\t\t      struct i40e_asq_cmd_details *cmd_details);\n>   enum i40e_status_code i40e_aq_get_lldp_mib(struct i40e_hw *hw, u8 bridge_type,\n>   \t\t\t\tu8 mib_type, void *buff, u16 buff_size,\n>   \t\t\t\tu16 *local_len, u16 *remote_len,",
        "headers": {
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
            "X-IronPort-AV": [
                "E=McAfee;i=\"6000,8403,9694\"; a=\"138464589\"",
                "E=Sophos;i=\"5.75,401,1589266800\"; d=\"scan'208\";a=\"138464589\"",
                "E=Sophos;i=\"5.75,401,1589266800\"; d=\"scan'208\";a=\"327895982\""
            ],
            "IronPort-SDR": [
                "\n vj3G5i/ROk/IWwx0r+6Go/kWK1orGZbTQ2kX4EbGiA3w2x9Rgh2YUsDtZNReO6lq0d83C9/77/\n I83Bvile5srw==",
                "\n CX+BzxUC/RX8vCD+8AYSdZ7u2Q3EiPtCe3s2xwnJt6d24V/rjQ8KWQtG4/Eu06gIvdaJ7rp9dp\n vHDontTF6h9w=="
            ],
            "X-Amp-File-Uploaded": "False",
            "Precedence": "list",
            "X-Mailman-Version": "2.1.15",
            "X-Original-To": "patchwork@inbox.dpdk.org",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "MIME-Version": "1.0",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "X-BeenThere": "dev@dpdk.org",
            "References": "<20200721074000.30449-1-guinanx.sun@intel.com>\n <20200721074000.30449-8-guinanx.sun@intel.com>",
            "Subject": "Re: [dpdk-dev] [PATCH 7/8] net/i40e/base: replace AQ command for\n\tNVM update",
            "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101\n Thunderbird/68.10.0",
            "Content-Type": "text/plain; charset=utf-8; format=flowed",
            "From": "Jeff Guo <jia.guo@intel.com>",
            "Received": [
                "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E754EA0524;\n\tMon, 27 Jul 2020 06:32:32 +0200 (CEST)",
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1C1AB1BFC8;\n\tMon, 27 Jul 2020 06:32:31 +0200 (CEST)",
                "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id 908391C01\n for <dev@dpdk.org>; Mon, 27 Jul 2020 06:32:28 +0200 (CEST)",
                "from fmsmga003.fm.intel.com ([10.253.24.29])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 26 Jul 2020 21:32:27 -0700",
                "from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.176])\n ([10.67.68.176])\n by FMSMGA003.fm.intel.com with ESMTP; 26 Jul 2020 21:32:25 -0700"
            ],
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "X-Amp-Result": "SKIPPED(no attachment in message)",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-ExtLoop1": "1",
            "Message-ID": "<a557d058-6669-bcf1-638e-fc1ffd45cddd@intel.com>",
            "Date": "Mon, 27 Jul 2020 12:32:24 +0800",
            "Content-Transfer-Encoding": "7bit",
            "To": "Guinan Sun <guinanx.sun@intel.com>, dev@dpdk.org",
            "Delivered-To": "patchwork@inbox.dpdk.org",
            "In-Reply-To": "<20200721074000.30449-8-guinanx.sun@intel.com>",
            "Cc": "Beilei Xing <beilei.xing@intel.com>,\n Jaroslaw Ilgiewicz <jaroslaw.ilgiewicz@intel.com>",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "Errors-To": "dev-bounces@dpdk.org",
            "Content-Language": "en-US"
        }
    }
]