Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7453/?format=api
{ "id": 7453, "url": "https://patches.dpdk.org/api/patches/7453/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1444067692-29645-14-git-send-email-adrien.mazarguil@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1444067692-29645-14-git-send-email-adrien.mazarguil@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1444067692-29645-14-git-send-email-adrien.mazarguil@6wind.com", "date": "2015-10-05T17:54:48", "name": "[dpdk-dev,13/17] mlx5: remove normal MAC flows when enabling promiscuous mode", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6a98a5baaa2cfe47c8eed6e26d3206f783619af0", "submitter": { "id": 165, "url": "https://patches.dpdk.org/api/people/165/?format=api", "name": "Adrien Mazarguil", "email": "adrien.mazarguil@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1444067692-29645-14-git-send-email-adrien.mazarguil@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/7453/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/7453/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 8957D9249;\n\tMon, 5 Oct 2015 19:55:43 +0200 (CEST)", "from mail-wi0-f178.google.com (mail-wi0-f178.google.com\n\t[209.85.212.178]) by dpdk.org (Postfix) with ESMTP id 2FFCF93F8\n\tfor <dev@dpdk.org>; Mon, 5 Oct 2015 19:55:42 +0200 (CEST)", "by wicfx3 with SMTP id fx3so131847143wic.1\n\tfor <dev@dpdk.org>; Mon, 05 Oct 2015 10:55:42 -0700 (PDT)", "from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by smtp.gmail.com with ESMTPSA id\n\tm9sm15802072wib.13.2015.10.05.10.55.41\n\t(version=TLSv1.2 cipher=RC4-SHA bits=128/128);\n\tMon, 05 Oct 2015 10:55:41 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=2A2c4f/aPydFh5Peico4hq3jk+JYgUXYGhQa/v3S+WI=;\n\tb=S6doDE4rNwZhsHVgt0SjAYmFwG4Q9dLv66XZpzWLKLLicF4cIjNYs2wS0h5ody+Jpt\n\tJfOAUIzHYW5iBnQIRVJyQ6VAAKEE/nUXueFwtsnSRQ82AB72cxVKLa9zF6mtm9fTl3I5\n\tcTjoEGuz3epfHFrS+NlKTfHQPvBgiMgEZhu3IXbLYOvL2EKwlRQv4BWy39Q49atNTRq+\n\tY9OspjOzGanIbIimwrSCMiPlX+shdK7dY+yitY0kVwIOirYSJqHPy/7G9+/ZW5C5C3t8\n\t42XW9kO5Xp4X/050/A9qydvzZTpC8fPW6ZGsJsZJkSNqk6SYT5XFsK2HENF9sJZoFr6E\n\tzN9A==", "X-Gm-Message-State": "ALoCoQkSOD1E2pgGysy7Ed6iAvuBNSnrRym5+n97rm6M2se0SERuAlo5WZDE3AwVhmdO3Oqb7Ct7", "X-Received": "by 10.180.101.163 with SMTP id fh3mr13825586wib.94.1444067741845;\n\tMon, 05 Oct 2015 10:55:41 -0700 (PDT)", "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>", "To": "dev@dpdk.org", "Date": "Mon, 5 Oct 2015 19:54:48 +0200", "Message-Id": "<1444067692-29645-14-git-send-email-adrien.mazarguil@6wind.com>", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1444067692-29645-1-git-send-email-adrien.mazarguil@6wind.com>", "References": "<1444067692-29645-1-git-send-email-adrien.mazarguil@6wind.com>", "Subject": "[dpdk-dev] [PATCH 13/17] mlx5: remove normal MAC flows when\n\tenabling promiscuous mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\n\nNormal MAC flows are not necessary when promiscuous mode is enabled.\nRemoving them frees up hardware resources.\n\nSigned-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\n---\n drivers/net/mlx5/mlx5_rxmode.c | 15 +++++++++++++--\n 1 file changed, 13 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_rxmode.c b/drivers/net/mlx5/mlx5_rxmode.c\nindex aab38ee..578f2fb 100644\n--- a/drivers/net/mlx5/mlx5_rxmode.c\n+++ b/drivers/net/mlx5/mlx5_rxmode.c\n@@ -123,6 +123,8 @@ priv_promiscuous_enable(struct priv *priv)\n \t\tstruct hash_rxq *hash_rxq = &(*priv->hash_rxqs)[i];\n \t\tint ret;\n \n+\t\t/* Remove normal MAC flows first. */\n+\t\thash_rxq_mac_addrs_del(hash_rxq);\n \t\tret = hash_rxq_promiscuous_enable(hash_rxq);\n \t\tif (!ret)\n \t\t\tcontinue;\n@@ -130,6 +132,9 @@ priv_promiscuous_enable(struct priv *priv)\n \t\twhile (i != 0) {\n \t\t\thash_rxq = &(*priv->hash_rxqs)[--i];\n \t\t\thash_rxq_promiscuous_disable(hash_rxq);\n+\t\t\t/* Restore MAC flows. */\n+\t\t\tif (priv->started)\n+\t\t\t\thash_rxq_mac_addrs_add(hash_rxq);\n \t\t}\n \t\treturn ret;\n \t}\n@@ -189,8 +194,14 @@ priv_promiscuous_disable(struct priv *priv)\n \n \tif (!priv->promisc)\n \t\treturn;\n-\tfor (i = 0; (i != priv->hash_rxqs_n); ++i)\n-\t\thash_rxq_promiscuous_disable(&(*priv->hash_rxqs)[i]);\n+\tfor (i = 0; (i != priv->hash_rxqs_n); ++i) {\n+\t\tstruct hash_rxq *hash_rxq = &(*priv->hash_rxqs)[i];\n+\n+\t\thash_rxq_promiscuous_disable(hash_rxq);\n+\t\t/* Restore MAC flows. */\n+\t\tif (priv->started)\n+\t\t\thash_rxq_mac_addrs_add(hash_rxq);\n+\t}\n \tpriv->promisc = 0;\n }\n \n", "prefixes": [ "dpdk-dev", "13/17" ] }