Patch Comment List
List patch comments
GET /api/patches/74526/comments/?format=api
[ { "id": 116656, "web_url": "https://patches.dpdk.org/comment/116656/", "msgid": "<30c383c8-1aee-dd34-4fdf-ba5f677d7613@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/30c383c8-1aee-dd34-4fdf-ba5f677d7613@intel.com", "date": "2020-07-27T03:53:20", "subject": "Re: [dpdk-dev] [PATCH 3/8] net/i40e/base: enable new custom cloud\n\tfilters", "submitter": { "id": 507, "url": "https://patches.dpdk.org/api/people/507/?format=api", "name": "Guo, Jia", "email": "jia.guo@intel.com" }, "content": "hi, guinan\n\nThis patch is just define some new types but not enable a feature, could \nthe title to be \"add new custom cloud filters types\",\n\nis it better and could eliminate some confuse?\n\nOn 7/21/2020 3:39 PM, Guinan Sun wrote:\n> This patch adds the new filter types needed for custom cloud filters.\n> These custom cloud filters will route traffic to VFs based on the\n> dst IP for both tunneled and non-tunneled packets.\n>\n> Signed-off-by: Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>\n> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>\n> ---\n> drivers/net/i40e/base/i40e_adminq_cmd.h | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h\n> index f790183be..21f544840 100644\n> --- a/drivers/net/i40e/base/i40e_adminq_cmd.h\n> +++ b/drivers/net/i40e/base/i40e_adminq_cmd.h\n> @@ -1406,6 +1406,8 @@ struct i40e_aqc_cloud_filters_element_data {\n> #define I40E_AQC_ADD_CLOUD_FILTER_IMAC\t\t\t0x000A\n> #define I40E_AQC_ADD_CLOUD_FILTER_OMAC_TEN_ID_IMAC\t0x000B\n> #define I40E_AQC_ADD_CLOUD_FILTER_IIP\t\t\t0x000C\n> +#define I40E_AQC_ADD_CLOUD_FILTER_OIP1\t\t\t0x0010\n> +#define I40E_AQC_ADD_CLOUD_FILTER_OIP2\t\t\t0x0012\n> /* 0x000D reserved */\n> /* 0x000E reserved */\n> /* 0x000F reserved */", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 81D99A0524;\n\tMon, 27 Jul 2020 05:53:27 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 30BAF1C0B9;\n\tMon, 27 Jul 2020 05:53:26 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by dpdk.org (Postfix) with ESMTP id 54CEE1C0B4\n for <dev@dpdk.org>; Mon, 27 Jul 2020 05:53:24 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 26 Jul 2020 20:53:23 -0700", "from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.176])\n ([10.67.68.176])\n by FMSMGA003.fm.intel.com with ESMTP; 26 Jul 2020 20:53:21 -0700" ], "IronPort-SDR": [ "\n RINva+1MgAB7vK7fQP3qqYttYnGGiptmUm2iGfMWQR/z80r2RT0dtkCpEm0Y+pTTq3YFVoB09m\n 0+ImAUEWj/kA==", "\n QGYZcBHNsO6L/aW0qKpa6yUoAuFWK+hubt/7ug8Jin6qKP5i302MJ/03xkK8E9JppSy7/c2DGy\n 377pn4u+tQMA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9694\"; a=\"148833966\"", "E=Sophos;i=\"5.75,401,1589266800\"; d=\"scan'208\";a=\"148833966\"", "E=Sophos;i=\"5.75,401,1589266800\"; d=\"scan'208\";a=\"327889908\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "To": "Guinan Sun <guinanx.sun@intel.com>, dev@dpdk.org", "Cc": "Beilei Xing <beilei.xing@intel.com>,\n Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>", "References": "<20200721074000.30449-1-guinanx.sun@intel.com>\n <20200721074000.30449-4-guinanx.sun@intel.com>", "From": "Jeff Guo <jia.guo@intel.com>", "Message-ID": "<30c383c8-1aee-dd34-4fdf-ba5f677d7613@intel.com>", "Date": "Mon, 27 Jul 2020 11:53:20 +0800", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101\n Thunderbird/68.10.0", "MIME-Version": "1.0", "In-Reply-To": "<20200721074000.30449-4-guinanx.sun@intel.com>", "Content-Type": "text/plain; charset=utf-8; format=flowed", "Content-Transfer-Encoding": "7bit", "Content-Language": "en-US", "Subject": "Re: [dpdk-dev] [PATCH 3/8] net/i40e/base: enable new custom cloud\n\tfilters", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116663, "web_url": "https://patches.dpdk.org/comment/116663/", "msgid": "<05758BDAD7FC8E4BAED63D0390A8A95587EEBE@SHSMSX101.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/05758BDAD7FC8E4BAED63D0390A8A95587EEBE@SHSMSX101.ccr.corp.intel.com", "date": "2020-07-27T04:55:06", "subject": "Re: [dpdk-dev] [PATCH 3/8] net/i40e/base: enable new custom cloud\n\tfilters", "submitter": { "id": 1476, "url": "https://patches.dpdk.org/api/people/1476/?format=api", "name": "Guinan Sun", "email": "guinanx.sun@intel.com" }, "content": "Hi Jeff\n\n> -----Original Message-----\n> From: Guo, Jia\n> Sent: Monday, July 27, 2020 11:53 AM\n> To: Sun, GuinanX <guinanx.sun@intel.com>; dev@dpdk.org\n> Cc: Xing, Beilei <beilei.xing@intel.com>; Ramamurthy, Harshitha\n> <harshitha.ramamurthy@intel.com>\n> Subject: Re: [PATCH 3/8] net/i40e/base: enable new custom cloud filters\n> \n> hi, guinan\n> \n> This patch is just define some new types but not enable a feature, could the\n> title to be \"add new custom cloud filters types\",\n> \n> is it better and could eliminate some confuse?\n\nI agree with you.\nPatch V2 will modify it.\n\n> \n> On 7/21/2020 3:39 PM, Guinan Sun wrote:\n> > This patch adds the new filter types needed for custom cloud filters.\n> > These custom cloud filters will route traffic to VFs based on the dst\n> > IP for both tunneled and non-tunneled packets.\n> >\n> > Signed-off-by: Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>\n> > Signed-off-by: Guinan Sun <guinanx.sun@intel.com>\n> > ---\n> > drivers/net/i40e/base/i40e_adminq_cmd.h | 2 ++\n> > 1 file changed, 2 insertions(+)\n> >\n> > diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h\n> > b/drivers/net/i40e/base/i40e_adminq_cmd.h\n> > index f790183be..21f544840 100644\n> > --- a/drivers/net/i40e/base/i40e_adminq_cmd.h\n> > +++ b/drivers/net/i40e/base/i40e_adminq_cmd.h\n> > @@ -1406,6 +1406,8 @@ struct i40e_aqc_cloud_filters_element_data {\n> > #define I40E_AQC_ADD_CLOUD_FILTER_IMAC\n> \t0x000A\n> > #define I40E_AQC_ADD_CLOUD_FILTER_OMAC_TEN_ID_IMAC\n> \t0x000B\n> > #define I40E_AQC_ADD_CLOUD_FILTER_IIP\t\t\t0x000C\n> > +#define I40E_AQC_ADD_CLOUD_FILTER_OIP1\n> \t0x0010\n> > +#define I40E_AQC_ADD_CLOUD_FILTER_OIP2\n> \t0x0012\n> > /* 0x000D reserved */\n> > /* 0x000E reserved */\n> > /* 0x000F reserved */", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F3305A0524;\n\tMon, 27 Jul 2020 06:55:14 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CC1901BFE8;\n\tMon, 27 Jul 2020 06:55:14 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 1E0511BFCF\n for <dev@dpdk.org>; Mon, 27 Jul 2020 06:55:12 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 26 Jul 2020 21:55:12 -0700", "from fmsmsx108.amr.corp.intel.com ([10.18.124.206])\n by fmsmga001.fm.intel.com with ESMTP; 26 Jul 2020 21:55:12 -0700", "from fmsmsx124.amr.corp.intel.com (10.18.125.39) by\n FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Sun, 26 Jul 2020 21:55:11 -0700", "from shsmsx104.ccr.corp.intel.com (10.239.4.70) by\n fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Sun, 26 Jul 2020 21:55:11 -0700", "from shsmsx101.ccr.corp.intel.com ([169.254.1.22]) by\n SHSMSX104.ccr.corp.intel.com ([169.254.5.135]) with mapi id 14.03.0439.000;\n Mon, 27 Jul 2020 12:55:07 +0800" ], "IronPort-SDR": [ "\n pIEIFtHJPekktVBd68ql8JAy26gjbCxM1ssJD0COJBDoNVsXKrBvaxw9+khs6A0z/Jb+4b11Vj\n hjxqoPAz/RIA==", "\n 3MwByPaSG9nY5RdvKWaHtS8cAS2LKq83RX7YIgOBWviZzJ4+EMZBvWixhImZ7K4tRo0G40jKuv\n ctasn4aIQl5Q==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9694\"; a=\"150935472\"", "E=Sophos;i=\"5.75,401,1589266800\"; d=\"scan'208\";a=\"150935472\"", "E=Sophos;i=\"5.75,401,1589266800\"; d=\"scan'208\";a=\"393870357\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "\"Sun, GuinanX\" <guinanx.sun@intel.com>", "To": "\"Guo, Jia\" <jia.guo@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"Xing, Beilei\" <beilei.xing@intel.com>, \"Ramamurthy, Harshitha\"\n <harshitha.ramamurthy@intel.com>", "Thread-Topic": "[PATCH 3/8] net/i40e/base: enable new custom cloud filters", "Thread-Index": "AQHWXzWXw4dndDCuo02d4QAihb89XakaTmcAgACXCFA=", "Date": "Mon, 27 Jul 2020 04:55:06 +0000", "Message-ID": "\n <05758BDAD7FC8E4BAED63D0390A8A95587EEBE@SHSMSX101.ccr.corp.intel.com>", "References": "<20200721074000.30449-1-guinanx.sun@intel.com>\n <20200721074000.30449-4-guinanx.sun@intel.com>\n <30c383c8-1aee-dd34-4fdf-ba5f677d7613@intel.com>", "In-Reply-To": "<30c383c8-1aee-dd34-4fdf-ba5f677d7613@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH 3/8] net/i40e/base: enable new custom cloud\n\tfilters", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]