List comments

GET /api/patches/74524/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 116653,
        "web_url": "https://patches.dpdk.org/comment/116653/",
        "msgid": "<27f4ae53-2d3c-7462-acdd-9229028e6e52@intel.com>",
        "date": "2020-07-27T03:38:42",
        "subject": "Re: [dpdk-dev] [PATCH 1/8] net/i40e/base: enable FEC on/off flag\n setting for X722",
        "submitter": {
            "id": 507,
            "url": "https://patches.dpdk.org/api/people/507/",
            "name": "Jeff Guo",
            "email": "jia.guo@intel.com"
        },
        "content": "Acked-by: Jeff Guo <jia.guo@intel.com>\n\nOn 7/21/2020 3:39 PM, Guinan Sun wrote:\n> Starting with API version 1.10 firmware for X722 devices has ability\n> to change FEC settings in PHY. Code added in this patch\n> checks API version and sets appropriate capability flag.\n>\n> Signed-off-by: Dawid Lukwinski <dawid.lukwinski@intel.com>\n> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>\n> ---\n>   drivers/net/i40e/base/i40e_adminq.c     | 6 ++++++\n>   drivers/net/i40e/base/i40e_adminq_cmd.h | 2 ++\n>   drivers/net/i40e/base/i40e_type.h       | 1 +\n>   3 files changed, 9 insertions(+)\n>\n> diff --git a/drivers/net/i40e/base/i40e_adminq.c b/drivers/net/i40e/base/i40e_adminq.c\n> index c89e1fb3f..0da45f03e 100644\n> --- a/drivers/net/i40e/base/i40e_adminq.c\n> +++ b/drivers/net/i40e/base/i40e_adminq.c\n> @@ -603,6 +603,12 @@ STATIC void i40e_set_hw_flags(struct i40e_hw *hw)\n>   \t\t    (aq->api_maj_ver == 1 &&\n>   \t\t     aq->api_min_ver >= I40E_MINOR_VER_GET_LINK_INFO_X722))\n>   \t\t\thw->flags |= I40E_HW_FLAG_AQ_PHY_ACCESS_CAPABLE;\n> +\n> +\t\tif (aq->api_maj_ver > 1 ||\n> +\t\t    (aq->api_maj_ver == 1 &&\n> +\t\t     aq->api_min_ver >= I40E_MINOR_VER_FW_REQUEST_FEC_X722))\n> +\t\t\thw->flags |= I40E_HW_FLAG_X722_FEC_REQUEST_CAPABLE;\n> +\n>   \t\t/* fall through */\n>   \tdefault:\n>   \t\tbreak;\n> diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h\n> index 1905167f5..f790183be 100644\n> --- a/drivers/net/i40e/base/i40e_adminq_cmd.h\n> +++ b/drivers/net/i40e/base/i40e_adminq_cmd.h\n> @@ -25,6 +25,8 @@\n>   #define I40E_MINOR_VER_GET_LINK_INFO_X722 0x0009\n>   /* API version 1.6 for X722 devices adds ability to stop FW LLDP agent */\n>   #define I40E_MINOR_VER_FW_LLDP_STOPPABLE_X722 0x0006\n> +/* API version 1.10 for X722 devices adds ability to request FEC encoding */\n> +#define I40E_MINOR_VER_FW_REQUEST_FEC_X722 0x000A\n>   \n>   struct i40e_aq_desc {\n>   \t__le16 flags;\n> diff --git a/drivers/net/i40e/base/i40e_type.h b/drivers/net/i40e/base/i40e_type.h\n> index 014a4c132..b5b5b928d 100644\n> --- a/drivers/net/i40e/base/i40e_type.h\n> +++ b/drivers/net/i40e/base/i40e_type.h\n> @@ -745,6 +745,7 @@ struct i40e_hw {\n>   #define I40E_HW_FLAG_FW_LLDP_PERSISTENT     BIT_ULL(5)\n>   #define I40E_HW_FLAG_AQ_PHY_ACCESS_EXTENDED BIT_ULL(6)\n>   #define I40E_HW_FLAG_DROP_MODE\t\t    BIT_ULL(7)\n> +#define I40E_HW_FLAG_X722_FEC_REQUEST_CAPABLE BIT_ULL(8)\n>   \tu64 flags;\n>   \n>   \t/* Used in set switch config AQ command */",
        "headers": {
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
            "X-IronPort-AV": [
                "E=McAfee;i=\"6000,8403,9694\"; a=\"212475962\"",
                "E=Sophos;i=\"5.75,401,1589266800\"; d=\"scan'208\";a=\"212475962\"",
                "E=Sophos;i=\"5.75,401,1589266800\"; d=\"scan'208\";a=\"327887252\""
            ],
            "IronPort-SDR": [
                "\n gb7KvNTVFKF990ez+4gPBvVi6ol8L+MH4kPfU6Cjx1YeuLXHUvJ0iuW8qjge6rOV5lJppthsa9\n pJm1P+qPaUsA==",
                "\n f4s2zH0Sc3dHwHQHlOF89Yvf9tJC6LDTPKIPUGw6kfb2AdVTXZFOPK3Z+u+QUB1mJR0+01p1yi\n VQ58HUR8estw=="
            ],
            "X-Amp-File-Uploaded": "False",
            "Precedence": "list",
            "X-Mailman-Version": "2.1.15",
            "X-Original-To": "patchwork@inbox.dpdk.org",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "MIME-Version": "1.0",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "X-BeenThere": "dev@dpdk.org",
            "References": "<20200721074000.30449-1-guinanx.sun@intel.com>\n <20200721074000.30449-2-guinanx.sun@intel.com>",
            "Subject": "Re: [dpdk-dev] [PATCH 1/8] net/i40e/base: enable FEC on/off flag\n setting for X722",
            "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101\n Thunderbird/68.10.0",
            "Content-Type": "text/plain; charset=utf-8; format=flowed",
            "From": "Jeff Guo <jia.guo@intel.com>",
            "Received": [
                "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 87157A0524;\n\tMon, 27 Jul 2020 05:38:49 +0200 (CEST)",
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2F5651C0AC;\n\tMon, 27 Jul 2020 05:38:48 +0200 (CEST)",
                "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id 38A0C1C023\n for <dev@dpdk.org>; Mon, 27 Jul 2020 05:38:46 +0200 (CEST)",
                "from fmsmga003.fm.intel.com ([10.253.24.29])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 26 Jul 2020 20:38:45 -0700",
                "from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.176])\n ([10.67.68.176])\n by FMSMGA003.fm.intel.com with ESMTP; 26 Jul 2020 20:38:43 -0700"
            ],
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "X-Amp-Result": "SKIPPED(no attachment in message)",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-ExtLoop1": "1",
            "Message-ID": "<27f4ae53-2d3c-7462-acdd-9229028e6e52@intel.com>",
            "Date": "Mon, 27 Jul 2020 11:38:42 +0800",
            "Content-Transfer-Encoding": "7bit",
            "To": "Guinan Sun <guinanx.sun@intel.com>, dev@dpdk.org",
            "Delivered-To": "patchwork@inbox.dpdk.org",
            "In-Reply-To": "<20200721074000.30449-2-guinanx.sun@intel.com>",
            "Cc": "Beilei Xing <beilei.xing@intel.com>,\n Dawid Lukwinski <dawid.lukwinski@intel.com>",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "Errors-To": "dev-bounces@dpdk.org",
            "Content-Language": "en-US"
        }
    }
]