List comments

GET /api/patches/74517/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 116372,
        "web_url": "https://patches.dpdk.org/comment/116372/",
        "msgid": "<6FD6A7610D20924F885A4ECF34E8AC910463D23C@CDSMSX102.ccr.corp.intel.com>",
        "date": "2020-07-21T06:19:44",
        "subject": "Re: [dts] [PATCH V1] tests/cvl_advanced_iavf_rss:change load ice\n package mode",
        "submitter": {
            "id": 1686,
            "url": "https://patches.dpdk.org/api/people/1686/",
            "name": "Xie, WeiX",
            "email": "weix.xie@intel.com"
        },
        "content": "Tested-by:  Xie,WeiX < weix.xie@intel.com>\n\nRegards,\nXie Wei\n\n\n-----Original Message-----\nFrom: Xie, WeiX \nSent: Tuesday, July 21, 2020 2:19 PM\nTo: dts@dpdk.org\nCc: Xie, WeiX <weix.xie@intel.com>\nSubject: [dts][PATCH V1] tests/cvl_advanced_iavf_rss:change load ice package mode\n\nuse conf/xxx.cfg mode load ice package.\n\nSigned-off-by: Xie wei <weix.xie@intel.com>\n---\n conf/cvl_advanced_iavf_rss_package.cfg   | 4 ++++\n tests/TestSuite_cvl_advanced_iavf_rss.py | 8 ++++++--\n 2 files changed, 10 insertions(+), 2 deletions(-)  create mode 100644 conf/cvl_advanced_iavf_rss_package.cfg\n\ndiff --git a/conf/cvl_advanced_iavf_rss_package.cfg b/conf/cvl_advanced_iavf_rss_package.cfg\nnew file mode 100644\nindex 0000000..228d481\n--- /dev/null\n+++ b/conf/cvl_advanced_iavf_rss_package.cfg\n@@ -0,0 +1,4 @@\n+[suite]\n+# cvl_advanced_iavf_rss ice package file location \n+os_default_package_file_location=/lib/firmware/updates/intel/ice/ddp/ic\n+e-1.3.13.0.pkg \n+comms_package_file_location=/lib/firmware/updates/intel/ice/ddp/ice_com\n+ms-1.3.16.0.pkg\ndiff --git a/tests/TestSuite_cvl_advanced_iavf_rss.py b/tests/TestSuite_cvl_advanced_iavf_rss.py\nindex eaf55fa..349cb40 100644\n--- a/tests/TestSuite_cvl_advanced_iavf_rss.py\n+++ b/tests/TestSuite_cvl_advanced_iavf_rss.py\n@@ -4,6 +4,7 @@ import time\n from packet import Packet\n from pmd_output import PmdOutput\n from test_case import TestCase\n+from config import UserConf\n import rte_flow_common as rfc\n \n vf0_mac = \"00:01:23:45:67:89\"\n@@ -735,8 +736,11 @@ class AdvancedIavfRSSTest(TestCase):\n         self.pf_pci = self.dut.ports_info[self.dut_ports[0]]['pci']\n         self.verify(self.nic in [\"columbiaville_25g\", \"columbiaville_100g\"], \"%s nic not support ethertype filter\" % self.nic)\n         self.ddp_fdir = \"/lib/firmware/updates/intel/ice/ddp/\"\n-        self.os_pkg_name = \"ice-1.3.11.0.pkg\"\n-        self.comms_pkg_name = \"ice_comms-1.3.16.0.pkg\"\n+        conf_file = 'conf/cvl_advanced_iavf_rss_package.cfg'\n+        conf_info = UserConf(conf_file)\n+        conf_section = conf_info.conf._sections['suite']\n+        self.os_pkg_name = conf_section['os_default_package_file_location']\n+        self.comms_pkg_name = \n+ conf_section['comms_package_file_location']\n         self.vf_flag = False\n         self.create_iavf()\n \n--\n2.17.1",
        "headers": {
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>",
            "Accept-Language": "en-US",
            "X-IronPort-AV": [
                "E=McAfee;i=\"6000,8403,9688\"; a=\"130147813\"",
                "E=Sophos;i=\"5.75,377,1589266800\";\n d=\"log'?scan'208\";a=\"130147813\"",
                "E=Sophos;i=\"5.75,377,1589266800\";\n d=\"log'?scan'208\";a=\"362258931\""
            ],
            "IronPort-SDR": [
                "\n eMtTgpdPiNlSaQalF/i08CAHFHU0TrrFrhdVy6rW7M4BlQG+SX4Qolua1rh9q3fjWlMdjztfPc\n 8K4VApv1O88w==",
                "\n glh0Wgx+tgvB6BoHqBJrK6LBGNOfL967cO6lRc7JQu0a7sTT9GqkU8uLcsDzC4lEpgKU6ZJp6L\n RdqG/l9t/jIA=="
            ],
            "Thread-Index": "AQHWXya2ARLhcOWT1UqmY9LZ0az2yqkRj3wQ",
            "X-Amp-File-Uploaded": "False",
            "Precedence": "list",
            "X-Amp-Original-Verdict": "FILE UNKNOWN",
            "Thread-Topic": "[dts][PATCH V1] tests/cvl_advanced_iavf_rss:change load ice\n package mode",
            "List-Post": "<mailto:dts@dpdk.org>",
            "X-Original-To": "patchwork@inbox.dpdk.org",
            "X-Mailman-Version": "2.1.15",
            "MIME-Version": "1.0",
            "List-Id": "test suite reviews and discussions <dts.dpdk.org>",
            "X-MS-TNEF-Correlator": "",
            "References": "<20200721061914.13088-1-weix.xie@intel.com>",
            "Subject": "Re: [dts] [PATCH V1] tests/cvl_advanced_iavf_rss:change load ice\n package mode",
            "Content-Type": "multipart/mixed;\n boundary=\"_002_6FD6A7610D20924F885A4ECF34E8AC910463D23CCDSMSX102ccrcor_\"",
            "Delivered-To": "patchwork@inbox.dpdk.org",
            "Received": [
                "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6712BA0527;\n\tTue, 21 Jul 2020 08:19:51 +0200 (CEST)",
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5F4091BFFF;\n\tTue, 21 Jul 2020 08:19:51 +0200 (CEST)",
                "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by dpdk.org (Postfix) with ESMTP id E60DB1BFFA\n for <dts@dpdk.org>; Tue, 21 Jul 2020 08:19:49 +0200 (CEST)",
                "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Jul 2020 23:19:48 -0700",
                "from fmsmsx108.amr.corp.intel.com ([10.18.124.206])\n by orsmga001.jf.intel.com with ESMTP; 20 Jul 2020 23:19:48 -0700",
                "from fmsmsx155.amr.corp.intel.com (10.18.116.71) by\n FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Mon, 20 Jul 2020 23:19:48 -0700",
                "from cdsmsx152.ccr.corp.intel.com (172.17.4.41) by\n FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Mon, 20 Jul 2020 23:19:47 -0700",
                "from cdsmsx102.ccr.corp.intel.com ([169.254.2.201]) by\n CDSMSX152.ccr.corp.intel.com ([169.254.6.95]) with mapi id 14.03.0439.000;\n Tue, 21 Jul 2020 14:19:45 +0800"
            ],
            "x-originating-ip": "[172.17.6.105]",
            "List-Help": "<mailto:dts-request@dpdk.org?subject=help>",
            "X-Amp-Result": "UNKNOWN",
            "List-Archive": "<http://mails.dpdk.org/archives/dts/>",
            "X-BeenThere": "dts@dpdk.org",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>",
            "X-ExtLoop1": "1",
            "Message-ID": "\n <6FD6A7610D20924F885A4ECF34E8AC910463D23C@CDSMSX102.ccr.corp.intel.com>",
            "Date": "Tue, 21 Jul 2020 06:19:44 +0000",
            "Sender": "\"dts\" <dts-bounces@dpdk.org>",
            "To": "\"dts@dpdk.org\" <dts@dpdk.org>",
            "X-MS-Has-Attach": "yes",
            "From": "\"Xie, WeiX\" <weix.xie@intel.com>",
            "In-Reply-To": "<20200721061914.13088-1-weix.xie@intel.com>",
            "Return-Path": "<dts-bounces@dpdk.org>",
            "Errors-To": "dts-bounces@dpdk.org",
            "Content-Language": "en-US"
        }
    },
    {
        "id": 116567,
        "web_url": "https://patches.dpdk.org/comment/116567/",
        "msgid": "<8CE3E05A3F976642AAB0F4675D0AD20E0BC840FD@SHSMSX101.ccr.corp.intel.com>",
        "date": "2020-07-24T02:40:29",
        "subject": "Re: [dts] [PATCH V1] tests/cvl_advanced_iavf_rss:change load\n\tice\tpackage mode",
        "submitter": {
            "id": 1098,
            "url": "https://patches.dpdk.org/api/people/1098/",
            "name": "Tu, Lijuan",
            "email": "lijuan.tu@intel.com"
        },
        "content": "Applied, thanks\n\n> -----Original Message-----\n> From: dts <dts-bounces@dpdk.org> On Behalf Of Xie wei\n> Sent: 2020年7月21日 14:19\n> To: dts@dpdk.org\n> Cc: Xie, WeiX <weix.xie@intel.com>\n> Subject: [dts] [PATCH V1] tests/cvl_advanced_iavf_rss:change load ice package\n> mode\n> \n> use conf/xxx.cfg mode load ice package.\n> \n> Signed-off-by: Xie wei <weix.xie@intel.com>\n> ---\n>  conf/cvl_advanced_iavf_rss_package.cfg   | 4 ++++\n>  tests/TestSuite_cvl_advanced_iavf_rss.py | 8 ++++++--\n>  2 files changed, 10 insertions(+), 2 deletions(-)  create mode 100644\n> conf/cvl_advanced_iavf_rss_package.cfg\n> \n> diff --git a/conf/cvl_advanced_iavf_rss_package.cfg\n> b/conf/cvl_advanced_iavf_rss_package.cfg\n> new file mode 100644\n> index 0000000..228d481\n> --- /dev/null\n> +++ b/conf/cvl_advanced_iavf_rss_package.cfg\n> @@ -0,0 +1,4 @@\n> +[suite]\n> +# cvl_advanced_iavf_rss ice package file location\n> +os_default_package_file_location=/lib/firmware/updates/intel/ice/ddp/ic\n> +e-1.3.13.0.pkg\n> +comms_package_file_location=/lib/firmware/updates/intel/ice/ddp/ice_com\n> +ms-1.3.16.0.pkg\n> diff --git a/tests/TestSuite_cvl_advanced_iavf_rss.py\n> b/tests/TestSuite_cvl_advanced_iavf_rss.py\n> index eaf55fa..349cb40 100644\n> --- a/tests/TestSuite_cvl_advanced_iavf_rss.py\n> +++ b/tests/TestSuite_cvl_advanced_iavf_rss.py\n> @@ -4,6 +4,7 @@ import time\n>  from packet import Packet\n>  from pmd_output import PmdOutput\n>  from test_case import TestCase\n> +from config import UserConf\n>  import rte_flow_common as rfc\n> \n>  vf0_mac = \"00:01:23:45:67:89\"\n> @@ -735,8 +736,11 @@ class AdvancedIavfRSSTest(TestCase):\n>          self.pf_pci = self.dut.ports_info[self.dut_ports[0]]['pci']\n>          self.verify(self.nic in [\"columbiaville_25g\", \"columbiaville_100g\"], \"%s nic\n> not support ethertype filter\" % self.nic)\n>          self.ddp_fdir = \"/lib/firmware/updates/intel/ice/ddp/\"\n> -        self.os_pkg_name = \"ice-1.3.11.0.pkg\"\n> -        self.comms_pkg_name = \"ice_comms-1.3.16.0.pkg\"\n> +        conf_file = 'conf/cvl_advanced_iavf_rss_package.cfg'\n> +        conf_info = UserConf(conf_file)\n> +        conf_section = conf_info.conf._sections['suite']\n> +        self.os_pkg_name = conf_section['os_default_package_file_location']\n> +        self.comms_pkg_name =\n> + conf_section['comms_package_file_location']\n>          self.vf_flag = False\n>          self.create_iavf()\n> \n> --\n> 2.17.1",
        "headers": {
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>",
            "Accept-Language": "zh-CN, en-US",
            "X-IronPort-AV": [
                "E=McAfee;i=\"6000,8403,9691\"; a=\"212185761\"",
                "E=Sophos;i=\"5.75,389,1589266800\"; d=\"scan'208\";a=\"212185761\"",
                "E=Sophos;i=\"5.75,389,1589266800\"; d=\"scan'208\";a=\"271220366\""
            ],
            "IronPort-SDR": [
                "\n ULHsbxxjHacpVYR0GZIJZTbquCmaccdUb7QZx3O/HnjGaJ7f0N5WIUbdUROPXPRdss6gN9OMKl\n 2HM9bbY4uVwg==",
                "\n S52w4lr4eLOYRv6UpzjwTCUBV/PMUcO1SigAY01PU+qlbZsDbAAUraoNi9/MdV3By4rQcN0A3p\n Wg+NSf8RKS3Q=="
            ],
            "Thread-Index": "AQHWXybM5UJpvVBfZ0yow4rlMQiuqqkWCUBA",
            "CC": "\"Xie, WeiX\" <weix.xie@intel.com>",
            "X-Amp-File-Uploaded": "False",
            "Precedence": "list",
            "Thread-Topic": "[dts] [PATCH V1] tests/cvl_advanced_iavf_rss:change load ice\n package mode",
            "List-Id": "test suite reviews and discussions <dts.dpdk.org>",
            "List-Post": "<mailto:dts@dpdk.org>",
            "X-Original-To": "patchwork@inbox.dpdk.org",
            "Sender": "\"dts\" <dts-bounces@dpdk.org>",
            "X-Mailman-Version": "2.1.15",
            "MIME-Version": "1.0",
            "dlp-version": "11.2.0.6",
            "X-MS-TNEF-Correlator": "",
            "References": "<20200721061914.13088-1-weix.xie@intel.com>",
            "Subject": "Re: [dts] [PATCH V1] tests/cvl_advanced_iavf_rss:change load\n\tice\tpackage mode",
            "Content-Type": "text/plain; charset=\"iso-2022-jp\"",
            "Delivered-To": "patchwork@inbox.dpdk.org",
            "Received": [
                "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DCE52A0518;\n\tFri, 24 Jul 2020 04:40:35 +0200 (CEST)",
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9D55C1D531;\n\tFri, 24 Jul 2020 04:40:35 +0200 (CEST)",
                "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id 0D1051C211\n for <dts@dpdk.org>; Fri, 24 Jul 2020 04:40:33 +0200 (CEST)",
                "from fmsmga007.fm.intel.com ([10.253.24.52])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Jul 2020 19:40:33 -0700",
                "from fmsmsx103.amr.corp.intel.com ([10.18.124.201])\n by fmsmga007.fm.intel.com with ESMTP; 23 Jul 2020 19:40:32 -0700",
                "from fmsmsx122.amr.corp.intel.com (10.18.125.37) by\n FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Thu, 23 Jul 2020 19:40:32 -0700",
                "from shsmsx102.ccr.corp.intel.com (10.239.4.154) by\n fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Thu, 23 Jul 2020 19:40:32 -0700",
                "from shsmsx101.ccr.corp.intel.com ([169.254.1.22]) by\n shsmsx102.ccr.corp.intel.com ([169.254.2.43]) with mapi id 14.03.0439.000;\n Fri, 24 Jul 2020 10:40:29 +0800"
            ],
            "x-originating-ip": "[10.239.127.40]",
            "List-Help": "<mailto:dts-request@dpdk.org?subject=help>",
            "X-Amp-Result": "SKIPPED(no attachment in message)",
            "List-Archive": "<http://mails.dpdk.org/archives/dts/>",
            "X-BeenThere": "dts@dpdk.org",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>",
            "X-ExtLoop1": "1",
            "Message-ID": "\n <8CE3E05A3F976642AAB0F4675D0AD20E0BC840FD@SHSMSX101.ccr.corp.intel.com>",
            "Date": "Fri, 24 Jul 2020 02:40:29 +0000",
            "Content-Transfer-Encoding": "quoted-printable",
            "To": "\"Xie, WeiX\" <weix.xie@intel.com>, \"dts@dpdk.org\" <dts@dpdk.org>",
            "X-MS-Has-Attach": "",
            "Errors-To": "dts-bounces@dpdk.org",
            "From": "\"Tu, Lijuan\" <lijuan.tu@intel.com>",
            "dlp-reaction": "no-action",
            "In-Reply-To": "<20200721061914.13088-1-weix.xie@intel.com>",
            "Return-Path": "<dts-bounces@dpdk.org>",
            "dlp-product": "dlpe-windows",
            "Content-Language": "en-US"
        }
    }
]