Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74513/?format=api
{ "id": 74513, "url": "https://patches.dpdk.org/api/patches/74513/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200721032304.3372145-1-patrick.fu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200721032304.3372145-1-patrick.fu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200721032304.3372145-1-patrick.fu@intel.com", "date": "2020-07-21T03:23:04", "name": "[v3] vhost: fix missing device pointer validity check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b57eae1d1ec1a05dd1998c5245098f6b77356277", "submitter": { "id": 1781, "url": "https://patches.dpdk.org/api/people/1781/?format=api", "name": "Patrick Fu", "email": "patrick.fu@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200721032304.3372145-1-patrick.fu@intel.com/mbox/", "series": [ { "id": 11184, "url": "https://patches.dpdk.org/api/series/11184/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11184", "date": "2020-07-21T03:23:04", "name": "[v3] vhost: fix missing device pointer validity check", "version": 3, "mbox": "https://patches.dpdk.org/series/11184/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/74513/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/74513/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BE199A0526;\n\tTue, 21 Jul 2020 05:25:17 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7185A1BFD4;\n\tTue, 21 Jul 2020 05:25:17 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id 6F5C11BFBA\n for <dev@dpdk.org>; Tue, 21 Jul 2020 05:25:16 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Jul 2020 20:25:15 -0700", "from npg-dpdk-patrickfu-casc2.sh.intel.com ([10.67.119.92])\n by fmsmga005.fm.intel.com with ESMTP; 20 Jul 2020 20:25:12 -0700" ], "IronPort-SDR": [ "\n bInZWIcc46vyikczn4LuoXighuwhE/H2sbNwo2BUk5/8C3Et6Ixd4yBlpcoWi2d4EVijFqljUk\n 06Lw3KVUukfw==", "\n sxGUhC2uFMNoIks6K0Jd3n4LDGJI4TPVeOOtHZUXBNJeAydFUKpk9m1WmyEOlDHKgUYaZ/Gcoq\n JSA+d0zYNsEA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9688\"; a=\"137542778\"", "E=Sophos;i=\"5.75,377,1589266800\"; d=\"scan'208\";a=\"137542778\"", "E=Sophos;i=\"5.75,377,1589266800\"; d=\"scan'208\";a=\"487934770\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "patrick.fu@intel.com", "To": "dev@dpdk.org,\n\tmaxime.coquelin@redhat.com,\n\tchenbo.xia@intel.com", "Cc": "Patrick Fu <patrick.fu@intel.com>", "Date": "Tue, 21 Jul 2020 11:23:04 +0800", "Message-Id": "<20200721032304.3372145-1-patrick.fu@intel.com>", "X-Mailer": "git-send-email 2.18.4", "In-Reply-To": "<20200714060008.1991779-1-patrick.fu@intel.com>", "References": "<20200714060008.1991779-1-patrick.fu@intel.com>", "Subject": "[dpdk-dev] [PATCH v3] vhost: fix missing device pointer validity\n\tcheck", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Patrick Fu <patrick.fu@intel.com>\n\nThis patch adds the check of dev pointer in vhost async enqueue\ncompletion poll. If a NULL dev pointer detected, the poll function\nreturns immediately.\n\nCoverity issue: 360839\nFixes: cd6760da1076 (\"vhost: introduce async enqueue for split ring\")\n\nSigned-off-by: Patrick Fu <patrick.fu@intel.com>\n---\nv2:\n - change fixline number\nv3:\n - revise commit message title\n\n lib/librte_vhost/virtio_net.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c\nindex 1d0be3dd4..235c31e28 100644\n--- a/lib/librte_vhost/virtio_net.c\n+++ b/lib/librte_vhost/virtio_net.c\n@@ -1635,6 +1635,9 @@ uint16_t rte_vhost_poll_enqueue_completed(int vid, uint16_t queue_id,\n \tuint16_t start_idx, pkts_idx, vq_size;\n \tuint64_t *async_pending_info;\n \n+\tif (!dev)\n+\t\treturn 0;\n+\n \tVHOST_LOG_DATA(DEBUG, \"(%d) %s\\n\", dev->vid, __func__);\n \tif (unlikely(!is_valid_virt_queue_idx(queue_id, 0, dev->nr_vring))) {\n \t\tVHOST_LOG_DATA(ERR, \"(%d) %s: invalid virtqueue idx %d.\\n\",\n", "prefixes": [ "v3" ] }