List comments

GET /api/patches/74509/comments/
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 116354,
        "web_url": "https://patches.dpdk.org/comment/116354/",
        "msgid": "<0e15997b-cbee-a04a-cbcb-09e437e79442@intel.com>",
        "date": "2020-07-21T03:11:45",
        "subject": "Re: [dpdk-dev] [DPDK v2] net/i40e: add VLAN filter feature to\n\tcapability",
        "submitter": {
            "id": 507,
            "url": "https://patches.dpdk.org/api/people/507/",
            "name": "Guo, Jia",
            "email": "jia.guo@intel.com"
        },
        "content": "Acked-by: Jeff Guo <jia.guo@intel.com>\n\nOn 7/21/2020 10:45 AM, zhihongx.peng@intel.com wrote:\n> From: Peng Zhihong <zhihongx.peng@intel.com>\n>\n> The rte_eth_dev_set_vlan_offload function will check vlan rx offload\n> capability, the i40e vf has vlan filter feature but\n> DEV_RX_OFFLOAD_VLAN_FILTER is not set into the capability, that will\n> cause setting fail. So need to add this capability in\n> i40e_vf_representor_dev_infos_get function.\n>\n> Fixes: e0cb96204b71 (net/i40e: add support for representor ports)\n> Cc: stable@dpdk.org\n>\n> Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>\n> ---\n>   drivers/net/i40e/i40e_vf_representor.c | 3 ++-\n>   1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/drivers/net/i40e/i40e_vf_representor.c b/drivers/net/i40e/i40e_vf_representor.c\n> index b07b35c03..083bc1a5f 100644\n> --- a/drivers/net/i40e/i40e_vf_representor.c\n> +++ b/drivers/net/i40e/i40e_vf_representor.c\n> @@ -46,7 +46,8 @@ i40e_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev,\n>   \t\tDEV_RX_OFFLOAD_QINQ_STRIP |\n>   \t\tDEV_RX_OFFLOAD_IPV4_CKSUM |\n>   \t\tDEV_RX_OFFLOAD_UDP_CKSUM |\n> -\t\tDEV_RX_OFFLOAD_TCP_CKSUM;\n> +\t\tDEV_RX_OFFLOAD_TCP_CKSUM |\n> +\t\tDEV_RX_OFFLOAD_VLAN_FILTER;\n>   \tdev_info->tx_offload_capa =\n>   \t\tDEV_TX_OFFLOAD_MULTI_SEGS  |\n>   \t\tDEV_TX_OFFLOAD_VLAN_INSERT |",
        "headers": {
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
            "X-IronPort-AV": [
                "E=McAfee;i=\"6000,8403,9688\"; a=\"214717945\"",
                "E=Sophos;i=\"5.75,377,1589266800\"; d=\"scan'208\";a=\"214717945\"",
                "E=Sophos;i=\"5.75,377,1589266800\"; d=\"scan'208\";a=\"461920378\""
            ],
            "IronPort-SDR": [
                "\n SJHYBLXoN2Oh6y/6BNsety1DDK0a9iFkFm1CoygAyKVMN/z/L6cKivjWIRwHp33Sv9Ibw4Rfn7\n PMUYudProPIw==",
                "\n 2tysUyN8AGiLBS9lHpSZZ7JkYhckGOpuES6fZh/Zb41TIRgH03r0znQoWaSwORb29FjMrjw4fo\n pnzrKrp9hy3w=="
            ],
            "X-Amp-File-Uploaded": "False",
            "Precedence": "list",
            "X-Mailman-Version": "2.1.15",
            "X-Original-To": "patchwork@inbox.dpdk.org",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "MIME-Version": "1.0",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "X-BeenThere": "dev@dpdk.org",
            "References": "<20200720024214.13972-1-zhihongx.peng@intel.com>\n <20200721024528.1520-1-zhihongx.peng@intel.com>",
            "Subject": "Re: [dpdk-dev] [DPDK v2] net/i40e: add VLAN filter feature to\n\tcapability",
            "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101\n Thunderbird/68.10.0",
            "Content-Type": "text/plain; charset=utf-8; format=flowed",
            "From": "Jeff Guo <jia.guo@intel.com>",
            "Received": [
                "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5D145A0526;\n\tTue, 21 Jul 2020 05:11:51 +0200 (CEST)",
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id ED5161BFF9;\n\tTue, 21 Jul 2020 05:11:50 +0200 (CEST)",
                "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id D4EB91BFEC;\n Tue, 21 Jul 2020 05:11:48 +0200 (CEST)",
                "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Jul 2020 20:11:47 -0700",
                "from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.145])\n ([10.67.68.145])\n by orsmga005.jf.intel.com with ESMTP; 20 Jul 2020 20:11:46 -0700"
            ],
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "X-Amp-Result": "SKIPPED(no attachment in message)",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-ExtLoop1": "1",
            "Message-ID": "<0e15997b-cbee-a04a-cbcb-09e437e79442@intel.com>",
            "Date": "Tue, 21 Jul 2020 11:11:45 +0800",
            "Content-Transfer-Encoding": "7bit",
            "To": "zhihongx.peng@intel.com, beilei.xing@intel.com",
            "Delivered-To": "patchwork@inbox.dpdk.org",
            "In-Reply-To": "<20200721024528.1520-1-zhihongx.peng@intel.com>",
            "Cc": "dev@dpdk.org, stable@dpdk.org",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "Errors-To": "dev-bounces@dpdk.org",
            "Content-Language": "en-US"
        }
    },
    {
        "id": 116364,
        "web_url": "https://patches.dpdk.org/comment/116364/",
        "msgid": "<039ED4275CED7440929022BC67E706115486303A@SHSMSX103.ccr.corp.intel.com>",
        "date": "2020-07-21T05:01:10",
        "subject": "Re: [dpdk-dev] [DPDK v2] net/i40e: add VLAN filter feature\n\tto\tcapability",
        "submitter": {
            "id": 504,
            "url": "https://patches.dpdk.org/api/people/504/",
            "name": "Zhang, Qi Z",
            "email": "qi.z.zhang@intel.com"
        },
        "content": "> -----Original Message-----\n> From: dev <dev-bounces@dpdk.org> On Behalf Of Jeff Guo\n> Sent: Tuesday, July 21, 2020 11:12 AM\n> To: Peng, ZhihongX <zhihongx.peng@intel.com>; Xing, Beilei\n> <beilei.xing@intel.com>\n> Cc: dev@dpdk.org; stable@dpdk.org\n> Subject: Re: [dpdk-dev] [DPDK v2] net/i40e: add VLAN filter feature to capability\n> \n> Acked-by: Jeff Guo <jia.guo@intel.com>\n> \n> On 7/21/2020 10:45 AM, zhihongx.peng@intel.com wrote:\n> > From: Peng Zhihong <zhihongx.peng@intel.com>\n> >\n> > The rte_eth_dev_set_vlan_offload function will check vlan rx offload\n> > capability, the i40e vf has vlan filter feature but\n> > DEV_RX_OFFLOAD_VLAN_FILTER is not set into the capability, that will\n> > cause setting fail. So need to add this capability in\n> > i40e_vf_representor_dev_infos_get function.\n> >\n> > Fixes: e0cb96204b71 (net/i40e: add support for representor ports)\n\nFix line should be (\".....\")\n\n> > Cc: stable@dpdk.org\n> >\n> > Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>\n\nApplied to dpdk-next-net-intel.\n\nThanks\nQi",
        "headers": {
            "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
            "Accept-Language": "en-US",
            "X-IronPort-AV": [
                "E=McAfee;i=\"6000,8403,9688\"; a=\"168203407\"",
                "E=Sophos;i=\"5.75,377,1589266800\"; d=\"scan'208\";a=\"168203407\"",
                "E=Sophos;i=\"5.75,377,1589266800\"; d=\"scan'208\";a=\"283746029\""
            ],
            "IronPort-SDR": [
                "\n Oew87+tc8hz+4okz0Xrq/5mX6pA5obp8eOBKejmF8xAiSUrSQh/DYvzXhzgsXr5B/FW0E4NARN\n TLGS0wP74LHQ==",
                "\n OGJ+uTXYF/CQo/AEBNdw/NrlcplGah6ypbFjU9kbLB/xOTgJRxujFuFrfXe4vglKfsTd2czzt0\n 7gshU2WhmnGg=="
            ],
            "Thread-Index": "AQHWXwy5PtPIVrjloEmQtpaUUsjFV6kReXyQ",
            "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, \"stable@dpdk.org\" <stable@dpdk.org>",
            "X-Amp-File-Uploaded": "False",
            "Precedence": "list",
            "Thread-Topic": "[dpdk-dev] [DPDK v2] net/i40e: add VLAN filter feature to\n capability",
            "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
            "List-Post": "<mailto:dev@dpdk.org>",
            "X-Original-To": "patchwork@inbox.dpdk.org",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "X-Mailman-Version": "2.1.15",
            "MIME-Version": "1.0",
            "dlp-version": "11.2.0.6",
            "X-MS-TNEF-Correlator": "",
            "References": "<20200720024214.13972-1-zhihongx.peng@intel.com>\n <20200721024528.1520-1-zhihongx.peng@intel.com>\n <0e15997b-cbee-a04a-cbcb-09e437e79442@intel.com>",
            "Subject": "Re: [dpdk-dev] [DPDK v2] net/i40e: add VLAN filter feature\n\tto\tcapability",
            "Content-Type": "text/plain; charset=\"utf-8\"",
            "Delivered-To": "patchwork@inbox.dpdk.org",
            "Received": [
                "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9B7BCA0526;\n\tTue, 21 Jul 2020 07:01:22 +0200 (CEST)",
                "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4BAAC1BFFF;\n\tTue, 21 Jul 2020 07:01:21 +0200 (CEST)",
                "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by dpdk.org (Postfix) with ESMTP id 702401BFCD;\n Tue, 21 Jul 2020 07:01:18 +0200 (CEST)",
                "from orsmga003.jf.intel.com ([10.7.209.27])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Jul 2020 22:01:17 -0700",
                "from fmsmsx108.amr.corp.intel.com ([10.18.124.206])\n by orsmga003.jf.intel.com with ESMTP; 20 Jul 2020 22:01:14 -0700",
                "from fmsmsx612.amr.corp.intel.com (10.18.126.92) by\n FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Mon, 20 Jul 2020 22:01:13 -0700",
                "from fmsmsx612.amr.corp.intel.com (10.18.126.92) by\n fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.1713.5; Mon, 20 Jul 2020 22:01:13 -0700",
                "from shsmsx151.ccr.corp.intel.com (10.239.6.50) by\n fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5\n via Frontend Transport; Mon, 20 Jul 2020 22:01:13 -0700",
                "from shsmsx103.ccr.corp.intel.com ([169.254.4.22]) by\n SHSMSX151.ccr.corp.intel.com ([169.254.3.49]) with mapi id 14.03.0439.000;\n Tue, 21 Jul 2020 13:01:10 +0800"
            ],
            "x-originating-ip": "[10.239.127.40]",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "X-Amp-Result": "SKIPPED(no attachment in message)",
            "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
            "X-BeenThere": "dev@dpdk.org",
            "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-ExtLoop1": "1",
            "Message-ID": "\n <039ED4275CED7440929022BC67E706115486303A@SHSMSX103.ccr.corp.intel.com>",
            "Date": "Tue, 21 Jul 2020 05:01:10 +0000",
            "Content-Transfer-Encoding": "base64",
            "To": "\"Guo, Jia\" <jia.guo@intel.com>, \"Peng, ZhihongX\"\n <zhihongx.peng@intel.com>, \"Xing, Beilei\" <beilei.xing@intel.com>",
            "X-MS-Has-Attach": "",
            "Errors-To": "dev-bounces@dpdk.org",
            "From": "\"Zhang, Qi Z\" <qi.z.zhang@intel.com>",
            "dlp-reaction": "no-action",
            "In-Reply-To": "<0e15997b-cbee-a04a-cbcb-09e437e79442@intel.com>",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "dlp-product": "dlpe-windows",
            "Content-Language": "en-US"
        }
    }
]