Patch Comment List
List patch comments
GET /api/patches/74504/comments/?format=api
[ { "id": 116337, "web_url": "https://patches.dpdk.org/comment/116337/", "msgid": "<33994bfc-9176-0b74-4a48-5be1b286ff44@partner.samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/33994bfc-9176-0b74-4a48-5be1b286ff44@partner.samsung.com", "date": "2020-07-20T17:45:42", "subject": "Re: [dpdk-dev] [PATCH v2 2/2] test/service: fix race condition on\n stopping lcore", "submitter": { "id": 1628, "url": "https://patches.dpdk.org/api/people/1628/?format=api", "name": "Lukasz Wojciechowski", "email": "l.wojciechow@partner.samsung.com" }, "content": "W dniu 20.07.2020 o 16:38, Harry van Haaren pisze:\n> This commit fixes a potential race condition in the tests\n> where the lcore running a service would increment a counter\n> that was already reset by the test-suite thread. The resulting\n> race-condition incremented value could cause CI failures, as\n> indicated by DPDK's CI.\n>\n> This patch fixes the race-condition by making use of the\n> added rte_service_lcore_active() API, which indicates when\n> a service-core is no longer in the service-core polling loop.\n>\n> The unit test makes use of the above function to detect when\n> all statistics increments are done in the service-core thread,\n> and then the unit test continues finalizing and checking state.\n>\n> Fixes: f28f3594ded2 (\"service: add attribute API\")\n>\n> Reported-by: David Marchand <david.marchand@redhat.com>\n> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n>\n> ---\n>\n> Thanks for discussion on v1, this v2 fixup for the CI\n> including previous feedback on ML.\n> ---\n> app/test/test_service_cores.c | 22 +++++++++++++++++++++-\n> 1 file changed, 21 insertions(+), 1 deletion(-)\n>\n> diff --git a/app/test/test_service_cores.c b/app/test/test_service_cores.c\n> index ef1d8fcb9..a45762915 100644\n> --- a/app/test/test_service_cores.c\n> +++ b/app/test/test_service_cores.c\n> @@ -362,6 +362,9 @@ service_lcore_attr_get(void)\n> \t\t\t\"Service core add did not return zero\");\n> \tTEST_ASSERT_EQUAL(0, rte_service_map_lcore_set(id, slcore_id, 1),\n> \t\t\t\"Enabling valid service and core failed\");\n> +\t/* Ensure service is not active before starting */\n> +\tTEST_ASSERT_EQUAL(0, rte_service_lcore_active(slcore_id),\n> +\t\t\t\"Not-active service core reported as active\");\n> \tTEST_ASSERT_EQUAL(0, rte_service_lcore_start(slcore_id),\n> \t\t\t\"Starting service core failed\");\n> \n> @@ -382,7 +385,24 @@ service_lcore_attr_get(void)\n> \t\t\tlcore_attr_id, &lcore_attr_value),\n> \t\t\t\"Invalid lcore attr didn't return -EINVAL\");\n> \n> -\trte_service_lcore_stop(slcore_id);\n> +\t/* Ensure service is active */\n> +\tTEST_ASSERT_EQUAL(1, rte_service_lcore_active(slcore_id),\n> +\t\t\t\"Active service core reported as not-active\");\n> +\n> +\tTEST_ASSERT_EQUAL(0, rte_service_map_lcore_set(id, slcore_id, 0),\n> +\t\t\t\"Disabling valid service and core failed\");\n> +\tTEST_ASSERT_EQUAL(0, rte_service_lcore_stop(slcore_id),\n> +\t\t\t\"Failed to stop service lcore\");\n> +\n> +\tint i = 0;\n> +\twhile (rte_service_lcore_active(slcore_id) == 1) {\n> +\t\trte_delay_ms(1);\n> +\t\ti++;\n> +\t\tif (i > 100)\n> +\t\t\tbreak;\n> +\t}\n> +\tTEST_ASSERT_EQUAL(0, rte_service_lcore_active(slcore_id),\n> +\t\t\t \"Service lcore not stopped after waiting.\");\n> \n> \tTEST_ASSERT_EQUAL(0, rte_service_lcore_attr_reset_all(slcore_id),\n> \t\t\t \"Valid lcore_attr_reset_all() didn't return success\");\nAcked-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 809D2A0527;\n\tMon, 20 Jul 2020 19:45:47 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 64F9C1BFC5;\n\tMon, 20 Jul 2020 19:45:47 +0200 (CEST)", "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 339C51BFBB\n for <dev@dpdk.org>; Mon, 20 Jul 2020 19:45:46 +0200 (CEST)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200720174545euoutp0293152d7e11c9615e55bead541ca66e7d~jhwRTYpyW3202632026euoutp02i\n for <dev@dpdk.org>; Mon, 20 Jul 2020 17:45:45 +0000 (GMT)", "from eusmges2new.samsung.com (unknown [203.254.199.244]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTP id\n 20200720174544eucas1p255db96200b5233144e546e8a5fea36d0~jhwQXuDr92389423894eucas1p2I;\n Mon, 20 Jul 2020 17:45:44 +0000 (GMT)", "from eucas1p1.samsung.com ( [182.198.249.206]) by\n eusmges2new.samsung.com (EUCPMTA) with SMTP id B8.54.05997.848D51F5; Mon, 20\n Jul 2020 18:45:44 +0100 (BST)", "from eusmtrp2.samsung.com (unknown [182.198.249.139]) by\n eucas1p2.samsung.com (KnoxPortal) with ESMTPA id\n 20200720174543eucas1p220a317558ec7ef1365096ba44cf15c46~jhwPrWdq-2174221742eucas1p2U;\n Mon, 20 Jul 2020 17:45:43 +0000 (GMT)", "from eusmgms1.samsung.com (unknown [182.198.249.179]) by\n eusmtrp2.samsung.com (KnoxPortal) with ESMTP id\n 20200720174543eusmtrp24a6889afcfab2c9b6de1fea2d80e1955~jhwPquXki2189021890eusmtrp2d;\n Mon, 20 Jul 2020 17:45:43 +0000 (GMT)", "from eusmtip2.samsung.com ( [203.254.199.222]) by\n eusmgms1.samsung.com (EUCPMTA) with SMTP id 41.2F.06314.748D51F5; Mon, 20\n Jul 2020 18:45:43 +0100 (BST)", "from [106.210.88.70] (unknown [106.210.88.70]) by\n eusmtip2.samsung.com (KnoxPortal) with ESMTPA id\n 20200720174543eusmtip2c73b9576af304a1771eadad1619186a1~jhwO1dHq_0636906369eusmtip2z;\n Mon, 20 Jul 2020 17:45:42 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com\n 20200720174545euoutp0293152d7e11c9615e55bead541ca66e7d~jhwRTYpyW3202632026euoutp02i", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1595267145;\n bh=MXx6wmuNEzhloIX8W2ZoDQ0cWyUnG0tG7r321x77Biw=;\n h=Subject:To:Cc:From:Date:In-Reply-To:References:From;\n b=u6FIv/NGCmwDA324jeUQG02Wb3jzrmh3D+JT6XIfP6YByIudYKOmWO5xrCxGFakjO\n 8UcuhWIKcpAx2M6ofcaN+loCVuas3RGsOuKSo9G8NKUhti6yNYvpsxFAYWjIYThCyp\n jo7tMbj/Q7G1X67VXd/FcquGbLH4um75/Owckr4U=", "X-AuditID": "cbfec7f4-677ff7000000176d-6a-5f15d84890c0", "To": "Harry van Haaren <harry.van.haaren@intel.com>, dev@dpdk.org", "Cc": "david.marchand@redhat.com, igor.romanov@oktetlabs.ru,\n honnappa.nagarahalli@arm.com, ferruh.yigit@intel.com, nd@arm.com,\n aconole@redhat.com", "From": "Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>", "Message-ID": "<33994bfc-9176-0b74-4a48-5be1b286ff44@partner.samsung.com>", "Date": "Mon, 20 Jul 2020 19:45:42 +0200", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101\n Thunderbird/68.10.0", "MIME-Version": "1.0", "In-Reply-To": "<20200720143829.46280-2-harry.van.haaren@intel.com>", "Content-Transfer-Encoding": "8bit", "Content-Language": "en-US", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA+NgFtrIKsWRmVeSWpSXmKPExsWy7djPc7oeN0TjDfqa1C1+vXnAbrF9RReb\n xbtP25ks7uw9zW7R2P+NxWLm0xZ2i0OTsy3OLO9hduDwWDNvDaPHrwVLWT0W73nJ5HH96ytW\n j/f7rrIFsEZx2aSk5mSWpRbp2yVwZXzvPMNW8Fu84kbvCfYGxqvCXYycHBICJhKN3ZuZuxi5\n OIQEVjBKLJ3fxAbhfGGUmPDvIFTmM6PE3DtzmGBamu+ehapazigxdfMLJgjnLaPEo3V7WUGq\n hAUCJBqWPWEBsUUE7CU+XzkNVsQsMIlR4tnTNewgCTYBW4kjM7+CNfAKuEk0v+9iBLFZBFQl\n undvBKsRFYiTWP9yOxNEjaDEyZkgQzk4OAUcJBr3qYOEmQXkJZq3zmaGsMUlbj2ZD7ZLQmAf\n u8SJngtQZ7tI/Dl1gRHCFpZ4dXwLO4QtI/F/J0zDNkaJq79/MkI4+xklrveugKqyljj87zcb\n yGZmAU2J9bv0IcKOEte3rWQGCUsI8EnceCsIcQSfxKRt06HCvBIdbUIQ1XoST3umMsKs/bP2\n CcsERqVZSD6bheSdWUjemYWwdwEjyypG8dTS4tz01GKjvNRyveLE3OLSvHS95PzcTYzAhHT6\n 3/EvOxh3/Uk6xCjAwajEw/uhWzReiDWxrLgy9xCjBAezkgiv09nTcUK8KYmVValF+fFFpTmp\n xYcYpTlYlMR5jRe9jBUSSE8sSc1OTS1ILYLJMnFwSjUwMr4+lbbH3mm2yLZdq9jmN13mO59f\n 9sR15/GUj0I3Nq1ePOXtnokFK3sffIwyvb1Zic/n1Bt3PV2LQwczVv3n1leeUMdsFhT7vfK8\n PY+QCrvn3a+TYx4VHcnpTPJV511SviI5y4vrv/jbN88EtlkaTlPJvC67IsMm/b8Lo2/H9L27\n XgUoL9jurMRSnJFoqMVcVJwIACvknApEAwAA", "\n H4sIAAAAAAAAA+NgFjrAIsWRmVeSWpSXmKPExsVy+t/xe7ruN0TjDZZuNbL49eYBu8X2FV1s\n Fu8+bWeyuLP3NLtFY/83FouZT1vYLQ5NzrY4s7yH2YHDY828NYwevxYsZfVYvOclk8f1r69Y\n Pd7vu8oWwBqlZ1OUX1qSqpCRX1xiqxRtaGGkZ2hpoWdkYqlnaGwea2VkqqRvZ5OSmpNZllqk\n b5egl/G98wxbwW/xihu9J9gbGK8KdzFyckgImEg03z3L1sXIxSEksJRRYsPmyexdjBxACRmJ\n D5cEIGqEJf5c62IDsYUEXjNKbFudB2ILC/hJdM7uYgKxRQTsJT5fOc0EModZYBKjxL/OBawQ\n Df8ZJTa3yoPYbAK2EkdmfgWL8wq4STS/72IEsVkEVCW6d29kB7FFBeIklm+Zzw5RIyhxcuYT\n FpB7OAUcJBr3qYOEmQXMJOZtfsgMYctLNG+dDWWLS9x6Mp9pAqPQLCTds5C0zELSMgtJywJG\n llWMIqmlxbnpucWGesWJucWleel6yfm5mxiBsbft2M/NOxgvbQw+xCjAwajEw/uhWzReiDWx\n rLgy9xCjBAezkgiv09nTcUK8KYmVValF+fFFpTmpxYcYTYF+m8gsJZqcD0wLeSXxhqaG5haW\n hubG5sZmFkrivB0CB2OEBNITS1KzU1MLUotg+pg4OKUaGKc93Z/gOX3rPLV/Agxbdh+r0FI8\n tPiJ99R40VM8nAnvH6+QLS2aPSti1eTAJypFLgJnrrqnKwj7zwyQL/ipvEFK0rnZdLrUces3\n n2o+PeOVPOEWdKW32yPkUev2l4VhqQf2FEWaHmaJbz1gFR7WeOajcCT/9w1Vt0TSv4tb5848\n +kNAPKz+ghJLcUaioRZzUXEiALfYuZbTAgAA" ], "X-CMS-MailID": "20200720174543eucas1p220a317558ec7ef1365096ba44cf15c46", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200720143737eucas1p14d0bbc0fa94029f28d4ecd42dd4bb2db", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200720143737eucas1p14d0bbc0fa94029f28d4ecd42dd4bb2db", "References": "<20200720120938.34660-1-harry.van.haaren@intel.com>\n <20200720143829.46280-1-harry.van.haaren@intel.com>\n <CGME20200720143737eucas1p14d0bbc0fa94029f28d4ecd42dd4bb2db@eucas1p1.samsung.com>\n <20200720143829.46280-2-harry.van.haaren@intel.com>", "Subject": "Re: [dpdk-dev] [PATCH v2 2/2] test/service: fix race condition on\n stopping lcore", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116389, "web_url": "https://patches.dpdk.org/comment/116389/", "msgid": "<VE1PR08MB46405AC8322BC9F871CF604CE9780@VE1PR08MB4640.eurprd08.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/VE1PR08MB46405AC8322BC9F871CF604CE9780@VE1PR08MB4640.eurprd08.prod.outlook.com", "date": "2020-07-21T08:38:58", "subject": "Re: [dpdk-dev] [PATCH v2 2/2] test/service: fix race condition\n\ton\tstopping lcore", "submitter": { "id": 833, "url": "https://patches.dpdk.org/api/people/833/?format=api", "name": "Phil Yang", "email": "phil.yang@arm.com" }, "content": "<...>\n\n> Subject: [dpdk-dev] [PATCH v2 2/2] test/service: fix race condition on\n> stopping lcore\n> \n> This commit fixes a potential race condition in the tests\n> where the lcore running a service would increment a counter\n> that was already reset by the test-suite thread. The resulting\n> race-condition incremented value could cause CI failures, as\n> indicated by DPDK's CI.\n> \n> This patch fixes the race-condition by making use of the\n> added rte_service_lcore_active() API, which indicates when\n> a service-core is no longer in the service-core polling loop.\n> \n> The unit test makes use of the above function to detect when\n> all statistics increments are done in the service-core thread,\n> and then the unit test continues finalizing and checking state.\n> \n> Fixes: f28f3594ded2 (\"service: add attribute API\")\n> \n> Reported-by: David Marchand <david.marchand@redhat.com>\n> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n\nMinor nit, otherwise it looks good to me.\n\nReviewed-by: Phil Yang <phil.yang@arm.com>\n\n> \n> ---\n> \n> Thanks for discussion on v1, this v2 fixup for the CI\n> including previous feedback on ML.\n> ---\n> app/test/test_service_cores.c | 22 +++++++++++++++++++++-\n> 1 file changed, 21 insertions(+), 1 deletion(-)\n> \n> diff --git a/app/test/test_service_cores.c b/app/test/test_service_cores.c\n> index ef1d8fcb9..a45762915 100644\n> --- a/app/test/test_service_cores.c\n> +++ b/app/test/test_service_cores.c\n> @@ -362,6 +362,9 @@ service_lcore_attr_get(void)\n> \t\t\t\"Service core add did not return zero\");\n> \tTEST_ASSERT_EQUAL(0, rte_service_map_lcore_set(id, slcore_id, 1),\n> \t\t\t\"Enabling valid service and core failed\");\n> +\t/* Ensure service is not active before starting */\n> +\tTEST_ASSERT_EQUAL(0, rte_service_lcore_active(slcore_id),\n> +\t\t\t\"Not-active service core reported as active\");\n> \tTEST_ASSERT_EQUAL(0, rte_service_lcore_start(slcore_id),\n> \t\t\t\"Starting service core failed\");\n> \n> @@ -382,7 +385,24 @@ service_lcore_attr_get(void)\n> \t\t\tlcore_attr_id, &lcore_attr_value),\n> \t\t\t\"Invalid lcore attr didn't return -EINVAL\");\n> \n> -\trte_service_lcore_stop(slcore_id);\n> +\t/* Ensure service is active */\n> +\tTEST_ASSERT_EQUAL(1, rte_service_lcore_active(slcore_id),\n> +\t\t\t\"Active service core reported as not-active\");\n> +\n> +\tTEST_ASSERT_EQUAL(0, rte_service_map_lcore_set(id, slcore_id, 0),\n> +\t\t\t\"Disabling valid service and core failed\");\n> +\tTEST_ASSERT_EQUAL(0, rte_service_lcore_stop(slcore_id),\n> +\t\t\t\"Failed to stop service lcore\");\n> +\n> +\tint i = 0;\n> +\twhile (rte_service_lcore_active(slcore_id) == 1) {\n> +\t\trte_delay_ms(1);\n\nJust as it does in other functions, use the macro instead of the magic number would be better.\nrte_delay_ms(SERVICE_DELAY); \n\n> +\t\ti++;\n> +\t\tif (i > 100)\n> +\t\t\tbreak;\n> +\t}\n> +\tTEST_ASSERT_EQUAL(0, rte_service_lcore_active(slcore_id),\n> +\t\t\t \"Service lcore not stopped after waiting.\");\n> \n> \tTEST_ASSERT_EQUAL(0, rte_service_lcore_attr_reset_all(slcore_id),\n> \t\t\t \"Valid lcore_attr_reset_all() didn't return success\");\n> --\n> 2.17.1", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DF07BA0526;\n\tTue, 21 Jul 2020 10:39:07 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C1CF21BFFB;\n\tTue, 21 Jul 2020 10:39:07 +0200 (CEST)", "from EUR05-AM6-obe.outbound.protection.outlook.com\n (mail-am6eur05on2085.outbound.protection.outlook.com [40.107.22.85])\n by dpdk.org (Postfix) with ESMTP id C3D301BFD4\n for <dev@dpdk.org>; Tue, 21 Jul 2020 10:39:06 +0200 (CEST)", "from AM6PR10CA0031.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::44)\n by HE1PR0801MB1913.eurprd08.prod.outlook.com (2603:10a6:3:51::16)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.25; Tue, 21 Jul\n 2020 08:39:05 +0000", "from AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com\n (2603:10a6:209:89:cafe::a3) by AM6PR10CA0031.outlook.office365.com\n (2603:10a6:209:89::44) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17 via Frontend\n Transport; Tue, 21 Jul 2020 08:39:05 +0000", "from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by\n AM5EUR03FT019.mail.protection.outlook.com (10.152.16.104) with\n Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.3195.18 via Frontend Transport; Tue, 21 Jul 2020 08:39:04 +0000", "(\"Tessian outbound c4059ed8d7bf:v62\");\n Tue, 21 Jul 2020 08:39:04 +0000", "from 0aa4e01f0756.2\n by 64aa7808-outbound-1.mta.getcheckrecipient.com id\n 48750454-C682-4C95-B184-F087DD2255AD.1;\n Tue, 21 Jul 2020 08:38:59 +0000", "from EUR05-AM6-obe.outbound.protection.outlook.com\n by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id\n 0aa4e01f0756.2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);\n Tue, 21 Jul 2020 08:38:59 +0000", "from VE1PR08MB4640.eurprd08.prod.outlook.com (2603:10a6:802:b2::11)\n by VI1PR08MB3600.eurprd08.prod.outlook.com (2603:10a6:803:85::11)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.24; Tue, 21 Jul\n 2020 08:38:58 +0000", "from VE1PR08MB4640.eurprd08.prod.outlook.com\n ([fe80::28a3:3a4e:65ca:5707]) by VE1PR08MB4640.eurprd08.prod.outlook.com\n ([fe80::28a3:3a4e:65ca:5707%3]) with mapi id 15.20.3195.025; Tue, 21 Jul 2020\n 08:38:58 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;\n s=selector2-armh-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=pcBBHV3THjAjptWAvApusrar6p7MHSq8xoGqbYdpeqk=;\n b=xxChvMj3seljrcagHEX/GP4bER+2uomy6KDmaUam79EoiLkqh/VdA99gDDMl2J1FOKtfGHFITyE95zoRI3dK0O7eR0TnfBSfLSlKK1/XVwGkU0X06BLf8ZubZ2lqryDTJLBoSgv10XoK5Dis+AqHR2hEDVgrASasMvNyNEYrOpk=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;\n s=selector2-armh-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=pcBBHV3THjAjptWAvApusrar6p7MHSq8xoGqbYdpeqk=;\n b=xxChvMj3seljrcagHEX/GP4bER+2uomy6KDmaUam79EoiLkqh/VdA99gDDMl2J1FOKtfGHFITyE95zoRI3dK0O7eR0TnfBSfLSlKK1/XVwGkU0X06BLf8ZubZ2lqryDTJLBoSgv10XoK5Dis+AqHR2hEDVgrASasMvNyNEYrOpk=" ], "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 63.35.35.123)\n smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified)\n header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none\n header.from=arm.com;", "Received-SPF": "Pass (protection.outlook.com: domain of arm.com designates\n 63.35.35.123 as permitted sender) receiver=protection.outlook.com;\n client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;", "X-CR-MTA-TID": "64aa7808", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=ZDDy+dPS1vVsC8USyRLUgu+tafUXjm+XOBT659e+53FaPxjYwc+/2x2uajU+4D5LYE8hSI9AixRtbormStgAqyQ/3NOLKhQEuF/itTv+iZYXrAdvd595FU3PC1iCirh6w1ImzALmCRHfxXiRPEFtB7mgs4Vwdk+owp/jO9jweZiToiJKAO04mFwy9YG62YvVJdQeYgAPy90xfTKMPRqsHCh1rRScoBH2M2TIunrWFxrikgPNC4OVn8Fm+ChrkFpIKAlLFmUIc+uH26UBsQ99I3FVnJybb+wb3fgEce7hWHPJaBNJ5SseZuC8LUWNSQbGsZnGqWy1fhvsMZNay9Y95A==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=pcBBHV3THjAjptWAvApusrar6p7MHSq8xoGqbYdpeqk=;\n b=MOkwRKYIJhn4HgpjX7crAn1ZC7o17Xz3p57+hPGghGP7HWsF34mRPl67T7zwmwg6TyC2swt3u5d+Zgt3txtPrr5Hhb6bq10FlNdAq1hw4UKUkBZx4yAArf1lcNDVmBG+tQv+rP5aNK7TiIXLVUwYrcrZCreVO3CltH8hYMYqcxP9YnJDy2tEcrWUU6MdtJLW3BlXN4k/u2wQ0J4GRghG58prQXpf1ucO/WgaCKqQzcvfAci/p4kXLGv7Xancwyr1ai9suODtLG3YeIKEAjvhztxe5AW7xmSAy9sU4s2W8OOpHovQa04s8V51zqKaoKtfbjJuQnxkIKPYgOiHFbPmgQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass\n header.d=arm.com; arc=none", "From": "Phil Yang <Phil.Yang@arm.com>", "To": "Harry van Haaren <harry.van.haaren@intel.com>, \"dev@dpdk.org\"\n <dev@dpdk.org>", "CC": "\"david.marchand@redhat.com\" <david.marchand@redhat.com>,\n \"igor.romanov@oktetlabs.ru\" <igor.romanov@oktetlabs.ru>, Honnappa Nagarahalli\n <Honnappa.Nagarahalli@arm.com>, \"ferruh.yigit@intel.com\"\n <ferruh.yigit@intel.com>, nd <nd@arm.com>, \"aconole@redhat.com\"\n <aconole@redhat.com>, \"l.wojciechow@partner.samsung.com\"\n <l.wojciechow@partner.samsung.com>, nd <nd@arm.com>", "Thread-Topic": "[dpdk-dev] [PATCH v2 2/2] test/service: fix race condition on\n stopping lcore", "Thread-Index": "AQHWXqNdHf5ki8kY806Pod2PDb8vmqkRqYZg", "Date": "Tue, 21 Jul 2020 08:38:58 +0000", "Message-ID": "\n <VE1PR08MB46405AC8322BC9F871CF604CE9780@VE1PR08MB4640.eurprd08.prod.outlook.com>", "References": "<20200720120938.34660-1-harry.van.haaren@intel.com>\n <20200720143829.46280-1-harry.van.haaren@intel.com>\n <20200720143829.46280-2-harry.van.haaren@intel.com>", "In-Reply-To": "<20200720143829.46280-2-harry.van.haaren@intel.com>", "Accept-Language": "zh-CN, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-ts-tracking-id": "4e2a5c22-f005-4258-8728-c4e4e9d9e7c3.0", "x-checkrecipientchecked": "true", "Authentication-Results-Original": "intel.com; dkim=none (message not signed)\n header.d=none;intel.com; dmarc=none action=none header.from=arm.com;", "x-originating-ip": "[203.126.0.113]", "x-ms-publictraffictype": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "ad825243-efcd-470a-3262-08d82d5186d3", "x-ms-traffictypediagnostic": "VI1PR08MB3600:|HE1PR0801MB1913:", "x-ms-exchange-transport-forked": "True", "X-Microsoft-Antispam-PRVS": "\n <HE1PR0801MB191359A0553E36008E8FBF9FE9780@HE1PR0801MB1913.eurprd08.prod.outlook.com>", "x-checkrecipientrouted": "true", "nodisclaimer": "true", "x-ms-oob-tlc-oobclassifiers": "OLM:8273;OLM:8273;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam-Untrusted": "BCL:0;", "X-Microsoft-Antispam-Message-Info-Original": "\n n5zhlFkdewtD9QZAw0/ktZo/SeuWvd/3l9NHTYNOYlbt52n9gmRQH8aGQ5JFR0Jm/iZCN2SakgRLYk47VqTr9VHwHIUf7nZIJiXzJ3jn3xA/RnkY5CErITgAuc0dYivBtEHkysY9iftVgBNPSPG8V290Z2nTphoeXky0QMN0qjYLGETffSBcPrpfNe+LDbgezLDPESgxkICqCOlq5BdlQoIJwKjEy2ur6/kY85bejkFt6LjR/W02MoSMWKfMA2503ps73GzxfkqoLffbS9mPVVsW8rXYN8ANiAzrraJisFoxzguuaQS2/go0g5DOD7ym", "X-Forefront-Antispam-Report-Untrusted": "CIP:255.255.255.255; CTRY:; LANG:en;\n SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4640.eurprd08.prod.outlook.com;\n PTR:; CAT:NONE; SFTY:;\n SFS:(4636009)(136003)(39860400002)(376002)(346002)(366004)(396003)(86362001)(316002)(5660300002)(2906002)(33656002)(76116006)(66556008)(66446008)(26005)(110136005)(66476007)(64756008)(186003)(478600001)(52536014)(54906003)(6506007)(4326008)(7696005)(71200400001)(83380400001)(55016002)(9686003)(8936002)(66946007);\n DIR:OUT; SFP:1101;", "x-ms-exchange-antispam-messagedata": "\n fVP+dr+9NiaFnqxzrL+9GMC6jZqbKjpzoX1pBTlyq51jneZg4XdI9Owdp+JQkabYYWRL/9+oBdrZzBwqQ3WarK6O1K4bBmcrChbdmm+JMj7TtgfjMOqAI9AX+kJ/BmqE6Wm5+2LMj+X81Ik0dm9ASN4V9NcPUWpX2AAnr5ugstXww5LjbNoCrXvWgvnpjiLqEOC4fUJIvVI9ao8awJPvyQ5pekSuXLy4cQS2b2pZiiFnLhnr4BoldkvqHVC3mGnq0hJW1sy9fkfXfPB9cR5iiKO7sTkO4eerzbkjQ7lVciBHwMRSMqx2R2DwLkDaRPXpYJVoMo7M9JPr8Y6XS4DcWPUrQdtrOwZiwXwd1Fvzo5l199SS/HlOwIezx2J9jANJwrXiSi+YwqVcyKLzHMwvZ7d4mlEak8O/eZfVbMJaiVGLXuNd+lBNVo9LCt/8tGcP/0yLAefGlZXkiev1k5WnTjSyr37XSQ/XivOi2Crgrdw=", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": [ "VI1PR08MB3600", "HE1PR0801MB1913" ], "Original-Authentication-Results": "intel.com; dkim=none (message not signed)\n header.d=none;intel.com; dmarc=none action=none header.from=arm.com;", "X-EOPAttributedMessage": "0", "X-MS-Exchange-Transport-CrossTenantHeadersStripped": "\n AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com", "X-Forefront-Antispam-Report": "CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com;\n PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:;\n SFS:(4636009)(39860400002)(376002)(136003)(396003)(346002)(46966005)(52536014)(2906002)(47076004)(82740400003)(4326008)(110136005)(33656002)(26005)(36906005)(6506007)(316002)(7696005)(186003)(54906003)(82310400002)(356005)(55016002)(9686003)(83380400001)(70586007)(81166007)(8936002)(5660300002)(86362001)(70206006)(336012)(478600001);\n DIR:OUT; SFP:1101;", "X-MS-Office365-Filtering-Correlation-Id-Prvs": "\n 3ebdcb2b-dba1-4139-875c-08d82d5182e7", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n LwxOJwkrjBzFFvvyKZkF4z9wuP/h1To7BJym3eB6PX1+pawexRZNDpE5NnCHd8OGurg8MJJjYafV1gmZ4rMoY1K+UTDEQI5XmAyZ5eKv2+oZCF1tjdQRXm3qNIqUPX6fVGjLo6FId8/NJJQZkA+8qilQ9hfDzjgxGjJsk/SIJ1CVI38fRRSOdVB24vzTYtW+gZFDI2oQePR1WmA5Wq4a/9bQCrJGljS6MeNPfVdlG4PipWp1SwEWBhenp8VTf7jUoQPvui+kAhYmWWR5IkzqHm0SF7SFsCN0+pK+dOYylBZNt0YoNWmKriOH6rCQZJVYWxJWPbp6wZcrog+rUPsuJGXCb8Lt4mCsSmJFFb8FWkPktkOiSWqGIjinkukJ9jXNAAIUEULdcQALknsQe34J6Q==", "X-OriginatorOrg": "arm.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "21 Jul 2020 08:39:04.9644 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n ad825243-efcd-470a-3262-08d82d5186d3", "X-MS-Exchange-CrossTenant-Id": "f34e5979-57d9-4aaa-ad4d-b122a662184d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123];\n Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "Subject": "Re: [dpdk-dev] [PATCH v2 2/2] test/service: fix race condition\n\ton\tstopping lcore", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 116493, "web_url": "https://patches.dpdk.org/comment/116493/", "msgid": "<BYAPR11MB3143708596B763006C312DE7D7790@BYAPR11MB3143.namprd11.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/BYAPR11MB3143708596B763006C312DE7D7790@BYAPR11MB3143.namprd11.prod.outlook.com", "date": "2020-07-22T10:26:07", "subject": "Re: [dpdk-dev] [PATCH v2 2/2] test/service: fix race condition\n\ton\tstopping lcore", "submitter": { "id": 317, "url": "https://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "content": "> -----Original Message-----\n> From: Phil Yang <Phil.Yang@arm.com>\n> Sent: Tuesday, July 21, 2020 9:39 AM\n> To: Van Haaren, Harry <harry.van.haaren@intel.com>; dev@dpdk.org\n> Cc: david.marchand@redhat.com; igor.romanov@oktetlabs.ru; Honnappa\n> Nagarahalli <Honnappa.Nagarahalli@arm.com>; Yigit, Ferruh\n> <ferruh.yigit@intel.com>; nd <nd@arm.com>; aconole@redhat.com;\n> l.wojciechow@partner.samsung.com; nd <nd@arm.com>\n> Subject: RE: [dpdk-dev] [PATCH v2 2/2] test/service: fix race condition on\n> stopping lcore\n> \n> <...>\n> \n> > Subject: [dpdk-dev] [PATCH v2 2/2] test/service: fix race condition on\n> > stopping lcore\n> >\n> > This commit fixes a potential race condition in the tests\n> > where the lcore running a service would increment a counter\n> > that was already reset by the test-suite thread. The resulting\n> > race-condition incremented value could cause CI failures, as\n> > indicated by DPDK's CI.\n> >\n> > This patch fixes the race-condition by making use of the\n> > added rte_service_lcore_active() API, which indicates when\n> > a service-core is no longer in the service-core polling loop.\n> >\n> > The unit test makes use of the above function to detect when\n> > all statistics increments are done in the service-core thread,\n> > and then the unit test continues finalizing and checking state.\n> >\n> > Fixes: f28f3594ded2 (\"service: add attribute API\")\n> >\n> > Reported-by: David Marchand <david.marchand@redhat.com>\n> > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n> \n> Minor nit, otherwise it looks good to me.\n> \n> Reviewed-by: Phil Yang <phil.yang@arm.com>\n\nThanks, will add in v3.\n\n<snip>\n\n> > +\tint i = 0;\n> > +\twhile (rte_service_lcore_active(slcore_id) == 1) {\n> > +\t\trte_delay_ms(1);\n> \n> Just as it does in other functions, use the macro instead of the magic number\n> would be better.\n> rte_delay_ms(SERVICE_DELAY);\n\nSure, will change. I've refactored the while() to a for() too, think it cleans up a little.\n\n<snip>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D34B0A0526;\n\tWed, 22 Jul 2020 12:26:18 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6FFE11BFF9;\n\tWed, 22 Jul 2020 12:26:17 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by dpdk.org (Postfix) with ESMTP id A41051BFE9\n for <dev@dpdk.org>; Wed, 22 Jul 2020 12:26:15 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Jul 2020 03:26:14 -0700", "from orsmsx602.amr.corp.intel.com ([10.22.229.15])\n by orsmga004.jf.intel.com with ESMTP; 22 Jul 2020 03:26:13 -0700", "from orsmsx602.amr.corp.intel.com (10.22.229.15) by\n ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.1713.5; Wed, 22 Jul 2020 03:26:12 -0700", "from ORSEDG001.ED.cps.intel.com (10.7.248.4) by\n orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5\n via Frontend Transport; Wed, 22 Jul 2020 03:26:12 -0700", "from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168)\n by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS)\n id 14.3.439.0; Wed, 22 Jul 2020 03:26:12 -0700", "from BYAPR11MB3143.namprd11.prod.outlook.com (2603:10b6:a03:92::32)\n by BYAPR11MB3269.namprd11.prod.outlook.com (2603:10b6:a03:75::19)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.21; Wed, 22 Jul\n 2020 10:26:08 +0000", "from BYAPR11MB3143.namprd11.prod.outlook.com\n ([fe80::9c6b:5ce:b551:8678]) by BYAPR11MB3143.namprd11.prod.outlook.com\n ([fe80::9c6b:5ce:b551:8678%4]) with mapi id 15.20.3195.026; Wed, 22 Jul 2020\n 10:26:08 +0000" ], "IronPort-SDR": [ "\n ivud7u9JhGyiEpuHdQDUDMbXVHEYPDzlYwt7iDVJQggjf/aLHV9xaRXxddqg35B7od748nSxS1\n J6ZebdM/lXLA==", "\n nnSV5q+e4h+3LDmfph7uIJXVwEpd5cVjl0m5O73ZO7PQG/pajUYn4DsoDX3k4GJS1qiofoIZ1X\n mnml/8N4mc6g==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9689\"; a=\"130384577\"", "E=Sophos;i=\"5.75,381,1589266800\"; d=\"scan'208\";a=\"130384577\"", "E=Sophos;i=\"5.75,381,1589266800\"; d=\"scan'208\";a=\"432331105\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=V8hLa0OwjD+vRpZDNltoFfcxtzMCACpoZ0TYwkB5n6CoYmh+frNnY5rTGkZbtRSmbOxMXQGHzSV4xG8ybEDcFOFXXrBZePf8ATC9rnikz/isXZO7cVhHQwMj4e66GMZ1Tt/4ZifH6V7wVfeSVAdML3P2/NYI7Ke0XxhMCufj/5cvj4fiN5b82hxXe0TJd49Sd5oyBnMZqvX17Xq82N1LjG4IR7Fv0ZWTOR/kha2Gr76t+3Ay9Zwgn44VBZEgopuXclCRN1F95Yc/bfJ1NVtYJyEF9m9odf4DkWEwAz6owPudBlZBvQSMbXk1ecB1uay3FGW2rhfGnle6oQcn+/+GrQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=0pztmVqYu4u/BQYJU28fAPuRNe5Jo9ISlQv3vCGsvug=;\n b=cSbaIUkCqPeRqs7JNRqMG7lSmLm4t6BhO7iwdBHy76XNMjU28ZySpXZZ+kw2iNjpqR/5fPW+eRG4UB0JiSI2LgXEQUfS9zMkxBeJGrJhhjAPVCv5ANmQQieYm0fjNDyQe9PRTZa9nGRCeE06WJ+XFKg8SLODbrYB2/v2tma7OCJfEACN8Zlj+SNmVXRnEroX39t33ofVTwUyelbIb/nNLMjrVCEFWUuDGzMvwHBsPleX9M7PsVVtvXSj+eN/4Pmtlb3n0UqhXJnhsqoXmHK9t29IyBAWg4UgC+cWKazmbkaZrhnHvwZkWphLuJb/5Q2VbkxZ80nDSzq8v+sFBc2WJA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;\n s=selector2-intel-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=0pztmVqYu4u/BQYJU28fAPuRNe5Jo9ISlQv3vCGsvug=;\n b=h46Es5d5mD9VWsmjkO5bsYO+lF5GrfVpDbddxwkvzdHR55bWLYEnEfWxJReinawDi4p0Dpf8gG30JVjicw+GOYIaD62Go16qh4IbqEjPASasgR39hE796q2mE+Gq9bz0a+2c5dBwxV9iuOaZRCQn8ZxWpnv1A1RU1CIts0Rx7Bo=", "From": "\"Van Haaren, Harry\" <harry.van.haaren@intel.com>", "To": "Phil Yang <Phil.Yang@arm.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"david.marchand@redhat.com\" <david.marchand@redhat.com>,\n \"igor.romanov@oktetlabs.ru\" <igor.romanov@oktetlabs.ru>, Honnappa Nagarahalli\n <Honnappa.Nagarahalli@arm.com>, \"Yigit, Ferruh\" <ferruh.yigit@intel.com>, nd\n <nd@arm.com>, \"aconole@redhat.com\" <aconole@redhat.com>,\n \"l.wojciechow@partner.samsung.com\" <l.wojciechow@partner.samsung.com>, nd\n <nd@arm.com>", "Thread-Topic": "[dpdk-dev] [PATCH v2 2/2] test/service: fix race condition on\n stopping lcore", "Thread-Index": "AQHWXzptZMdQXJ09jky2OArSBK/ssqkTZArw", "Date": "Wed, 22 Jul 2020 10:26:07 +0000", "Message-ID": "\n <BYAPR11MB3143708596B763006C312DE7D7790@BYAPR11MB3143.namprd11.prod.outlook.com>", "References": "<20200720120938.34660-1-harry.van.haaren@intel.com>\n <20200720143829.46280-1-harry.van.haaren@intel.com>\n <20200720143829.46280-2-harry.van.haaren@intel.com>\n <VE1PR08MB46405AC8322BC9F871CF604CE9780@VE1PR08MB4640.eurprd08.prod.outlook.com>", "In-Reply-To": "\n <VE1PR08MB46405AC8322BC9F871CF604CE9780@VE1PR08MB4640.eurprd08.prod.outlook.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "dlp-product": "dlpe-windows", "dlp-reaction": "no-action", "dlp-version": "11.2.0.6", "authentication-results": "arm.com; dkim=none (message not signed)\n header.d=none;arm.com; dmarc=none action=none header.from=intel.com;", "x-originating-ip": "[87.198.126.230]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "05464878-4611-4998-d5b6-08d82e29a5bf", "x-ms-traffictypediagnostic": "BYAPR11MB3269:", "x-ld-processed": "46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <BYAPR11MB32692C0768447D6FF3227703D7790@BYAPR11MB3269.namprd11.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:4941;", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n MtZDg/y8rh/flz5z3yZ2WGVxKXb6wS7GWSMsqJr21DChaQ537lGemjki7qNxbOjlv5M7dsHT4PGx8VVwoPgnbuirbgyDXixPbL3JvYaDErMi9caDuBtGR/3WDpwkFV82G0THmUMIRxjG5cVOoPbnW+6OZTfR+ucGVYRQj8U2ElH6ft9fwfWSMOdvU7yoSn//HdJ4v478/lJfujP5eedfvT4/7l6UeVIiDhe2/gu9SCHhsGWkf6k6/6nF12anbqkBo7zBwqp/0QxsI50UI67b4FVTCZeEvzWfobwVBTNsBVjqVHwJNJBC0BN5DDqgYeQDsl3g0s1HHXd5m4gCc5tcaQ==", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:BYAPR11MB3143.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(4636009)(396003)(39860400002)(346002)(136003)(366004)(376002)(2906002)(186003)(76116006)(71200400001)(83380400001)(66946007)(66556008)(66446008)(4326008)(33656002)(66476007)(5660300002)(9686003)(64756008)(52536014)(55016002)(53546011)(478600001)(6506007)(7696005)(86362001)(8936002)(316002)(54906003)(110136005)(26005);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata": "\n vdq1FXd3WY1kNCa8r5AJC9l6d/CoH3CgUYA4nXoARY3KOzW+DlO8DY6l9YpWm+AjcovaXMYy/7voPd+0xDr4/NhCnYaZgvpaPtg0HqcNPBCPdO0wo3bKAnTC9P//XupzH9dYG2IsmLKTaz4hMw632+SeHkOYuBlQNxKd+4IuPyR714dYVbmCfT/bf7NeC2TDPEG2qgMqjsCS6AXL8YiPk+aD0b5Zp9a6cIQLtLm9/vpUKe1kjaYXyBA1oSsMngk0ZhrQIGcb2VOqZT2mSbYizkBMxYmDjIIIVXnAGG4TYiBELRJIN8GC0564o2cqlPGYRnYepIu6d+6IYZ72SjDvROSCduSnZDvvIxqW/d+isCTrlSTYHoEjiAgj2Oi45lDR1ywCmO3vzUJtEFYVcVJ6wDuu6lY8lrLxSIt9AbRe6V4qMfzc4a/GDI0Na61vf+ICUP7aDZaAdqdaAa6uuy4KE7HCGvAtu/z3Ud8vhvSroAxW1Iu/PTPBv8LR+oIFjlmY", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "BYAPR11MB3143.namprd11.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 05464878-4611-4998-d5b6-08d82e29a5bf", "X-MS-Exchange-CrossTenant-originalarrivaltime": "22 Jul 2020 10:26:08.0495 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "46c98d88-e344-4ed4-8496-4ed7712e255d", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n 9sJYKWaniVHOLJWQd7Qfrxt0fnhGfEXMqMDDrh6hCHlCSUlXLmpqh3oxyIOnuei1jAUaGDGlaLH6Yad+iPqsL5+ZK4sfYFE4aCZUcMPVDc4=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BYAPR11MB3269", "X-OriginatorOrg": "intel.com", "Subject": "Re: [dpdk-dev] [PATCH v2 2/2] test/service: fix race condition\n\ton\tstopping lcore", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]