Patch Comment List
List patch comments
GET /api/patches/74501/comments/?format=api
[ { "id": 116315, "web_url": "https://patches.dpdk.org/comment/116315/", "msgid": "<20200720143232.GA731@bricha3-MOBL.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200720143232.GA731@bricha3-MOBL.ger.corp.intel.com", "date": "2020-07-20T14:32:32", "subject": "Re: [dpdk-dev] [PATCH v7 2/3] test/test_telemetry_data: add unit\n tests for data to JSON", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "content": "On Mon, Jul 20, 2020 at 03:04:02PM +0100, Ciara Power wrote:\n> From: Louise Kilheeney <louise.kilheeney@intel.com>\n> \n> This patch adds tests for verifying telemetry data structures are\n> converted to JSON as expected. Both flat and recursive data structures\n> are tested, for all possible value types.\n> \n> The app connects to the telemetry socket as a client, and registers one\n> command with a corresponding callback function. Each time the callback\n> function is called, it copies a global data variable to the data pointer\n> passed in by telemetry.\n> When a test case is run, the test case function builds up the global\n> data variable with the relevant data types, and the expected json string\n> output which should be generated from that. The 'test_output()' function\n> is used to trigger the callback and ensure the actual output matches\n> that expected.\n> \n> Signed-off-by: Louise Kilheeney <louise.kilheeney@intel.com>\n> Signed-off-by: Ciara Power <ciara.power@intel.com>\n> \nAcked-by: Bruce Richardson <bruce.richardson@intel.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1838EA0527;\n\tMon, 20 Jul 2020 16:32:41 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EA3161BFC4;\n\tMon, 20 Jul 2020 16:32:40 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by dpdk.org (Postfix) with ESMTP id CDA20A69\n for <dev@dpdk.org>; Mon, 20 Jul 2020 16:32:39 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Jul 2020 07:32:39 -0700", "from bricha3-mobl.ger.corp.intel.com ([10.252.33.168])\n by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;\n 20 Jul 2020 07:32:36 -0700" ], "IronPort-SDR": [ "\n g6LxZspd6PwKlII0a8V8iKV/ZMZCtxpyXuA6jHvMoX16DiRE/ss3oumAUCPAL9py+oi4tv97OP\n 4Sly0ptug8gg==", "\n d6geSD8MA1K77Kct5XSPYmwnH6a9Psgut81G/e/er85kNEsUJdRggQ+IsyYNnM4qjAOdbFTreh\n kXbTgTvYOkvQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9687\"; a=\"129998584\"", "E=Sophos;i=\"5.75,375,1589266800\"; d=\"scan'208\";a=\"129998584\"", "E=Sophos;i=\"5.75,375,1589266800\"; d=\"scan'208\";a=\"461708301\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "Date": "Mon, 20 Jul 2020 15:32:32 +0100", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "Ciara Power <ciara.power@intel.com>", "Cc": "kevin.laatz@intel.com, thomas@monjalon.net, ferruh.yigit@intel.com,\n arybchenko@solarflare.com, dev@dpdk.org, keith.wiles@intel.com,\n Louise Kilheeney <louise.kilheeney@intel.com>", "Message-ID": "<20200720143232.GA731@bricha3-MOBL.ger.corp.intel.com>", "References": "<20200612105344.15383-1-ciara.power@intel.com>\n <20200720140403.69865-1-ciara.power@intel.com>\n <20200720140403.69865-3-ciara.power@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<20200720140403.69865-3-ciara.power@intel.com>", "Subject": "Re: [dpdk-dev] [PATCH v7 2/3] test/test_telemetry_data: add unit\n tests for data to JSON", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]