Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/74483/?format=api
{ "id": 74483, "url": "https://patches.dpdk.org/api/patches/74483/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200720091356.59144-1-jia.guo@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200720091356.59144-1-jia.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200720091356.59144-1-jia.guo@intel.com", "date": "2020-07-20T09:13:56", "name": "[v1] net/ice: fix symmetric hash configuration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ab6b914048d3698c00118d06ed787fa8d4babd4a", "submitter": { "id": 507, "url": "https://patches.dpdk.org/api/people/507/?format=api", "name": "Guo, Jia", "email": "jia.guo@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200720091356.59144-1-jia.guo@intel.com/mbox/", "series": [ { "id": 11165, "url": "https://patches.dpdk.org/api/series/11165/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11165", "date": "2020-07-20T09:13:56", "name": "[v1] net/ice: fix symmetric hash configuration", "version": 1, "mbox": "https://patches.dpdk.org/series/11165/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/74483/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/74483/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6C5A6A0540;\n\tMon, 20 Jul 2020 11:16:29 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3CD7E2AA6;\n\tMon, 20 Jul 2020 11:16:28 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by dpdk.org (Postfix) with ESMTP id EF5C91DBB\n for <dev@dpdk.org>; Mon, 20 Jul 2020 11:16:26 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Jul 2020 02:16:26 -0700", "from npg-dpdk-cvl-jeffguo-01.sh.intel.com ([10.67.111.128])\n by orsmga008.jf.intel.com with ESMTP; 20 Jul 2020 02:16:24 -0700" ], "IronPort-SDR": [ "\n tp8D6VaBBpWOaBgnYqMmPE+dNTCzMDjS/y8u8NgBuX2aiKfPvJjQ78LYsdULTxIMKuWT0p9DCZ\n 7r4Ysi8GRmxA==", "\n J/CtS0AcjW8WwNC2u0w91qiJu2s+drFW3wgZY1qW4pPK4sKYtJKATrfrtcr+daf68itF2/gTDN\n PfhLizKNc3jQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9687\"; a=\"149033301\"", "E=Sophos;i=\"5.75,374,1589266800\"; d=\"scan'208\";a=\"149033301\"", "E=Sophos;i=\"5.75,374,1589266800\"; d=\"scan'208\";a=\"317957357\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Jeff Guo <jia.guo@intel.com>", "To": "qi.z.zhang@intel.com,\n\tqiming.yang@intel.com", "Cc": "dev@dpdk.org,\n\tsimei.su@intel.com,\n\tjia.guo@intel.com", "Date": "Mon, 20 Jul 2020 17:13:56 +0800", "Message-Id": "<20200720091356.59144-1-jia.guo@intel.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [dpdk-dev v1] net/ice: fix symmetric hash configuration", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Some protocol don't support symmetric hash, need to handle these cases.\nWhen set an invalid symmetric hash rule, just return failed.\n\nFixes: 7d0824387e63 (\"net/ice: fix invalid RSS type\")\nSigned-off-by: Jeff Guo <jia.guo@intel.com>\n---\n drivers/net/ice/ice_hash.c | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c\nindex 13f88d37c..e535e4b95 100644\n--- a/drivers/net/ice/ice_hash.c\n+++ b/drivers/net/ice/ice_hash.c\n@@ -1026,6 +1026,7 @@ ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item,\n \tconst struct rte_flow_action *action;\n \tuint64_t rss_attr_src_dst;\n \tuint64_t rss_attr_l3_pre;\n+\tuint64_t rss_attr_symm;\n \tuint64_t rss_attr_all;\n \tuint64_t rss_type;\n \tuint16_t i;\n@@ -1089,6 +1090,15 @@ ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item,\n \t\t\t\t\t RTE_ETH_RSS_L3_PRE48 |\n \t\t\t\t\t RTE_ETH_RSS_L3_PRE64;\n \n+\t\t\trss_attr_symm = ETH_RSS_IPV4 |\n+\t\t\t\t\tETH_RSS_NONFRAG_IPV4_UDP |\n+\t\t\t\t\tETH_RSS_NONFRAG_IPV4_TCP |\n+\t\t\t\t\tETH_RSS_NONFRAG_IPV4_SCTP |\n+\t\t\t\t\tETH_RSS_IPV6 |\n+\t\t\t\t\tETH_RSS_NONFRAG_IPV6_UDP |\n+\t\t\t\t\tETH_RSS_NONFRAG_IPV6_TCP |\n+\t\t\t\t\tETH_RSS_NONFRAG_IPV6_SCTP;\n+\n \t\t\trss_attr_all = rss_attr_src_dst | rss_attr_l3_pre;\n \n \t\t\t/* Check if only SRC/DST_ONLY or ipv6 prefix exists. */\n@@ -1103,7 +1113,8 @@ ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item,\n \t\t\t */\n \t\t\tif (rss->func ==\n \t\t\t\tRTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ) {\n-\t\t\t\tif (rss_type & rss_attr_src_dst)\n+\t\t\t\tif (rss_type & (rss_attr_src_dst |\n+\t\t\t\t\t\t~rss_attr_symm))\n \t\t\t\t\treturn rte_flow_error_set(error,\n \t\t\t\t\t\tENOTSUP,\n \t\t\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n", "prefixes": [ "v1" ] }